<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185115] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185115">185115</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2015-06-02 12:40:13 -0700 (Tue, 02 Jun 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add more tests for "should open external urls" flag.
https://bugs.webkit.org/show_bug.cgi?id=145558
Rubberstamped by Geoff Garen.
* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html: Added.
* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html: Added.
* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html: Added.
* loader/navigation-policy/should-open-external-urls/resources/do-nothing.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapifalsefollowedbyapitrueexpectedtxt">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapifalsefollowedbyapitruehtml">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapitruefollowedbyapifalseexpectedtxt">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapitruefollowedbyapifalsehtml">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsdispatcheventclickisnotusergestureexpectedtxt">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsdispatcheventclickisnotusergesturehtml">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html</a></li>
<li><a href="#trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsresourcesdonothinghtml">trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/resources/do-nothing.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (185114 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-06-02 19:28:11 UTC (rev 185114)
+++ trunk/LayoutTests/ChangeLog 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-06-02 Brady Eidson <beidson@apple.com>
+
+ Add more tests for "should open external urls" flag.
+ https://bugs.webkit.org/show_bug.cgi?id=145558
+
+ Rubber-stamped by Geoff Garen.
+
+ * loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt: Added.
+ * loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html: Added.
+ * loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt: Added.
+ * loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html: Added.
+ * loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt: Added.
+ * loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html: Added.
+ * loader/navigation-policy/should-open-external-urls/resources/do-nothing.html: Added.
+
</ins><span class="cx"> 2015-06-02 Xabier Rodriguez Calvar <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [Streams API] Implement ReadableStreamReader read method in closed and errored state
</span><span class="lines">@@ -23,7 +38,7 @@
</span><span class="cx"> * streams/reference-implementation/readable-stream-templated-expected.txt:
</span><span class="cx"> * streams/reference-implementation/readable-stream-templated.html:
</span><span class="cx"> * streams/reference-implementation/readable-stream.html:
</span><del>-
</del><ins>+
</ins><span class="cx"> 2015-06-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
</span></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapifalsefollowedbyapitrueexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+ - decidePolicyForNavigationAction
+<NSURLRequest URL resources/do-nothing, main document URL resources/do-nothing, http method GET> is main frame - yes should open URLs externally - no
+ - decidePolicyForNavigationAction
+<NSURLRequest URL resources/notify-done.html, main document URL resources/notify-done.html, http method GET> is main frame - yes should open URLs externally - yes
+
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapifalsefollowedbyapitruehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.dumpPolicyDelegateCallbacks();
+ testRunner.queueLoad("resources/do-nothing");
+ testRunner.queueLoad("resources/notify-done.html", "", true);
+}
+</script>
+This test loads a page via API with the flag not set.<br>
+It then loads a page via API with the flag set to true.<br>
+The first load should have the flag defaulted to false, the second load should have it be true.<br>
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapitruefollowedbyapifalseexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+ - decidePolicyForNavigationAction
+<NSURLRequest URL resources/do-nothing, main document URL resources/do-nothing, http method GET> is main frame - yes should open URLs externally - yes
+ - decidePolicyForNavigationAction
+<NSURLRequest URL resources/notify-done.html, main document URL resources/notify-done.html, http method GET> is main frame - yes should open URLs externally - no
+
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsapitruefollowedbyapifalsehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.dumpPolicyDelegateCallbacks();
+ testRunner.queueLoad("resources/do-nothing", "", true);
+ testRunner.queueLoad("resources/notify-done.html");
+}
+</script>
+This test loads a page via API with the flag set to true.<br>
+It then loads a page via API with the flag not set.<br>
+The second load should have the flag defaulted to false.<br>
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsdispatcheventclickisnotusergestureexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+ - decidePolicyForNavigationAction
+<NSURLRequest URL resources/notify-done.html, main document URL resources/notify-done.html, http method GET> is main frame - yes should open URLs externally - no
+
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsdispatcheventclickisnotusergesturehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+<script>
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.dumpPolicyDelegateCallbacks();
+ testRunner.waitUntilDone();
+}
+
+function runTest()
+{
+ var event = top.document.createEvent('MouseEvent');
+ event.initEvent('click', true, true);
+ document.getElementById('a').dispatchEvent(event);
+}
+
+</script>
+
+<body onload="runTest();">
+This test "clicks" a link using dispatchEvent and checks the "should open external URLs" flag.<br>
+Since the fake click is not a user gesture, the flag should be false.<br>
+<a id="a" href="resources/notify-done.html">Click me to finish</a>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsloadernavigationpolicyshouldopenexternalurlsresourcesdonothinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/resources/do-nothing.html (0 => 185115)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/resources/do-nothing.html (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/resources/do-nothing.html 2015-06-02 19:40:13 UTC (rev 185115)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<body>
+This page does nothing.
+</body>
</ins></span></pre>
</div>
</div>
</body>
</html>