<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[185033] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/185033">185033</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2015-05-30 15:07:37 -0700 (Sat, 30 May 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix Windows tests broken by <a href="http://trac.webkit.org/projects/webkit/changeset/185007">r185007</a>.
https://bugs.webkit.org/show_bug.cgi?id=145472

Unreviewed. Discussed with Alexey Proskuryakov.

No new tests (Fixing the four broken ones should suffice).

The bug was that evaluating arguments in a method/constructor call has no guaranteed sequencing.

Clang seems to always do LTR, allowing the PassRefPtr to be evaluated as a bool in the call to
navigationType() before it is &quot;consumed&quot; by the PassRefPtr argument.

In Visual Studio the PassRefPtr consumption happened before the bool evaluation, meaning `false`
was always passed in to navigationType(), breaking the four tests.

The fix? Using PassRefPtr here was silly in the first place.
No ownership is being transferred.
Raw pointers it is.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):
* loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction):
* loader/NavigationAction.h: Nobody is actually transferring ownership of these Events.
  Raw pointers will work just fine, thanks.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderNavigationActioncpp">trunk/Source/WebCore/loader/NavigationAction.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderNavigationActionh">trunk/Source/WebCore/loader/NavigationAction.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (185032 => 185033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-05-30 21:48:35 UTC (rev 185032)
+++ trunk/Source/WebCore/ChangeLog        2015-05-30 22:07:37 UTC (rev 185033)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2015-05-30  Brady Eidson  &lt;beidson@apple.com&gt;
+
+        Fix Windows tests broken by r185007.
+        https://bugs.webkit.org/show_bug.cgi?id=145472
+
+        Unreviewed. Discussed with Alexey Proskuryakov.
+
+        No new tests (Fixing the four broken ones should suffice).
+
+        The bug was that evaluating arguments in a method/constructor call has no guaranteed sequencing.
+        
+        Clang seems to always do LTR, allowing the PassRefPtr to be evaluated as a bool in the call to
+        navigationType() before it is &quot;consumed&quot; by the PassRefPtr argument.
+        
+        In Visual Studio the PassRefPtr consumption happened before the bool evaluation, meaning `false`
+        was always passed in to navigationType(), breaking the four tests.
+        
+        The fix? Using PassRefPtr here was silly in the first place.
+        No ownership is being transferred.
+        Raw pointers it is.
+        
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::loadURL):
+        (WebCore::FrameLoader::loadPostRequest):
+        * loader/NavigationAction.cpp:
+
+        (WebCore::NavigationAction::NavigationAction):
+        * loader/NavigationAction.h: Nobody is actually transferring ownership of these Events.
+          Raw pointers will work just fine, thanks.
+
</ins><span class="cx"> 2015-05-29  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Unreviewed bindings test rebaseline after r185023.
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (185032 => 185033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp        2015-05-30 21:48:35 UTC (rev 185032)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp        2015-05-30 22:07:37 UTC (rev 185033)
</span><span class="lines">@@ -1230,7 +1230,7 @@
</span><span class="cx">     if (m_pageDismissalEventBeingDispatched != NoDismissal)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    NavigationAction action(request, newLoadType, isFormSubmission, event);
</del><ins>+    NavigationAction action(request, newLoadType, isFormSubmission, event.get());
</ins><span class="cx"> 
</span><span class="cx">     if (!targetFrame &amp;&amp; !frameName.isEmpty()) {
</span><span class="cx">         policyChecker().checkNewWindowPolicy(action, request, formState.release(), frameName, [this, allowNavigationToInvalidURL, openerPolicy](const ResourceRequest&amp; request, PassRefPtr&lt;FormState&gt; formState, const String&amp; frameName, const NavigationAction&amp; action, bool shouldContinue) {
</span><span class="lines">@@ -2643,7 +2643,7 @@
</span><span class="cx">     workingResourceRequest.setHTTPContentType(contentType);
</span><span class="cx">     addExtraFieldsToRequest(workingResourceRequest, loadType, true);
</span><span class="cx"> 
</span><del>-    NavigationAction action(workingResourceRequest, loadType, true, event);
</del><ins>+    NavigationAction action(workingResourceRequest, loadType, true, event.get());
</ins><span class="cx"> 
</span><span class="cx">     if (!frameName.isEmpty()) {
</span><span class="cx">         // The search for a target frame is done earlier in the case of form submission.
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderNavigationActioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/NavigationAction.cpp (185032 => 185033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/NavigationAction.cpp        2015-05-30 21:48:35 UTC (rev 185032)
+++ trunk/Source/WebCore/loader/NavigationAction.cpp        2015-05-30 22:07:37 UTC (rev 185033)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     return NavigationType::Other;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, NavigationType type, PassRefPtr&lt;Event&gt; event, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy)
</del><ins>+NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, NavigationType type, Event* event, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy)
</ins><span class="cx">     : m_resourceRequest(resourceRequest)
</span><span class="cx">     , m_type(type)
</span><span class="cx">     , m_event(event)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, NavigationType type, PassRefPtr&lt;Event&gt; event)
</del><ins>+NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, NavigationType type, Event* event)
</ins><span class="cx">     : NavigationAction(resourceRequest, type, event, ShouldOpenExternalURLsPolicy::ShouldNotAllow)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, FrameLoadType frameLoadType, bool isFormSubmission, PassRefPtr&lt;Event&gt; event)
</del><ins>+NavigationAction::NavigationAction(const ResourceRequest&amp; resourceRequest, FrameLoadType frameLoadType, bool isFormSubmission, Event* event)
</ins><span class="cx">     : NavigationAction(resourceRequest, navigationType(frameLoadType, isFormSubmission, event), event, ShouldOpenExternalURLsPolicy::ShouldNotAllow)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderNavigationActionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/NavigationAction.h (185032 => 185033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/NavigationAction.h        2015-05-30 21:48:35 UTC (rev 185032)
+++ trunk/Source/WebCore/loader/NavigationAction.h        2015-05-30 22:07:37 UTC (rev 185033)
</span><span class="lines">@@ -43,10 +43,10 @@
</span><span class="cx">     WEBCORE_EXPORT explicit NavigationAction(const ResourceRequest&amp;);
</span><span class="cx">     WEBCORE_EXPORT NavigationAction(const ResourceRequest&amp;, NavigationType);
</span><span class="cx">     WEBCORE_EXPORT NavigationAction(const ResourceRequest&amp;, FrameLoadType, bool isFormSubmission);
</span><del>-    NavigationAction(const ResourceRequest&amp;, NavigationType, PassRefPtr&lt;Event&gt;);
-    NavigationAction(const ResourceRequest&amp;, NavigationType, PassRefPtr&lt;Event&gt;, ShouldOpenExternalURLsPolicy);
</del><ins>+    NavigationAction(const ResourceRequest&amp;, NavigationType, Event*);
+    NavigationAction(const ResourceRequest&amp;, NavigationType, Event*, ShouldOpenExternalURLsPolicy);
</ins><span class="cx">     NavigationAction(const ResourceRequest&amp;, NavigationType, ShouldOpenExternalURLsPolicy);
</span><del>-    NavigationAction(const ResourceRequest&amp;, FrameLoadType, bool isFormSubmission, PassRefPtr&lt;Event&gt;);
</del><ins>+    NavigationAction(const ResourceRequest&amp;, FrameLoadType, bool isFormSubmission, Event*);
</ins><span class="cx"> 
</span><span class="cx">     bool isEmpty() const { return m_resourceRequest.url().isEmpty(); }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>