<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184978] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184978">184978</a></dd>
<dt>Author</dt> <dd>nvasilyev@apple.com</dd>
<dt>Date</dt> <dd>2015-05-28 21:50:59 -0700 (Thu, 28 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Update toolbar styles
https://bugs.webkit.org/show_bug.cgi?id=145419
Also, use hairline borders (1 phisical pixel) on retina (DPI >= 2).
Reviewed by Timothy Hatcher.
* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button): Deleted.
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar .item.button > .glyph): Deleted.
(.toolbar.small-size .item.button > .glyph): Deleted.
* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container): Deleted.
(.toolbar.collapsed .dashboard-container): Deleted.
(.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar .dashboard.slide-out-down): Deleted.
(.toolbar .dashboard.slide-in-up): Deleted.
* UserInterface/Views/Toolbar.css:
(.toolbar .search-bar > input[type="search"]):
(.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
(body:not(.unknown-mac) .toolbar .dashboard-container):
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus):
(body:not(.unknown-mac) .toolbar .item.button:active):
(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
(body.unknown-mac .toolbar .dashboard-container):
(body.unknown-mac .toolbar .search-bar > input[type="search"]):
(body.unknown-mac .toolbar .search-bar > input[type="search"]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.unknown-mac .toolbar .item.button:active):
(body.unknown-mac.window-inactive .toolbar .dashboard-container):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsButtonToolbarItemcss">trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDashboardContainerViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsToolbarcss">trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (184977 => 184978)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-29 04:50:59 UTC (rev 184978)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2015-05-28 Nikita Vasilyev <nvasilyev@apple.com>
+
+ Web Inspector: Update toolbar styles
+ https://bugs.webkit.org/show_bug.cgi?id=145419
+
+ Also, use hairline borders (1 phisical pixel) on retina (DPI >= 2).
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ButtonToolbarItem.css:
+ (.toolbar .item.button): Deleted.
+ (.toolbar.icon-and-label-vertical .item.button): Deleted.
+ (.toolbar.icon-and-label-horizontal .item.button): Deleted.
+ (.toolbar .item.button > .glyph): Deleted.
+ (.toolbar.small-size .item.button > .glyph): Deleted.
+ * UserInterface/Views/DashboardContainerView.css:
+ (.toolbar .dashboard-container): Deleted.
+ (.toolbar.collapsed .dashboard-container): Deleted.
+ (.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
+ (.toolbar .dashboard.slide-out-down): Deleted.
+ (.toolbar .dashboard.slide-in-up): Deleted.
+ * UserInterface/Views/Toolbar.css:
+ (.toolbar .search-bar > input[type="search"]):
+ (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
+ (body:not(.unknown-mac) .toolbar .dashboard-container):
+ (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
+ (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus):
+ (body:not(.unknown-mac) .toolbar .item.button:active):
+ (body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
+ (body.unknown-mac .toolbar .dashboard-container):
+ (body.unknown-mac .toolbar .search-bar > input[type="search"]):
+ (body.unknown-mac .toolbar .search-bar > input[type="search"]:focus):
+ (@media (-webkit-min-device-pixel-ratio: 2)):
+ (body.unknown-mac .toolbar .item.button:active):
+ (body.unknown-mac.window-inactive .toolbar .dashboard-container):
+
</ins><span class="cx"> 2015-05-28 Devin Rousso <drousso@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Jump from a computed style to the rule it came from
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsButtonToolbarItemcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css (184977 => 184978)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css 2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css 2015-05-29 04:50:59 UTC (rev 184978)
</span><span class="lines">@@ -27,30 +27,10 @@
</span><span class="cx"> align-items: center;
</span><span class="cx"> justify-content: center;
</span><span class="cx">
</span><del>- border-radius: 4px;
- background-color: rgb(252, 252, 252);
-
- border: 1px solid transparent;
- border-top-color: white;
-
- box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0;
-
</del><span class="cx"> margin: 4px;
</span><del>-
</del><span class="cx"> padding: 0 10px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.toolbar .item.button:active {
- border-top-color: rgb(241, 241, 241);
- background-color: rgb(228, 228, 228);
-}
-
-body.window-inactive .toolbar .item.button {
- border: 1px solid rgb(220, 220, 220);
- background-color: rgb(246, 246, 246);
- box-shadow: none;
-}
-
</del><span class="cx"> .toolbar.icon-and-label-vertical .item.button {
</span><span class="cx"> flex-direction: column;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDashboardContainerViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (184977 => 184978)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-05-29 04:50:59 UTC (rev 184978)
</span><span class="lines">@@ -25,26 +25,13 @@
</span><span class="cx">
</span><span class="cx"> .toolbar .dashboard-container {
</span><span class="cx"> position: relative;
</span><del>-
</del><span class="cx"> width: 36vw;
</span><span class="cx">
</span><span class="cx"> border-radius: 4px;
</span><del>- background-color: rgb(252, 252, 252);
-
- border: 1px solid transparent;
- border-top-color: white;
-
- box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0;
-
</del><span class="cx"> margin: 4px;
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-body.window-inactive .toolbar .dashboard-container {
- border: 1px solid rgb(220, 220, 220);
- background-color: rgb(246, 246, 246);
- box-shadow: none;
-}
</del><span class="cx">
</span><span class="cx"> .toolbar.collapsed .dashboard-container {
</span><span class="cx"> width: 175px;
</span><span class="lines">@@ -81,11 +68,6 @@
</span><span class="cx"> -webkit-animation-duration: 0.4s;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-body.window-inactive .toolbar .dashboard {
- background-color: rgb(246, 246, 246);
- box-shadow: none;
-}
-
</del><span class="cx"> .toolbar .dashboard.visible {
</span><span class="cx"> z-index: 1; /* Establish a stacking context. */
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsToolbarcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (184977 => 184978)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2015-05-29 04:47:39 UTC (rev 184977)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2015-05-29 04:50:59 UTC (rev 184978)
</span><span class="lines">@@ -105,33 +105,96 @@
</span><span class="cx">
</span><span class="cx"> .toolbar .search-bar > input[type="search"] {
</span><span class="cx"> width: 100%;
</span><del>-
</del><span class="cx"> font-size: 12px;
</span><ins>+ background-clip: initial;
+ margin: 4px;
+}
</ins><span class="cx">
</span><del>- border-radius: 4px;
- background-color: rgb(252, 252, 252) !important;
</del><ins>+.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container {
+ margin-left: 4px;
+}
</ins><span class="cx">
</span><ins>+body:not(.unknown-mac) .toolbar .item.button,
+body:not(.unknown-mac) .toolbar .search-bar > input[type="search"],
+body:not(.unknown-mac) .toolbar .dashboard-container {
+ background-color: hsl(0, 0%, 99%);
</ins><span class="cx"> border: 1px solid transparent;
</span><del>- border-top-color: white;
</del><ins>+ border-top-color: hsl(0, 0%, 100%);
+ box-shadow: hsla(0, 0%, 0%, 0.15) 0 1px 0;
+ border-radius: 4px;
+}
</ins><span class="cx">
</span><del>- background-clip: initial;
</del><ins>+body:not(.unknown-mac) .toolbar .search-bar > input[type="search"] {
+ box-shadow: hsla(0, 0%, 0%, 0.3) 0 1px 1px -1px, 0 0 0 7px hsla(211, 96%, 48%, 0);
+ transition: box-shadow .25s cubic-bezier(0.165, 0.840, 0.440, 1) /* easeOutQuart */;
+}
</ins><span class="cx">
</span><del>- margin: 4px;
</del><ins>+body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus {
+ box-shadow: hsla(0, 0%, 0%, 0.15) 0 1px 0, 0 0 0 3px hsla(211, 96%, 48%, 0.4);
+}
</ins><span class="cx">
</span><del>- box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0, 0 0 0 7px hsla(211, 96%, 48%, 0);
</del><ins>+body:not(.unknown-mac) .toolbar .item.button:active {
+ border-top-color: hsl(0, 0%, 94%);
+ background-color: hsl(0, 0%, 89%);
+}
+
+body.window-inactive:not(.unknown-mac) .toolbar .item.button,
+body.window-inactive:not(.unknown-mac) .toolbar .search-bar > input[type="search"],
+body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container {
+ border: 1px solid hsl(0, 0%, 86%);
+ background-color: hsl(0, 0%, 96%);
+ box-shadow: none;
+}
+
+body.unknown-mac .toolbar .item.button,
+body.unknown-mac .toolbar .search-bar > input[type="search"],
+body.unknown-mac .toolbar .dashboard-container {
+ background-image: linear-gradient(hsl(0, 0%, 99%), hsl(0, 0%, 94%));
+ box-shadow: hsla(0, 0%, 0%, 0.3) 0 1px 1px -1px;
+
+ border-radius: 4px;
+ border: 1px solid hsl(0, 1%, 82%);
+ border-top-color: hsl(0, 0%, 83%);
+ border-bottom-color: hsl(0, 0%, 76%);
+}
+
+body.unknown-mac .toolbar .search-bar > input[type="search"] {
+ box-shadow: hsla(0, 0%, 0%, 0.3) 0 1px 1px -1px, 0 0 0 7px hsla(211, 96%, 48%, 0);
</ins><span class="cx"> transition: box-shadow .25s cubic-bezier(0.165, 0.840, 0.440, 1) /* easeOutQuart */;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.toolbar .search-bar > input[type="search"]:focus {
- box-shadow: rgba(0, 0, 0, 0.15) 0 1px 0, 0 0 0 3px hsla(211, 96%, 48%, 0.4);
</del><ins>+body.unknown-mac .toolbar .search-bar > input[type="search"]:focus {
+ box-shadow: hsla(0, 0%, 0%, 0.15) 0 1px 0, 0 0 0 3px hsla(211, 96%, 48%, 0.4);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container {
- margin-left: 4px;
</del><ins>+@media (-webkit-min-device-pixel-ratio: 2) {
+ body.unknown-mac .toolbar .item.button,
+ body.unknown-mac .toolbar .search-bar > input[type="search"],
+ body.unknown-mac .toolbar .dashboard-container {
+ border: 0.5px solid hsl(0, 0%, 78%);
+ border-top-color: hsl(0, 0%, 80%);
+ border-bottom-color: hsl(0, 0%, 65%);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-body.window-inactive .toolbar .search-bar > input[type="search"] {
- border: 1px solid rgb(220, 220, 220);
- background-color: rgb(246, 246, 246);
- box-shadow: none;
</del><ins>+body.unknown-mac .toolbar .item.button:active {
+ background-image: linear-gradient(hsl(0, 0%, 89%), hsl(0, 0%, 86%));
+ box-shadow: hsla(0, 0%, 0%, 0.3) 0 1px 1px -1px, inset 0 1px 1px -1px white;
</ins><span class="cx"> }
</span><ins>+
+body.unknown-mac.window-inactive .toolbar .item.button,
+body.unknown-mac.window-inactive .toolbar .search-bar > input[type="search"],
+body.unknown-mac.window-inactive .toolbar .dashboard-container {
+ opacity: 0.65;
+ border-color: hsla(0, 0%, 0%, 0.15);
+ background-color: transparent;
+ background-image: none;
+}
+
+@media (-webkit-min-device-pixel-ratio: 2) {
+ body.unknown-mac.window-inactive .toolbar .item.button,
+ body.unknown-mac.window-inactive .toolbar .search-bar > input[type="search"],
+ body.unknown-mac.window-inactive .toolbar .dashboard-container {
+ box-shadow: inset 0 0 1px 0 hsla(0, 0%, 0%, 0.1);
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>