<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184970] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184970">184970</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-05-28 17:15:24 -0700 (Thu, 28 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Pixel crack in text selection of simple text in <textarea>.
https://bugs.webkit.org/show_bug.cgi?id=145393
rdar://problem/19918941
Reviewed by Darin Adler.
Float to LayoutUnit conversion is lossy. To ensure that selection
painting always lines up (snaps) properly, the calculated width needs to
be adjusted by ceiling the float to the next LayoutUnit value.
Source/WebCore:
Test: fast/text/hidpi-text-selection-gap-between-words.html
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::adjustSelectionRectForSimpleText):
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::adjustSelectionRectForComplexText):
LayoutTests:
* fast/text/hidpi-text-selection-gap-between-words-expected.html: Added.
* fast/text/hidpi-text-selection-gap-between-words.html: Added.
* platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacplatformmaceditinginputcaretprimarybidiexpectedtxt">trunk/LayoutTests/platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontCascadecpp">trunk/Source/WebCore/platform/graphics/FontCascade.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscocoaFontCascadeCocoamm">trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttexthidpitextselectiongapbetweenwordsexpectedhtml">trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasttexthidpitextselectiongapbetweenwordshtml">trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (184969 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-28 23:51:57 UTC (rev 184969)
+++ trunk/LayoutTests/ChangeLog 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-05-28 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Pixel crack in text selection of simple text in <textarea>.
+ https://bugs.webkit.org/show_bug.cgi?id=145393
+ rdar://problem/19918941
+
+ Reviewed by Darin Adler.
+
+ Float to LayoutUnit conversion is lossy. To ensure that selection
+ painting always lines up (snaps) properly, the calculated width needs to
+ be adjusted by ceiling the float to the next LayoutUnit value.
+
+ * fast/text/hidpi-text-selection-gap-between-words-expected.html: Added.
+ * fast/text/hidpi-text-selection-gap-between-words.html: Added.
+ * platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt:
+
</ins><span class="cx"> 2015-05-28 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> GraphicsLayerCA should start out with m_intersectsCoverageRect=false
</span></span></pre></div>
<a id="trunkLayoutTestsfasttexthidpitextselectiongapbetweenwordsexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words-expected.html (0 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words-expected.html 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that selection rect does not have gaps inbetween words.</title>
+<style>
+ div {
+ position: absolute;
+ top: 8px;
+ left: 0px;
+ width: 7px;
+ height: 13px;
+ background: rgba(0, 96, 0, 0.8);
+ }
+</style>
+</head>
+<body>
+ <div></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfasttexthidpitextselectiongapbetweenwordshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words.html (0 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words.html (rev 0)
+++ trunk/LayoutTests/fast/text/hidpi-text-selection-gap-between-words.html 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that selection rect does not have gaps inbetween words.</title>
+<style>
+ div {
+ font-family: monospace;
+ font-size: 11px;
+ width: 500px;
+ white-space: pre-wrap;
+ color: white;
+ margin-left: -351px;
+ }
+
+ div::selection {
+ background: green;
+ }
+</style>
+</head>
+<body>
+ <div id=target>Inspector doesn't do this. I have been aware of this </div>
+ <script>
+ var target = document.getElementById("target");
+ getSelection().setBaseAndExtent(target.firstChild, 48, target.firstChild, 53);
+ </script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacplatformmaceditinginputcaretprimarybidiexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt (184969 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt 2015-05-28 23:51:57 UTC (rev 184969)
+++ trunk/LayoutTests/platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> 34: 32,478,0,28
</span><span class="cx"> 35: 18,478,0,28
</span><span class="cx"> 36: 47,478,0,28
</span><del>-37: 60,478,0,28
</del><ins>+37: 61,478,0,28
</ins><span class="cx"> 38: 76,478,0,28
</span><span class="cx"> 39: 88,478,0,28
</span><span class="cx"> 40: 113,478,0,28
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184969 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-28 23:51:57 UTC (rev 184969)
+++ trunk/Source/WebCore/ChangeLog 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-05-28 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Pixel crack in text selection of simple text in <textarea>.
+ https://bugs.webkit.org/show_bug.cgi?id=145393
+ rdar://problem/19918941
+
+ Reviewed by Darin Adler.
+
+ Float to LayoutUnit conversion is lossy. To ensure that selection
+ painting always lines up (snaps) properly, the calculated width needs to
+ be adjusted by ceiling the float to the next LayoutUnit value.
+
+ Test: fast/text/hidpi-text-selection-gap-between-words.html
+
+ * platform/graphics/FontCascade.cpp:
+ (WebCore::FontCascade::adjustSelectionRectForSimpleText):
+ * platform/graphics/cocoa/FontCascadeCocoa.mm:
+ (WebCore::FontCascade::adjustSelectionRectForComplexText):
+
</ins><span class="cx"> 2015-05-28 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> GraphicsLayerCA should start out with m_intersectsCoverageRect=false
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontCascadecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (184969 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2015-05-28 23:51:57 UTC (rev 184969)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -1476,7 +1476,7 @@
</span><span class="cx"> selectionRect.move(totalWidth - afterWidth, 0);
</span><span class="cx"> } else
</span><span class="cx"> selectionRect.move(beforeWidth, 0);
</span><del>- selectionRect.setWidth(afterWidth - beforeWidth);
</del><ins>+ selectionRect.setWidth(LayoutUnit::fromFloatCeil(afterWidth - beforeWidth));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int FontCascade::offsetForPositionForSimpleText(const TextRun& run, float x, bool includePartialGlyphs) const
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscocoaFontCascadeCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm (184969 => 184970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm 2015-05-28 23:51:57 UTC (rev 184969)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm 2015-05-29 00:15:24 UTC (rev 184970)
</span><span class="lines">@@ -708,7 +708,7 @@
</span><span class="cx"> selectionRect.move(controller.totalWidth() - afterWidth + controller.leadingExpansion(), 0);
</span><span class="cx"> else
</span><span class="cx"> selectionRect.move(beforeWidth, 0);
</span><del>- selectionRect.setWidth(afterWidth - beforeWidth);
</del><ins>+ selectionRect.setWidth(LayoutUnit::fromFloatCeil(afterWidth - beforeWidth));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> float FontCascade::getGlyphsAndAdvancesForComplexText(const TextRun& run, int from, int to, GlyphBuffer& glyphBuffer, ForTextEmphasisOrNot forTextEmphasis) const
</span></span></pre>
</div>
</div>
</body>
</html>