<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184906] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184906">184906</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2015-05-27 09:52:51 -0700 (Wed, 27 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
https://bugs.webkit.org/show_bug.cgi?id=145403
Reviewed by Anders Carlsson.
JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 was used to enable the JavaScriptCore Objective-C API
for WebKit and Safari projects building with JavaScriptCore targeting OS X 10.8. We don’t
need it anymore.
* API/JSBase.h:
* API/JSContext.h:
* API/JSManagedValue.h:
* API/JSValue.h:
* API/JSVirtualMachine.h:
* Configurations/Base.xcconfig:
* postprocess-headers.sh:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSBaseh">trunk/Source/JavaScriptCore/API/JSBase.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSContexth">trunk/Source/JavaScriptCore/API/JSContext.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSManagedValueh">trunk/Source/JavaScriptCore/API/JSManagedValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSValueh">trunk/Source/JavaScriptCore/API/JSValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSVirtualMachineh">trunk/Source/JavaScriptCore/API/JSVirtualMachine.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsBasexcconfig">trunk/Source/JavaScriptCore/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceJavaScriptCorepostprocessheaderssh">trunk/Source/JavaScriptCore/postprocess-headers.sh</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSBase.h (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSBase.h 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/API/JSBase.h 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -141,11 +141,7 @@
</span><span class="cx">
</span><span class="cx"> /* Enable the Objective-C API for platforms with a modern runtime. */
</span><span class="cx"> #if !defined(JSC_OBJC_API_ENABLED)
</span><del>-#ifndef JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
</del><span class="cx"> #define JSC_OBJC_API_ENABLED (defined(__clang__) && defined(__APPLE__) && ((defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 && !defined(__i386__)) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)))
</span><del>-#else
-#define JSC_OBJC_API_ENABLED (defined(__clang__) && defined(__APPLE__) && ((defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !defined(__i386__)) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)))
</del><span class="cx"> #endif
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> #endif /* JSBase_h */
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSContext.h (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSContext.h 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/API/JSContext.h 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -44,11 +44,7 @@
</span><span class="cx"> that reference a particular JSContext have been deallocated the JSContext
</span><span class="cx"> will be deallocated unless it has been previously retained.
</span><span class="cx"> */
</span><del>-#ifndef JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
</del><span class="cx"> NS_CLASS_AVAILABLE(10_9, 7_0)
</span><del>-#else
-OBJC_VISIBLE
-#endif
</del><span class="cx"> @interface JSContext : NSObject
</span><span class="cx">
</span><span class="cx"> /*!
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSManagedValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSManagedValue.h (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSManagedValue.h 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/API/JSManagedValue.h 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -50,11 +50,7 @@
</span><span class="cx"> Objective-C heap object, as this can very easily create a reference cycle,
</span><span class="cx"> keeping the entire JSContext alive.
</span><span class="cx"> */
</span><del>-#ifndef JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
</del><span class="cx"> NS_CLASS_AVAILABLE(10_9, 7_0)
</span><del>-#else
-OBJC_VISIBLE
-#endif
</del><span class="cx"> @interface JSManagedValue : NSObject
</span><span class="cx">
</span><span class="cx"> /*!
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSValue.h (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSValue.h 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/API/JSValue.h 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -50,11 +50,7 @@
</span><span class="cx"> from a different JSVirtualMachine will result in an Objective-C exception
</span><span class="cx"> being raised.
</span><span class="cx"> */
</span><del>-#ifndef JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
</del><span class="cx"> NS_CLASS_AVAILABLE(10_9, 7_0)
</span><del>-#else
-OBJC_VISIBLE
-#endif
</del><span class="cx"> @interface JSValue : NSObject
</span><span class="cx">
</span><span class="cx"> /*!
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSVirtualMachineh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSVirtualMachine.h (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSVirtualMachine.h 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/API/JSVirtualMachine.h 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -34,11 +34,7 @@
</span><span class="cx"> virtual machine, with concurrent JavaScript execution supported by allocating
</span><span class="cx"> separate instances of JSVirtualMachine.
</span><span class="cx"> */
</span><del>-#ifndef JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
</del><span class="cx"> NS_CLASS_AVAILABLE(10_9, 7_0)
</span><del>-#else
-OBJC_VISIBLE
-#endif
</del><span class="cx"> @interface JSVirtualMachine : NSObject
</span><span class="cx">
</span><span class="cx"> /*!
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-05-27 Dan Bernstein <mitz@apple.com>
+
+ Remove JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
+ https://bugs.webkit.org/show_bug.cgi?id=145403
+
+ Reviewed by Anders Carlsson.
+
+ JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 was used to enable the JavaScriptCore Objective-C API
+ for WebKit and Safari projects building with JavaScriptCore targeting OS X 10.8. We don’t
+ need it anymore.
+
+ * API/JSBase.h:
+ * API/JSContext.h:
+ * API/JSManagedValue.h:
+ * API/JSValue.h:
+ * API/JSVirtualMachine.h:
+ * Configurations/Base.xcconfig:
+ * postprocess-headers.sh:
+
</ins><span class="cx"> 2015-05-26 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> Photo Booth hangs under JSC::MachineThreads::tryCopyOtherThreadStacks
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/Base.xcconfig (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> GCC_MODEL_TUNING[sdk=macosx*] = G5;
</span><span class="cx"> GCC_OBJC_CALL_CXX_CDTORS = YES;
</span><span class="cx"> GCC_PRECOMPILE_PREFIX_HEADER = YES;
</span><del>-GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) HAVE_HEADER_DETECTION_H JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 $(FEATURE_DEFINES) $(inherited);
</del><ins>+GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) HAVE_HEADER_DETECTION_H $(FEATURE_DEFINES) $(inherited);
</ins><span class="cx"> GCC_STRICT_ALIASING = YES;
</span><span class="cx"> GCC_THREADSAFE_STATICS = NO;
</span><span class="cx"> GCC_TREAT_WARNINGS_AS_ERRORS = YES;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorepostprocessheaderssh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/postprocess-headers.sh (184905 => 184906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/postprocess-headers.sh 2015-05-27 16:08:45 UTC (rev 184905)
+++ trunk/Source/JavaScriptCore/postprocess-headers.sh 2015-05-27 16:52:51 UTC (rev 184906)
</span><span class="lines">@@ -1,13 +1,7 @@
</span><span class="cx"> cd "${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}"
</span><span class="cx">
</span><del>-if [[ ${TARGET_MAC_OS_X_VERSION_MAJOR} == "1080" ]]; then
- UNIFDEF_OPTIONS="-DJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080";
-else
- UNIFDEF_OPTIONS="-UJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080";
-fi
</del><ins>+UNIFDEF_OPTIONS="-D__MAC_OS_X_VERSION_MIN_REQUIRED=${TARGET_MAC_OS_X_VERSION_MAJOR}"
</ins><span class="cx">
</span><del>-UNIFDEF_OPTIONS+=" -D__MAC_OS_X_VERSION_MIN_REQUIRED=${TARGET_MAC_OS_X_VERSION_MAJOR}"
-
</del><span class="cx"> for ((i = 0; i < ${SCRIPT_INPUT_FILE_COUNT}; ++i)); do
</span><span class="cx"> eval HEADER=\${SCRIPT_INPUT_FILE_${i}};
</span><span class="cx"> unifdef -B ${UNIFDEF_OPTIONS} -o ${HEADER}.unifdef ${HEADER}
</span><span class="lines">@@ -22,4 +16,3 @@
</span><span class="cx"> exit 1
</span><span class="cx"> esac
</span><span class="cx"> done
</span><del>-
</del></span></pre>
</div>
</div>
</body>
</html>