<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184858] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184858">184858</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-05-26 10:23:49 -0700 (Tue, 26 May 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
https://bugs.webkit.org/show_bug.cgi?id=145342

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (184857 => 184858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js        2015-05-26 11:53:15 UTC (rev 184857)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js        2015-05-26 17:23:49 UTC (rev 184858)
</span><span class="lines">@@ -64,29 +64,26 @@
</span><span class="cx"> BuildbotIteration.RETRY = 5;
</span><span class="cx"> 
</span><span class="cx"> // If none of these steps ran, then we didn't get any real results, and the iteration was not productive.
</span><ins>+// All test steps are considered productive too.
</ins><span class="cx"> BuildbotIteration.ProductiveSteps = {
</span><del>-    &quot;compile-webkit&quot;: 1,
-    &quot;build ASan archive&quot;: 1,
</del><span class="cx">     &quot;Build&quot; : 1,
</span><del>-    &quot;layout-test&quot;: 1,
-    &quot;jscore-test&quot;: 1,
-    &quot;run-api-tests&quot;: 1,
-    &quot;API tests&quot;: 1,
-    &quot;webkitpy-test&quot;: 1,
-    &quot;webkitperl-test&quot;: 1,
-    &quot;bindings-generation-tests&quot;: 1,
-    &quot;perf-test&quot;: 1,
</del><ins>+    &quot;build ASan archive&quot;: 1,
+    &quot;compile-webkit&quot;: 1,
</ins><span class="cx">     &quot;scan build&quot;: 1,
</span><span class="cx"> };
</span><span class="cx"> 
</span><ins>+// These have a special meaning for test queue views.
</ins><span class="cx"> BuildbotIteration.TestSteps = {
</span><del>-    &quot;layout-test&quot;: &quot;layout test&quot;,
</del><ins>+    &quot;API tests&quot;: &quot;platform api test&quot;,
+    &quot;bindings-generation-tests&quot;: &quot;bindings tests&quot;,
</ins><span class="cx">     &quot;jscore-test&quot;: &quot;javascript test&quot;,
</span><ins>+    &quot;layout-test&quot;: &quot;layout test&quot;,
+    &quot;perf-test&quot;: &quot;performance test&quot;,
</ins><span class="cx">     &quot;run-api-tests&quot;: &quot;api test&quot;,
</span><del>-    &quot;API tests&quot;: &quot;platform api test&quot;,
-    &quot;webkitpy-test&quot;: &quot;webkitpy test&quot;,
</del><ins>+    &quot;webkit-32bit-jsc-test&quot;: &quot;javascript test&quot;,
+    &quot;webkit-jsc-cloop-test&quot;: &quot;javascript cloop test&quot;,
</ins><span class="cx">     &quot;webkitperl-test&quot;: &quot;webkitperl test&quot;,
</span><del>-    &quot;bindings-generation-tests&quot;: &quot;bindings tests&quot;,
</del><ins>+    &quot;webkitpy-test&quot;: &quot;webkitpy test&quot;,
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> BuildbotIteration.Event = {
</span><span class="lines">@@ -274,7 +271,7 @@
</span><span class="cx">                 var step = data.steps[i];
</span><span class="cx">                 if (!step.isFinished)
</span><span class="cx">                     break;
</span><del>-                if (step.name in BuildbotIteration.ProductiveSteps) {
</del><ins>+                if (step.name in BuildbotIteration.ProductiveSteps || step.name in BuildbotIteration.TestSteps) {
</ins><span class="cx">                     finishedAnyProductiveStep = true;
</span><span class="cx">                     break;
</span><span class="cx">                 }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (184857 => 184858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2015-05-26 11:53:15 UTC (rev 184857)
+++ trunk/Tools/ChangeLog        2015-05-26 17:23:49 UTC (rev 184858)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-05-26  Alexey Proskuryakov  &lt;ap@apple.com&gt;
+
+        build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
+        https://bugs.webkit.org/show_bug.cgi?id=145342
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        (BuildbotIteration.prototype._parseData):
+
</ins><span class="cx"> 2015-05-26  Milan Crha  &lt;mcrha@redhat.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
</span></span></pre>
</div>
</div>

</body>
</html>