<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184869] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184869">184869</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-26 12:50:18 -0700 (Tue, 26 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
https://bugs.webkit.org/show_bug.cgi?id=145343
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-05-26
Reviewed by Timothy Hatcher.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
LayoutTests:
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-font-family-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcssgetComputedStylecomputedstyleexpectedtxt">trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgetComputedStylecomputedstylefontfamilyexpectedtxt">trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgetComputedStylecomputedstylewithoutrendererexpectedtxt">trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgetComputedStyleresourcespropertynamesjs">trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js</a></li>
<li><a href="#trunkLayoutTestssvgcssgetComputedStylebasicexpectedtxt">trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/ChangeLog 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-05-26 Joseph Pecoraro <pecoraro@apple.com>
+
+ CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
+ https://bugs.webkit.org/show_bug.cgi?id=145343
+
+ Reviewed by Timothy Hatcher.
+
+ * fast/css/getComputedStyle/computed-style-expected.txt:
+ * fast/css/getComputedStyle/computed-style-font-family-expected.txt:
+ * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+ * fast/css/getComputedStyle/resources/property-names.js:
+
</ins><span class="cx"> 2015-05-26 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Implement Array.prototype.copyWithin
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgetComputedStylecomputedstyleexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> float: none;
</span><span class="cx"> font-size: 16px;
</span><span class="cx"> font-style: normal;
</span><ins>+font-synthesis: style weight;
</ins><span class="cx"> font-variant: normal;
</span><span class="cx"> font-weight: normal;
</span><span class="cx"> height: 576px;
</span><span class="lines">@@ -140,6 +141,7 @@
</span><span class="cx"> -webkit-column-break-inside: auto;
</span><span class="cx"> -webkit-column-axis: auto;
</span><span class="cx"> column-count: auto;
</span><ins>+column-fill: balance;
</ins><span class="cx"> column-gap: normal;
</span><span class="cx"> column-rule-color: rgb(0, 0, 0);
</span><span class="cx"> column-rule-style: none;
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgetComputedStylecomputedstylefontfamilyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> font-family: monospace, 'Lucida Grande', sans-serif;
</span><span class="cx"> font-size: 16px;
</span><span class="cx"> font-style: normal;
</span><ins>+font-synthesis: style weight;
</ins><span class="cx"> font-variant: normal;
</span><span class="cx"> font-weight: normal;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgetComputedStylecomputedstylewithoutrendererexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -43,6 +43,7 @@
</span><span class="cx"> float: none
</span><span class="cx"> font-size: 16px
</span><span class="cx"> font-style: normal
</span><ins>+font-synthesis: style weight
</ins><span class="cx"> font-variant: normal
</span><span class="cx"> font-weight: normal
</span><span class="cx"> height: 100px
</span><span class="lines">@@ -139,6 +140,7 @@
</span><span class="cx"> -webkit-column-break-inside: auto
</span><span class="cx"> -webkit-column-axis: auto
</span><span class="cx"> column-count: auto
</span><ins>+column-fill: balance
</ins><span class="cx"> column-gap: normal
</span><span class="cx"> column-rule-color: rgb(0, 0, 0)
</span><span class="cx"> column-rule-style: none
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgetComputedStyleresourcespropertynamesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> "-webkit-column-break-before": true,
</span><span class="cx"> "-webkit-column-break-inside": true,
</span><span class="cx"> "column-count": true,
</span><ins>+ "column-fill": true,
</ins><span class="cx"> "column-gap": true,
</span><span class="cx"> "column-rule-color": true,
</span><span class="cx"> "column-rule-style": true,
</span><span class="lines">@@ -181,6 +182,7 @@
</span><span class="cx"> "flood-opacity": true,
</span><span class="cx"> "font-size": true,
</span><span class="cx"> "font-style": true,
</span><ins>+ "font-synthesis": true,
</ins><span class="cx"> "font-variant": true,
</span><span class="cx"> "font-weight": true,
</span><span class="cx"> "glyph-orientation-horizontal": true,
</span></span></pre></div>
<a id="trunkLayoutTestssvgcssgetComputedStylebasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -86,6 +86,8 @@
</span><span class="cx"> rect: style.getPropertyCSSValue(font-size) : [object CSSPrimitiveValue]
</span><span class="cx"> rect: style.getPropertyValue(font-style) : normal
</span><span class="cx"> rect: style.getPropertyCSSValue(font-style) : [object CSSPrimitiveValue]
</span><ins>+rect: style.getPropertyValue(font-synthesis) : style weight
+rect: style.getPropertyCSSValue(font-synthesis) : [object CSSValueList]
</ins><span class="cx"> rect: style.getPropertyValue(font-variant) : normal
</span><span class="cx"> rect: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
</span><span class="cx"> rect: style.getPropertyValue(font-weight) : normal
</span><span class="lines">@@ -278,6 +280,8 @@
</span><span class="cx"> rect: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue]
</span><span class="cx"> rect: style.getPropertyValue(column-count) : auto
</span><span class="cx"> rect: style.getPropertyCSSValue(column-count) : [object CSSPrimitiveValue]
</span><ins>+rect: style.getPropertyValue(column-fill) : balance
+rect: style.getPropertyCSSValue(column-fill) : [object CSSPrimitiveValue]
</ins><span class="cx"> rect: style.getPropertyValue(column-gap) : normal
</span><span class="cx"> rect: style.getPropertyCSSValue(column-gap) : [object CSSPrimitiveValue]
</span><span class="cx"> rect: style.getPropertyValue(column-rule-color) : rgb(0, 0, 0)
</span><span class="lines">@@ -604,6 +608,8 @@
</span><span class="cx"> g: style.getPropertyCSSValue(font-size) : [object CSSPrimitiveValue]
</span><span class="cx"> g: style.getPropertyValue(font-style) : normal
</span><span class="cx"> g: style.getPropertyCSSValue(font-style) : [object CSSPrimitiveValue]
</span><ins>+g: style.getPropertyValue(font-synthesis) : style weight
+g: style.getPropertyCSSValue(font-synthesis) : [object CSSValueList]
</ins><span class="cx"> g: style.getPropertyValue(font-variant) : normal
</span><span class="cx"> g: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
</span><span class="cx"> g: style.getPropertyValue(font-weight) : normal
</span><span class="lines">@@ -796,6 +802,8 @@
</span><span class="cx"> g: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue]
</span><span class="cx"> g: style.getPropertyValue(column-count) : auto
</span><span class="cx"> g: style.getPropertyCSSValue(column-count) : [object CSSPrimitiveValue]
</span><ins>+g: style.getPropertyValue(column-fill) : balance
+g: style.getPropertyCSSValue(column-fill) : [object CSSPrimitiveValue]
</ins><span class="cx"> g: style.getPropertyValue(column-gap) : normal
</span><span class="cx"> g: style.getPropertyCSSValue(column-gap) : [object CSSPrimitiveValue]
</span><span class="cx"> g: style.getPropertyValue(column-rule-color) : rgb(0, 0, 0)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/Source/WebCore/ChangeLog 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-05-26 Joseph Pecoraro <pecoraro@apple.com>
+
+ CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
+ https://bugs.webkit.org/show_bug.cgi?id=145343
+
+ Reviewed by Timothy Hatcher.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+
</ins><span class="cx"> 2015-05-26 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> <rdar://problem/21104551> Update build settings
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (184868 => 184869)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2015-05-26 19:50:18 UTC (rev 184869)
</span><span class="lines">@@ -152,6 +152,7 @@
</span><span class="cx"> CSSPropertyFontFamily,
</span><span class="cx"> CSSPropertyFontSize,
</span><span class="cx"> CSSPropertyFontStyle,
</span><ins>+ CSSPropertyFontSynthesis,
</ins><span class="cx"> CSSPropertyFontVariant,
</span><span class="cx"> CSSPropertyFontWeight,
</span><span class="cx"> CSSPropertyHeight,
</span><span class="lines">@@ -286,6 +287,7 @@
</span><span class="cx"> CSSPropertyWebkitColumnBreakInside,
</span><span class="cx"> CSSPropertyWebkitColumnAxis,
</span><span class="cx"> CSSPropertyColumnCount,
</span><ins>+ CSSPropertyColumnFill,
</ins><span class="cx"> CSSPropertyColumnGap,
</span><span class="cx"> CSSPropertyColumnProgression,
</span><span class="cx"> CSSPropertyColumnRuleColor,
</span></span></pre>
</div>
</div>
</body>
</html>