<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184823] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184823">184823</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-23 08:03:43 -0700 (Sat, 23 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Improve native parameter lists a bit
https://bugs.webkit.org/show_bug.cgi?id=145338
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-05-23
Reviewed by Timothy Hatcher.
* UserInterface/Models/NativeFunctionParameters.js:
* UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs">trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (184822 => 184823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-23 15:01:59 UTC (rev 184822)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-23 15:03:43 UTC (rev 184823)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2015-05-23 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Improve native parameter lists a bit
+ https://bugs.webkit.org/show_bug.cgi?id=145338
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+ * UserInterface/Views/ObjectTreePropertyTreeElement.js:
+ (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
+
+2015-05-23 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Update CSS Autocompletion properties and values
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=145341
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (184822 => 184823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2015-05-23 15:01:59 UTC (rev 184822)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2015-05-23 15:03:43 UTC (rev 184823)
</span><span class="lines">@@ -30,19 +30,21 @@
</span><span class="cx"> Object: {
</span><span class="cx"> assign: "target, ...sources",
</span><span class="cx"> create: "prototype, [propertiesObject]",
</span><ins>+ defineProperties: "object, properties",
</ins><span class="cx"> defineProperty: "object, propertyName, descriptor",
</span><del>- defineProperties: "object, properties",
</del><span class="cx"> freeze: "object",
</span><span class="cx"> getOwnPropertyDescriptor: "object, propertyName",
</span><span class="cx"> getOwnPropertyNames: "object",
</span><span class="cx"> getOwnPropertySymbols: "object",
</span><span class="cx"> getPrototypeOf: "object",
</span><ins>+ is: "value1, value2",
</ins><span class="cx"> isExtensible: "object",
</span><span class="cx"> isFrozen: "object",
</span><span class="cx"> isSealed: "object",
</span><span class="cx"> keys: "object",
</span><span class="cx"> preventExtensions: "object",
</span><span class="cx"> seal: "object",
</span><ins>+ setPrototypeOf: "object, prototype",
</ins><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -75,11 +77,12 @@
</span><span class="cx"> acosh: "x",
</span><span class="cx"> asin: "x",
</span><span class="cx"> asinh: "x",
</span><ins>+ atan2: "y, x",
</ins><span class="cx"> atan: "x",
</span><del>- atan2: "y, x",
</del><span class="cx"> atanh: "x",
</span><span class="cx"> cbrt: "x",
</span><span class="cx"> ceil: "x",
</span><ins>+ clz32: "x",
</ins><span class="cx"> cos: "x",
</span><span class="cx"> cosh: "x",
</span><span class="cx"> exp: "x",
</span><span class="lines">@@ -96,6 +99,7 @@
</span><span class="cx"> min: "[...x]",
</span><span class="cx"> pow: "x, y",
</span><span class="cx"> round: "x",
</span><ins>+ sign: "x",
</ins><span class="cx"> sin: "x",
</span><span class="cx"> sinh: "x",
</span><span class="cx"> sqrt: "x",
</span><span class="lines">@@ -126,7 +130,9 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> String: {
</span><del>- fromCharCode: "code, [...codes]",
</del><ins>+ fromCharCode: "...codeUnits",
+ fromCodePoint: "...codePoints",
+ raw: "template, ...substitutions",
</ins><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -300,12 +306,14 @@
</span><span class="cx"> String: {
</span><span class="cx"> charAt: "index",
</span><span class="cx"> charCodeAt: "index",
</span><ins>+ codePoints: "index",
</ins><span class="cx"> concat: "string, ...",
</span><span class="cx"> includes: "searchValue, [startIndex=0]",
</span><span class="cx"> indexOf: "searchValue, [startIndex=0]",
</span><span class="cx"> lastIndexOf: "searchValue, [startIndex=length]",
</span><span class="cx"> localeCompare: "string",
</span><span class="cx"> match: "regex",
</span><ins>+ repeat: "count",
</ins><span class="cx"> replace: "regex|string, replaceString|replaceHandler, [flags]",
</span><span class="cx"> search: "regex",
</span><span class="cx"> slice: "startIndex, [endIndex=length]",
</span><span class="lines">@@ -733,6 +741,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> DocumentFragment: {
</span><ins>+ getElementById: "id",
</ins><span class="cx"> querySelector: "selectors",
</span><span class="cx"> querySelectorAll: "selectors",
</span><span class="cx"> __proto__: null,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js (184822 => 184823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2015-05-23 15:01:59 UTC (rev 184822)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2015-05-23 15:03:43 UTC (rev 184823)
</span><span class="lines">@@ -257,9 +257,11 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ var parentDescription = this._propertyPath.object.description;
+
</ins><span class="cx"> // Native function property on a native function is likely a "Foo.method".
</span><del>- if (isFunctionStringNativeCode(this._propertyPath.object.description)) {
- var match = this._propertyPath.object.description.match(/^function\s+([^)]+?)\(/);
</del><ins>+ if (isFunctionStringNativeCode(parentDescription)) {
+ var match = parentDescription.match(/^function\s+([^)]+?)\(/);
</ins><span class="cx"> if (match) {
</span><span class="cx"> var name = match[1];
</span><span class="cx"> if (WebInspector.NativeConstructorFunctionParameters[name]) {
</span><span class="lines">@@ -269,9 +271,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Native DOM constructor.
- if (this._propertyPath.object.description.endsWith("Constructor")) {
- var name = this._propertyPath.object.description;
</del><ins>+ // Native DOM constructor or on native objects that are not functions.
+ if (parentDescription.endsWith("Constructor") || parentDescription === "Math" || parentDescription === "JSON") {
+ var name = parentDescription;
</ins><span class="cx"> if (WebInspector.NativeConstructorFunctionParameters[name]) {
</span><span class="cx"> var params = WebInspector.NativeConstructorFunctionParameters[name][this._property.name];
</span><span class="cx"> return params ? "(" + params + ")" : "()";
</span></span></pre>
</div>
</div>
</body>
</html>