<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184804] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184804">184804</a></dd>
<dt>Author</dt> <dd>dburkart@apple.com</dd>
<dt>Date</dt> <dd>2015-05-22 17:11:30 -0700 (Fri, 22 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support to the botwatchers dashboard for a static analyzer bot.
https://bugs.webkit.org/show_bug.cgi?id=144814
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
scan-build should be considered a productive step.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue):
Adds support for the staticAnalyzer property
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype._parseResults):
Get bug count from the scan-build step output
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
Rename the performance column 'Other', and merge the current 'Other' column with it.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Now that performance bots are part of the 'Other' column, give them better headings.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTestResultsjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsWebKitBuildbotjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -75,7 +75,8 @@
</span><span class="cx"> "webkitpy-test": 1,
</span><span class="cx"> "webkitperl-test": 1,
</span><span class="cx"> "bindings-generation-tests": 1,
</span><del>- "perf-test": 1
</del><ins>+ "perf-test": 1,
+ "scan build": 1,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> BuildbotIteration.TestSteps = {
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> this.builder = info.builder || false;
</span><span class="cx"> this.tester = info.tester || false;
</span><span class="cx"> this.performance = info.performance || false;
</span><ins>+ this.staticAnalyzer = info.staticAnalyzer || false;
</ins><span class="cx"> this.leaks = info.leaks || false;
</span><span class="cx"> this.architecture = info.architecture || null;
</span><span class="cx"> this.testCategory = info.testCategory || null;
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTestResultsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -93,6 +93,7 @@
</span><span class="cx"> this.newPassesCount = testStep.results[1].reduce(resultSummarizer.bind(null, "new pass"), undefined);
</span><span class="cx"> this.missingCount = testStep.results[1].reduce(resultSummarizer.bind(null, "missing"), undefined);
</span><span class="cx"> this.crashCount = testStep.results[1].reduce(resultSummarizer.bind(null, "crash"), undefined);
</span><ins>+ this.issueCount = testStep.results[1].reduce(resultSummarizer.bind(null, "issue"), undefined);
</ins><span class="cx">
</span><span class="cx"> if (!this.failureCount && !this.flakyCount && !this.totalLeakCount && !this.uniqueLeakCount && !this.newPassesCount && !this.missingCount) {
</span><span class="cx"> // This step exited with a non-zero exit status, but we didn't find any output about the number of failed tests.
</span><span class="lines">@@ -146,7 +147,7 @@
</span><span class="cx">
</span><span class="cx"> // FIXME (bug 127186): It is particularly unfortunate for image diffs, because we currently only check image results
</span><span class="cx"> // on retry (except for reftests), so many times, you will see images on buildbot page, but not on the dashboard.
</span><del>- // FIXME: Find a way to display expected mismatch reftest failures.
</del><ins>+ // FIXME: Find a way to display expected mismatch reftest failures.
</ins><span class="cx"> if (value.actual.split(" ")[0].contains("IMAGE") && value.reftest_type != "!=")
</span><span class="cx"> item.has_image_diff = true;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -47,6 +47,8 @@
</span><span class="cx"> categoryName = "performance";
</span><span class="cx"> else if (queue.leaks)
</span><span class="cx"> categoryName = "leaks";
</span><ins>+ else if (queue.staticAnalyzer)
+ categoryName = "staticAnalyzer";
</ins><span class="cx"> else {
</span><span class="cx"> console.assert("Unknown queue type.");
</span><span class="cx"> continue;
</span><span class="lines">@@ -147,16 +149,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var header = document.createElement("th");
</span><del>- header.textContent = "Performance";
</del><ins>+ header.textContent = "Other";
</ins><span class="cx"> row.appendChild(header);
</span><span class="cx">
</span><del>- if (hasBubbles) {
- // Currently, EWS and commit queues are the only items in Other category.
- var header = document.createElement("th");
- header.textContent = "Other";
- row.appendChild(header);
- }
-
</del><span class="cx"> table.appendChild(row);
</span><span class="cx">
</span><span class="cx"> var platforms = sortedPlatforms();
</span><span class="lines">@@ -215,6 +210,11 @@
</span><span class="cx"> cell.appendChild(view.element);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (platformQueues.staticAnalyzer) {
+ var view = new BuildbotStaticAnalyzerQueueView(platformQueues.staticAnalyzer.release);
+ cell.appendChild(view.element);
+ }
+
</ins><span class="cx"> if (platformQueues.leaks) {
</span><span class="cx"> var view = new BuildbotLeaksQueueView(platformQueues.leaks);
</span><span class="cx"> cell.appendChild(view.element);
</span><span class="lines">@@ -223,8 +223,6 @@
</span><span class="cx"> row.appendChild(cell);
</span><span class="cx">
</span><span class="cx"> if (hasBubbles) {
</span><del>- var cell = document.createElement("td");
-
</del><span class="cx"> if (platformQueues[BubblesCategory]) {
</span><span class="cx"> var view = new BubbleQueueView(platformQueues[BubblesCategory]);
</span><span class="cx"> cell.appendChild(view.element);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsWebKitBuildbotjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> "Apple Mavericks Debug WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><span class="cx"> "Apple Mavericks Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
</span><span class="cx"> "Apple Mavericks Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><del>- "Apple Mavericks Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, performance: true},
</del><ins>+ "Apple Mavericks Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, performance: true, heading: "Performance"},
</ins><span class="cx"> "Apple Yosemite Debug (Build)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
</span><span class="cx"> "Apple Yosemite Release (Build)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
</span><span class="cx"> "Apple Yosemite Release (32-bit Build)": {platform: Dashboard.Platform.MacOSXYosemite, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> "Apple Yosemite Debug WK2 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><span class="cx"> "Apple Yosemite Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
</span><span class="cx"> "Apple Yosemite Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><del>- "Apple Yosemite Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, performance: true},
</del><ins>+ "Apple Yosemite Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, performance: true, heading: "Performance"},
</ins><span class="cx"> "Apple Yosemite (Leaks)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, leaks: true},
</span><span class="cx"> "Apple Win Debug (Build)": {platform: Dashboard.Platform.Windows7, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
</span><span class="cx"> "Apple Win Release (Build)": {platform: Dashboard.Platform.Windows7, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
</span><span class="lines">@@ -50,9 +50,9 @@
</span><span class="cx"> "GTK Linux 64-bit Release (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><span class="cx"> "GTK Linux 64-bit Debug (Build)": {platform: Dashboard.Platform.LinuxGTK, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
</span><span class="cx"> "GTK Linux 64-bit Debug (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><del>- "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true},
</del><ins>+ "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true, heading: "Performance"},
</ins><span class="cx"> "EFL Linux 64-bit Release WK2": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
</span><del>- "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, performance: true}
</del><ins>+ "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, performance: true, heading: "Performance"}
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> Buildbot.call(this, "https://build.webkit.org/", queueInfo);
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (184803 => 184804)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/ChangeLog 2015-05-23 00:11:30 UTC (rev 184804)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2015-05-22 Dana Burkart <dburkart@apple.com>
+
+ Add support to the botwatchers dashboard for a static analyzer bot.
+ https://bugs.webkit.org/show_bug.cgi?id=144814
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ scan-build should be considered a productive step.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue):
+ Adds support for the staticAnalyzer property
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+ (BuildbotTestResults.prototype._parseResults):
+ Get bug count from the scan-build step output
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+ (documentReady):
+ Rename the performance column 'Other', and merge the current 'Other' column with it.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+ (WebKitBuildbot):
+ Now that performance bots are part of the 'Other' column, give them better headings.
+
</ins><span class="cx"> 2015-05-22 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Turn on autosaving of toolbar configuration in MiniBrowser
</span></span></pre>
</div>
</div>
</body>
</html>