<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184661] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184661">184661</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-20 14:52:35 -0700 (Wed, 20 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>UI to associate bugs with an analysis task is crappy
https://bugs.webkit.org/show_bug.cgi?id=145198
Reviewed by Andreas Kling.
Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
a bug and a separate select view with a text field to associate a new bug instead of implicitly
updating or deleting the existing record based on what the user had typed.
* init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
a given analysis task since it's perfectly reasonable for a given task to be associated with
multiple WebKit bugs.
* public/privileged-api/associate-bug.php:
(main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
one that matches the analysis task and the bug tracker when the bug number is falsey.
* public/v2/analysis.js:
(App.Bug.url): Added.
(App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
* public/v2/app.css:
* public/v2/app.js:
(App.AnalysisTaskController.actions.addBug): Added.
(App.AnalysisTaskController.actions.deleteBug): Added.
(App.AnalysisTaskController.associateBug): Deleted.
* public/v2/index.html: Updated the templates.
* public/v2/manifest.js:
(App.BugTracker.urlFromBugNumber): Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorginitdatabasesql">trunk/Websites/perf.webkit.org/init-database.sql</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicprivilegedapiassociatebugphp">trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2analysisjs">trunk/Websites/perf.webkit.org/public/v2/analysis.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appcss">trunk/Websites/perf.webkit.org/public/v2/app.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -1,5 +1,40 @@
</span><span class="cx"> 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ UI to associate bugs with an analysis task is crappy
+ https://bugs.webkit.org/show_bug.cgi?id=145198
+
+ Reviewed by Andreas Kling.
+
+ Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
+ a bug and a separate select view with a text field to associate a new bug instead of implicitly
+ updating or deleting the existing record based on what the user had typed.
+
+ * init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
+ a given analysis task since it's perfectly reasonable for a given task to be associated with
+ multiple WebKit bugs.
+
+ * public/privileged-api/associate-bug.php:
+ (main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
+ one that matches the analysis task and the bug tracker when the bug number is falsey.
+
+ * public/v2/analysis.js:
+ (App.Bug.url): Added.
+ (App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
+
+ * public/v2/app.css:
+
+ * public/v2/app.js:
+ (App.AnalysisTaskController.actions.addBug): Added.
+ (App.AnalysisTaskController.actions.deleteBug): Added.
+ (App.AnalysisTaskController.associateBug): Deleted.
+
+ * public/v2/index.html: Updated the templates.
+
+ * public/v2/manifest.js:
+ (App.BugTracker.urlFromBugNumber): Added.
+
+2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> A/B testing rootSets should provide commit times as well as revisions
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=145207
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorginitdatabasesql"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/init-database.sql (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/init-database.sql 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/init-database.sql 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -200,8 +200,7 @@
</span><span class="cx"> bug_id serial PRIMARY KEY,
</span><span class="cx"> bug_task integer REFERENCES analysis_tasks NOT NULL,
</span><span class="cx"> bug_tracker integer REFERENCES bug_trackers NOT NULL,
</span><del>- bug_number integer NOT NULL,
- CONSTRAINT bug_task_and_tracker_must_be_unique UNIQUE(bug_task, bug_tracker));
</del><ins>+ bug_number integer NOT NULL);
</ins><span class="cx">
</span><span class="cx"> CREATE TABLE build_triggerables (
</span><span class="cx"> triggerable_id serial PRIMARY KEY,
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicprivilegedapiassociatebugphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/privileged-api/associate-bug.php 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -8,25 +8,23 @@
</span><span class="cx"> $analysis_task_id = array_get($data, 'task');
</span><span class="cx"> $bug_tracker_id = array_get($data, 'bugTracker');
</span><span class="cx"> $bug_number = array_get($data, 'number');
</span><ins>+ $bug_id = array_get($data, 'bugToDelete');
</ins><span class="cx">
</span><del>- require_format('AnalysisTask', $analysis_task_id, '/^\d+$/');
- require_format('BugTracker', $bug_tracker_id, '/^\d+$/');
- require_format('BugNumber', $bug_number, '/^\d*$/');
-
</del><span class="cx"> $db = connect();
</span><span class="cx"> $db->begin_transaction();
</span><span class="cx">
</span><del>- $bug_id = NULL;
- if (!$bug_number) {
- $count = $db->query_and_get_affected_rows("DELETE FROM bugs WHERE bug_task = $1 AND bug_tracker = $2",
- array($analysis_task_id, $bug_tracker_id));
- if ($count > 1) {
</del><ins>+ if ($bug_id) {
+ require_format('BugToDelete', $bug_id, '/^\d+$/');
+ $count = $db->query_and_get_affected_rows("DELETE FROM bugs WHERE bug_id = $1", array($bug_id));
+ if ($count != 1) {
</ins><span class="cx"> $db->rollback_transaction();
</span><span class="cx"> exit_with_error('UnexpectedNumberOfAffectedRows', array('affectedRows' => $count));
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- $bug_id = $db->update_or_insert_row('bugs', 'bug', array('task' => $analysis_task_id, 'tracker' => $bug_tracker_id),
- array('task' => $analysis_task_id, 'tracker' => $bug_tracker_id, 'number' => $bug_number));
</del><ins>+ require_format('AnalysisTask', $analysis_task_id, '/^\d+$/');
+ require_format('BugTracker', $bug_tracker_id, '/^\d+$/');
+ require_format('BugNumber', $bug_number, '/^\d+$/');
+ $bug_id = $db->insert_row('bugs', 'bug', array('task' => $analysis_task_id, 'tracker' => $bug_tracker_id, 'number' => $bug_number));
</ins><span class="cx"> }
</span><span class="cx"> $db->commit_transaction();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2analysisjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/analysis.js (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/analysis.js 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/v2/analysis.js 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -61,6 +61,9 @@
</span><span class="cx"> bugTracker: DS.belongsTo('BugTracker'),
</span><span class="cx"> createdAt: DS.attr('date'),
</span><span class="cx"> number: DS.attr('number'),
</span><ins>+ url: function () {
+ return this.get('bugTracker').urlFromBugNumber(this.get('number'));
+ }.property('bugTracker.bugUrl', 'number'),
</ins><span class="cx"> label: function () {
</span><span class="cx"> return this.get('bugTracker').get('label') + ': ' + this.get('number');
</span><span class="cx"> }.property('name', 'bugTracker'),
</span><span class="lines">@@ -95,6 +98,12 @@
</span><span class="cx"> param['id'] = data['bugId'];
</span><span class="cx"> return {'bug': param};
</span><span class="cx"> });
</span><ins>+ },
+ deleteRecord: function (store, type, record)
+ {
+ return PrivilegedAPI.sendRequest('associate-bug', {bugToDelete: record.get('id')}).then(function () {
+ return {};
+ });
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appcss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.css (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.css 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/v2/app.css 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -587,6 +587,12 @@
</span><span class="cx"> font-size: 0.9rem;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.analysis-bugs .icon-button {
+ margin-left: 0.2rem;
+ width: 0.8rem;
+ height: 0.8rem;
+}
+
</ins><span class="cx"> .analysis-bugs .hidden {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -1196,6 +1196,7 @@
</span><span class="cx"> elementId: 'bug-' + bugTracker.get('id'),
</span><span class="cx"> content: bugTracker,
</span><span class="cx"> bugNumber: bugNumber,
</span><ins>+ bugUrl: bugTracker.urlFromBugNumber(bugNumber),
</ins><span class="cx"> editedBugNumber: bugNumber,
</span><span class="cx"> });
</span><span class="cx"> }));
</span><span class="lines">@@ -1295,16 +1296,26 @@
</span><span class="cx"> });
</span><span class="cx"> }.observes('analysisPoints'),
</span><span class="cx"> actions: {
</span><del>- associateBug: function (bugTracker, bugNumber)
</del><ins>+ addBug: function (bugTracker, bugNumber)
</ins><span class="cx"> {
</span><span class="cx"> var model = this.get('model');
</span><del>- this.store.createRecord('bug',
- {task: this.get('model'), bugTracker: bugTracker.get('content'), number: bugNumber}).save().then(function () {
- // FIXME: Should we notify the user?
- }, function (error) {
- alert('Failed to associate the bug: ' + error);
- });
</del><ins>+ if (!bugTracker)
+ bugTracker = this.get('bugTrackers').objectAt(0);
+ var bug = {task: this.get('model'), bugTracker: bugTracker.get('content'), number: bugNumber};
+ this.store.createRecord('bug', bug).save().then(function () {
+ alert('Associated the ' + bugTracker.get('name') + ' ' + bugNumber + ' with this analysis.');
+ }, function (error) {
+ alert('Failed to associate the bug: ' + error);
+ });
</ins><span class="cx"> },
</span><ins>+ deleteBug: function (bug)
+ {
+ bug.destroyRecord().then(function () {
+ alert('Successfully deassociated the bug.');
+ }, function (error) {
+ alert('Failed to disassociate the bug: ' + error);
+ });
+ },
</ins><span class="cx"> saveStatus: function ()
</span><span class="cx"> {
</span><span class="cx"> var chosenResult = this.get('chosenAnalysisResult');
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> {{#if chartData}}
</span><span class="cx"> <div class="dashboard-status">
</span><span class="cx"> {{#if latestStatus}}
</span><del>- {{latestStatus.currentValue}} {{chartData.unit}}
</del><ins>+ {{latestStatus.currentValue}}{{chartData.unit}}
</ins><span class="cx"> {{#if latestStatus.label}}
</span><span class="cx"> <span {{bind-attr class=":status-label latestStatus.className"}}>{{latestStatus.label}}</span>
</span><span class="cx"> {{/if}}
</span><span class="lines">@@ -264,9 +264,8 @@
</span><span class="cx"> <tr>
</span><span class="cx"> <th>{{label}}</th>
</span><span class="cx"> <td>
</span><del>- {{#each bugs}}
- <a {{bind-attr href=bugUrl}} target="_blank">{{bugNumber}}</a>
- {{/each}}
</del><ins>+ [{{bugUrl}}]
+ <a {{bind-attr href=bugUrl}} target="_blank">{{bugNumber}}</a>
</ins><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><span class="cx"> {{/if}}
</span><span class="lines">@@ -736,16 +735,26 @@
</span><span class="cx"> <script type="text/x-handlebars" data-template-name="analysisStatusForm">
</span><span class="cx"> <table class="analysis-bugs">
</span><span class="cx"> <tbody>
</span><del>- {{#each bugTrackers}}
</del><ins>+ {{#each model.bugs}}
</ins><span class="cx"> <tr>
</span><del>- <th><label {{bind-attr for=elementId}}>{{label}}</label></th>
</del><ins>+ <th>{{bugTracker.name}}</th>
</ins><span class="cx"> <td>
</span><del>- <form {{action "associateBug" this editedBugNumber on="submit"}}>
- {{input id=elementId type=text value=editedBugNumber}}
- </form>
</del><ins>+ <a {{bind-attr href=url}} target="_blank">{{number}}</a>
+ <a href="javascript:false" {{action "deleteBug" this}}>{{partial "close-button"}}</a>
</ins><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><span class="cx"> {{/each}}
</span><ins>+ {{#if bugTrackers}}
+ <tr>
+ <td>
+ {{view Ember.Select content=bugTrackers optionValuePath="content" optionLabelPath="content.name" value=chosenBugTracker}}
+ </td>
+ <td>
+ {{input id=elementId type=text value=editedBugNumber}}
+ <button {{action "addBug" chosenBugTracker editedBugNumber}}>Add</button>
+ </td>
+ </tr>
+ {{/if}}
</ins><span class="cx"> </tbody>
</span><span class="cx"> <tbody>
</span><span class="cx"> <tr>
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (184660 => 184661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-05-20 21:38:01 UTC (rev 184660)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-05-20 21:52:35 UTC (rev 184661)
</span><span class="lines">@@ -52,6 +52,10 @@
</span><span class="cx"> bugUrl: DS.attr('string'),
</span><span class="cx"> newBugUrl: DS.attr('string'),
</span><span class="cx"> repositories: DS.hasMany('repository'),
</span><ins>+ urlFromBugNumber: function (bugNumber) {
+ var template = this.get('bugUrl');
+ return template && bugNumber ? template.replace(/\$number/g, bugNumber) : null;
+ }
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> App.DateArrayTransform = DS.Transform.extend({
</span></span></pre>
</div>
</div>
</body>
</html>