<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184658] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184658">184658</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-20 14:22:21 -0700 (Wed, 20 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>A/B testing rootSets should provide commit times as well as revisions
https://bugs.webkit.org/show_bug.cgi?id=145207
Reviewed by Andreas Kling.
Some continuous build systems need the commit time as well as the revision number / hash so provide one
in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
* public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
the revision number as well as the commit time.
* tools/sync-with-buildbot.py:
(schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludebuildrequestsfetcherphp">trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtoolssyncwithbuildbotpy">trunk/Websites/perf.webkit.org/tools/sync-with-buildbot.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (184657 => 184658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-05-20 21:08:24 UTC (rev 184657)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-05-20 21:22:21 UTC (rev 184658)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
+
+ A/B testing rootSets should provide commit times as well as revisions
+ https://bugs.webkit.org/show_bug.cgi?id=145207
+
+ Reviewed by Andreas Kling.
+
+ Some continuous build systems need the commit time as well as the revision number / hash so provide one
+ in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
+
+ * public/include/build-requests-fetcher.php:
+ (BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
+ the revision number as well as the commit time.
+ * tools/sync-with-buildbot.py:
+ (schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
+ when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
+ revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".
+
</ins><span class="cx"> 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludebuildrequestsfetcherphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php (184657 => 184658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php 2015-05-20 21:08:24 UTC (rev 184657)
+++ trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php 2015-05-20 21:22:21 UTC (rev 184658)
</span><span class="lines">@@ -93,10 +93,11 @@
</span><span class="cx"> foreach ($root_rows as $row) {
</span><span class="cx"> $repository = $row['repository_id'];
</span><span class="cx"> $revision = $row['commit_revision'];
</span><ins>+ $commit_time = $row['commit_time'];
</ins><span class="cx"> $root_id = $root_set_id . '-' . $repository;
</span><span class="cx"> array_push($root_ids, $root_id);
</span><span class="cx"> array_push($this->roots, array('id' => $root_id, 'repository' => $repository, 'revision' => $revision));
</span><del>- $roots[$resolve_ids ? $row['repository_name'] : $row['repository_id']] = $revision;
</del><ins>+ $roots[$resolve_ids ? $row['repository_name'] : $row['repository_id']] = array('revision' => $revision, 'time' => $commit_time);
</ins><span class="cx"> }
</span><span class="cx"> array_push($this->root_sets, array('id' => $root_set_id, 'roots' => $root_ids));
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtoolssyncwithbuildbotpy"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tools/sync-with-buildbot.py (184657 => 184658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tools/sync-with-buildbot.py 2015-05-20 21:08:24 UTC (rev 184657)
+++ trunk/Websites/perf.webkit.org/tools/sync-with-buildbot.py 2015-05-20 21:22:21 UTC (rev 184658)
</span><span class="lines">@@ -134,14 +134,13 @@
</span><span class="cx">
</span><span class="cx"> def schedule_request(config, request, root_sets):
</span><span class="cx"> roots = root_sets.get(request['rootSet'], {})
</span><del>- replacements = roots.copy()
</del><span class="cx">
</span><span class="cx"> payload = {}
</span><span class="cx"> for property_name, property_value in config['arguments'].iteritems():
</span><span class="cx"> if not isinstance(property_value, dict):
</span><span class="cx"> payload[property_name] = property_value
</span><span class="cx"> elif 'root' in property_value:
</span><del>- payload[property_name] = replacements[property_value['root']]
</del><ins>+ payload[property_name] = roots[property_value['root']]['revision']
</ins><span class="cx"> elif 'rootsExcluding' in property_value:
</span><span class="cx"> excluded_roots = property_value['rootsExcluding']
</span><span class="cx"> filtered_roots = {}
</span></span></pre>
</div>
</div>
</body>
</html>