<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184621] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184621">184621</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-20 00:26:56 -0700 (Wed, 20 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=144992
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2015-05-20
Reviewed by Gyuyoung Kim.
* MiniBrowser/efl/main.c:
(toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
(on_key_down):
(on_fullscreen_enter):
(on_fullscreen_exit):
(window_create):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsereflmainc">trunk/Tools/MiniBrowser/efl/main.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (184620 => 184621)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-05-20 07:04:34 UTC (rev 184620)
+++ trunk/Tools/ChangeLog 2015-05-20 07:26:56 UTC (rev 184621)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-05-20 Rohit Kumar <kumar.rohit@samsung.com>
+
+ [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
+ https://bugs.webkit.org/show_bug.cgi?id=144992
+
+ Reviewed by Gyuyoung Kim.
+
+ * MiniBrowser/efl/main.c:
+ (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
+ (on_key_down):
+ (on_fullscreen_enter):
+ (on_fullscreen_exit):
+ (window_create):
+
</ins><span class="cx"> 2015-05-19 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
</span></span></pre></div>
<a id="trunkToolsMiniBrowsereflmainc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/efl/main.c (184620 => 184621)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/efl/main.c 2015-05-20 07:04:34 UTC (rev 184620)
+++ trunk/Tools/MiniBrowser/efl/main.c 2015-05-20 07:26:56 UTC (rev 184621)
</span><span class="lines">@@ -99,6 +99,8 @@
</span><span class="cx"> typedef struct _Browser_Window {
</span><span class="cx"> Evas_Object *elm_window;
</span><span class="cx"> Evas_Object *ewk_view;
</span><ins>+ Evas_Object *horizontal_layout;
+ Evas_Object *vertical_layout;
</ins><span class="cx"> Evas_Object *url_bar;
</span><span class="cx"> Evas_Object *back_button;
</span><span class="cx"> Evas_Object *forward_button;
</span><span class="lines">@@ -527,6 +529,20 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void
</span><ins>+toggle_window_fullscreen(Browser_Window *window, Eina_Bool isFullScreen)
+{
+ if (isFullScreen) {
+ evas_object_hide(window->horizontal_layout);
+ elm_box_unpack(window->vertical_layout, window->horizontal_layout);
+ elm_win_fullscreen_set(window->elm_window, EINA_TRUE);
+ } else {
+ elm_win_fullscreen_set(window->elm_window, EINA_FALSE);
+ elm_box_pack_start(window->vertical_layout, window->horizontal_layout);
+ evas_object_show(window->horizontal_layout);
+ }
+}
+
+static void
</ins><span class="cx"> on_key_down(void *user_data, Evas *e, Evas_Object *ewk_view, void *event_info)
</span><span class="cx"> {
</span><span class="cx"> Browser_Window *window = (Browser_Window *)user_data;
</span><span class="lines">@@ -576,7 +592,7 @@
</span><span class="cx"> INFO("Change Pagination Mode (F7) was pressed, but NOT changed!");
</span><span class="cx"> } else if (!strcmp(ev->key, "F11")) {
</span><span class="cx"> INFO("Fullscreen (F11) was pressed, toggling window/fullscreen.");
</span><del>- elm_win_fullscreen_set(window->elm_window, !elm_win_fullscreen_get(window->elm_window));
</del><ins>+ toggle_window_fullscreen(window, !elm_win_fullscreen_get(window->elm_window));
</ins><span class="cx"> } else if (!strcmp(ev->key, "n") && ctrlPressed) {
</span><span class="cx"> INFO("Create new window (Ctrl+n) was pressed.");
</span><span class="cx"> Browser_Window *window = window_create(NULL, 0, 0);
</span><span class="lines">@@ -1630,7 +1646,7 @@
</span><span class="cx"> Browser_Window *window = window_find_with_ewk_view(sd->self);
</span><span class="cx">
</span><span class="cx"> /* Go fullscreen */
</span><del>- elm_win_fullscreen_set(window->elm_window, EINA_TRUE);
</del><ins>+ toggle_window_fullscreen(window, EINA_TRUE);
</ins><span class="cx">
</span><span class="cx"> /* Show user popup */
</span><span class="cx"> Evas_Object *permission_popup = elm_popup_add(window->elm_window);
</span><span class="lines">@@ -1665,7 +1681,7 @@
</span><span class="cx"> {
</span><span class="cx"> Browser_Window *window = window_find_with_ewk_view(sd->self);
</span><span class="cx">
</span><del>- elm_win_fullscreen_set(window->elm_window, EINA_FALSE);
</del><ins>+ toggle_window_fullscreen(window, EINA_FALSE);
</ins><span class="cx">
</span><span class="cx"> return EINA_TRUE;
</span><span class="cx"> }
</span><span class="lines">@@ -2043,19 +2059,19 @@
</span><span class="cx"> evas_object_show(bg);
</span><span class="cx">
</span><span class="cx"> /* Create vertical layout */
</span><del>- Evas_Object *vertical_layout = elm_box_add(window->elm_window);
- elm_box_padding_set(vertical_layout, 0, 2);
- evas_object_size_hint_weight_set(vertical_layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
- elm_win_resize_object_add(window->elm_window, vertical_layout);
- evas_object_show(vertical_layout);
</del><ins>+ window->vertical_layout = elm_box_add(window->elm_window);
+ elm_box_padding_set(window->vertical_layout, 0, 2);
+ evas_object_size_hint_weight_set(window->vertical_layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+ elm_win_resize_object_add(window->elm_window, window->vertical_layout);
+ evas_object_show(window->vertical_layout);
</ins><span class="cx">
</span><span class="cx"> /* Create horizontal layout for top bar */
</span><del>- Evas_Object *horizontal_layout = elm_box_add(window->elm_window);
- elm_box_horizontal_set(horizontal_layout, EINA_TRUE);
- evas_object_size_hint_weight_set(horizontal_layout, EVAS_HINT_EXPAND, 0.0);
- evas_object_size_hint_align_set(horizontal_layout, EVAS_HINT_FILL, 0.0);
- elm_box_pack_end(vertical_layout, horizontal_layout);
- evas_object_show(horizontal_layout);
</del><ins>+ window->horizontal_layout = elm_box_add(window->elm_window);
+ elm_box_horizontal_set(window->horizontal_layout, EINA_TRUE);
+ evas_object_size_hint_weight_set(window->horizontal_layout, EVAS_HINT_EXPAND, 0.0);
+ evas_object_size_hint_align_set(window->horizontal_layout, EVAS_HINT_FILL, 0.0);
+ elm_box_pack_end(window->vertical_layout, window->horizontal_layout);
+ evas_object_show(window->horizontal_layout);
</ins><span class="cx">
</span><span class="cx"> /* Create Back button */
</span><span class="cx"> window->back_button = create_toolbar_button(window->elm_window, "arrow_left");
</span><span class="lines">@@ -2066,7 +2082,7 @@
</span><span class="cx"> elm_object_disabled_set(window->back_button, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_weight_set(window->back_button, 0.0, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(window->back_button, 0.0, 0.5);
</span><del>- elm_box_pack_end(horizontal_layout, window->back_button);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, window->back_button);
</ins><span class="cx"> evas_object_show(window->back_button);
</span><span class="cx">
</span><span class="cx"> /* Create Forward button */
</span><span class="lines">@@ -2078,7 +2094,7 @@
</span><span class="cx"> elm_object_disabled_set(window->forward_button, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_weight_set(window->forward_button, 0.0, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(window->forward_button, 0.0, 0.5);
</span><del>- elm_box_pack_end(horizontal_layout, window->forward_button);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, window->forward_button);
</ins><span class="cx"> evas_object_show(window->forward_button);
</span><span class="cx">
</span><span class="cx"> /* Create URL bar */
</span><span class="lines">@@ -2092,7 +2108,7 @@
</span><span class="cx"> evas_object_smart_callback_add(window->url_bar, "clicked", on_url_bar_clicked, window);
</span><span class="cx"> evas_object_size_hint_weight_set(window->url_bar, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(window->url_bar, EVAS_HINT_FILL, EVAS_HINT_FILL);
</span><del>- elm_box_pack_end(horizontal_layout, window->url_bar);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, window->url_bar);
</ins><span class="cx"> evas_object_show(window->url_bar);
</span><span class="cx">
</span><span class="cx"> /* Create Refresh button */
</span><span class="lines">@@ -2102,7 +2118,7 @@
</span><span class="cx"> elm_object_tooltip_window_mode_set(refresh_button, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_weight_set(refresh_button, 0.0, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(refresh_button, 1.0, 0.5);
</span><del>- elm_box_pack_end(horizontal_layout, refresh_button);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, refresh_button);
</ins><span class="cx"> evas_object_show(refresh_button);
</span><span class="cx">
</span><span class="cx"> /* Create Stop button */
</span><span class="lines">@@ -2112,7 +2128,7 @@
</span><span class="cx"> elm_object_tooltip_window_mode_set(stop_button, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_weight_set(stop_button, 0.0, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(stop_button, 1.0, 0.5);
</span><del>- elm_box_pack_end(horizontal_layout, stop_button);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, stop_button);
</ins><span class="cx"> evas_object_show(stop_button);
</span><span class="cx">
</span><span class="cx"> /* Create Home button */
</span><span class="lines">@@ -2122,7 +2138,7 @@
</span><span class="cx"> elm_object_tooltip_window_mode_set(home_button, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_weight_set(home_button, 0.0, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(home_button, 1.0, 0.5);
</span><del>- elm_box_pack_end(horizontal_layout, home_button);
</del><ins>+ elm_box_pack_end(window->horizontal_layout, home_button);
</ins><span class="cx"> evas_object_show(home_button);
</span><span class="cx">
</span><span class="cx"> /* Create Search bar */
</span><span class="lines">@@ -2130,7 +2146,7 @@
</span><span class="cx"> elm_box_horizontal_set(window->search.search_bar, EINA_TRUE);
</span><span class="cx"> evas_object_size_hint_min_set(window->search.search_bar, SEARCH_FIELD_SIZE + 2 * SEARCH_BUTTON_SIZE, 0);
</span><span class="cx"> evas_object_size_hint_align_set(window->search.search_bar, EVAS_HINT_FILL, EVAS_HINT_FILL);
</span><del>- elm_box_pack_end(vertical_layout, window->search.search_bar);
</del><ins>+ elm_box_pack_end(window->vertical_layout, window->search.search_bar);
</ins><span class="cx">
</span><span class="cx"> /* Create Search field */
</span><span class="cx"> window->search.search_field = elm_entry_add(window->elm_window);
</span><span class="lines">@@ -2288,7 +2304,7 @@
</span><span class="cx">
</span><span class="cx"> evas_object_size_hint_weight_set(window->ewk_view, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
</span><span class="cx"> evas_object_size_hint_align_set(window->ewk_view, EVAS_HINT_FILL, EVAS_HINT_FILL);
</span><del>- elm_box_pack_before(vertical_layout, window->ewk_view, window->search.search_bar);
</del><ins>+ elm_box_pack_before(window->vertical_layout, window->ewk_view, window->search.search_bar);
</ins><span class="cx"> evas_object_show(window->ewk_view);
</span><span class="cx">
</span><span class="cx"> evas_object_resize(window->elm_window, width ? width : window_width, height ? height : window_height);
</span></span></pre>
</div>
</div>
</body>
</html>