<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184595] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184595">184595</a></dd>
<dt>Author</dt> <dd>roger_fong@apple.com</dd>
<dt>Date</dt> <dd>2015-05-19 14:52:15 -0700 (Tue, 19 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>
Reviewed by Jer Noble.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.
Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
Override methods to use add and remove panelContainer for iOS.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsiOSjs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184594 => 184595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-19 21:49:59 UTC (rev 184594)
+++ trunk/Source/WebCore/ChangeLog 2015-05-19 21:52:15 UTC (rev 184595)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2015-05-19 Roger Fong <roger_fong@apple.com>
+
+ Media Controls stop updating after hovering for a few seconds.
+ https://bugs.webkit.org/show_bug.cgi?id=144770.
+ <rdar://problem/19823121>
+
+ Reviewed by Jer Noble.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.createBase):
+ We should never hide controls immediately as a result of mousing out of the controls.
+ It should only happen when the mouse leaves the video entirely.
+ (Controller.prototype.updateTimelineMetricsIfNeeded):
+ Don’t update if controls are hidden, timeline dimensions will be 0.
+ (Controller.prototype.handlePanelTransitionEnd):
+ Instead of adjusting visibility via adding and removing classes,
+ remove controls entirely from the tree.
+ (Controller.prototype.showControls):
+ Add controls back into the tree when showing controls.
+ (Controller.prototype.updateForShowingControls):
+ Helper method for showControls.
+ (Controller.prototype.controlsAreHidden):
+ Controls also hidden if removed from tree.
+
+ Remove forceUpdate logic, no longer necessary.
+ (Controller.prototype.handleDurationChange):
+ (Controller.prototype.updateProgress):
+ (Controller.prototype.updateTime):
+
+ Override methods to use add and remove panelContainer for iOS.
+ * Modules/mediacontrols/mediaControlsiOS.js:
+ (ControllerIOS.prototype.handlePanelTransitionEnd):
+ (ControllerIOS.prototype.showControls):
+ (ControllerIOS.prototype.controlsAreHidden):
+
</ins><span class="cx"> 2015-05-19 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Scroll-snap animations should not start on axes with zero-delta
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (184594 => 184595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-19 21:49:59 UTC (rev 184594)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-19 21:52:15 UTC (rev 184595)
</span><span class="lines">@@ -266,7 +266,7 @@
</span><span class="cx"> var base = this.base = document.createElement('div');
</span><span class="cx"> base.setAttribute('pseudo', '-webkit-media-controls');
</span><span class="cx"> this.listenFor(base, 'mousemove', this.handleWrapperMouseMove);
</span><del>- this.listenFor(base, 'mouseout', this.handleWrapperMouseOut);
</del><ins>+ this.listenFor(this.video, 'mouseout', this.handleWrapperMouseOut);
</ins><span class="cx"> if (this.host.textTrackContainer)
</span><span class="cx"> base.appendChild(this.host.textTrackContainer);
</span><span class="cx"> },
</span><span class="lines">@@ -291,7 +291,7 @@
</span><span class="cx">
</span><span class="cx"> updateTimelineMetricsIfNeeded: function()
</span><span class="cx"> {
</span><del>- if (this.timelineMetricsNeedsUpdate) {
</del><ins>+ if (this.timelineMetricsNeedsUpdate && !this.controlsAreHidden()) {
</ins><span class="cx"> this.timelineLeft = this.controls.timeline.offsetLeft;
</span><span class="cx"> this.timelineWidth = this.controls.timeline.offsetWidth;
</span><span class="cx"> this.timelineHeight = this.controls.timeline.offsetHeight;
</span><span class="lines">@@ -682,8 +682,8 @@
</span><span class="cx"> handleDurationChange: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.updateDuration();
</span><del>- this.updateTime(true);
- this.updateProgress(true);
</del><ins>+ this.updateTime();
+ this.updateProgress();
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> handlePlay: function(event)
</span><span class="lines">@@ -816,14 +816,9 @@
</span><span class="cx"> handlePanelTransitionEnd: function(event)
</span><span class="cx"> {
</span><span class="cx"> var opacity = window.getComputedStyle(this.controls.panel).opacity;
</span><del>- if (parseInt(opacity) > 0) {
- this.controls.panel.classList.remove(this.ClassNames.hidden);
- if (this.controls.panelBackground)
- this.controls.panelBackground.classList.remove(this.ClassNames.hidden);
- } else if (!this.controlsAlwaysVisible()) {
- this.controls.panel.classList.add(this.ClassNames.hidden);
- if (this.controls.panelBackground)
- this.controls.panelBackground.classList.add(this.ClassNames.hidden);
</del><ins>+ if (!parseInt(opacity) && !this.controlsAlwaysVisible()) {
+ this.base.removeChild(this.controls.inlinePlaybackPlaceholder);
+ this.base.removeChild(this.controls.panel);
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -1147,11 +1142,8 @@
</span><span class="cx"> return gradient;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- updateProgress: function(forceUpdate)
</del><ins>+ updateProgress: function()
</ins><span class="cx"> {
</span><del>- if (!forceUpdate && this.controlsAreHidden())
- return;
-
</del><span class="cx"> this.updateTimelineMetricsIfNeeded();
</span><span class="cx"> this.drawTimelineBackground();
</span><span class="cx"> },
</span><span class="lines">@@ -1359,27 +1351,35 @@
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><del>- showControls: function()
</del><ins>+ updateForShowingControls: function()
</ins><span class="cx"> {
</span><del>- this.updateShouldListenForPlaybackTargetAvailabilityEvent();
- if (this.showInlinePlaybackPlaceholderOnly())
- return;
-
</del><span class="cx"> this.updateLayoutForDisplayedWidth();
</span><span class="cx"> this.setNeedsTimelineMetricsUpdate();
</span><del>- this.updateTime(true);
- this.updateProgress(true);
</del><ins>+ this.updateTime();
+ this.updateProgress();
</ins><span class="cx"> this.drawVolumeBackground();
</span><span class="cx"> this.drawTimelineBackground();
</span><span class="cx"> this.controls.panel.classList.add(this.ClassNames.show);
</span><span class="cx"> this.controls.panel.classList.remove(this.ClassNames.hidden);
</span><del>-
</del><span class="cx"> if (this.controls.panelBackground) {
</span><span class="cx"> this.controls.panelBackground.classList.add(this.ClassNames.show);
</span><span class="cx"> this.controls.panelBackground.classList.remove(this.ClassNames.hidden);
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ showControls: function()
+ {
+ this.updateShouldListenForPlaybackTargetAvailabilityEvent();
+ if (this.showInlinePlaybackPlaceholderOnly())
+ return;
+
+ this.updateForShowingControls();
+ if (this.shouldHaveControls()) {
+ this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
+ this.base.appendChild(this.controls.panel);
+ }
+ },
+
</ins><span class="cx"> hideControls: function()
</span><span class="cx"> {
</span><span class="cx"> if (this.controlsAlwaysVisible())
</span><span class="lines">@@ -1455,7 +1455,8 @@
</span><span class="cx">
</span><span class="cx"> controlsAreHidden: function()
</span><span class="cx"> {
</span><del>- return !this.controlsAlwaysVisible() && !this.controls.panel.classList.contains(this.ClassNames.show);
</del><ins>+ // Controls are only ever actually hidden when they are removed from the tree
+ return !this.controls.panel.parentElement;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> removeControls: function()
</span><span class="lines">@@ -1472,11 +1473,8 @@
</span><span class="cx"> this.setNeedsTimelineMetricsUpdate();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- updateTime: function(forceUpdate)
</del><ins>+ updateTime: function()
</ins><span class="cx"> {
</span><del>- if (!forceUpdate && this.controlsAreHidden())
- return;
-
</del><span class="cx"> var currentTime = this.video.currentTime;
</span><span class="cx"> var timeRemaining = currentTime - this.video.duration;
</span><span class="cx"> this.controls.currentTime.innerText = this.formatTime(currentTime);
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsiOSjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js (184594 => 184595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js 2015-05-19 21:49:59 UTC (rev 184594)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js 2015-05-19 21:52:15 UTC (rev 184595)
</span><span class="lines">@@ -202,6 +202,12 @@
</span><span class="cx"> // Explicitly do nothing to override base-class behavior.
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ controlsAreHidden: function()
+ {
+ // Controls are only ever actually hidden when they are removed from the tree
+ return !this.controls.panelContainer.parentElement;
+ },
+
</ins><span class="cx"> addControls: function() {
</span><span class="cx"> this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
</span><span class="cx"> this.base.appendChild(this.controls.panelContainer);
</span><span class="lines">@@ -380,6 +386,15 @@
</span><span class="cx"> this.updateShouldListenForPlaybackTargetAvailabilityEvent();
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ handlePanelTransitionEnd: function(event)
+ {
+ var opacity = window.getComputedStyle(this.controls.panel).opacity;
+ if (!parseInt(opacity) && !this.controlsAlwaysVisible()) {
+ this.base.removeChild(this.controls.inlinePlaybackPlaceholder);
+ this.base.removeChild(this.controls.panelContainer);
+ }
+ },
+
</ins><span class="cx"> presentationMode: function() {
</span><span class="cx"> if ('webkitPresentationMode' in this.video)
</span><span class="cx"> return this.video.webkitPresentationMode;
</span><span class="lines">@@ -535,6 +550,19 @@
</span><span class="cx"> this.showControls();
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ showControls: function()
+ {
+ this.updateShouldListenForPlaybackTargetAvailabilityEvent();
+ if (this.showInlinePlaybackPlaceholderOnly())
+ return;
+
+ this.updateForShowingControls();
+ if (this.shouldHaveControls()) {
+ this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
+ this.base.appendChild(this.controls.panelContainer);
+ }
+ },
+
</ins><span class="cx"> setShouldListenForPlaybackTargetAvailabilityEvent: function(shouldListen)
</span><span class="cx"> {
</span><span class="cx"> if (shouldListen && (this.shouldHaveStartPlaybackButton() || this.video.error))
</span></span></pre>
</div>
</div>
</body>
</html>