<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184515] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184515">184515</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-18 15:16:59 -0700 (Mon, 18 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
https://bugs.webkit.org/show_bug.cgi?id=145139
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-05-18
Reviewed by Timothy Hatcher.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.highlightSearchResults):
(WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
(WebInspector.DOMTreeElement.prototype._updateChildren):
(WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
(WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
(WebInspector.DOMTreeElement.prototype.updateTitle):
Stop using the `delete` operator.
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype.setVisible):
Trigger an update when the outline is made visible.
* UserInterface/Views/FrameDOMTreeContentView.js:
(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
Provide a reasonable default selection if there is no body or document element.
For example in an augmented DOM tree.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsFrameDOMTreeContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (184514 => 184515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-18 22:09:53 UTC (rev 184514)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-18 22:16:59 UTC (rev 184515)
</span><span class="lines">@@ -1,5 +1,33 @@
</span><span class="cx"> 2015-05-18 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
+ https://bugs.webkit.org/show_bug.cgi?id=145139
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype.highlightSearchResults):
+ (WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
+ (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
+ (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
+ (WebInspector.DOMTreeElement.prototype._updateChildren):
+ (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
+ (WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
+ (WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
+ (WebInspector.DOMTreeElement.prototype.updateTitle):
+ Stop using the `delete` operator.
+
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline.prototype.setVisible):
+ Trigger an update when the outline is made visible.
+
+ * UserInterface/Views/FrameDOMTreeContentView.js:
+ (WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
+ Provide a reasonable default selection if there is no body or document element.
+ For example in an augmented DOM tree.
+
+2015-05-18 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Tab Restoration incorrectly makes ContentViews "shown" in background tabs
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=145080
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (184514 => 184515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-05-18 22:09:53 UTC (rev 184514)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-05-18 22:16:59 UTC (rev 184515)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._searchQuery !== searchQuery) {
</span><span class="cx"> this._updateSearchHighlight(false);
</span><del>- delete this._highlightResult; // A new search query.
</del><ins>+ this._highlightResult = undefined; // A new search query.
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._searchQuery = searchQuery;
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx">
</span><span class="cx"> hideSearchHighlights()
</span><span class="cx"> {
</span><del>- delete this._searchHighlightsVisible;
</del><ins>+ this._searchHighlightsVisible = false;
</ins><span class="cx"> this._updateSearchHighlight(false);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> this._bouncyHighlightElement.remove();
</span><del>- delete this._bouncyHighlightElement;
</del><ins>+ this._bouncyHighlightElement = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));
</span><span class="lines">@@ -407,7 +407,7 @@
</span><span class="cx"> treeOutlineContainerElement.scrollTop = originalScrollTop;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- delete this._updateChildrenInProgress;
</del><ins>+ this._updateChildrenInProgress = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> adjustCollapsedRange()
</span><span class="lines">@@ -447,7 +447,7 @@
</span><span class="cx">
</span><span class="cx"> this.expandAllButtonElement.textContent = WebInspector.UIString("Show All Nodes (%d More)").format(childNodeCount - expandedChildCount);
</span><span class="cx"> } else if (this.expandAllButtonElement)
</span><del>- delete this.expandAllButtonElement;
</del><ins>+ this.expandAllButtonElement = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> handleLoadAllChildren()
</span><span class="lines">@@ -839,7 +839,7 @@
</span><span class="cx">
</span><span class="cx"> // Remove editor.
</span><span class="cx"> this.listItemElement.removeChild(this._htmlEditElement);
</span><del>- delete this._htmlEditElement;
</del><ins>+ this._htmlEditElement = null;
</ins><span class="cx"> // Unhide children item.
</span><span class="cx"> if (this._childrenListNode)
</span><span class="cx"> this._childrenListNode.style.removeProperty("display");
</span><span class="lines">@@ -1030,10 +1030,10 @@
</span><span class="cx"> } else {
</span><span class="cx"> this.title = document.createElement("span");
</span><span class="cx"> this.title.appendChild(this._nodeTitleInfo().titleDOM);
</span><del>- delete this._highlightResult;
</del><ins>+ this._highlightResult = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- delete this.selectionElement;
</del><ins>+ this.selectionElement = null;
</ins><span class="cx"> this.updateSelection();
</span><span class="cx"> this._highlightSearchResults();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (184514 => 184515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-05-18 22:09:53 UTC (rev 184514)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-05-18 22:16:59 UTC (rev 184515)
</span><span class="lines">@@ -89,8 +89,11 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> this._updateModifiedNodes();
</span><ins>+
</ins><span class="cx"> if (this._selectedDOMNode)
</span><span class="cx"> this._revealAndSelectNode(this._selectedDOMNode, omitFocus);
</span><ins>+
+ this.update();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> get rootDOMNode()
</span><span class="lines">@@ -176,7 +179,7 @@
</span><span class="cx"> treeElement.selectable = this._selectEnabled;
</span><span class="cx"> this.appendChild(treeElement);
</span><span class="cx"> node = node.nextSibling;
</span><del>-
</del><ins>+
</ins><span class="cx"> if (treeElement.hasChildren && !treeElement.expanded)
</span><span class="cx"> treeElement.expand();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsFrameDOMTreeContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js (184514 => 184515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js 2015-05-18 22:09:53 UTC (rev 184514)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js 2015-05-18 22:16:59 UTC (rev 184515)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- this._restoreSelectedNodeAfterUpdate(this._domTree.frame.url, rootDOMNode.body || rootDOMNode.documentElement);
</del><ins>+ this._restoreSelectedNodeAfterUpdate(this._domTree.frame.url, rootDOMNode.body || rootDOMNode.documentElement || rootDOMNode.firstChild);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _rootDOMNodeInvalidated: function(event)
</span></span></pre>
</div>
</div>
</body>
</html>