<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184494] branches/safari-601.1.32.2-branch</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184494">184494</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2015-05-18 10:00:45 -0700 (Mon, 18 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/184341">r184341</a>. rdar://problem/20809399</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari6011322branchSourceWTFChangeLog">branches/safari-601.1.32.2-branch/Source/WTF/ChangeLog</a></li>
<li><a href="#branchessafari6011322branchSourceWTFwtftextStringImplcpp">branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.cpp</a></li>
<li><a href="#branchessafari6011322branchSourceWTFwtftextStringImplh">branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.h</a></li>
<li><a href="#branchessafari6011322branchSourceWTFwtftextStringViewcpp">branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.cpp</a></li>
<li><a href="#branchessafari6011322branchSourceWTFwtftextStringViewh">branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.h</a></li>
<li><a href="#branchessafari6011322branchSourceWTFwtftextWTFStringh">branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#branchessafari6011322branchToolsChangeLog">branches/safari-601.1.32.2-branch/Tools/ChangeLog</a></li>
<li><a href="#branchessafari6011322branchToolsTestWebKitAPITestsWTFStringImplcpp">branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp</a></li>
<li><a href="#branchessafari6011322branchToolsTestWebKitAPITestsWTFStringViewcpp">branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringView.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari6011322branchSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/ChangeLog (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/ChangeLog 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/ChangeLog 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2015-05-18 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><ins>+ Merge r184341. rdar://problem/20809399
+
+ 2015-05-14 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Add String literal overloads to equalIgnoringASCIICase()
+ https://bugs.webkit.org/show_bug.cgi?id=145008
+
+ Reviewed by Benjamin Poulain.
+
+ Create an overload for equalIgnoringASCIICase for string literals.
+
+ * wtf/text/StringImpl.h:
+ (WTF::equalIgnoringASCIICase): Use a non-templated helper function.
+ * wtf/text/StringImpl.cpp:
+ (WTF::equalIgnoringASCIICase): Implement it.
+ * wtf/text/StringView.h:
+ (WTF::equalIgnoringASCIICase): Use a non-templated helper function.
+ * wtf/text/StringView.cpp:
+ (WTF::equalIgnoringASCIICase): Implement it.
+ * wtf/text/WTFString.h:
+ (WTF::equalIgnoringASCIICase): Delegate to StringImpl's implementation.
+
+2015-05-18 Matthew Hanson <matthew_hanson@apple.com>
+
</ins><span class="cx"> Merge r184245. rdar://problem/19611967
</span><span class="cx">
</span><span class="cx"> 2015-05-12 Michael Saboff <msaboff@apple.com>
</span></span></pre></div>
<a id="branchessafari6011322branchSourceWTFwtftextStringImplcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.cpp (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.cpp 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.cpp 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -2075,6 +2075,17 @@
</span><span class="cx"> return equalIgnoringASCIICaseCommon(*a, *b);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool equalIgnoringASCIICase(const StringImpl& a, const char* b, unsigned bLength)
+{
+ if (bLength != a.length())
+ return false;
+
+ if (a.is8Bit())
+ return equalIgnoringASCIICase(a.characters8(), b, bLength);
+
+ return equalIgnoringASCIICase(a.characters16(), b, bLength);
+}
+
</ins><span class="cx"> bool equalIgnoringASCIICaseNonNull(const StringImpl* a, const StringImpl* b)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(a);
</span></span></pre></div>
<a id="branchessafari6011322branchSourceWTFwtftextStringImplh"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.h (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.h 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringImpl.h 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -972,8 +972,15 @@
</span><span class="cx">
</span><span class="cx"> WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl&, const StringImpl&);
</span><span class="cx"> WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
</span><ins>+WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl& a, const char* b, unsigned bLength);
</ins><span class="cx"> WTF_EXPORT_STRING_API bool equalIgnoringASCIICaseNonNull(const StringImpl*, const StringImpl*);
</span><span class="cx">
</span><ins>+template<unsigned charactersCount>
+bool equalIgnoringASCIICase(const StringImpl* a, const char (&b)[charactersCount])
+{
+ return a ? equalIgnoringASCIICase(*a, b, charactersCount - 1) : false;
+}
+
</ins><span class="cx"> template<typename CharacterType>
</span><span class="cx"> inline size_t find(const CharacterType* characters, unsigned length, CharacterType matchCharacter, unsigned index = 0)
</span><span class="cx"> {
</span></span></pre></div>
<a id="branchessafari6011322branchSourceWTFwtftextStringViewcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.cpp (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.cpp 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.cpp 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -73,6 +73,17 @@
</span><span class="cx"> return ::WTF::endsWithIgnoringASCIICase(*this, suffix);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool equalIgnoringASCIICase(StringView a, const char* b, unsigned bLength)
+{
+ if (bLength != a.length())
+ return false;
+
+ if (a.is8Bit())
+ return equalIgnoringASCIICase(a.characters8(), b, bLength);
+
+ return equalIgnoringASCIICase(a.characters16(), b, bLength);
+}
+
</ins><span class="cx"> #if CHECK_STRINGVIEW_LIFETIME
</span><span class="cx">
</span><span class="cx"> // Manage reference count manually so UnderlyingString does not need to be defined in the header.
</span></span></pre></div>
<a id="branchessafari6011322branchSourceWTFwtftextStringViewh"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.h (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.h 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/StringView.h 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -155,6 +155,12 @@
</span><span class="cx"> bool equal(StringView, const LChar*);
</span><span class="cx"> bool equal(StringView, const char*);
</span><span class="cx"> bool equalIgnoringASCIICase(StringView, StringView);
</span><ins>+WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(StringView a, const char* b, unsigned bLength);
+template<unsigned charactersCount>
+bool equalIgnoringASCIICase(StringView a, const char (&b)[charactersCount])
+{
+ return equalIgnoringASCIICase(a, b, charactersCount - 1);
+}
</ins><span class="cx">
</span><span class="cx"> inline bool operator==(StringView a, StringView b) { return equal(a, b); }
</span><span class="cx"> inline bool operator==(StringView a, const LChar* b) { return equal(a, b); }
</span></span></pre></div>
<a id="branchessafari6011322branchSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/WTFString.h (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/WTFString.h 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Source/WTF/wtf/text/WTFString.h 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -509,6 +509,8 @@
</span><span class="cx"> inline bool equalIgnoringCase(const char* a, const String& b) { return equalIgnoringCase(reinterpret_cast<const LChar*>(a), b.impl()); }
</span><span class="cx">
</span><span class="cx"> inline bool equalIgnoringASCIICase(const String& a, const String& b) { return equalIgnoringASCIICase(a.impl(), b.impl()); }
</span><ins>+template<unsigned charactersCount>
+inline bool equalIgnoringASCIICase(const String& a, const char (&b)[charactersCount]) { return equalIgnoringASCIICase<charactersCount>(a.impl(), b); }
</ins><span class="cx">
</span><span class="cx"> inline bool equalPossiblyIgnoringCase(const String& a, const String& b, bool ignoreCase)
</span><span class="cx"> {
</span></span></pre></div>
<a id="branchessafari6011322branchToolsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Tools/ChangeLog (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Tools/ChangeLog 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Tools/ChangeLog 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-05-18 Matthew Hanson <matthew_hanson@apple.com>
+
+ Merge r184341. rdar://problem/20809399
+
+ 2015-05-14 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Add String literal overloads to equalIgnoringASCIICase()
+ https://bugs.webkit.org/show_bug.cgi?id=145008
+
+ Reviewed by Benjamin Poulain.
+
+ Test changes to WTF.
+
+ * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
+ (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
+ (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
+ * TestWebKitAPI/Tests/WTF/StringView.cpp:
+ (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
+ (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
+
</ins><span class="cx"> 2015-05-13 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r183976.
</span></span></pre></div>
<a id="branchessafari6011322branchToolsTestWebKitAPITestsWTFStringImplcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -104,13 +104,18 @@
</span><span class="cx"> RefPtr<StringImpl> a = StringImpl::createFromLiteral("aBcDeFG");
</span><span class="cx"> RefPtr<StringImpl> b = StringImpl::createFromLiteral("ABCDEFG");
</span><span class="cx"> RefPtr<StringImpl> c = StringImpl::createFromLiteral("abcdefg");
</span><ins>+ const char d[] = "aBcDeFG";
</ins><span class="cx"> RefPtr<StringImpl> empty = StringImpl::create(reinterpret_cast<const LChar*>(""));
</span><span class="cx"> RefPtr<StringImpl> shorter = StringImpl::createFromLiteral("abcdef");
</span><ins>+ RefPtr<StringImpl> different = StringImpl::createFromLiteral("abcrefg");
</ins><span class="cx">
</span><span class="cx"> // Identity.
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(a.get(), a.get()));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(b.get(), b.get()));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(c.get(), c.get()));
</span><ins>+ ASSERT_TRUE(equalIgnoringASCIICase(a.get(), d));
+ ASSERT_TRUE(equalIgnoringASCIICase(b.get(), d));
+ ASSERT_TRUE(equalIgnoringASCIICase(c.get(), d));
</ins><span class="cx">
</span><span class="cx"> // Transitivity.
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(a.get(), b.get()));
</span><span class="lines">@@ -124,6 +129,12 @@
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(a.get(), shorter.get()));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(b.get(), shorter.get()));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(c.get(), shorter.get()));
</span><ins>+ ASSERT_FALSE(equalIgnoringASCIICase(a.get(), different.get()));
+ ASSERT_FALSE(equalIgnoringASCIICase(b.get(), different.get()));
+ ASSERT_FALSE(equalIgnoringASCIICase(c.get(), different.get()));
+ ASSERT_FALSE(equalIgnoringASCIICase(empty.get(), d));
+ ASSERT_FALSE(equalIgnoringASCIICase(shorter.get(), d));
+ ASSERT_FALSE(equalIgnoringASCIICase(different.get(), d));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TEST(WTF, StringImplEqualIgnoringASCIICaseWithNull)
</span><span class="lines">@@ -153,6 +164,7 @@
</span><span class="cx"> RefPtr<StringImpl> b = stringFromUTF8("ABCÉEFG");
</span><span class="cx"> RefPtr<StringImpl> c = stringFromUTF8("ABCéEFG");
</span><span class="cx"> RefPtr<StringImpl> d = stringFromUTF8("abcéefg");
</span><ins>+ const char e[] = "aBcéeFG";
</ins><span class="cx">
</span><span class="cx"> // Identity.
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(a.get(), a.get()));
</span><span class="lines">@@ -167,6 +179,10 @@
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(b.get(), c.get()));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(b.get(), d.get()));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(c.get(), d.get()));
</span><ins>+ ASSERT_FALSE(equalIgnoringASCIICase(a.get(), e));
+ ASSERT_FALSE(equalIgnoringASCIICase(b.get(), e));
+ ASSERT_FALSE(equalIgnoringASCIICase(c.get(), e));
+ ASSERT_FALSE(equalIgnoringASCIICase(d.get(), e));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TEST(WTF, StringImplFindIgnoringASCIICaseBasic)
</span></span></pre></div>
<a id="branchessafari6011322branchToolsTestWebKitAPITestsWTFStringViewcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringView.cpp (184493 => 184494)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringView.cpp 2015-05-18 17:00:31 UTC (rev 184493)
+++ branches/safari-601.1.32.2-branch/Tools/TestWebKitAPI/Tests/WTF/StringView.cpp 2015-05-18 17:00:45 UTC (rev 184494)
</span><span class="lines">@@ -147,18 +147,24 @@
</span><span class="cx"> RefPtr<StringImpl> a = StringImpl::createFromLiteral("aBcDeFG");
</span><span class="cx"> RefPtr<StringImpl> b = StringImpl::createFromLiteral("ABCDEFG");
</span><span class="cx"> RefPtr<StringImpl> c = StringImpl::createFromLiteral("abcdefg");
</span><ins>+ const char d[] = "aBcDeFG";
</ins><span class="cx"> RefPtr<StringImpl> empty = StringImpl::create(reinterpret_cast<const LChar*>(""));
</span><span class="cx"> RefPtr<StringImpl> shorter = StringImpl::createFromLiteral("abcdef");
</span><ins>+ RefPtr<StringImpl> different = StringImpl::createFromLiteral("abcrefg");
</ins><span class="cx">
</span><span class="cx"> StringView stringViewA(*a.get());
</span><span class="cx"> StringView stringViewB(*b.get());
</span><span class="cx"> StringView stringViewC(*c.get());
</span><span class="cx"> StringView emptyStringView(*empty.get());
</span><span class="cx"> StringView shorterStringView(*shorter.get());
</span><ins>+ StringView differentStringView(*different.get());
</ins><span class="cx">
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(stringViewA, stringViewB));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(stringViewB, stringViewC));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(stringViewB, stringViewC));
</span><ins>+ ASSERT_TRUE(equalIgnoringASCIICase(stringViewA, d));
+ ASSERT_TRUE(equalIgnoringASCIICase(stringViewB, d));
+ ASSERT_TRUE(equalIgnoringASCIICase(stringViewC, d));
</ins><span class="cx">
</span><span class="cx"> // Identity.
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(stringViewA, stringViewA));
</span><span class="lines">@@ -177,6 +183,12 @@
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(stringViewA, shorterStringView));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(stringViewB, shorterStringView));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(stringViewC, shorterStringView));
</span><ins>+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewA, differentStringView));
+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewB, differentStringView));
+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewC, differentStringView));
+ ASSERT_FALSE(equalIgnoringASCIICase(emptyStringView, d));
+ ASSERT_FALSE(equalIgnoringASCIICase(shorterStringView, d));
+ ASSERT_FALSE(equalIgnoringASCIICase(differentStringView, d));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TEST(WTF, StringViewEqualIgnoringASCIICaseWithEmpty)
</span><span class="lines">@@ -195,6 +207,7 @@
</span><span class="cx"> RefPtr<StringImpl> b = StringImpl::create(reinterpret_cast<const LChar*>("ABCÉEFG"));
</span><span class="cx"> RefPtr<StringImpl> c = StringImpl::create(reinterpret_cast<const LChar*>("ABCéEFG"));
</span><span class="cx"> RefPtr<StringImpl> d = StringImpl::create(reinterpret_cast<const LChar*>("abcéefg"));
</span><ins>+ const char e[] = "aBcéeFG";
</ins><span class="cx"> StringView stringViewA(*a.get());
</span><span class="cx"> StringView stringViewB(*b.get());
</span><span class="cx"> StringView stringViewC(*c.get());
</span><span class="lines">@@ -213,6 +226,10 @@
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(stringViewB, stringViewC));
</span><span class="cx"> ASSERT_FALSE(equalIgnoringASCIICase(stringViewB, stringViewD));
</span><span class="cx"> ASSERT_TRUE(equalIgnoringASCIICase(stringViewC, stringViewD));
</span><ins>+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewA, e));
+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewB, e));
+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewC, e));
+ ASSERT_FALSE(equalIgnoringASCIICase(stringViewD, e));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> StringView stringViewFromLiteral(const char* characters)
</span></span></pre>
</div>
</div>
</body>
</html>