<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184531] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184531">184531</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-18 17:24:19 -0700 (Mon, 18 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: v2 UI reports a higher memory usage
https://bugs.webkit.org/show_bug.cgi?id=145151
Reviewed by Chris Dumez.
The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
Fixed the bug by manually implementing the formatter as done in v1.
* public/v2/manifest.js:
(App.Manfiest._formatBytes): Added.
(App.Manifest._formatFetchedData): Use _formatByte instead of format('s').</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (184530 => 184531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-05-19 00:09:36 UTC (rev 184530)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-05-19 00:24:19 UTC (rev 184531)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-05-18 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION: v2 UI reports a higher memory usage
+ https://bugs.webkit.org/show_bug.cgi?id=145151
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
+ Fixed the bug by manually implementing the formatter as done in v1.
+
+ * public/v2/manifest.js:
+ (App.Manfiest._formatBytes): Added.
+ (App.Manifest._formatFetchedData): Use _formatByte instead of format('s').
+
</ins><span class="cx"> 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix. Add "Duration" as a time metric.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (184530 => 184531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-05-19 00:09:36 UTC (rev 184530)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-05-19 00:24:19 UTC (rev 184531)
</span><span class="lines">@@ -315,14 +315,28 @@
</span><span class="cx"> };
</span><span class="cx"> });
</span><span class="cx"> },
</span><ins>+ _formatBytes: function (sigFig, alwaysShowSign)
+ {
+ var units = ['', 'K', 'M', 'G', 'T', 'P', 'E'];
+ var threshold = sigFig >= 3 ? 1024 : 102.4;
+ return function (bytes) {
+ var i;
+ var sign = bytes >= 0 ? (alwaysShowSign ? '+' : '') : '-';
+ bytes = Math.abs(bytes);
+
+ for (i = 0; bytes >= threshold; i++)
+ bytes /= 1024;
+ return sign + bytes.toPrecision(Math.max(2, sigFig)) + units[i];
+ }
+ },
</ins><span class="cx"> _formatFetchedData: function (metricName, configurations)
</span><span class="cx"> {
</span><span class="cx"> var unit = RunsData.unitFromMetricName(metricName);
</span><span class="cx"> var smallerIsBetter = RunsData.isSmallerBetter(unit);
</span><span class="cx">
</span><del>- var useSI = unit == 'bytes';
</del><ins>+ var isBytes = unit == 'bytes';
</ins><span class="cx"> var unitSuffix = unit ? ' ' + unit : '';
</span><del>- var deltaFormatterWithoutSign = useSI ? d3.format('.2s') : d3.format('.2g');
</del><ins>+ var deltaFormatterWithoutSign = isBytes ? this._formatBytes(2, false) : d3.format('.2g');
</ins><span class="cx">
</span><span class="cx"> var currentTimeSeries = configurations.current.timeSeriesByCommitTime(false);
</span><span class="cx"> var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(false) : null;
</span><span class="lines">@@ -339,8 +353,8 @@
</span><span class="cx"> {
</span><span class="cx"> return this.formatter(value) + (delta && !isNaN(delta) ? ' \u00b1 ' + deltaFormatterWithoutSign(delta) : '') + unitSuffix;
</span><span class="cx"> },
</span><del>- formatter: useSI ? d3.format('.4s') : d3.format('.4g'),
- deltaFormatter: useSI ? d3.format('+.2s') : d3.format('+.2g'),
</del><ins>+ formatter: isBytes ? this._formatBytes(4, false) : d3.format('.4g'),
+ deltaFormatter: isBytes ? this._formatBytes(2, true) : d3.format('+.2g'),
</ins><span class="cx"> smallerIsBetter: smallerIsBetter,
</span><span class="cx"> showOutlier: function (show)
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>