<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184543] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184543">184543</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-18 22:55:22 -0700 (Mon, 18 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use Ref instead of PassRefPtr in WebCore/bindings
https://bugs.webkit.org/show_bug.cgi?id=144981
Reviewed by Darin Adler.
As a step to purge PassRefPtr, remove PassRefPtr in WebCore/bindings.
No new tests, no behavior changes.
* bindings/gobject/GObjectNodeFilterCondition.h:
(WebCore::GObjectNodeFilterCondition::create):
* bindings/gobject/GObjectXPathNSResolver.h:
(WebCore::GObjectXPathNSResolver::create):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSDOMGlobalObjectTask.cpp:
* bindings/js/JSErrorHandler.h:
(WebCore::JSErrorHandler::create):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::createForNode):
(WebCore::JSLazyEventListener::createForDOMWindow):
* bindings/js/JSLazyEventListener.h:
* bindings/js/JSMutationCallback.h:
(WebCore::JSMutationCallback::create):
* bindings/js/JSNodeFilterCondition.h:
(WebCore::JSNodeFilterCondition::create):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):
* bindings/js/SerializedScriptValue.h:
* bindings/objc/ObjCEventListener.h:
* bindings/objc/ObjCEventListener.mm:
(WebCore::ObjCEventListener::wrap):
* bindings/objc/ObjCNodeFilterCondition.h:
(WebCore::ObjCNodeFilterCondition::create):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectGObjectNodeFilterConditionh">trunk/Source/WebCore/bindings/gobject/GObjectNodeFilterCondition.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectGObjectXPathNSResolverh">trunk/Source/WebCore/bindings/gobject/GObjectXPathNSResolver.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSCustomXPathNSResolvercpp">trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSCustomXPathNSResolverh">trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMGlobalObjectTaskcpp">trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSErrorHandlerh">trunk/Source/WebCore/bindings/js/JSErrorHandler.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSLazyEventListenercpp">trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSLazyEventListenerh">trunk/Source/WebCore/bindings/js/JSLazyEventListener.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSMutationCallbackh">trunk/Source/WebCore/bindings/js/JSMutationCallback.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSNodeFilterConditionh">trunk/Source/WebCore/bindings/js/JSNodeFilterCondition.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValueh">trunk/Source/WebCore/bindings/js/SerializedScriptValue.h</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcObjCEventListenerh">trunk/Source/WebCore/bindings/objc/ObjCEventListener.h</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcObjCEventListenermm">trunk/Source/WebCore/bindings/objc/ObjCEventListener.mm</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcObjCNodeFilterConditionh">trunk/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/ChangeLog 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2015-05-18 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Use Ref instead of PassRefPtr in WebCore/bindings
+ https://bugs.webkit.org/show_bug.cgi?id=144981
+
+ Reviewed by Darin Adler.
+
+ As a step to purge PassRefPtr, remove PassRefPtr in WebCore/bindings.
+
+ No new tests, no behavior changes.
+
+ * bindings/gobject/GObjectNodeFilterCondition.h:
+ (WebCore::GObjectNodeFilterCondition::create):
+ * bindings/gobject/GObjectXPathNSResolver.h:
+ (WebCore::GObjectXPathNSResolver::create):
+ * bindings/js/JSCustomXPathNSResolver.cpp:
+ (WebCore::JSCustomXPathNSResolver::create):
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSDOMGlobalObjectTask.cpp:
+ * bindings/js/JSErrorHandler.h:
+ (WebCore::JSErrorHandler::create):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::createForNode):
+ (WebCore::JSLazyEventListener::createForDOMWindow):
+ * bindings/js/JSLazyEventListener.h:
+ * bindings/js/JSMutationCallback.h:
+ (WebCore::JSMutationCallback::create):
+ * bindings/js/JSNodeFilterCondition.h:
+ (WebCore::JSNodeFilterCondition::create):
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::SerializedScriptValue::create):
+ (WebCore::SerializedScriptValue::numberValue):
+ (WebCore::SerializedScriptValue::undefinedValue):
+ (WebCore::SerializedScriptValue::nullValue):
+ * bindings/js/SerializedScriptValue.h:
+ * bindings/objc/ObjCEventListener.h:
+ * bindings/objc/ObjCEventListener.mm:
+ (WebCore::ObjCEventListener::wrap):
+ * bindings/objc/ObjCNodeFilterCondition.h:
+ (WebCore::ObjCNodeFilterCondition::create):
+
</ins><span class="cx"> 2015-05-18 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix uninitialized warnings in RealtimeMediaSourceCenterOwr.cpp
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectGObjectNodeFilterConditionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/GObjectNodeFilterCondition.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/GObjectNodeFilterCondition.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/gobject/GObjectNodeFilterCondition.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -32,9 +32,9 @@
</span><span class="cx"> class GObjectNodeFilterCondition : public NodeFilterCondition {
</span><span class="cx"> public:
</span><span class="cx">
</span><del>- static PassRefPtr<GObjectNodeFilterCondition> create(WebKitDOMNodeFilter* filter)
</del><ins>+ static Ref<GObjectNodeFilterCondition> create(WebKitDOMNodeFilter* filter)
</ins><span class="cx"> {
</span><del>- return adoptRef(new GObjectNodeFilterCondition(filter));
</del><ins>+ return adoptRef(*new GObjectNodeFilterCondition(filter));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual short acceptNode(JSC::ExecState*, Node*) const;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectGObjectXPathNSResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/GObjectXPathNSResolver.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/GObjectXPathNSResolver.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/gobject/GObjectXPathNSResolver.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -29,9 +29,9 @@
</span><span class="cx"> class GObjectXPathNSResolver : public XPathNSResolver {
</span><span class="cx"> public:
</span><span class="cx">
</span><del>- static PassRefPtr<GObjectXPathNSResolver> create(WebKitDOMXPathNSResolver* resolver)
</del><ins>+ static Ref<GObjectXPathNSResolver> create(WebKitDOMXPathNSResolver* resolver)
</ins><span class="cx"> {
</span><del>- return adoptRef(new GObjectXPathNSResolver(resolver));
</del><ins>+ return adoptRef(*new GObjectXPathNSResolver(resolver));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~GObjectXPathNSResolver();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSCustomXPathNSResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -42,18 +42,18 @@
</span><span class="cx">
</span><span class="cx"> using namespace JSC;
</span><span class="cx">
</span><del>-PassRefPtr<JSCustomXPathNSResolver> JSCustomXPathNSResolver::create(ExecState* exec, JSValue value)
</del><ins>+RefPtr<JSCustomXPathNSResolver> JSCustomXPathNSResolver::create(ExecState* exec, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isUndefinedOrNull())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> JSObject* resolverObject = value.getObject();
</span><span class="cx"> if (!resolverObject) {
</span><span class="cx"> setDOMException(exec, TYPE_MISMATCH_ERR);
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return adoptRef(new JSCustomXPathNSResolver(exec, resolverObject, asJSDOMWindow(exec->vmEntryGlobalObject())));
</del><ins>+ return adoptRef(*new JSCustomXPathNSResolver(exec, resolverObject, asJSDOMWindow(exec->vmEntryGlobalObject())));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSCustomXPathNSResolver::JSCustomXPathNSResolver(ExecState* exec, JSObject* customResolver, JSDOMWindow* globalObject)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSCustomXPathNSResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> class JSCustomXPathNSResolver : public XPathNSResolver {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSCustomXPathNSResolver> create(JSC::ExecState*, JSC::JSValue);
</del><ins>+ static RefPtr<JSCustomXPathNSResolver> create(JSC::ExecState*, JSC::JSValue);
</ins><span class="cx">
</span><span class="cx"> virtual ~JSCustomXPathNSResolver();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMGlobalObjectTaskcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -38,9 +38,9 @@
</span><span class="cx">
</span><span class="cx"> class JSGlobalObjectCallback final : public RefCounted<JSGlobalObjectCallback>, private ActiveDOMCallback {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSGlobalObjectCallback> create(JSDOMGlobalObject* globalObject, PassRefPtr<Microtask> task)
</del><ins>+ static Ref<JSGlobalObjectCallback> create(JSDOMGlobalObject* globalObject, PassRefPtr<Microtask> task)
</ins><span class="cx"> {
</span><del>- return adoptRef(new JSGlobalObjectCallback(globalObject, task));
</del><ins>+ return adoptRef(*new JSGlobalObjectCallback(globalObject, task));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void call()
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSErrorHandlerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSErrorHandler.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSErrorHandler.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSErrorHandler.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx">
</span><span class="cx"> class JSErrorHandler : public JSEventListener {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSErrorHandler> create(JSC::JSObject* listener, JSC::JSObject* wrapper, bool isAttribute, DOMWrapperWorld& world)
</del><ins>+ static Ref<JSErrorHandler> create(JSC::JSObject* listener, JSC::JSObject* wrapper, bool isAttribute, DOMWrapperWorld& world)
</ins><span class="cx"> {
</span><del>- return adoptRef(new JSErrorHandler(listener, wrapper, isAttribute, world));
</del><ins>+ return adoptRef(*new JSErrorHandler(listener, wrapper, isAttribute, world));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~JSErrorHandler();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSLazyEventListenercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -142,7 +142,7 @@
</span><span class="cx"> return isSVGEvent ? evtString : eventString;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<JSLazyEventListener> JSLazyEventListener::createForNode(ContainerNode& node, const QualifiedName& attributeName, const AtomicString& attributeValue)
</del><ins>+RefPtr<JSLazyEventListener> JSLazyEventListener::createForNode(ContainerNode& node, const QualifiedName& attributeName, const AtomicString& attributeValue)
</ins><span class="cx"> {
</span><span class="cx"> if (attributeValue.isNull())
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -159,12 +159,12 @@
</span><span class="cx"> sourceURL = node.document().url().string();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return adoptRef(new JSLazyEventListener(attributeName.localName().string(),
</del><ins>+ return adoptRef(*new JSLazyEventListener(attributeName.localName().string(),
</ins><span class="cx"> eventParameterName(node.isSVGElement()), attributeValue,
</span><span class="cx"> &node, sourceURL, position, nullptr, mainThreadNormalWorld()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<JSLazyEventListener> JSLazyEventListener::createForDOMWindow(Frame& frame, const QualifiedName& attributeName, const AtomicString& attributeValue)
</del><ins>+RefPtr<JSLazyEventListener> JSLazyEventListener::createForDOMWindow(Frame& frame, const QualifiedName& attributeName, const AtomicString& attributeValue)
</ins><span class="cx"> {
</span><span class="cx"> if (attributeValue.isNull())
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -172,7 +172,7 @@
</span><span class="cx"> if (!frame.script().canExecuteScripts(AboutToExecuteScript))
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return adoptRef(new JSLazyEventListener(attributeName.localName().string(),
</del><ins>+ return adoptRef(*new JSLazyEventListener(attributeName.localName().string(),
</ins><span class="cx"> eventParameterName(frame.document()->isSVGDocument()), attributeValue,
</span><span class="cx"> nullptr, frame.document()->url().string(), frame.script().eventHandlerPosition(),
</span><span class="cx"> toJSDOMWindow(&frame, mainThreadNormalWorld()), mainThreadNormalWorld()));
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSLazyEventListenerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSLazyEventListener.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSLazyEventListener.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSLazyEventListener.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -32,8 +32,8 @@
</span><span class="cx">
</span><span class="cx"> class JSLazyEventListener final : public JSEventListener {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSLazyEventListener> createForNode(ContainerNode&, const QualifiedName& attributeName, const AtomicString& attributeValue);
- static PassRefPtr<JSLazyEventListener> createForDOMWindow(Frame&, const QualifiedName& attributeName, const AtomicString& attributeValue);
</del><ins>+ static RefPtr<JSLazyEventListener> createForNode(ContainerNode&, const QualifiedName& attributeName, const AtomicString& attributeValue);
+ static RefPtr<JSLazyEventListener> createForDOMWindow(Frame&, const QualifiedName& attributeName, const AtomicString& attributeValue);
</ins><span class="cx">
</span><span class="cx"> virtual ~JSLazyEventListener();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSMutationCallbackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSMutationCallback.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSMutationCallback.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSMutationCallback.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx">
</span><span class="cx"> class JSMutationCallback : public MutationCallback, public ActiveDOMCallback {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSMutationCallback> create(JSC::JSObject* callback, JSDOMGlobalObject* globalObject)
</del><ins>+ static Ref<JSMutationCallback> create(JSC::JSObject* callback, JSDOMGlobalObject* globalObject)
</ins><span class="cx"> {
</span><del>- return adoptRef(new JSMutationCallback(callback, globalObject));
</del><ins>+ return adoptRef(*new JSMutationCallback(callback, globalObject));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~JSMutationCallback();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSNodeFilterConditionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSNodeFilterCondition.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSNodeFilterCondition.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/JSNodeFilterCondition.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -34,9 +34,9 @@
</span><span class="cx">
</span><span class="cx"> class JSNodeFilterCondition : public NodeFilterCondition {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<JSNodeFilterCondition> create(JSC::VM& vm, NodeFilter* owner, JSC::JSValue filter)
</del><ins>+ static Ref<JSNodeFilterCondition> create(JSC::VM& vm, NodeFilter* owner, JSC::JSValue filter)
</ins><span class="cx"> {
</span><del>- return adoptRef(new JSNodeFilterCondition(vm, owner, filter));
</del><ins>+ return adoptRef(*new JSNodeFilterCondition(vm, owner, filter));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -2650,9 +2650,7 @@
</span><span class="cx"> return contents;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(ExecState* exec, JSValue value,
- MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
- SerializationErrorMode throwExceptions)
</del><ins>+RefPtr<SerializedScriptValue> SerializedScriptValue::create(ExecState* exec, JSValue value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, SerializationErrorMode throwExceptions)
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="cx"> Vector<String> blobURLs;
</span><span class="lines">@@ -2667,32 +2665,32 @@
</span><span class="cx"> maybeThrowExceptionIfSerializationFailed(exec, code);
</span><span class="cx">
</span><span class="cx"> if (!serializationDidCompleteSuccessfully(code))
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- return adoptRef(new SerializedScriptValue(buffer, blobURLs, WTF::move(arrayBufferContentsArray)));
</del><ins>+ return adoptRef(*new SerializedScriptValue(buffer, blobURLs, WTF::move(arrayBufferContentsArray)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(const String& string)
</del><ins>+RefPtr<SerializedScriptValue> SerializedScriptValue::create(const String& string)
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="cx"> if (!CloneSerializer::serialize(string, buffer))
</span><del>- return 0;
- return adoptRef(new SerializedScriptValue(buffer));
</del><ins>+ return nullptr;
+ return adoptRef(*new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::numberValue(double value)
</del><ins>+Ref<SerializedScriptValue> SerializedScriptValue::numberValue(double value)
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="cx"> CloneSerializer::serializeNumber(value, buffer);
</span><del>- return adoptRef(new SerializedScriptValue(buffer));
</del><ins>+ return adoptRef(*new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::undefinedValue()
</del><ins>+Ref<SerializedScriptValue> SerializedScriptValue::undefinedValue()
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><span class="cx"> CloneSerializer::serializeUndefined(buffer);
</span><del>- return adoptRef(new SerializedScriptValue(buffer));
</del><ins>+ return adoptRef(*new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -2742,10 +2740,10 @@
</span><span class="cx"> return toRef(exec, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<SerializedScriptValue> SerializedScriptValue::nullValue()
</del><ins>+Ref<SerializedScriptValue> SerializedScriptValue::nullValue()
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint8_t> buffer;
</span><del>- return adoptRef(new SerializedScriptValue(buffer));
</del><ins>+ return adoptRef(*new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SerializedScriptValue::maybeThrowExceptionIfSerializationFailed(ExecState* exec, SerializationReturnCode code)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -67,15 +67,15 @@
</span><span class="cx"> public RefCounted<SerializedScriptValue> {
</span><span class="cx"> #endif
</span><span class="cx"> public:
</span><del>- WEBCORE_EXPORT static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, MessagePortArray*, ArrayBufferArray*, SerializationErrorMode = Throwing);
</del><ins>+ WEBCORE_EXPORT static RefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, MessagePortArray*, ArrayBufferArray*, SerializationErrorMode = Throwing);
</ins><span class="cx">
</span><del>- WEBCORE_EXPORT static PassRefPtr<SerializedScriptValue> create(const String&);
- static PassRefPtr<SerializedScriptValue> adopt(Vector<uint8_t>& buffer)
</del><ins>+ WEBCORE_EXPORT static RefPtr<SerializedScriptValue> create(const String&);
+ static Ref<SerializedScriptValue> adopt(Vector<uint8_t>& buffer)
</ins><span class="cx"> {
</span><del>- return adoptRef(new SerializedScriptValue(buffer));
</del><ins>+ return adoptRef(*new SerializedScriptValue(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<SerializedScriptValue> nullValue();
</del><ins>+ static Ref<SerializedScriptValue> nullValue();
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT JSC::JSValue deserialize(JSC::ExecState*, JSC::JSGlobalObject*, MessagePortArray*, SerializationErrorMode = Throwing);
</span><span class="cx">
</span><span class="lines">@@ -93,13 +93,13 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><span class="cx"> // FIXME: Get rid of these. The only caller immediately deserializes the result, so it's a very roundabout way to create a JSValue.
</span><del>- static PassRefPtr<SerializedScriptValue> numberValue(double value);
- static PassRefPtr<SerializedScriptValue> undefinedValue();
</del><ins>+ static Ref<SerializedScriptValue> numberValue(double value);
+ static Ref<SerializedScriptValue> undefinedValue();
</ins><span class="cx"> #endif
</span><span class="cx">
</span><del>- static PassRefPtr<SerializedScriptValue> createFromWireBytes(const Vector<uint8_t>& data)
</del><ins>+ static Ref<SerializedScriptValue> createFromWireBytes(const Vector<uint8_t>& data)
</ins><span class="cx"> {
</span><del>- return adoptRef(new SerializedScriptValue(data));
</del><ins>+ return adoptRef(*new SerializedScriptValue(data));
</ins><span class="cx"> }
</span><span class="cx"> const Vector<uint8_t>& toWireBytes() const { return m_data; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcObjCEventListenerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/objc/ObjCEventListener.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/ObjCEventListener.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/objc/ObjCEventListener.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> class ObjCEventListener : public EventListener {
</span><span class="cx"> public:
</span><span class="cx"> typedef id<DOMEventListener> ObjCListener;
</span><del>- static PassRefPtr<ObjCEventListener> wrap(ObjCListener);
</del><ins>+ static Ref<ObjCEventListener> wrap(ObjCListener);
</ins><span class="cx">
</span><span class="cx"> static const ObjCEventListener* cast(const EventListener* listener)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcObjCEventListenermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/objc/ObjCEventListener.mm (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/ObjCEventListener.mm 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/objc/ObjCEventListener.mm 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -48,12 +48,12 @@
</span><span class="cx"> return map->get(listener);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ObjCEventListener> ObjCEventListener::wrap(ObjCListener listener)
</del><ins>+Ref<ObjCEventListener> ObjCEventListener::wrap(ObjCListener listener)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<ObjCEventListener> wrapper = find(listener);
</span><span class="cx"> if (wrapper)
</span><del>- return wrapper;
- return adoptRef(new ObjCEventListener(listener));
</del><ins>+ return wrapper.releaseNonNull();
+ return adoptRef(*new ObjCEventListener(listener));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ObjCEventListener::ObjCEventListener(ObjCListener listener)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcObjCNodeFilterConditionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h (184542 => 184543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h 2015-05-19 04:46:26 UTC (rev 184542)
+++ trunk/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h 2015-05-19 05:55:22 UTC (rev 184543)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx">
</span><span class="cx"> class ObjCNodeFilterCondition : public NodeFilterCondition {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ObjCNodeFilterCondition> create(id <DOMNodeFilter> filter)
</del><ins>+ static Ref<ObjCNodeFilterCondition> create(id <DOMNodeFilter> filter)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ObjCNodeFilterCondition(filter));
</del><ins>+ return adoptRef(*new ObjCNodeFilterCondition(filter));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual short acceptNode(JSC::ExecState*, Node*) const;
</span></span></pre>
</div>
</div>
</body>
</html>