<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184325] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184325">184325</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-13 18:34:08 -0700 (Wed, 13 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up some possible RefPtr to PassRefPtr churn
https://bugs.webkit.org/show_bug.cgi?id=144779
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-05-13
Reviewed by Darin Adler.
* runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
* runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
* runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
* runtime/TypedArrayBase.h:
(JSC::TypedArrayBase::create):
(JSC::TypedArrayBase::createUninitialized):
* tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):
Release the last use of a RefPtr as it is passed on.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewInlinesh">trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSArrayBufferConstructorcpp">trunk/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeStructurecpp">trunk/Source/JavaScriptCore/runtime/Structure.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeTypedArrayBaseh">trunk/Source/JavaScriptCore/runtime/TypedArrayBase.h</a></li>
<li><a href="#trunkSourceJavaScriptCoretoolsFunctionOverridescpp">trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsISOVTTCuecpp">trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2015-05-13 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Clean up some possible RefPtr to PassRefPtr churn
+ https://bugs.webkit.org/show_bug.cgi?id=144779
+
+ Reviewed by Darin Adler.
+
+ * runtime/GenericTypedArrayViewInlines.h:
+ (JSC::GenericTypedArrayView<Adaptor>::create):
+ (JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
+ * runtime/JSArrayBufferConstructor.cpp:
+ (JSC::constructArrayBuffer):
+ * runtime/Structure.cpp:
+ (JSC::Structure::toStructureShape):
+ * runtime/TypedArrayBase.h:
+ (JSC::TypedArrayBase::create):
+ (JSC::TypedArrayBase::createUninitialized):
+ * tools/FunctionOverrides.cpp:
+ (JSC::initializeOverrideInfo):
+ Release the last use of a RefPtr as it is passed on.
+
+2015-05-13 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> ES6: Allow duplicate property names
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142895
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeGenericTypedArrayViewInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> RefPtr<ArrayBuffer> buffer = ArrayBuffer::create(length, sizeof(typename Adaptor::Type));
</span><span class="cx"> if (!buffer)
</span><span class="cx"> return 0;
</span><del>- return create(buffer, 0, length);
</del><ins>+ return create(buffer.release(), 0, length);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<GenericTypedArrayView> result = create(length);
</span><span class="cx"> memcpy(result->data(), array, length * sizeof(typename Adaptor::Type));
</span><del>- return result;
</del><ins>+ return result.release();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return adoptRef(new GenericTypedArrayView(buffer, byteOffset, length));
</del><ins>+ return adoptRef(new GenericTypedArrayView(buffer.release(), byteOffset, length));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> ArrayBuffer::createUninitialized(length, sizeof(typename Adaptor::Type));
</span><span class="cx"> if (!buffer)
</span><span class="cx"> return 0;
</span><del>- return create(buffer, 0, length);
</del><ins>+ return create(buffer.release(), 0, length);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Adaptor>
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSArrayBufferConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> return throwVMError(exec, createOutOfMemoryError(exec));
</span><span class="cx">
</span><span class="cx"> JSArrayBuffer* result = JSArrayBuffer::create(
</span><del>- exec->vm(), constructor->globalObject()->arrayBufferStructure(), buffer);
</del><ins>+ exec->vm(), constructor->globalObject()->arrayBufferStructure(), buffer.release());
</ins><span class="cx">
</span><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeStructurecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Structure.cpp (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Structure.cpp 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/runtime/Structure.cpp 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -1052,7 +1052,6 @@
</span><span class="cx"> curShape->addProperty(structure->m_nameInPrevious.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> if (JSObject* curObject = curValue.getObject())
</span><span class="cx"> curShape->setConstructorName(JSObject::calculatedClassName(curObject));
</span><span class="cx"> else
</span><span class="lines">@@ -1066,7 +1065,7 @@
</span><span class="cx"> if (curStructure->storedPrototypeStructure()) {
</span><span class="cx"> RefPtr<StructureShape> newShape = StructureShape::create();
</span><span class="cx"> curShape->setProto(newShape);
</span><del>- curShape = newShape;
</del><ins>+ curShape = newShape.release();
</ins><span class="cx"> curValue = curStructure->storedPrototype();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeTypedArrayBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/TypedArrayBase.h (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/TypedArrayBase.h 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/runtime/TypedArrayBase.h 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> RefPtr<ArrayBuffer> buffer = ArrayBuffer::create(length, sizeof(T));
</span><span class="cx"> if (!buffer.get())
</span><span class="cx"> return 0;
</span><del>- return create<Subclass>(buffer, 0, length);
</del><ins>+ return create<Subclass>(buffer.release(), 0, length);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <class Subclass>
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> if (a)
</span><span class="cx"> for (unsigned i = 0; i < length; ++i)
</span><span class="cx"> a->set(i, array[i]);
</span><del>- return a;
</del><ins>+ return a.release();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <class Subclass>
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> if (!verifySubRange<T>(buf, byteOffset, length))
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- return adoptRef(new Subclass(buf, byteOffset, length));
</del><ins>+ return adoptRef(new Subclass(buf.release(), byteOffset, length));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <class Subclass>
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> RefPtr<ArrayBuffer> buffer = ArrayBuffer::createUninitialized(length, sizeof(T));
</span><span class="cx"> if (!buffer.get())
</span><span class="cx"> return 0;
</span><del>- return create<Subclass>(buffer, 0, length);
</del><ins>+ return create<Subclass>(buffer.release(), 0, length);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <class Subclass>
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretoolsFunctionOverridescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> info.typeProfilingEndOffset = newProviderStr.length() - 1;
</span><span class="cx">
</span><span class="cx"> info.sourceCode =
</span><del>- SourceCode(newProvider, info.typeProfilingStartOffset, info.typeProfilingEndOffset + 1, 1, 1);
</del><ins>+ SourceCode(newProvider.release(), info.typeProfilingStartOffset, info.typeProfilingEndOffset + 1, 1, 1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool FunctionOverrides::initializeOverrideFor(const SourceCode& origCode, FunctionOverrides::OverrideInfo& result)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsISOVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp (184324 => 184325)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp 2015-05-14 01:32:25 UTC (rev 184324)
+++ trunk/Source/WebCore/platform/graphics/ISOVTTCue.cpp 2015-05-14 01:34:08 UTC (rev 184325)
</span><span class="lines">@@ -30,6 +30,8 @@
</span><span class="cx"> #include <runtime/ArrayBuffer.h>
</span><span class="cx"> #include <runtime/DataView.h>
</span><span class="cx"> #include <runtime/Int8Array.h>
</span><ins>+#include <runtime/JSCInlines.h>
+#include <runtime/TypedArrayInlines.h>
</ins><span class="cx"> #include <wtf/NeverDestroyed.h>
</span><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx"> #include <wtf/text/StringBuilder.h>
</span></span></pre>
</div>
</div>
</body>
</html>