<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184291] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184291">184291</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-13 11:51:44 -0700 (Wed, 13 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Pass String as reference in more places
https://bugs.webkit.org/show_bug.cgi?id=144769
Reviewed by Daniel Bates.
Source/JavaScriptCore:
* debugger/Breakpoint.h:
(JSC::Breakpoint::Breakpoint):
* parser/Parser.h:
(JSC::Parser::setErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
* parser/ParserError.h:
(JSC::ParserError::ParserError):
* runtime/RegExp.cpp:
(JSC::RegExpFunctionalTestCollector::outputOneTest):
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSourceInternal):
* runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::typeInformationForExpressionAtOffset):
* runtime/TypeProfilerLog.cpp:
(JSC::TypeProfilerLog::processLogEntries):
* runtime/TypeProfilerLog.h:
* tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):
* inspector/scripts/codegen/generate_objc_conversion_helpers.py:
(ObjCConversionHelpersGenerator._generate_enum_from_protocol_string):
* inspector/scripts/codegen/objc_generator_templates.py:
* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/enum-values.json-result:
* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
* inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
Rebaseline tests after updating the generator.
Source/WebCore:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpString):
(WebCore::CloneSerializer::dumpStringObject):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
* dom/DocumentMarkerController.h:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorNodeFinder.cpp:
(WebCore::stripCharacters):
(WebCore::InspectorNodeFinder::InspectorNodeFinder):
* inspector/InspectorNodeFinder.h:
Source/WebKit2:
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::showMainResourceForFrame):
* WebProcess/WebPage/WebInspectorUI.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerBreakpointh">trunk/Source/JavaScriptCore/debugger/Breakpoint.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptscodegengenerate_objc_conversion_helperspy">trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptscodegenobjc_generator_templatespy">trunk/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedcommandswithasyncattributejsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedcommandswithoptionalcallreturnparametersjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpecteddomainswithvaryingcommandsizesjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedenumvaluesjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedeventswithoptionalparametersjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedgeneratedomainswithfeatureguardsjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedsametypeiddifferentdomainjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedshadowedoptionaltypesettersjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationaliasedprimitivetypejsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationarraytypejsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationenumtypejsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationobjecttypejsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtyperequiringruntimecastsjsonresult">trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParserh">trunk/Source/JavaScriptCore/parser/Parser.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParserErrorh">trunk/Source/JavaScriptCore/parser/ParserError.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeRegExpcpp">trunk/Source/JavaScriptCore/runtime/RegExp.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeRegExpObjectcpp">trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeTypeProfilercpp">trunk/Source/JavaScriptCore/runtime/TypeProfiler.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeTypeProfilerLogcpp">trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeTypeProfilerLogh">trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.h</a></li>
<li><a href="#trunkSourceJavaScriptCoretoolsFunctionOverridescpp">trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentMarkerControllercpp">trunk/Source/WebCore/dom/DocumentMarkerController.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentMarkerControllerh">trunk/Source/WebCore/dom/DocumentMarkerController.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgentcpp">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth">trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorNodeFindercpp">trunk/Source/WebCore/inspector/InspectorNodeFinder.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorNodeFinderh">trunk/Source/WebCore/inspector/InspectorNodeFinder.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIh">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2015-05-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Pass String as reference in more places
+ https://bugs.webkit.org/show_bug.cgi?id=144769
+
+ Reviewed by Daniel Bates.
+
+ * debugger/Breakpoint.h:
+ (JSC::Breakpoint::Breakpoint):
+ * parser/Parser.h:
+ (JSC::Parser::setErrorMessage):
+ (JSC::Parser::updateErrorWithNameAndMessage):
+ * parser/ParserError.h:
+ (JSC::ParserError::ParserError):
+ * runtime/RegExp.cpp:
+ (JSC::RegExpFunctionalTestCollector::outputOneTest):
+ * runtime/RegExpObject.cpp:
+ (JSC::regExpObjectSourceInternal):
+ * runtime/TypeProfiler.cpp:
+ (JSC::TypeProfiler::typeInformationForExpressionAtOffset):
+ * runtime/TypeProfilerLog.cpp:
+ (JSC::TypeProfilerLog::processLogEntries):
+ * runtime/TypeProfilerLog.h:
+ * tools/FunctionOverrides.cpp:
+ (JSC::initializeOverrideInfo):
+ * inspector/scripts/codegen/generate_objc_conversion_helpers.py:
+ (ObjCConversionHelpersGenerator._generate_enum_from_protocol_string):
+
+ * inspector/scripts/codegen/objc_generator_templates.py:
+ * inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
+ * inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
+ * inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
+ * inspector/scripts/tests/expected/enum-values.json-result:
+ * inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
+ * inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
+ * inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
+ * inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
+ * inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
+ * inspector/scripts/tests/expected/type-declaration-array-type.json-result:
+ * inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
+ * inspector/scripts/tests/expected/type-declaration-object-type.json-result:
+ * inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
+ Rebaseline tests after updating the generator.
+
</ins><span class="cx"> 2015-05-13 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finalizeUnconditionally
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerBreakpointh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Breakpoint.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Breakpoint.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/debugger/Breakpoint.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Breakpoint(SourceID sourceID, unsigned line, unsigned column, String condition, bool autoContinue)
</del><ins>+ Breakpoint(SourceID sourceID, unsigned line, unsigned column, const String& condition, bool autoContinue)
</ins><span class="cx"> : id(noBreakpointID)
</span><span class="cx"> , sourceID(sourceID)
</span><span class="cx"> , line(line)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptscodegengenerate_objc_conversion_helperspy"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> def _generate_enum_from_protocol_string(self, objc_enum_name, enum_values):
</span><span class="cx"> lines = []
</span><span class="cx"> lines.append('template<>')
</span><del>- lines.append('inline %s fromProtocolString(String value)' % objc_enum_name)
</del><ins>+ lines.append('inline %s fromProtocolString(const String& value)' % objc_enum_name)
</ins><span class="cx"> lines.append('{')
</span><span class="cx"> for enum_value in enum_values:
</span><span class="cx"> lines.append(' if (value == "%s")' % enum_value)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptscodegenobjc_generator_templatespy"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">
</span><span class="cx"> ConversionHelpersStandard = (
</span><span class="cx"> """template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);""")
</del><ins>+ObjCEnumType fromProtocolString(const String& value);""")
</ins><span class="cx">
</span><span class="cx"> BackendDispatcherHeaderPrelude = (
</span><span class="cx"> """${includes}
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedcommandswithasyncattributejsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1226,7 +1226,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolDatabasePrimaryColors value)
</span><span class="lines">@@ -1242,7 +1242,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabasePrimaryColors fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabasePrimaryColors fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "red")
</span><span class="cx"> return RWIProtocolDatabasePrimaryColorsRed;
</span><span class="lines">@@ -1269,7 +1269,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteSQLSyncOptionalReturnValuesPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteSQLSyncOptionalReturnValuesPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteSQLSyncOptionalReturnValuesPrintColorCyan;
</span><span class="lines">@@ -1298,7 +1298,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteSQLAsyncOptionalReturnValuesPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteSQLAsyncOptionalReturnValuesPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteSQLAsyncOptionalReturnValuesPrintColorCyan;
</span><span class="lines">@@ -1327,7 +1327,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteSQLSyncPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteSQLSyncPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteSQLSyncPrintColorCyan;
</span><span class="lines">@@ -1356,7 +1356,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteSQLAsyncPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteSQLAsyncPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteSQLAsyncPrintColorCyan;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedcommandswithoptionalcallreturnparametersjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1077,7 +1077,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolDatabasePrimaryColors value)
</span><span class="lines">@@ -1093,7 +1093,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabasePrimaryColors fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabasePrimaryColors fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "red")
</span><span class="cx"> return RWIProtocolDatabasePrimaryColorsRed;
</span><span class="lines">@@ -1120,7 +1120,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteAllOptionalParametersPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteAllOptionalParametersPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteAllOptionalParametersPrintColorCyan;
</span><span class="lines">@@ -1149,7 +1149,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteAllOptionalParametersPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteAllOptionalParametersPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteAllOptionalParametersPrintColorCyan;
</span><span class="lines">@@ -1178,7 +1178,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteNoOptionalParametersPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteNoOptionalParametersPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteNoOptionalParametersPrintColorCyan;
</span><span class="lines">@@ -1207,7 +1207,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDatabaseExecuteNoOptionalParametersPrintColor fromProtocolString(String value)
</del><ins>+inline RWIProtocolDatabaseExecuteNoOptionalParametersPrintColor fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "cyan")
</span><span class="cx"> return RWIProtocolDatabaseExecuteNoOptionalParametersPrintColorCyan;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpecteddomainswithvaryingcommandsizesjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1103,7 +1103,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedenumvaluesjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -835,7 +835,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolTypeDomainEnum value)
</span><span class="lines">@@ -853,7 +853,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolTypeDomainEnum fromProtocolString(String value)
</del><ins>+inline RWIProtocolTypeDomainEnum fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "shared")
</span><span class="cx"> return RWIProtocolTypeDomainEnumShared;
</span><span class="lines">@@ -883,7 +883,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolCommandDomainCommandWithEnumReturnValueReturnValue fromProtocolString(String value)
</del><ins>+inline RWIProtocolCommandDomainCommandWithEnumReturnValueReturnValue fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "shared")
</span><span class="cx"> return RWIProtocolCommandDomainCommandWithEnumReturnValueReturnValueShared;
</span><span class="lines">@@ -911,7 +911,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolEventDomainEventWithEnumParameterParameter fromProtocolString(String value)
</del><ins>+inline RWIProtocolEventDomainEventWithEnumParameterParameter fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "shared")
</span><span class="cx"> return RWIProtocolEventDomainEventWithEnumParameterParameterShared;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedeventswithoptionalparametersjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -784,7 +784,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedgeneratedomainswithfeatureguardsjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -881,7 +881,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedsametypeiddifferentdomainjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -646,7 +646,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedshadowedoptionaltypesettersjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -715,7 +715,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolRuntimeKeyPathType value)
</span><span class="lines">@@ -731,7 +731,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolRuntimeKeyPathType fromProtocolString(String value)
</del><ins>+inline RWIProtocolRuntimeKeyPathType fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "null")
</span><span class="cx"> return RWIProtocolRuntimeKeyPathTypeNull;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationaliasedprimitivetypejsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -637,7 +637,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationarraytypejsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -669,7 +669,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolDebuggerReason value)
</span><span class="lines">@@ -685,7 +685,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolDebuggerReason fromProtocolString(String value)
</del><ins>+inline RWIProtocolDebuggerReason fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "Died")
</span><span class="cx"> return RWIProtocolDebuggerReasonDied;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationenumtypejsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -666,7 +666,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolRuntimeFarmAnimals value)
</span><span class="lines">@@ -684,7 +684,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolRuntimeFarmAnimals fromProtocolString(String value)
</del><ins>+inline RWIProtocolRuntimeFarmAnimals fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "Pigs")
</span><span class="cx"> return RWIProtocolRuntimeFarmAnimalsPigs;
</span><span class="lines">@@ -713,7 +713,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolRuntimeTwoLeggedAnimals fromProtocolString(String value)
</del><ins>+inline RWIProtocolRuntimeTwoLeggedAnimals fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "Ducks")
</span><span class="cx"> return RWIProtocolRuntimeTwoLeggedAnimalsDucks;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtypedeclarationobjecttypejsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1106,7 +1106,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorscriptstestsexpectedtyperequiringruntimecastsjsonresult"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -993,7 +993,7 @@
</span><span class="cx"> namespace Inspector {
</span><span class="cx">
</span><span class="cx"> template<typename ObjCEnumType>
</span><del>-ObjCEnumType fromProtocolString(String value);
</del><ins>+ObjCEnumType fromProtocolString(const String& value);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> inline String toProtocolString(RWIProtocolTestUncastedAnimals value)
</span><span class="lines">@@ -1011,7 +1011,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolTestUncastedAnimals fromProtocolString(String value)
</del><ins>+inline RWIProtocolTestUncastedAnimals fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "Pigs")
</span><span class="cx"> return RWIProtocolTestUncastedAnimalsPigs;
</span><span class="lines">@@ -1040,7 +1040,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<>
</span><del>-inline RWIProtocolTestCastedAnimals fromProtocolString(String value)
</del><ins>+inline RWIProtocolTestCastedAnimals fromProtocolString(const String& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value == "Ducks")
</span><span class="cx"> return RWIProtocolTestCastedAnimalsDucks;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/parser/Parser.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -653,9 +653,9 @@
</span><span class="cx"> return m_token.m_location;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void setErrorMessage(String msg)
</del><ins>+ void setErrorMessage(const String& message)
</ins><span class="cx"> {
</span><del>- m_errorMessage = msg;
</del><ins>+ m_errorMessage = message;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> NEVER_INLINE void logError(bool);
</span><span class="lines">@@ -667,9 +667,9 @@
</span><span class="cx"> template <typename A, typename B, typename C, typename D, typename E, typename F> NEVER_INLINE void logError(bool, const A&, const B&, const C&, const D&, const E&, const F&);
</span><span class="cx"> template <typename A, typename B, typename C, typename D, typename E, typename F, typename G> NEVER_INLINE void logError(bool, const A&, const B&, const C&, const D&, const E&, const F&, const G&);
</span><span class="cx">
</span><del>- NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, String name, const char* afterMsg)
</del><ins>+ NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMessage, const String& name, const char* afterMessage)
</ins><span class="cx"> {
</span><del>- m_errorMessage = makeString(beforeMsg, " '", name, "' ", afterMsg);
</del><ins>+ m_errorMessage = makeString(beforeMessage, " '", name, "' ", afterMessage);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> NEVER_INLINE void updateErrorMessage(const char* msg)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParserErrorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/ParserError.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/ParserError.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/parser/ParserError.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- ParserError(ErrorType type, SyntaxErrorType syntaxError, JSToken token, String msg, int line)
</del><ins>+ ParserError(ErrorType type, SyntaxErrorType syntaxError, JSToken token, const String& msg, int line)
</ins><span class="cx"> : m_token(token)
</span><span class="cx"> , m_message(msg)
</span><span class="cx"> , m_line(line)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeRegExpcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/RegExp.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/RegExp.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/runtime/RegExp.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx"> return s_instance;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RegExpFunctionalTestCollector::outputOneTest(RegExp* regExp, String s, int startOffset, int* ovector, int result)
</del><ins>+void RegExpFunctionalTestCollector::outputOneTest(RegExp* regExp, const String& s, int startOffset, int* ovector, int result)
</ins><span class="cx"> {
</span><span class="cx"> if ((!m_lastRegExp) || (m_lastRegExp != regExp)) {
</span><span class="cx"> m_lastRegExp = regExp;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeRegExpObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -199,7 +199,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <typename CharacterType>
</span><del>-static inline JSValue regExpObjectSourceInternal(ExecState* exec, String pattern, const CharacterType* characters, unsigned length)
</del><ins>+static inline JSValue regExpObjectSourceInternal(ExecState* exec, const String& pattern, const CharacterType* characters, unsigned length)
</ins><span class="cx"> {
</span><span class="cx"> bool previousCharacterWasBackslash = false;
</span><span class="cx"> bool inBrackets = false;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeTypeProfilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/TypeProfiler.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/TypeProfiler.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/runtime/TypeProfiler.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -101,7 +101,6 @@
</span><span class="cx"> else
</span><span class="cx"> json.appendLiteral("false");
</span><span class="cx">
</span><del>-
</del><span class="cx"> json.append('}');
</span><span class="cx">
</span><span class="cx"> return json.toString();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeTypeProfilerLogcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> delete[] m_logStartPtr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TypeProfilerLog::processLogEntries(String reason)
</del><ins>+void TypeProfilerLog::processLogEntries(const String& reason)
</ins><span class="cx"> {
</span><span class="cx"> if (verbose)
</span><span class="cx"> dataLog("Process caller:'", reason, "'");
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeTypeProfilerLogh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/runtime/TypeProfilerLog.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx">
</span><span class="cx"> ~TypeProfilerLog();
</span><span class="cx">
</span><del>- JS_EXPORT_PRIVATE void processLogEntries(String);
</del><ins>+ JS_EXPORT_PRIVATE void processLogEntries(const String&);
</ins><span class="cx"> LogEntry* logEndPtr() const { return m_logEndPtr; }
</span><span class="cx">
</span><span class="cx"> static ptrdiff_t logStartOffset() { return OBJECT_OFFSETOF(TypeProfilerLog, m_logStartPtr); }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretoolsFunctionOverridescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> parseOverridesInFile(overridesFileName);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void initializeOverrideInfo(const SourceCode& origCode, String newBody, FunctionOverrides::OverrideInfo& info)
</del><ins>+static void initializeOverrideInfo(const SourceCode& origCode, const String& newBody, FunctionOverrides::OverrideInfo& info)
</ins><span class="cx"> {
</span><span class="cx"> String origProviderStr = origCode.provider()->source();
</span><span class="cx"> unsigned origBraceStart = origCode.startOffset();
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/ChangeLog 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-05-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Pass String as reference in more places
+ https://bugs.webkit.org/show_bug.cgi?id=144769
+
+ Reviewed by Daniel Bates.
+
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::CloneSerializer::dumpString):
+ (WebCore::CloneSerializer::dumpStringObject):
+ * dom/DocumentMarkerController.cpp:
+ (WebCore::DocumentMarkerController::addMarker):
+ * dom/DocumentMarkerController.h:
+ * inspector/InspectorApplicationCacheAgent.cpp:
+ (WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
+ * inspector/InspectorApplicationCacheAgent.h:
+ * inspector/InspectorNodeFinder.cpp:
+ (WebCore::stripCharacters):
+ (WebCore::InspectorNodeFinder::InspectorNodeFinder):
+ * inspector/InspectorNodeFinder.h:
+
</ins><span class="cx"> 2015-05-13 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> View scale changes are temporarily lost after restoring a page from the page cache
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -681,23 +681,23 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void dumpString(String str)
</del><ins>+ void dumpString(const String& string)
</ins><span class="cx"> {
</span><del>- if (str.isEmpty())
</del><ins>+ if (string.isEmpty())
</ins><span class="cx"> write(EmptyStringTag);
</span><span class="cx"> else {
</span><span class="cx"> write(StringTag);
</span><del>- write(str);
</del><ins>+ write(string);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void dumpStringObject(String str)
</del><ins>+ void dumpStringObject(const String& string)
</ins><span class="cx"> {
</span><del>- if (str.isEmpty())
</del><ins>+ if (string.isEmpty())
</ins><span class="cx"> write(EmptyStringObjectTag);
</span><span class="cx"> else {
</span><span class="cx"> write(StringObjectTag);
</span><del>- write(str);
</del><ins>+ write(string);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentMarkerControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>-void DocumentMarkerController::addMarker(Range* range, DocumentMarker::MarkerType type, String description, const Vector<String>& interpretations, const RetainPtr<id>& metadata)
</del><ins>+void DocumentMarkerController::addMarker(Range* range, DocumentMarker::MarkerType type, const String& description, const Vector<String>& interpretations, const RetainPtr<id>& metadata)
</ins><span class="cx"> {
</span><span class="cx"> // Use a TextIterator to visit the potentially multiple nodes the range covers.
</span><span class="cx"> for (TextIterator markedText(range); !markedText.atEnd(); markedText.advance()) {
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentMarkerControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentMarkerController.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentMarkerController.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> void addMarkerToNode(Node*, unsigned startOffset, unsigned length, DocumentMarker::MarkerType, PassRefPtr<DocumentMarkerDetails>);
</span><span class="cx"> WEBCORE_EXPORT void addTextMatchMarker(const Range*, bool activeMatch);
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- void addMarker(Range*, DocumentMarker::MarkerType, String description, const Vector<String>& interpretations, const RetainPtr<id>& metadata);
</del><ins>+ void addMarker(Range*, DocumentMarker::MarkerType, const String& description, const Vector<String>& interpretations, const RetainPtr<id>& metadata);
</ins><span class="cx"> void addDictationPhraseWithAlternativesMarker(Range*, const Vector<String>& interpretations);
</span><span class="cx"> void addDictationResultMarker(Range*, const RetainPtr<id>& metadata);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-DocumentLoader* InspectorApplicationCacheAgent::assertFrameWithDocumentLoader(ErrorString& errorString, String frameId)
</del><ins>+DocumentLoader* InspectorApplicationCacheAgent::assertFrameWithDocumentLoader(ErrorString& errorString, const String& frameId)
</ins><span class="cx"> {
</span><span class="cx"> Frame* frame = m_pageAgent->assertFrame(errorString, frameId);
</span><span class="cx"> if (!frame)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorApplicationCacheAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> Ref<Inspector::Protocol::Array<Inspector::Protocol::ApplicationCache::ApplicationCacheResource>> buildArrayForApplicationCacheResources(const ApplicationCacheHost::ResourceInfoList&);
</span><span class="cx"> Ref<Inspector::Protocol::ApplicationCache::ApplicationCacheResource> buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);
</span><span class="cx">
</span><del>- DocumentLoader* assertFrameWithDocumentLoader(ErrorString&, String frameId);
</del><ins>+ DocumentLoader* assertFrameWithDocumentLoader(ErrorString&, const String& frameId);
</ins><span class="cx">
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx"> std::unique_ptr<Inspector::ApplicationCacheFrontendDispatcher> m_frontendDispatcher;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorNodeFindercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorNodeFinder.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorNodeFinder.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/inspector/InspectorNodeFinder.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-static String stripCharacters(String string, const char startCharacter, const char endCharacter, bool& startCharFound, bool& endCharFound)
</del><ins>+static String stripCharacters(const String& string, const char startCharacter, const char endCharacter, bool& startCharFound, bool& endCharFound)
</ins><span class="cx"> {
</span><span class="cx"> startCharFound = string.startsWith(startCharacter);
</span><span class="cx"> endCharFound = string.endsWith(endCharacter);
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> return string.substring(start, end - start);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorNodeFinder::InspectorNodeFinder(String whitespaceTrimmedQuery)
</del><ins>+InspectorNodeFinder::InspectorNodeFinder(const String& whitespaceTrimmedQuery)
</ins><span class="cx"> : m_whitespaceTrimmedQuery(whitespaceTrimmedQuery)
</span><span class="cx"> {
</span><span class="cx"> m_tagNameQuery = stripCharacters(whitespaceTrimmedQuery, '<', '>', m_startTagFound, m_endTagFound);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorNodeFinderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorNodeFinder.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorNodeFinder.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebCore/inspector/InspectorNodeFinder.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> class InspectorNodeFinder {
</span><span class="cx"> public:
</span><del>- InspectorNodeFinder(String whitespaceTrimmedQuery);
</del><ins>+ InspectorNodeFinder(const String& whitespaceTrimmedQuery);
</ins><span class="cx"> void performSearch(Node*);
</span><span class="cx"> const ListHashSet<Node*>& results() const { return m_results; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-05-13 Joseph Pecoraro <pecoraro@apple.com>
+
+ Pass String as reference in more places
+ https://bugs.webkit.org/show_bug.cgi?id=144769
+
+ Reviewed by Daniel Bates.
+
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::showMainResourceForFrame):
+ * WebProcess/WebPage/WebInspectorUI.h:
+
</ins><span class="cx"> 2015-05-13 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> View scale changes are temporarily lost after restoring a page from the page cache
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -215,7 +215,7 @@
</span><span class="cx"> evaluateCommandOnLoad(ASCIILiteral("showResources"));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebInspectorUI::showMainResourceForFrame(String frameIdentifier)
</del><ins>+void WebInspectorUI::showMainResourceForFrame(const String& frameIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> evaluateCommandOnLoad(ASCIILiteral("showMainResourceForFrame"), frameIdentifier);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (184290 => 184291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-05-13 18:11:38 UTC (rev 184290)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-05-13 18:51:44 UTC (rev 184291)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> void showConsole();
</span><span class="cx"> void showResources();
</span><span class="cx">
</span><del>- void showMainResourceForFrame(String frameIdentifier);
</del><ins>+ void showMainResourceForFrame(const String& frameIdentifier);
</ins><span class="cx">
</span><span class="cx"> void startPageProfiling();
</span><span class="cx"> void stopPageProfiling();
</span></span></pre>
</div>
</div>
</body>
</html>