<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184210] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184210">184210</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-05-12 12:29:42 -0700 (Tue, 12 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[WK2] Log using diagnostic logging how far back in history we navigate
https://bugs.webkit.org/show_bug.cgi?id=144919
<rdar://problem/20920043>
Reviewed by Gavin Barraclough.
Source/WebCore:
Add diagnostic logging keys for logging back history navigation delta.
* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::deltaKey):
(WebCore::DiagnosticLoggingKeys::backNavigationKey):
* page/DiagnosticLoggingKeys.h:
Source/WebKit2:
Log using diagnostic logging how far back in history we navigate.
When a back navigation or a backward indexed navigation occurs, we
log the delta: (HistoryListSize - 1) - NewHistoryItemIndex.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::goToItem):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageDiagnosticLoggingKeyscpp">trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDiagnosticLoggingKeysh">trunk/Source/WebCore/page/DiagnosticLoggingKeys.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebBackForwardListcpp">trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184209 => 184210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-12 19:23:51 UTC (rev 184209)
+++ trunk/Source/WebCore/ChangeLog 2015-05-12 19:29:42 UTC (rev 184210)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-05-12 Chris Dumez <cdumez@apple.com>
+
+ [WK2] Log using diagnostic logging how far back in history we navigate
+ https://bugs.webkit.org/show_bug.cgi?id=144919
+ <rdar://problem/20920043>
+
+ Reviewed by Gavin Barraclough.
+
+ Add diagnostic logging keys for logging back history navigation delta.
+
+ * page/DiagnosticLoggingKeys.cpp:
+ (WebCore::DiagnosticLoggingKeys::deltaKey):
+ (WebCore::DiagnosticLoggingKeys::backNavigationKey):
+ * page/DiagnosticLoggingKeys.h:
+
</ins><span class="cx"> 2015-05-12 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Avoid CSSPrimitiveValue allocation when parsing sizes
</span></span></pre></div>
<a id="trunkSourceWebCorepageDiagnosticLoggingKeyscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp (184209 => 184210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-05-12 19:23:51 UTC (rev 184209)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-05-12 19:29:42 UTC (rev 184210)
</span><span class="lines">@@ -263,6 +263,11 @@
</span><span class="cx"> return ASCIILiteral("cannotSuspendActiveDOMObjects");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+String DiagnosticLoggingKeys::deltaKey()
+{
+ return ASCIILiteral("delta");
+}
+
</ins><span class="cx"> String DiagnosticLoggingKeys::applicationCacheKey()
</span><span class="cx"> {
</span><span class="cx"> return ASCIILiteral("applicationCache");
</span><span class="lines">@@ -273,6 +278,11 @@
</span><span class="cx"> return ASCIILiteral("audio");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+String DiagnosticLoggingKeys::backNavigationKey()
+{
+ return ASCIILiteral("backNavigation");
+}
+
</ins><span class="cx"> String DiagnosticLoggingKeys::cacheControlNoStoreKey()
</span><span class="cx"> {
</span><span class="cx"> return ASCIILiteral("cacheControlNoStore");
</span></span></pre></div>
<a id="trunkSourceWebCorepageDiagnosticLoggingKeysh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.h (184209 => 184210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-05-12 19:23:51 UTC (rev 184209)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-05-12 19:29:42 UTC (rev 184210)
</span><span class="lines">@@ -34,9 +34,11 @@
</span><span class="cx"> public:
</span><span class="cx"> static String applicationCacheKey();
</span><span class="cx"> static String audioKey();
</span><ins>+ WEBCORE_EXPORT static String backNavigationKey();
</ins><span class="cx"> WEBCORE_EXPORT static String cacheControlNoStoreKey();
</span><span class="cx"> static String cachedResourceRevalidationKey();
</span><span class="cx"> static String cannotSuspendActiveDOMObjectsKey();
</span><ins>+ WEBCORE_EXPORT static String deltaKey();
</ins><span class="cx"> static String deniedByClientKey();
</span><span class="cx"> static String deviceMotionKey();
</span><span class="cx"> static String deviceOrientationKey();
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (184209 => 184210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-05-12 19:23:51 UTC (rev 184209)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-12 19:29:42 UTC (rev 184210)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-05-12 Chris Dumez <cdumez@apple.com>
+
+ [WK2] Log using diagnostic logging how far back in history we navigate
+ https://bugs.webkit.org/show_bug.cgi?id=144919
+ <rdar://problem/20920043>
+
+ Reviewed by Gavin Barraclough.
+
+ Log using diagnostic logging how far back in history we navigate.
+ When a back navigation or a backward indexed navigation occurs, we
+ log the delta: (HistoryListSize - 1) - NewHistoryItemIndex.
+
+ * UIProcess/WebBackForwardList.cpp:
+ (WebKit::WebBackForwardList::goToItem):
+
</ins><span class="cx"> 2015-05-11 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> ChildProcess should take an os_activity
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebBackForwardListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp (184209 => 184210)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-05-12 19:23:51 UTC (rev 184209)
+++ trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-05-12 19:29:42 UTC (rev 184210)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "APIArray.h"
</span><span class="cx"> #include "SessionState.h"
</span><span class="cx"> #include "WebPageProxy.h"
</span><ins>+#include <WebCore/DiagnosticLoggingKeys.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><span class="lines">@@ -175,6 +176,12 @@
</span><span class="cx"> if (targetIndex == notFound)
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ if (targetIndex < m_currentIndex) {
+ unsigned delta = m_entries.size() - targetIndex - 1;
+ String deltaValue = delta > 10 ? ASCIILiteral("over10") : String::number(delta);
+ m_page->logDiagnosticMessageWithValue(WebCore::DiagnosticLoggingKeys::backNavigationKey(), WebCore::DiagnosticLoggingKeys::deltaKey(), deltaValue, false /* shouldSample */);
+ }
+
</ins><span class="cx"> // If we're going to an item different from the current item, ask the client if the current
</span><span class="cx"> // item should remain in the list.
</span><span class="cx"> WebBackForwardListItem* currentItem = m_entries[m_currentIndex].get();
</span></span></pre>
</div>
</div>
</body>
</html>