<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184082] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184082">184082</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-11 05:05:49 -0700 (Mon, 11 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/182868">r182868</a> - Math.imul has wrong length in Safari 8.0.4
https://bugs.webkit.org/show_bug.cgi?id=143658
Patch by Jordan Harband <ljharb@gmail.com> on 2015-04-15
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Correcting function length from 1, to 2, to match spec
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-math.imul
* runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
LayoutTests:
* js/script-tests/math.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsjsmathexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/js/math-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsjsscripttestsmathjs">releases/WebKitGTK/webkit-2.8/LayoutTests/js/script-tests/math.js</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceJavaScriptCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceJavaScriptCoreruntimeMathObjectcpp">releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/runtime/MathObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (184081 => 184082)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-05-11 12:01:21 UTC (rev 184081)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-05-11 12:05:49 UTC (rev 184082)
</span><span class="lines">@@ -1,5 +1,14 @@
</span><span class="cx"> 2015-04-15 Jordan Harband <ljharb@gmail.com>
</span><span class="cx">
</span><ins>+ Math.imul has wrong length in Safari 8.0.4
+ https://bugs.webkit.org/show_bug.cgi?id=143658
+
+ Reviewed by Benjamin Poulain.
+
+ * js/script-tests/math.js:
+
+2015-04-15 Jordan Harband <ljharb@gmail.com>
+
</ins><span class="cx"> Number.parseInt in nightly r182673 has wrong length
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=143657
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsjsmathexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/js/math-expected.txt (184081 => 184082)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/js/math-expected.txt 2015-05-11 12:01:21 UTC (rev 184081)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/js/math-expected.txt 2015-05-11 12:05:49 UTC (rev 184082)
</span><span class="lines">@@ -102,6 +102,7 @@
</span><span class="cx"> PASS Math.hypot({valueOf:function(){throw "error1"}}, {valueOf:function(){sideEffect = 1}}) threw exception error1.
</span><span class="cx"> PASS sideEffect is 0
</span><span class="cx"> PASS Math.hypot(3, 4, 'foo') is NaN
</span><ins>+PASS Math.imul.length is 2
</ins><span class="cx"> PASS Math.log(NaN) is NaN
</span><span class="cx"> PASS Math.log(0) is -Infinity
</span><span class="cx"> PASS Math.log(-0) is -Infinity
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsjsscripttestsmathjs"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/js/script-tests/math.js (184081 => 184082)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/js/script-tests/math.js 2015-05-11 12:01:21 UTC (rev 184081)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/js/script-tests/math.js 2015-05-11 12:05:49 UTC (rev 184082)
</span><span class="lines">@@ -145,6 +145,8 @@
</span><span class="cx"> shouldBe('sideEffect', '0');
</span><span class="cx"> shouldBe("Math.hypot(3, 4, 'foo')", "NaN");
</span><span class="cx">
</span><ins>+shouldBe("Math.imul.length", "2");
+
</ins><span class="cx"> shouldBe("Math.log(NaN)", "NaN");
</span><span class="cx"> shouldBe("Math.log(0)", "-Infinity");
</span><span class="cx"> shouldBe("Math.log(-0)", "-Infinity");
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog (184081 => 184082)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog 2015-05-11 12:01:21 UTC (rev 184081)
+++ releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog 2015-05-11 12:05:49 UTC (rev 184082)
</span><span class="lines">@@ -1,11 +1,24 @@
</span><span class="cx"> 2015-04-15 Jordan Harband <ljharb@gmail.com>
</span><span class="cx">
</span><ins>+ Math.imul has wrong length in Safari 8.0.4
+ https://bugs.webkit.org/show_bug.cgi?id=143658
+
+ Reviewed by Benjamin Poulain.
+
+ Correcting function length from 1, to 2, to match spec
+ https://people.mozilla.org/~jorendorff/es6-draft.html#sec-math.imul
+
+ * runtime/MathObject.cpp:
+ (JSC::MathObject::finishCreation):
+
+2015-04-15 Jordan Harband <ljharb@gmail.com>
+
</ins><span class="cx"> Number.parseInt in nightly r182673 has wrong length
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=143657
</span><span class="cx">
</span><span class="cx"> Reviewed by Benjamin Poulain.
</span><span class="cx">
</span><del>- Correcting funciton length from 1, to 2, to match spec
</del><ins>+ Correcting function length from 1, to 2, to match spec
</ins><span class="cx"> https://people.mozilla.org/~jorendorff/es6-draft.html#sec-number.parseint
</span><span class="cx">
</span><span class="cx"> * runtime/NumberConstructor.cpp:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceJavaScriptCoreruntimeMathObjectcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/runtime/MathObject.cpp (184081 => 184082)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/runtime/MathObject.cpp 2015-05-11 12:01:21 UTC (rev 184081)
+++ releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/runtime/MathObject.cpp 2015-05-11 12:05:49 UTC (rev 184082)
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "tan"), 1, mathProtoFuncTan, NoIntrinsic, DontEnum | Function);
</span><span class="cx"> putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "tanh"), 1, mathProtoFuncTanh, NoIntrinsic, DontEnum | Function);
</span><span class="cx"> putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "trunc"), 1, mathProtoFuncTrunc, NoIntrinsic, DontEnum | Function);
</span><del>- putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "imul"), 1, mathProtoFuncIMul, IMulIntrinsic, DontEnum | Function);
</del><ins>+ putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "imul"), 2, mathProtoFuncIMul, IMulIntrinsic, DontEnum | Function);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // ------------------------------ Functions --------------------------------
</span></span></pre>
</div>
</div>
</body>
</html>