<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184147] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184147">184147</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-11 19:06:54 -0700 (Mon, 11 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Purge PassRefPtr in WebCore/rendering
https://bugs.webkit.org/show_bug.cgi?id=144872
Patch by Gyuyoung Kim <gyuyoung.kim@webkit.org> on 2015-05-11
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref in WebCore/rendering.
No new tests, no behavior changes.
* rendering/HitTestingTransformState.h:
(WebCore::HitTestingTransformState::create):
* rendering/RenderLayer.cpp:
(WebCore::ClipRects::create):
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::create):
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeGtk.h:
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeIOS::create):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeMac::create):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::create):
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeSafari.h:
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::create):
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeWin.h:
* rendering/TextAutoSizing.h:
(WebCore::TextAutoSizingValue::create):
* rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createShapeValue):
(WebCore::ShapeValue::createBoxShapeValue):
(WebCore::ShapeValue::createImageValue):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleCachedImageSet.h:
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StylePendingImage.h:
* rendering/style/StyleReflection.h:
(WebCore::StyleReflection::create):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingHitTestingTransformStateh">trunk/Source/WebCore/rendering/HitTestingTransformState.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeGtkcpp">trunk/Source/WebCore/rendering/RenderThemeGtk.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeGtkh">trunk/Source/WebCore/rendering/RenderThemeGtk.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeIOSh">trunk/Source/WebCore/rendering/RenderThemeIOS.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeIOSmm">trunk/Source/WebCore/rendering/RenderThemeIOS.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMach">trunk/Source/WebCore/rendering/RenderThemeMac.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeSafaricpp">trunk/Source/WebCore/rendering/RenderThemeSafari.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeSafarih">trunk/Source/WebCore/rendering/RenderThemeSafari.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeWincpp">trunk/Source/WebCore/rendering/RenderThemeWin.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeWinh">trunk/Source/WebCore/rendering/RenderThemeWin.h</a></li>
<li><a href="#trunkSourceWebCorerenderingTextAutoSizingh">trunk/Source/WebCore/rendering/TextAutoSizing.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleShapeValueh">trunk/Source/WebCore/rendering/style/ShapeValue.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleCachedImageh">trunk/Source/WebCore/rendering/style/StyleCachedImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleCachedImageSeth">trunk/Source/WebCore/rendering/style/StyleCachedImageSet.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleGeneratedImageh">trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStylePendingImageh">trunk/Source/WebCore/rendering/style/StylePendingImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleReflectionh">trunk/Source/WebCore/rendering/style/StyleReflection.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/ChangeLog 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -1,3 +1,51 @@
</span><ins>+2015-05-11 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Purge PassRefPtr in WebCore/rendering
+ https://bugs.webkit.org/show_bug.cgi?id=144872
+
+ Reviewed by Darin Adler.
+
+ As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref in WebCore/rendering.
+
+ No new tests, no behavior changes.
+
+ * rendering/HitTestingTransformState.h:
+ (WebCore::HitTestingTransformState::create):
+ * rendering/RenderLayer.cpp:
+ (WebCore::ClipRects::create):
+ * rendering/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeGtk.h:
+ * rendering/RenderThemeIOS.h:
+ * rendering/RenderThemeIOS.mm:
+ (WebCore::RenderTheme::themeForPage):
+ (WebCore::RenderThemeIOS::create):
+ * rendering/RenderThemeMac.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderTheme::themeForPage):
+ (WebCore::RenderThemeMac::create):
+ * rendering/RenderThemeSafari.cpp:
+ (WebCore::RenderThemeSafari::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeSafari.h:
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeWin.h:
+ * rendering/TextAutoSizing.h:
+ (WebCore::TextAutoSizingValue::create):
+ * rendering/style/ShapeValue.h:
+ (WebCore::ShapeValue::createShapeValue):
+ (WebCore::ShapeValue::createBoxShapeValue):
+ (WebCore::ShapeValue::createImageValue):
+ * rendering/style/StyleCachedImage.h:
+ * rendering/style/StyleCachedImageSet.h:
+ * rendering/style/StyleGeneratedImage.h:
+ * rendering/style/StylePendingImage.h:
+ * rendering/style/StyleReflection.h:
+ (WebCore::StyleReflection::create):
+
</ins><span class="cx"> 2015-05-11 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] Update device picker icon when video tracks change
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingHitTestingTransformStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/HitTestingTransformState.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/HitTestingTransformState.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/HitTestingTransformState.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> #include "FloatQuad.h"
</span><span class="cx"> #include "IntSize.h"
</span><span class="cx"> #include "TransformationMatrix.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><ins>+#include <wtf/Ref.h>
</ins><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -42,14 +42,14 @@
</span><span class="cx"> // differently than move()) so care has to be taken when this is done.
</span><span class="cx"> class HitTestingTransformState : public RefCounted<HitTestingTransformState> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<HitTestingTransformState> create(const FloatPoint& p, const FloatQuad& quad, const FloatQuad& area)
</del><ins>+ static Ref<HitTestingTransformState> create(const FloatPoint& p, const FloatQuad& quad, const FloatQuad& area)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HitTestingTransformState(p, quad, area));
</del><ins>+ return adoptRef(*new HitTestingTransformState(p, quad, area));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<HitTestingTransformState> create(const HitTestingTransformState& other)
</del><ins>+ static Ref<HitTestingTransformState> create(const HitTestingTransformState& other)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HitTestingTransformState(other));
</del><ins>+ return adoptRef(*new HitTestingTransformState(other));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> enum TransformAccumulation { FlattenTransform, AccumulateTransform };
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -137,14 +137,14 @@
</span><span class="cx"> class ClipRects {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ClipRects> create()
</del><ins>+ static Ref<ClipRects> create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new ClipRects);
</del><ins>+ return adoptRef(*new ClipRects);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<ClipRects> create(const ClipRects& other)
</del><ins>+ static Ref<ClipRects> create(const ClipRects& other)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ClipRects(other));
</del><ins>+ return adoptRef(*new ClipRects(other));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ClipRects() = default;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.cpp (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -60,15 +60,15 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeGtk::create()
</del><ins>+Ref<RenderTheme> RenderThemeGtk::create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeGtk());
</del><ins>+ return adoptRef(*new RenderThemeGtk());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</span><span class="cx"> {
</span><del>- static RenderTheme* rt = RenderThemeGtk::create().leakRef();
- return rt;
</del><ins>+ static RenderTheme& rt = RenderThemeGtk::create().leakRef();
+ return &rt;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static double getScreenDPI()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderThemeGtk final : public RenderTheme {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create();
</del><ins>+ static Ref<RenderTheme> create();
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(DATALIST_ELEMENT)
</span><span class="cx"> // Returns size of one slider tick mark for a horizontal track.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeIOS.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderThemeIOS final : public RenderTheme {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create();
</del><ins>+ static Ref<RenderTheme> create();
</ins><span class="cx">
</span><span class="cx"> virtual int popupInternalPaddingRight(RenderStyle&) const override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -291,13 +291,13 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</span><span class="cx"> {
</span><del>- static RenderTheme* renderTheme = RenderThemeIOS::create().leakRef();
- return renderTheme;
</del><ins>+ static RenderTheme& renderTheme = RenderThemeIOS::create().leakRef();
+ return &renderTheme;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeIOS::create()
</del><ins>+Ref<RenderTheme> RenderThemeIOS::create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeIOS);
</del><ins>+ return adoptRef(*new RenderThemeIOS);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static String& _contentSizeCategory()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMach"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderThemeMac final : public RenderTheme {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create();
</del><ins>+ static Ref<RenderTheme> create();
</ins><span class="cx">
</span><span class="cx"> // A method asking if the control changes its tint when the window has focus or not.
</span><span class="cx"> virtual bool controlSupportsTints(const RenderObject&) const override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -201,13 +201,13 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</span><span class="cx"> {
</span><del>- static RenderTheme* rt = RenderThemeMac::create().leakRef();
- return rt;
</del><ins>+ static RenderTheme& rt = RenderThemeMac::create().leakRef();
+ return &rt;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeMac::create()
</del><ins>+Ref<RenderTheme> RenderThemeMac::create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeMac);
</del><ins>+ return adoptRef(*new RenderThemeMac);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderThemeMac::RenderThemeMac()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeSafaricpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeSafari.cpp (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeSafari.cpp 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeSafari.cpp 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -73,24 +73,24 @@
</span><span class="cx"> leftPadding
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeSafari::create()
</del><ins>+Ref<RenderTheme> RenderThemeSafari::create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeSafari);
</del><ins>+ return adoptRef(*new RenderThemeSafari);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
</span><span class="cx"> {
</span><del>- static RenderTheme* safariTheme = RenderThemeSafari::create().leakRef();
- static RenderTheme* windowsTheme = RenderThemeWin::create().leakRef();
</del><ins>+ static RenderTheme& safariTheme = RenderThemeSafari::create().leakRef();
+ static RenderTheme& windowsTheme = RenderThemeWin::create().leakRef();
</ins><span class="cx">
</span><span class="cx"> // FIXME: This is called before Settings has been initialized by WebKit, so will return a
</span><span class="cx"> // potentially wrong answer the very first time it's called (see
</span><span class="cx"> // <https://bugs.webkit.org/show_bug.cgi?id=26493>).
</span><span class="cx"> if (Settings::shouldPaintNativeControls()) {
</span><span class="cx"> RenderTheme::setCustomFocusRingColor(safariTheme->platformFocusRingColor());
</span><del>- return windowsTheme; // keep the reference of one.
</del><ins>+ return &windowsTheme;
</ins><span class="cx"> }
</span><del>- return safariTheme; // keep the reference of one.
</del><ins>+ return &safariTheme;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifdef DEBUG_ALL
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeSafarih"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeSafari.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeSafari.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeSafari.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderThemeSafari : public RenderTheme {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create();
</del><ins>+ static Ref<RenderTheme> create();
</ins><span class="cx">
</span><span class="cx"> // A method to obtain the baseline position for a "leaf" control. This will only be used if a baseline
</span><span class="cx"> // position cannot be determined by examining child content. Checkboxes and radio buttons are examples of
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -182,15 +182,15 @@
</span><span class="cx"> gWebKitIsBeingUnloaded = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeWin::create()
</del><ins>+Ref<RenderTheme> RenderThemeWin::create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeWin);
</del><ins>+ return adoptRef(*new RenderThemeWin);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
</span><span class="cx"> {
</span><del>- static RenderTheme* winTheme = RenderThemeWin::create().leakRef();
- return winTheme;
</del><ins>+ static RenderTheme& winTheme = RenderThemeWin::create().leakRef();
+ return &winTheme;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderThemeWin::RenderThemeWin()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeWinh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeWin.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderThemeWin final: public RenderTheme {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create();
</del><ins>+ static Ref<RenderTheme> create();
</ins><span class="cx">
</span><span class="cx"> virtual String extraDefaultStyleSheet() override;
</span><span class="cx"> virtual String extraQuirksStyleSheet() override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingTextAutoSizingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/TextAutoSizing.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/TextAutoSizing.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/TextAutoSizing.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -73,9 +73,9 @@
</span><span class="cx">
</span><span class="cx"> class TextAutoSizingValue : public RefCounted<TextAutoSizingValue> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<TextAutoSizingValue> create()
</del><ins>+ static Ref<TextAutoSizingValue> create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new TextAutoSizingValue);
</del><ins>+ return adoptRef(*new TextAutoSizingValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void addNode(Node*, float size);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleShapeValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/ShapeValue.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/ShapeValue.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/ShapeValue.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -46,19 +46,19 @@
</span><span class="cx"> Image
</span><span class="cx"> };
</span><span class="cx">
</span><del>- static PassRefPtr<ShapeValue> createShapeValue(PassRefPtr<BasicShape> shape, CSSBoxType cssBox)
</del><ins>+ static Ref<ShapeValue> createShapeValue(PassRefPtr<BasicShape> shape, CSSBoxType cssBox)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ShapeValue(shape, cssBox));
</del><ins>+ return adoptRef(*new ShapeValue(shape, cssBox));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<ShapeValue> createBoxShapeValue(CSSBoxType boxShape)
</del><ins>+ static Ref<ShapeValue> createBoxShapeValue(CSSBoxType boxShape)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ShapeValue(boxShape));
</del><ins>+ return adoptRef(*new ShapeValue(boxShape));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<ShapeValue> createImageValue(PassRefPtr<StyleImage> image)
</del><ins>+ static Ref<ShapeValue> createImageValue(PassRefPtr<StyleImage> image)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ShapeValue(image));
</del><ins>+ return adoptRef(*new ShapeValue(image));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Type type() const { return m_type; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleCachedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleCachedImage.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleCachedImage.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/StyleCachedImage.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> class StyleCachedImage final : public StyleImage, private CachedImageClient {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<StyleCachedImage> create(CachedImage* image) { return adoptRef(new StyleCachedImage(image)); }
</del><ins>+ static Ref<StyleCachedImage> create(CachedImage* image) { return adoptRef(*new StyleCachedImage(image)); }
</ins><span class="cx"> virtual ~StyleCachedImage();
</span><span class="cx">
</span><span class="cx"> virtual CachedImage* cachedImage() const override { return m_image.get(); }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleCachedImageSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleCachedImageSet.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleCachedImageSet.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/StyleCachedImageSet.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -43,9 +43,9 @@
</span><span class="cx"> class StyleCachedImageSet final : public StyleImage, private CachedImageClient {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- static PassRefPtr<StyleCachedImageSet> create(CachedImage* image, float imageScaleFactor, CSSImageSetValue* value)
</del><ins>+ static Ref<StyleCachedImageSet> create(CachedImage* image, float imageScaleFactor, CSSImageSetValue* value)
</ins><span class="cx"> {
</span><del>- return adoptRef(new StyleCachedImageSet(image, imageScaleFactor, value));
</del><ins>+ return adoptRef(*new StyleCachedImageSet(image, imageScaleFactor, value));
</ins><span class="cx"> }
</span><span class="cx"> virtual ~StyleCachedImageSet();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleGeneratedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -33,9 +33,9 @@
</span><span class="cx">
</span><span class="cx"> class StyleGeneratedImage final : public StyleImage {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<StyleGeneratedImage> create(Ref<CSSImageGeneratorValue>&& value)
</del><ins>+ static Ref<StyleGeneratedImage> create(Ref<CSSImageGeneratorValue>&& value)
</ins><span class="cx"> {
</span><del>- return adoptRef(new StyleGeneratedImage(WTF::move(value)));
</del><ins>+ return adoptRef(*new StyleGeneratedImage(WTF::move(value)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CSSImageGeneratorValue& imageValue() { return m_imageGeneratorValue; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStylePendingImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StylePendingImage.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StylePendingImage.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/StylePendingImage.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> class StylePendingImage final : public StyleImage {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<StylePendingImage> create(CSSValue* value) { return adoptRef(new StylePendingImage(value)); }
</del><ins>+ static Ref<StylePendingImage> create(CSSValue* value) { return adoptRef(*new StylePendingImage(value)); }
</ins><span class="cx">
</span><span class="cx"> CSSImageValue* cssImageValue() const { return is<CSSImageValue>(m_value) ? downcast<CSSImageValue>(m_value) : nullptr; }
</span><span class="cx"> CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value && m_value->isImageGeneratorValue() ? static_cast<CSSImageGeneratorValue*>(m_value) : nullptr; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleReflectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleReflection.h (184146 => 184147)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleReflection.h 2015-05-12 01:54:51 UTC (rev 184146)
+++ trunk/Source/WebCore/rendering/style/StyleReflection.h 2015-05-12 02:06:54 UTC (rev 184147)
</span><span class="lines">@@ -34,9 +34,9 @@
</span><span class="cx">
</span><span class="cx"> class StyleReflection : public RefCounted<StyleReflection> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<StyleReflection> create()
</del><ins>+ static Ref<StyleReflection> create()
</ins><span class="cx"> {
</span><del>- return adoptRef(new StyleReflection);
</del><ins>+ return adoptRef(*new StyleReflection);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool operator==(const StyleReflection& o) const
</span></span></pre>
</div>
</div>
</body>
</html>