<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184069] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184069">184069</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2015-05-11 01:40:15 -0700 (Mon, 11 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add missing vtable override specifiers under Source/WebCore/loader, Source/WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=144793
Reviewed by Darin Adler.
Update virtual method overrides under Source/WebCore/loader
and Source/WebCore/dom which are missing the override specifier.
* loader/DocumentThreadableLoader.h:
(WebCore::DocumentThreadableLoader::refThreadableLoader):
(WebCore::DocumentThreadableLoader::derefThreadableLoader):
* loader/cache/CachedRawResource.h:
* xml/parser/XMLDocumentParser.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderDocumentThreadableLoaderh">trunk/Source/WebCore/loader/DocumentThreadableLoader.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedRawResourceh">trunk/Source/WebCore/loader/cache/CachedRawResource.h</a></li>
<li><a href="#trunkSourceWebCorexmlparserXMLDocumentParserh">trunk/Source/WebCore/xml/parser/XMLDocumentParser.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184068 => 184069)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-11 08:39:19 UTC (rev 184068)
+++ trunk/Source/WebCore/ChangeLog 2015-05-11 08:40:15 UTC (rev 184069)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-05-11 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><ins>+ Add missing vtable override specifiers under Source/WebCore/loader, Source/WebCore/xml
+ https://bugs.webkit.org/show_bug.cgi?id=144793
+
+ Reviewed by Darin Adler.
+
+ Update virtual method overrides under Source/WebCore/loader
+ and Source/WebCore/dom which are missing the override specifier.
+
+ * loader/DocumentThreadableLoader.h:
+ (WebCore::DocumentThreadableLoader::refThreadableLoader):
+ (WebCore::DocumentThreadableLoader::derefThreadableLoader):
+ * loader/cache/CachedRawResource.h:
+ * xml/parser/XMLDocumentParser.h:
+
+2015-05-11 Zan Dobersek <zdobersek@igalia.com>
+
</ins><span class="cx"> Add missing vtable override specifiers under Source/WebCore/accessibility, Source/WebCore/dom
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=144792
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderDocumentThreadableLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.h (184068 => 184069)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2015-05-11 08:39:19 UTC (rev 184068)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2015-05-11 08:40:15 UTC (rev 184069)
</span><span class="lines">@@ -56,15 +56,15 @@
</span><span class="cx"> static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient&, const ResourceRequest&, const ThreadableLoaderOptions&);
</span><span class="cx"> virtual ~DocumentThreadableLoader();
</span><span class="cx">
</span><del>- virtual void cancel();
</del><ins>+ virtual void cancel() override;
</ins><span class="cx"> virtual void setDefersLoading(bool);
</span><span class="cx">
</span><span class="cx"> using RefCounted<DocumentThreadableLoader>::ref;
</span><span class="cx"> using RefCounted<DocumentThreadableLoader>::deref;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void refThreadableLoader() { ref(); }
- virtual void derefThreadableLoader() { deref(); }
</del><ins>+ virtual void refThreadableLoader() override { ref(); }
+ virtual void derefThreadableLoader() override { deref(); }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> enum BlockingBehavior {
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedRawResourceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedRawResource.h (184068 => 184069)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedRawResource.h 2015-05-11 08:39:19 UTC (rev 184068)
+++ trunk/Source/WebCore/loader/cache/CachedRawResource.h 2015-05-11 08:40:15 UTC (rev 184069)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> void notifyClientsDataWasReceived(const char* data, unsigned length);
</span><span class="cx">
</span><span class="cx"> #if USE(SOUP)
</span><del>- virtual char* getOrCreateReadBuffer(size_t requestedSize, size_t& actualSize);
</del><ins>+ virtual char* getOrCreateReadBuffer(size_t requestedSize, size_t& actualSize) override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> unsigned long m_identifier;
</span></span></pre></div>
<a id="trunkSourceWebCorexmlparserXMLDocumentParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.h (184068 => 184069)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2015-05-11 08:39:19 UTC (rev 184068)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2015-05-11 08:40:15 UTC (rev 184069)
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> static bool parseDocumentFragment(const String&, DocumentFragment&, Element* parent = 0, ParserContentPolicy = AllowScriptingContent);
</span><span class="cx">
</span><span class="cx"> // Used by the XMLHttpRequest to check if the responseXML was well formed.
</span><del>- virtual bool wellFormed() const { return !m_sawError; }
</del><ins>+ virtual bool wellFormed() const override { return !m_sawError; }
</ins><span class="cx">
</span><span class="cx"> static bool supportsXMLVersion(const String&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>