<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184060] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184060">184060</a></dd>
<dt>Author</dt> <dd>mrobinson@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-10 17:57:01 -0700 (Sun, 10 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] fast/events/page-visibility-transition-test.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=114789
Reviewed by Darin Adler.
Tools:
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.
LayoutTests:
* platform/gtk/TestExpectations: Unskip failing tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnergtkTestControllerGtkcpp">trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (184059 => 184060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/LayoutTests/ChangeLog 2015-05-11 00:57:01 UTC (rev 184060)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-05-10 Martin Robinson <mrobinson@igalia.com>
+
+ [GTK] fast/events/page-visibility-transition-test.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=114789
+
+ Reviewed by Darin Adler.
+
+ * platform/gtk/TestExpectations: Unskip failing tests.
+
</ins><span class="cx"> 2015-05-10 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Don't expose elements as data tables just because they use display: table
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (184059 => 184060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-11 00:57:01 UTC (rev 184060)
</span><span class="lines">@@ -2270,12 +2270,6 @@
</span><span class="cx"> webkit.org/b/144765 fast/events/touch/touch-slider-no-js-touch-listener.html [ Failure ]
</span><span class="cx"> webkit.org/b/144765 fast/events/touch/touch-inside-iframe.html [ Timeout ]
</span><span class="cx">
</span><del>-# Need support for adjusting page visibility in the test harness.
-webkit.org/b/114789 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-propagation-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-transition-test.html [ Timeout ]
-
</del><span class="cx"> webkit.org/b/144763 fast/events/scroll-in-scaled-page-with-overflow-hidden.html
</span><span class="cx">
</span><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (184059 => 184060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/Tools/ChangeLog 2015-05-11 00:57:01 UTC (rev 184060)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-05-10 Martin Robinson <mrobinson@igalia.com>
+
+ [GTK] fast/events/page-visibility-transition-test.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=114789
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/gtk/TestControllerGtk.cpp:
+ (WTR::TestController::setHidden): Map and unmap the WebView when the harness
+ requests visibility changes.
+
</ins><span class="cx"> 2015-05-10 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnergtkTestControllerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (184059 => 184060)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2015-05-11 00:57:01 UTC (rev 184060)
</span><span class="lines">@@ -95,9 +95,14 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TestController::setHidden(bool)
</del><ins>+void TestController::setHidden(bool hidden)
</ins><span class="cx"> {
</span><del>- // FIXME: Need to implement this to test visibilityState.
</del><ins>+ if (!m_mainWebView)
+ return;
+ if (hidden)
+ gtk_widget_unmap(GTK_WIDGET(m_mainWebView->platformView()));
+ else
+ gtk_widget_map(GTK_WIDGET(m_mainWebView->platformView()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestController::runModal(PlatformWebView*)
</span></span></pre>
</div>
</div>
</body>
</html>