<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[184046] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/184046">184046</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2015-05-10 07:52:50 -0700 (Sun, 10 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Don't expose elements as data tables just because they use display: table
https://bugs.webkit.org/show_bug.cgi?id=144804
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Elements will create RenderTable objects if they have display:table. We shouldn't assume these are accessibility tables.
Test: accessibility/css-table-ignored.html
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
LayoutTests:
* accessibility/css-table-ignored-expected.txt: Added.
* accessibility/css-table-ignored.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTablecpp">trunk/Source/WebCore/accessibility/AccessibilityTable.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilitycsstableignoredexpectedtxt">trunk/LayoutTests/accessibility/css-table-ignored-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitycsstableignoredhtml">trunk/LayoutTests/accessibility/css-table-ignored.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (184045 => 184046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-10 12:23:07 UTC (rev 184045)
+++ trunk/LayoutTests/ChangeLog 2015-05-10 14:52:50 UTC (rev 184046)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-05-10 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Don't expose elements as data tables just because they use display: table
+ https://bugs.webkit.org/show_bug.cgi?id=144804
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/css-table-ignored-expected.txt: Added.
+ * accessibility/css-table-ignored.html: Added.
+
</ins><span class="cx"> 2015-05-09 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Introduce ParentNode.idl / NonDocumentTypeChildNode.idl
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitycsstableignoredexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/css-table-ignored-expected.txt (0 => 184046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/css-table-ignored-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/css-table-ignored-expected.txt 2015-05-10 14:52:50 UTC (rev 184046)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+This tests that an element use display:table will not be exposed as an accessible table.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS !table || !table.isValid is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilitycsstableignoredhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/css-table-ignored.html (0 => 184046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/css-table-ignored.html (rev 0)
+++ trunk/LayoutTests/accessibility/css-table-ignored.html 2015-05-10 14:52:50 UTC (rev 184046)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+<style>
+.layout-table { display:table; }
+.layout-table .second-cell, .layout-table .third-cell, .layout-table .third-cell-no-border { display: table-cell; }
+.layout-table .third-cell { border-left: 5px solid #f00; }
+</style>
+</head>
+
+<body id="body">
+
+<div id="content">
+<div class="layout-table" id="table">
+ <div class="first-cell a11y">Visually hidden div</div>
+ <div class="second-cell">Left div</div>
+ <div class="third-cell">Right div</div>
+</div>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+description("This tests that an element use display:table will not be exposed as an accessible table.");
+
+if (window.accessibilityController) {
+ var table = accessibilityController.accessibleElementById("table");
+ shouldBeTrue("!table || !table.isValid");
+ document.getElementById("content").style.visibility = "hidden";
+}
+
+</script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (184045 => 184046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-10 12:23:07 UTC (rev 184045)
+++ trunk/Source/WebCore/ChangeLog 2015-05-10 14:52:50 UTC (rev 184046)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-05-10 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Don't expose elements as data tables just because they use display: table
+ https://bugs.webkit.org/show_bug.cgi?id=144804
+
+ Reviewed by Mario Sanchez Prada.
+
+ Elements will create RenderTable objects if they have display:table. We shouldn't assume these are accessibility tables.
+
+ Test: accessibility/css-table-ignored.html
+
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::isDataTable):
+
</ins><span class="cx"> 2015-05-09 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Introduce ParentNode.idl / NonDocumentTypeChildNode.idl
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (184045 => 184046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-05-10 12:23:07 UTC (rev 184045)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-05-10 14:52:50 UTC (rev 184046)
</span><span class="lines">@@ -150,6 +150,10 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // The following checks should only apply if this is a real <table> element.
+ if (!hasTagName(tableTag))
+ return false;
+
</ins><span class="cx"> RenderTable& table = downcast<RenderTable>(*m_renderer);
</span><span class="cx"> // go through the cell's and check for tell-tale signs of "data" table status
</span><span class="cx"> // cells have borders, or use attributes like headers, abbr, scope or axis
</span></span></pre>
</div>
</div>
</body>
</html>