<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183995] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183995">183995</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-08 09:09:42 -0700 (Fri, 08 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] WTR doesn't correctly handle the Escape key
https://bugs.webkit.org/show_bug.cgi?id=144788
Reviewed by Martin Robinson.
Tools:
Correctly handle 0x001B character code in GTK+ event sender to be
recognized as Escape key, because gdk_unicode_to_keyval() doesn't
handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
to dismiss popup menus.
Fixes editing/selection/5354455-1.html.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::getGDKKeySymForKeyRef):
LayoutTests:
Unskip editing/selection/5354455-1.html.
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnergtkEventSenderProxyGtkcpp">trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183994 => 183995)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/LayoutTests/ChangeLog 2015-05-08 16:09:42 UTC (rev 183995)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] WTR doesn't correctly handle the Escape key
+ https://bugs.webkit.org/show_bug.cgi?id=144788
+
+ Reviewed by Martin Robinson.
+
+ Unskip editing/selection/5354455-1.html.
+
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2015-05-08 Hyungwook Lee <hyungwook.lee@navercorp.com>
</span><span class="cx">
</span><span class="cx"> [Win] Unskip passing test case after r183981
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (183994 => 183995)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-08 16:09:42 UTC (rev 183995)
</span><span class="lines">@@ -1443,7 +1443,6 @@
</span><span class="cx"> webkit.org/b/63706 editing/pasteboard/drag-list-item.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # WebKit2 needs testRunner.setEditingBehaviour and other issues.
</span><del>-webkit.org/b/40601 editing/selection/5354455-1.html [ Failure ]
</del><span class="cx"> Bug(GTK) editing/selection/extend-after-mouse-selection.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # WebKit2 needs textInputController.selectedRange
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (183994 => 183995)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/Tools/ChangeLog 2015-05-08 16:09:42 UTC (rev 183995)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] WTR doesn't correctly handle the Escape key
+ https://bugs.webkit.org/show_bug.cgi?id=144788
+
+ Reviewed by Martin Robinson.
+
+ Correctly handle 0x001B character code in GTK+ event sender to be
+ recognized as Escape key, because gdk_unicode_to_keyval() doesn't
+ handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
+ to dismiss popup menus.
+
+ Fixes editing/selection/5354455-1.html.
+
+ * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+ (WTR::getGDKKeySymForKeyRef):
+
+2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=144748
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnergtkEventSenderProxyGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (183994 => 183995)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2015-05-08 16:09:42 UTC (rev 183995)
</span><span class="lines">@@ -277,6 +277,8 @@
</span><span class="cx"> return GDK_KEY_Tab;
</span><span class="cx"> if (charCode == '\x8')
</span><span class="cx"> return GDK_KEY_BackSpace;
</span><ins>+ if (charCode == 0x001B)
+ return GDK_KEY_Escape;
</ins><span class="cx">
</span><span class="cx"> if (WTF::isASCIIUpper(charCode))
</span><span class="cx"> *modifiers |= GDK_SHIFT_MASK;
</span></span></pre>
</div>
</div>
</body>
</html>