<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183949] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183949">183949</a></dd>
<dt>Author</dt> <dd>mrobinson@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-07 14:45:30 -0700 (Thu, 07 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Followup fixes to <a href="http://trac.webkit.org/projects/webkit/changeset/183936">r183936</a>
I neglected to include a few review comments when I landed the patch.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::checkerState): Remove double semicolons.
(WebKit::updateStateForAllProcessPools): Use range-based-for loop here and
give the function a better name.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled): Use new function name
(WebKit::TextChecker::setGrammarCheckingEnabled):Use new function name
(WebKit::TextChecker::ignoreWord): Fix unused parameter warning.
(WebKit::updateStateForAllContexts): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessgtkTextCheckerGtkcpp">trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (183948 => 183949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-05-07 21:22:35 UTC (rev 183948)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 21:45:30 UTC (rev 183949)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-05-07 Martin Robinson <mrobinson@igalia.com>
+
+ Followup fixes to r183936
+
+ I neglected to include a few review comments when I landed the patch.
+
+ * UIProcess/gtk/TextCheckerGtk.cpp:
+ (WebKit::checkerState): Remove double semicolons.
+ (WebKit::updateStateForAllProcessPools): Use range-based-for loop here and
+ give the function a better name.
+ (WebKit::TextChecker::setContinuousSpellCheckingEnabled): Use new function name
+ (WebKit::TextChecker::setGrammarCheckingEnabled):Use new function name
+ (WebKit::TextChecker::ignoreWord): Fix unused parameter warning.
+ (WebKit::updateStateForAllContexts): Deleted.
+
</ins><span class="cx"> 2015-05-07 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Checks for DEVELOPMENT_BUILD are all wrong
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessgtkTextCheckerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp (183948 => 183949)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp 2015-05-07 21:22:35 UTC (rev 183948)
+++ trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp 2015-05-07 21:45:30 UTC (rev 183949)
</span><span class="lines">@@ -63,8 +63,8 @@
</span><span class="cx"> static TextCheckerState textCheckerState;
</span><span class="cx"> static std::once_flag onceFlag;
</span><span class="cx"> std::call_once(onceFlag, [] {
</span><del>- textCheckerState.isContinuousSpellCheckingEnabled = false;;
- textCheckerState.isGrammarCheckingEnabled = false;;
</del><ins>+ textCheckerState.isContinuousSpellCheckingEnabled = false;
+ textCheckerState.isGrammarCheckingEnabled = false;
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> return textCheckerState;
</span><span class="lines">@@ -75,11 +75,10 @@
</span><span class="cx"> return checkerState();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void updateStateForAllContexts()
</del><ins>+static void updateStateForAllProcessPools()
</ins><span class="cx"> {
</span><del>- const Vector<WebProcessPool*>& contexts = WebProcessPool::allProcessPools();
- for (size_t i = 0; i < contexts.size(); ++i)
- contexts[i]->textCheckerStateChanged();
</del><ins>+ for (const auto& processPool : WebProcessPool::allProcessPools())
+ processPool->textCheckerStateChanged();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool TextChecker::isContinuousSpellCheckingAllowed()
</span><span class="lines">@@ -92,7 +91,7 @@
</span><span class="cx"> if (checkerState().isContinuousSpellCheckingEnabled == isContinuousSpellCheckingEnabled)
</span><span class="cx"> return;
</span><span class="cx"> checkerState().isContinuousSpellCheckingEnabled = isContinuousSpellCheckingEnabled;
</span><del>- updateStateForAllContexts();
</del><ins>+ updateStateForAllProcessPools();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TextChecker::setGrammarCheckingEnabled(bool isGrammarCheckingEnabled)
</span><span class="lines">@@ -100,7 +99,7 @@
</span><span class="cx"> if (checkerState().isGrammarCheckingEnabled == isGrammarCheckingEnabled)
</span><span class="cx"> return;
</span><span class="cx"> checkerState().isGrammarCheckingEnabled = isGrammarCheckingEnabled;
</span><del>- updateStateForAllContexts();
</del><ins>+ updateStateForAllProcessPools();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TextChecker::continuousSpellCheckingEnabledStateChanged(bool enabled)
</span><span class="lines">@@ -160,7 +159,7 @@
</span><span class="cx"> enchantTextChecker().learnWord(word);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TextChecker::ignoreWord(int64_t spellDocumentTag, const String& word)
</del><ins>+void TextChecker::ignoreWord(int64_t /* spellDocumentTag */, const String& word)
</ins><span class="cx"> {
</span><span class="cx"> enchantTextChecker().ignoreWord(word);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>