<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183967] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183967">183967</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2015-05-07 17:59:01 -0700 (Thu, 07 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Consider implementing Document.scrollingElement
<rdar://problem/20845213>
https://bugs.webkit.org/show_bug.cgi?id=143609
Reviewed by Simon Fraser.
Source/WebCore:
Add the non-compliant implementation of Document.scrollingElement that the spec,
found at http://dev.w3.org/csswg/cssom-view/#dom-document-scrollingelement,
says we should have while we have non-compliant implementations of Element.scrollTop
and Element.scrollLeft (fixing that is tracked by https://bugs.webkit.org/show_bug.cgi?id=106133).
Tests: fast/dom/Document/scrollingElement-quirks-mode.html
fast/dom/Document/scrollingElement-standards-mode.html
* dom/Document.cpp:
(WebCore::Document::scrollingElement):
* dom/Document.h:
* dom/Document.idl:
LayoutTests:
* fast/dom/Document/scrollingElement-quirks-mode-expected.txt: Added.
* fast/dom/Document/scrollingElement-quirks-mode.html: Added.
* fast/dom/Document/scrollingElement-standards-mode-expected.txt: Added.
* fast/dom/Document/scrollingElement-standards-mode.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomDocumentscrollingElementquirksmodeexpectedtxt">trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentscrollingElementquirksmodehtml">trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode.html</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentscrollingElementstandardsmodeexpectedtxt">trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentscrollingElementstandardsmodehtml">trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183966 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-08 00:54:54 UTC (rev 183966)
+++ trunk/LayoutTests/ChangeLog 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-05-07 Sam Weinig <sam@webkit.org>
+
+ Consider implementing Document.scrollingElement
+ <rdar://problem/20845213>
+ https://bugs.webkit.org/show_bug.cgi?id=143609
+
+ Reviewed by Simon Fraser.
+
+ * fast/dom/Document/scrollingElement-quirks-mode-expected.txt: Added.
+ * fast/dom/Document/scrollingElement-quirks-mode.html: Added.
+ * fast/dom/Document/scrollingElement-standards-mode-expected.txt: Added.
+ * fast/dom/Document/scrollingElement-standards-mode.html: Added.
+
</ins><span class="cx"> 2015-05-07 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Applying a filter on an SVG element, which is larger than 4096 pixels, causes this element to be rendered shifted to the left
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentscrollingElementquirksmodeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode-expected.txt (0 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode-expected.txt 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+Tests the behavior of document.scrollingElement in quirks mode.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+In quirks mode the scrolling element is `BODY`
+PASS document.scrollingElement is document.body
+PASS document.scrollingElement is document.body
+PASS document.scrollingElement is document.body
+In quirks mode, if the `BODY` is scrollable, the scrolling element is `null`
+INTENTIONAL FAILURE. This can be fixed once https://bugs.webkit.org/show_bug.cgi?id=106133 is fixed.
+FAIL document.scrollingElement.scrollingElement should be null (of type object). Was undefined (of type undefined).
+In quirks mode, if the `BODY` is `display: none`, the scrolling element is `BODY`
+PASS document.scrollingElement is document.body
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentscrollingElementquirksmodehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode.html (0 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/scrollingElement-quirks-mode.html 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<html>
+<head>
+<meta charset="utf-8">
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script>
+
+description("Tests the behavior of document.scrollingElement in quirks mode.");
+
+debug("In quirks mode the scrolling element is `BODY`");
+shouldBe("document.scrollingElement", "document.body");
+
+document.documentElement.setAttribute('style', 'overflow: scroll');
+document.body.setAttribute('style', 'overflow: visible');
+shouldBe("document.scrollingElement", "document.body");
+
+document.documentElement.setAttribute('style', 'overflow: visible');
+document.body.setAttribute('style', 'overflow: scroll');
+shouldBe("document.scrollingElement", "document.body");
+
+debug("In quirks mode, if the `BODY` is scrollable, the scrolling element is `null`");
+debug("INTENTIONAL FAILURE. This can be fixed once https://bugs.webkit.org/show_bug.cgi?id=106133 is fixed.");
+document.documentElement.setAttribute('style', 'overflow: scroll');
+document.body.setAttribute('style', 'overflow: scroll');
+shouldBeNull("document.scrollingElement.scrollingElement");
+
+debug("In quirks mode, if the `BODY` is `display: none`, the scrolling element is `BODY`");
+document.documentElement.setAttribute('style', 'overflow: scroll');
+document.body.setAttribute('style', 'overflow: scroll; display: none');
+shouldBe("document.scrollingElement", "document.body");
+
+document.body.setAttribute('style', '');
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentscrollingElementstandardsmodeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode-expected.txt (0 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode-expected.txt 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Tests the behavior of document.scrollingElement in standards mode.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+In standards mode the scrolling element is supposed to be `HTML`
+INTENTIONAL FAILURE. This can be fixed once https://bugs.webkit.org/show_bug.cgi?id=106133 is fixed.
+FAIL document.scrollingElement should be [object HTMLHtmlElement]. Was [object HTMLBodyElement].
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentscrollingElementstandardsmodehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode.html (0 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/scrollingElement-standards-mode.html 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script>
+
+description("Tests the behavior of document.scrollingElement in standards mode.");
+
+debug("In standards mode the scrolling element is supposed to be `HTML`");
+debug("INTENTIONAL FAILURE. This can be fixed once https://bugs.webkit.org/show_bug.cgi?id=106133 is fixed.");
+shouldBe("document.scrollingElement", "document.documentElement");
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183966 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-08 00:54:54 UTC (rev 183966)
+++ trunk/Source/WebCore/ChangeLog 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-05-07 Sam Weinig <sam@webkit.org>
+
+ Consider implementing Document.scrollingElement
+ <rdar://problem/20845213>
+ https://bugs.webkit.org/show_bug.cgi?id=143609
+
+ Reviewed by Simon Fraser.
+
+ Add the non-compliant implementation of Document.scrollingElement that the spec,
+ found at http://dev.w3.org/csswg/cssom-view/#dom-document-scrollingelement,
+ says we should have while we have non-compliant implementations of Element.scrollTop
+ and Element.scrollLeft (fixing that is tracked by https://bugs.webkit.org/show_bug.cgi?id=106133).
+
+ Tests: fast/dom/Document/scrollingElement-quirks-mode.html
+ fast/dom/Document/scrollingElement-standards-mode.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::scrollingElement):
+ * dom/Document.h:
+ * dom/Document.idl:
+
</ins><span class="cx"> 2015-05-07 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] While scrubbing and holding down, video continues to play
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (183966 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2015-05-08 00:54:54 UTC (rev 183966)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -1429,6 +1429,14 @@
</span><span class="cx"> return Range::create(*this, rangeCompliantPosition, rangeCompliantPosition);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+Element* Document::scrollingElement()
+{
+ // FIXME: When we fix https://bugs.webkit.org/show_bug.cgi?id=106133, this should be replaced with the full implementation
+ // of Document.scrollingElement() as specified at http://dev.w3.org/csswg/cssom-view/#dom-document-scrollingelement.
+
+ return body();
+}
+
</ins><span class="cx"> /*
</span><span class="cx"> * Performs three operations:
</span><span class="cx"> * 1. Convert control characters to spaces
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (183966 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2015-05-08 00:54:54 UTC (rev 183966)
+++ trunk/Source/WebCore/dom/Document.h 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -381,6 +381,8 @@
</span><span class="cx"> RefPtr<Range> caretRangeFromPoint(int x, int y);
</span><span class="cx"> RefPtr<Range> caretRangeFromPoint(const LayoutPoint& clientPoint);
</span><span class="cx">
</span><ins>+ Element* scrollingElement();
+
</ins><span class="cx"> String readyState() const;
</span><span class="cx">
</span><span class="cx"> String defaultCharset() const;
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (183966 => 183967)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2015-05-08 00:54:54 UTC (rev 183966)
+++ trunk/Source/WebCore/dom/Document.idl 2015-05-08 00:59:01 UTC (rev 183967)
</span><span class="lines">@@ -341,5 +341,7 @@
</span><span class="cx">
</span><span class="cx"> // http://www.w3.org/TR/2014/WD-dom-20140204/#dom-document-origin
</span><span class="cx"> readonly attribute DOMString origin;
</span><ins>+
+ readonly attribute Element scrollingElement;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>