<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183913] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183913">183913</a></dd>
<dt>Author</dt> <dd>rego@igalia.com</dd>
<dt>Date</dt> <dd>2015-05-06 23:07:25 -0700 (Wed, 06 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Grid Layout] Mark grid shorthands as layout dependent
https://bugs.webkit.org/show_bug.cgi?id=144687
Reviewed by Darin Adler.
Source/WebCore:
grid-template and grid shorthands were not marked us layout dependent,
so you can end up calling them before the grid has been laid out and
you'll get a crash at valueForGridTrackList() because of trackPositions
won't be initialized yet.
Tests: fast/css-grid-layout/grid-shorthand-computed-style-crash.html
fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::isLayoutDependent): Add the grid shorthands only if the object
is a RenderGrid as otherwise it's not needed (using the same condition
for grid-template-columns and grid-template-rows properties too).
LayoutTests:
* fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt: Added.
* fast/css-grid-layout/grid-shorthand-computed-style-crash.html: Added.
* fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt: Added.
* fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridshorthandcomputedstylecrashexpectedtxt">trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridshorthandcomputedstylecrashhtml">trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash.html</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridtemplateshorthandcomputedstylecrashexpectedtxt">trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridtemplateshorthandcomputedstylecrashhtml">trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183912 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-07 05:15:56 UTC (rev 183912)
+++ trunk/LayoutTests/ChangeLog 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-05-06 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Mark grid shorthands as layout dependent
+ https://bugs.webkit.org/show_bug.cgi?id=144687
+
+ Reviewed by Darin Adler.
+
+ * fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt: Added.
+ * fast/css-grid-layout/grid-shorthand-computed-style-crash.html: Added.
+ * fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt: Added.
+ * fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html: Added.
+
</ins><span class="cx"> 2015-05-06 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> ToT WebKit crashes while loading ES6 compatibility table
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridshorthandcomputedstylecrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt (0 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash-expected.txt 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+This test checks that getting computed style of grid shorthand does not crash.
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridshorthandcomputedstylecrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash.html (0 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-computed-style-crash.html 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
+<style>
+ .grid {
+ -webkit-grid: 100px / 50px;
+ }
+</style>
+<p>This test checks that getting computed style of grid shorthand does not crash.</p>
+<div id="grid" class="grid">
+</div>
+<script>
+ var grid = document.getElementById("grid");
+ getComputedStyle(grid).webkitGrid;
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridtemplateshorthandcomputedstylecrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt (0 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash-expected.txt 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+This test checks that getting computed style of grid-template shorthand does not crash.
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridtemplateshorthandcomputedstylecrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html (0 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
+<style>
+ .grid {
+ -webkit-grid-template: 100px / 50px;
+ }
+</style>
+<p>This test checks that getting computed style of grid-template shorthand does not crash.</p>
+<div id="grid" class="grid">
+</div>
+<script>
+ var grid = document.getElementById("grid");
+ getComputedStyle(grid).webkitGridTemplate;
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183912 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-07 05:15:56 UTC (rev 183912)
+++ trunk/Source/WebCore/ChangeLog 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-05-06 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Mark grid shorthands as layout dependent
+ https://bugs.webkit.org/show_bug.cgi?id=144687
+
+ Reviewed by Darin Adler.
+
+ grid-template and grid shorthands were not marked us layout dependent,
+ so you can end up calling them before the grid has been laid out and
+ you'll get a crash at valueForGridTrackList() because of trackPositions
+ won't be initialized yet.
+
+ Tests: fast/css-grid-layout/grid-shorthand-computed-style-crash.html
+ fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::isLayoutDependent): Add the grid shorthands only if the object
+ is a RenderGrid as otherwise it's not needed (using the same condition
+ for grid-template-columns and grid-template-rows properties too).
+
</ins><span class="cx"> 2015-05-06 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS][WK2] Pause/resume database thread when UIProcess enters/leaves the background
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (183912 => 183913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2015-05-07 05:15:56 UTC (rev 183912)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2015-05-07 06:07:25 UTC (rev 183913)
</span><span class="lines">@@ -1652,10 +1652,6 @@
</span><span class="cx"> switch (propertyID) {
</span><span class="cx"> case CSSPropertyWidth:
</span><span class="cx"> case CSSPropertyHeight:
</span><del>-#if ENABLE(CSS_GRID_LAYOUT)
- case CSSPropertyWebkitGridTemplateColumns:
- case CSSPropertyWebkitGridTemplateRows:
-#endif
</del><span class="cx"> case CSSPropertyPerspectiveOrigin:
</span><span class="cx"> case CSSPropertyTransformOrigin:
</span><span class="cx"> case CSSPropertyTransform:
</span><span class="lines">@@ -1692,6 +1688,13 @@
</span><span class="cx"> return paddingOrMarginIsRendererDependent<&RenderStyle::paddingBottom>(style, renderer);
</span><span class="cx"> case CSSPropertyPaddingLeft:
</span><span class="cx"> return paddingOrMarginIsRendererDependent<&RenderStyle::paddingLeft>(style, renderer);
</span><ins>+#if ENABLE(CSS_GRID_LAYOUT)
+ case CSSPropertyWebkitGridTemplateColumns:
+ case CSSPropertyWebkitGridTemplateRows:
+ case CSSPropertyWebkitGridTemplate:
+ case CSSPropertyWebkitGrid:
+ return renderer && renderer->isRenderGrid();
+#endif
</ins><span class="cx"> default:
</span><span class="cx"> return false;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>