<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183821] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183821">183821</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2015-05-05 11:11:50 -0700 (Tue, 05 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Web Inspector: no way to navigate to a resource/source location from overview timeline view
https://bugs.webkit.org/show_bug.cgi?id=144539
Reviewed by Brian Burg.
* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set status): Call didChange() so the onchange event fires. This allows
TimelineSidebarPanel to update the status element when it goes from a spinner to empty for ResourceTreeElements.
(WebInspector.GeneralTreeElement.prototype.onattach): Don't call _updateStatusElement, just append it if needed.
Calling _updateStatusElement caused DOMNodeFragments as status elements to be appended a second time and fail.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement):
(WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
(WebInspector.NetworkTimelineView.prototype.treeElementSelected):
(WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):
(WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked): Deleted.
* UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement):
(WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement):
(WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):
(WebInspector.OverviewTimelineView.prototype._treeElementDeselected): Deleted.
(WebInspector.OverviewTimelineView.prototype._treeElementSelected): Deleted.
(WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
(WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked): Deleted.
* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement):
(WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent): Don't show a go-to arrow in the Domain column.
(WebInspector.ResourceTimelineDataGridNode.prototype._goToResource): Deleted.
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype.canShowContentViewForTreeElement):
(WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
(WebInspector.ScriptTimelineView.prototype.treeElementSelected):
* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement.prototype.get sourceCodeLocation):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button):
(.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button):
(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button):
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.treeElementAddedOrChanged): Added.
(WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
(WebInspector.TimelineSidebarPanel.prototype._treeElementGoToArrowWasClicked): Added.
(WebInspector.TimelineSidebarPanel.prototype._treeElementCloseButtonClicked): Added.
* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype.canShowContentViewForTreeElement):
(WebInspector.TimelineView.prototype.showContentViewForTreeElement):
(WebInspector.TimelineView.prototype.treeElementDeselected):
(WebInspector.TimelineView.prototype.treeElementSelected):
(WebInspector.TimelineView.prototype.needsLayout):
(WebInspector.TimelineView.prototype._closeStatusButtonClicked): Deleted.
(WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
* UserInterface/Views/TreeElementStatusButton.css:
(.item > .status > .status-button): Fix an alignment issue with close and go-to arrows being side-by-side.
Does not happen in the final patch because they are mutually exclusive, but still good to fix.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsGeneralTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNetworkTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsOverviewTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsResourceTimelineDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsScriptTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeElementStatusButtoncss">trunk/Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -1,5 +1,69 @@
</span><span class="cx"> 2015-05-05 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><ins>+ REGRESSION: Web Inspector: no way to navigate to a resource/source location from overview timeline view
+ https://bugs.webkit.org/show_bug.cgi?id=144539
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WebInspector.GeneralTreeElement.prototype.set status): Call didChange() so the onchange event fires. This allows
+ TimelineSidebarPanel to update the status element when it goes from a spinner to empty for ResourceTreeElements.
+ (WebInspector.GeneralTreeElement.prototype.onattach): Don't call _updateStatusElement, just append it if needed.
+ Calling _updateStatusElement caused DOMNodeFragments as status elements to be appended a second time and fail.
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
+ (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
+ * UserInterface/Views/NetworkTimelineView.js:
+ (WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement):
+ (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
+ (WebInspector.NetworkTimelineView.prototype.treeElementSelected):
+ (WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):
+ (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
+ (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked): Deleted.
+ * UserInterface/Views/OverviewTimelineView.js:
+ (WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement):
+ (WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement):
+ (WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):
+ (WebInspector.OverviewTimelineView.prototype._treeElementDeselected): Deleted.
+ (WebInspector.OverviewTimelineView.prototype._treeElementSelected): Deleted.
+ (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
+ (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked): Deleted.
+ * UserInterface/Views/RenderingFrameTimelineView.js:
+ (WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement):
+ (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
+ * UserInterface/Views/ResourceTimelineDataGridNode.js:
+ (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent): Don't show a go-to arrow in the Domain column.
+ (WebInspector.ResourceTimelineDataGridNode.prototype._goToResource): Deleted.
+ * UserInterface/Views/ScriptTimelineView.js:
+ (WebInspector.ScriptTimelineView.prototype.canShowContentViewForTreeElement):
+ (WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
+ (WebInspector.ScriptTimelineView.prototype.treeElementSelected):
+ * UserInterface/Views/TimelineRecordTreeElement.js:
+ (WebInspector.TimelineRecordTreeElement.prototype.get sourceCodeLocation):
+ * UserInterface/Views/TimelineSidebarPanel.css:
+ (.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button):
+ (.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button):
+ (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button):
+ * UserInterface/Views/TimelineSidebarPanel.js:
+ (WebInspector.TimelineSidebarPanel.prototype.treeElementAddedOrChanged): Added.
+ (WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
+ (WebInspector.TimelineSidebarPanel.prototype._treeElementGoToArrowWasClicked): Added.
+ (WebInspector.TimelineSidebarPanel.prototype._treeElementCloseButtonClicked): Added.
+ * UserInterface/Views/TimelineView.js:
+ (WebInspector.TimelineView):
+ (WebInspector.TimelineView.prototype.canShowContentViewForTreeElement):
+ (WebInspector.TimelineView.prototype.showContentViewForTreeElement):
+ (WebInspector.TimelineView.prototype.treeElementDeselected):
+ (WebInspector.TimelineView.prototype.treeElementSelected):
+ (WebInspector.TimelineView.prototype.needsLayout):
+ (WebInspector.TimelineView.prototype._closeStatusButtonClicked): Deleted.
+ (WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
+ * UserInterface/Views/TreeElementStatusButton.css:
+ (.item > .status > .status-button): Fix an alignment issue with close and go-to arrows being side-by-side.
+ Does not happen in the final patch because they are mutually exclusive, but still good to fix.
+
+2015-05-05 Timothy Hatcher <timothy@apple.com>
+
</ins><span class="cx"> Web Inspector: Fix some issues with Search tabs
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=144531
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsGeneralTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -188,6 +188,7 @@
</span><span class="cx">
</span><span class="cx"> this._status = x || "";
</span><span class="cx"> this._updateStatusElement();
</span><ins>+ this.didChange();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> get filterableData()
</span><span class="lines">@@ -219,9 +220,8 @@
</span><span class="cx">
</span><span class="cx"> this._listItemNode.classList.add("item");
</span><span class="cx">
</span><del>- if (this._classNames) {
</del><ins>+ if (this._classNames)
</ins><span class="cx"> this._listItemNode.classList.add(...this._classNames);
</span><del>- }
</del><span class="cx">
</span><span class="cx"> if (this._small)
</span><span class="cx"> this._listItemNode.classList.add(WebInspector.GeneralTreeElement.SmallStyleClassName);
</span><span class="lines">@@ -231,6 +231,8 @@
</span><span class="cx">
</span><span class="cx"> this._listItemNode.appendChild(this._disclosureButton);
</span><span class="cx"> this._listItemNode.appendChild(this._iconElement);
</span><ins>+ if (this._statusElement)
+ this._listItemNode.appendChild(this._statusElement);
</ins><span class="cx"> this._listItemNode.appendChild(this._titlesElement);
</span><span class="cx">
</span><span class="cx"> if (this.oncontextmenu && typeof this.oncontextmenu === "function") {
</span><span class="lines">@@ -242,8 +244,6 @@
</span><span class="cx"> this._boundContextMenuEventHandler = function(event) { this.treeOutline.oncontextmenu(event, this); }.bind(this);
</span><span class="cx"> this._listItemNode.addEventListener("contextmenu", this._boundContextMenuEventHandler);
</span><span class="cx"> }
</span><del>-
- this._updateStatusElement();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ondetach()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -388,6 +388,11 @@
</span><span class="cx"> treeElement.hidden = true;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ treeElementAddedOrChanged(treeElement)
+ {
+ // Implemented by subclasses if needed.
+ }
+
</ins><span class="cx"> show()
</span><span class="cx"> {
</span><span class="cx"> if (!this.parentSidebar)
</span><span class="lines">@@ -520,6 +525,8 @@
</span><span class="cx">
</span><span class="cx"> if (this.selected)
</span><span class="cx"> this._checkElementsForPendingViewStateCookie(treeElement);
</span><ins>+
+ this.treeElementAddedOrChanged(treeElement);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _treeElementExpandedOrCollapsed(treeElement)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNetworkTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -154,15 +154,21 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><ins>+ canShowContentViewForTreeElement: function(treeElement)
+ {
+ if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement)
+ return true;
+ return WebInspector.TimelineView.prototype.canShowContentViewForTreeElement(treeElement);
+ },
+
</ins><span class="cx"> showContentViewForTreeElement: function(treeElement)
</span><span class="cx"> {
</span><span class="cx"> if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement) {
</span><span class="cx"> WebInspector.showSourceCode(treeElement.representedObject);
</span><del>- return true;
</del><ins>+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> console.error("Unknown tree element selected.", treeElement);
</span><del>- return false;
</del><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> treeElementPathComponentSelected: function(event)
</span><span class="lines">@@ -176,7 +182,7 @@
</span><span class="cx"> treeElementSelected: function(treeElement, selectedByUser)
</span><span class="cx"> {
</span><span class="cx"> if (this._dataGrid.shouldIgnoreSelectionEvent())
</span><del>- return false;
</del><ins>+ return;
</ins><span class="cx">
</span><span class="cx"> WebInspector.TimelineView.prototype.treeElementSelected.call(this, treeElement, selectedByUser);
</span><span class="cx"> },
</span><span class="lines">@@ -221,26 +227,5 @@
</span><span class="cx"> _dataGridNodeSelected: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);
</span><del>- },
-
- _updateTreeElementWithCloseButton: function(treeElement)
- {
- if (this._closeStatusButton) {
- treeElement.status = this._closeStatusButton.element;
- return;
- }
-
- wrappedSVGDocument("Images/Close.svg", null, WebInspector.UIString("Close resource view"), function(element) {
- this._closeStatusButton = new WebInspector.TreeElementStatusButton(element);
- this._closeStatusButton.addEventListener(WebInspector.TreeElementStatusButton.Event.Clicked, this._closeStatusButtonClicked, this);
- if (treeElement === this.navigationSidebarTreeOutline.selectedTreeElement)
- this._updateTreeElementWithCloseButton(treeElement);
- }.bind(this));
- },
-
- _closeStatusButtonClicked: function(event)
- {
- this.navigationSidebarTreeOutline.selectedTreeElement.deselect();
- this.timelineSidebarPanel.showTimelineViewForTimeline(this.representedObject);
</del><span class="cx"> }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsOverviewTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -27,9 +27,6 @@
</span><span class="cx"> {
</span><span class="cx"> WebInspector.TimelineView.call(this, recording, extraArguments);
</span><span class="cx">
</span><del>- this.navigationSidebarTreeOutline.onselect = this._treeElementSelected.bind(this);
- this.navigationSidebarTreeOutline.ondeselect = this._treeElementDeselected.bind(this);
-
</del><span class="cx"> this._recording = recording;
</span><span class="cx">
</span><span class="cx"> var columns = {"graph": {width: "100%"}};
</span><span class="lines">@@ -159,6 +156,33 @@
</span><span class="cx"> dataGridNode.revealAndSelect();
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ canShowContentViewForTreeElement: function(treeElement)
+ {
+ if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement)
+ return true;
+ return WebInspector.TimelineView.prototype.canShowContentViewForTreeElement(treeElement);
+ },
+
+ showContentViewForTreeElement: function(treeElement)
+ {
+ if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement) {
+ WebInspector.showSourceCode(treeElement.representedObject);
+ return;
+ }
+
+ if (!(treeElement instanceof WebInspector.SourceCodeTimelineTreeElement)) {
+ console.error("Unknown tree element selected.");
+ return;
+ }
+
+ if (!treeElement.sourceCodeTimeline.sourceCodeLocation) {
+ this.timelineSidebarPanel.showTimelineOverview();
+ return;
+ }
+
+ WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.sourceCodeTimeline.sourceCodeLocation);
+ },
+
</ins><span class="cx"> // Private
</span><span class="cx">
</span><span class="cx"> _compareTreeElementsByDetails: function(a, b)
</span><span class="lines">@@ -329,61 +353,5 @@
</span><span class="cx"> _dataGridNodeSelected: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);
</span><del>- },
-
- _treeElementDeselected: function(treeElement)
- {
- if (treeElement.status)
- treeElement.status = "";
- },
-
- _treeElementSelected: function(treeElement, selectedByUser)
- {
- if (!this.timelineSidebarPanel.canShowDifferentContentView())
- return;
-
- if (treeElement instanceof WebInspector.FolderTreeElement)
- return;
-
- if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement) {
- WebInspector.showSourceCode(treeElement.representedObject);
- this._updateTreeElementWithCloseButton(treeElement);
- return;
- }
-
- if (!(treeElement instanceof WebInspector.SourceCodeTimelineTreeElement)) {
- console.error("Unknown tree element selected.");
- return;
- }
-
- if (!treeElement.sourceCodeTimeline.sourceCodeLocation) {
- this.timelineSidebarPanel.showTimelineOverview();
- this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);
- return;
- }
-
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.sourceCodeTimeline.sourceCodeLocation);
- this._updateTreeElementWithCloseButton(treeElement);
- },
-
- _updateTreeElementWithCloseButton: function(treeElement)
- {
- if (this._closeStatusButton) {
- treeElement.status = this._closeStatusButton.element;
- return;
- }
-
- wrappedSVGDocument("Images/Close.svg", null, WebInspector.UIString("Close resource view"), function(element) {
- this._closeStatusButton = new WebInspector.TreeElementStatusButton(element);
- this._closeStatusButton.addEventListener(WebInspector.TreeElementStatusButton.Event.Clicked, this._closeStatusButtonClicked, this);
- if (treeElement === this.navigationSidebarTreeOutline.selectedTreeElement)
- this._updateTreeElementWithCloseButton(treeElement);
- }.bind(this));
- },
-
- _closeStatusButtonClicked: function(event)
- {
- this.navigationSidebarTreeOutline.selectedTreeElement.deselect();
- this.timelineSidebarPanel.showTimelineOverview();
</del><span class="cx"> }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -156,14 +156,22 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><ins>+ canShowContentViewForTreeElement: function(treeElement)
+ {
+ if (treeElement instanceof WebInspector.ProfileNodeTreeElement)
+ return !!treeElement.profileNode.sourceCodeLocation;
+ return WebInspector.TimelineView.prototype.canShowContentViewForTreeElement(treeElement);
+ },
+
</ins><span class="cx"> showContentViewForTreeElement: function(treeElement)
</span><span class="cx"> {
</span><del>- if (treeElement instanceof WebInspector.ProfileNodeTreeElement && treeElement.profileNode.sourceCodeLocation) {
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
- return true;
</del><ins>+ if (treeElement instanceof WebInspector.ProfileNodeTreeElement) {
+ if (treeElement.profileNode.sourceCodeLocation)
+ WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return WebInspector.TimelineView.prototype.showContentViewForTreeElement.call(this, treeElement);
</del><ins>+ WebInspector.TimelineView.prototype.showContentViewForTreeElement.call(this, treeElement);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> treeElementSelected: function(treeElement, selectedByUser)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsResourceTimelineDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -116,17 +116,8 @@
</span><span class="cx"> return value ? WebInspector.UIString("Yes") : WebInspector.UIString("No");
</span><span class="cx">
</span><span class="cx"> case "domain":
</span><del>- var fragment = document.createDocumentFragment();
</del><ins>+ return value || emptyValuePlaceholderString;
</ins><span class="cx">
</span><del>- var goToButton = WebInspector.createGoToArrowButton();
- goToButton.addEventListener("click", this._goToResource.bind(this));
- fragment.appendChild(goToButton);
-
- var text = document.createTextNode(value || emptyValuePlaceholderString);
- fragment.appendChild(text);
-
- return fragment;
-
</del><span class="cx"> case "size":
</span><span class="cx"> case "transferSize":
</span><span class="cx"> return isNaN(value) ? emptyValuePlaceholderString : Number.bytesToString(value, true);
</span><span class="lines">@@ -167,11 +158,6 @@
</span><span class="cx"> this._scheduledRefreshIdentifier = requestAnimationFrame(this.refresh.bind(this));
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _goToResource: function(event)
- {
- WebInspector.showSourceCode(this._resource);
- },
-
</del><span class="cx"> _timelineRecordUpdated: function(event)
</span><span class="cx"> {
</span><span class="cx"> if (this.isRecordVisible(this._record))
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsScriptTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTimelineView.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -169,14 +169,22 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><ins>+ canShowContentViewForTreeElement: function(treeElement)
+ {
+ if (treeElement instanceof WebInspector.ProfileNodeTreeElement)
+ return !!treeElement.profileNode.sourceCodeLocation;
+ return WebInspector.TimelineView.prototype.canShowContentViewForTreeElement(treeElement);
+ },
+
</ins><span class="cx"> showContentViewForTreeElement: function(treeElement)
</span><span class="cx"> {
</span><del>- if (treeElement instanceof WebInspector.ProfileNodeTreeElement && treeElement.profileNode.sourceCodeLocation) {
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
- return true;
</del><ins>+ if (treeElement instanceof WebInspector.ProfileNodeTreeElement) {
+ if (treeElement.profileNode.sourceCodeLocation)
+ WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return WebInspector.TimelineView.prototype.showContentViewForTreeElement.call(this, treeElement);
</del><ins>+ WebInspector.TimelineView.prototype.showContentViewForTreeElement.call(this, treeElement);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> treeElementPathComponentSelected: function(event)
</span><span class="lines">@@ -190,7 +198,7 @@
</span><span class="cx"> treeElementSelected: function(treeElement, selectedByUser)
</span><span class="cx"> {
</span><span class="cx"> if (this._dataGrid.shouldIgnoreSelectionEvent())
</span><del>- return false;
</del><ins>+ return;
</ins><span class="cx">
</span><span class="cx"> WebInspector.TimelineView.prototype.treeElementSelected.call(this, treeElement, selectedByUser);
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineRecordTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -133,6 +133,11 @@
</span><span class="cx"> return {text: [this.mainTitle, url || "", this._record.details || ""]};
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ get sourceCodeLocation()
+ {
+ return this._sourceCodeLocation;
+ }
+
</ins><span class="cx"> // Protected
</span><span class="cx">
</span><span class="cx"> onattach()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -193,6 +193,19 @@
</span><span class="cx"> right: -16px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.sidebar > .panel.navigation.timeline .item:not(:hover, .selected) .status .status-button,
+.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button {
+ display: none;
+}
+
+.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button {
+ display: none;
+}
+
+.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button {
+ display: none;
+}
+
</ins><span class="cx"> .sidebar > .panel.navigation.timeline > .timelines-content > .details-section > div.header {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -354,8 +354,39 @@
</span><span class="cx"> return this._displayedContentView.matchTreeElementAgainstCustomFilters(treeElement);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ treeElementAddedOrChanged(treeElement)
+ {
+ if (treeElement.status)
+ return;
+
+ if (!treeElement.treeOutline || typeof treeElement.treeOutline.__canShowContentViewForTreeElement !== "function")
+ return;
+
+ if (!treeElement.treeOutline.__canShowContentViewForTreeElement(treeElement))
+ return;
+
+ wrappedSVGDocument("Images/Close.svg", null, WebInspector.UIString("Close resource view"), function(element) {
+ var fragment = document.createDocumentFragment();
+
+ var closeButton = new WebInspector.TreeElementStatusButton(element);
+ closeButton.element.classList.add("close");
+ closeButton.addEventListener(WebInspector.TreeElementStatusButton.Event.Clicked, this._treeElementCloseButtonClicked, this);
+ fragment.appendChild(closeButton.element);
+
+ var goToButton = new WebInspector.TreeElementStatusButton(WebInspector.createGoToArrowButton());
+ goToButton.__treeElement = treeElement;
+ goToButton.addEventListener(WebInspector.TreeElementStatusButton.Event.Clicked, this._treeElementGoToArrowWasClicked, this);
+ fragment.appendChild(goToButton.element);
+
+ treeElement.status = fragment;
+ }.bind(this));
+ }
+
</ins><span class="cx"> canShowDifferentContentView()
</span><span class="cx"> {
</span><ins>+ if (this._clickedTreeElementGoToArrow)
+ return true;
+
</ins><span class="cx"> if (this.contentBrowser.currentContentView instanceof WebInspector.TimelineRecordingContentView)
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -409,6 +440,27 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><ins>+ _treeElementGoToArrowWasClicked(event)
+ {
+ this._clickedTreeElementGoToArrow = true;
+
+ var treeElement = event.target.__treeElement;
+ console.assert(treeElement instanceof WebInspector.TreeElement);
+
+ treeElement.select(true, true);
+
+ this._clickedTreeElementGoToArrow = false;
+ }
+
+ _treeElementCloseButtonClicked(event)
+ {
+ var currentTimelineView = this._displayedContentView ? this._displayedContentView.currentTimelineView : null;
+ if (currentTimelineView && currentTimelineView.representedObject instanceof WebInspector.Timeline)
+ this.showTimelineViewForTimeline(currentTimelineView.representedObject);
+ else
+ this.showTimelineOverview();
+ }
+
</ins><span class="cx"> _recordingsTreeElementSelected(treeElement, selectedByUser)
</span><span class="cx"> {
</span><span class="cx"> console.assert(treeElement.representedObject instanceof WebInspector.TimelineRecording);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> this._contentTreeOutline = this._timelineSidebarPanel.createContentTreeOutline();
</span><span class="cx"> this._contentTreeOutline.onselect = this.treeElementSelected.bind(this);
</span><span class="cx"> this._contentTreeOutline.ondeselect = this.treeElementDeselected.bind(this);
</span><ins>+ this._contentTreeOutline.__canShowContentViewForTreeElement = this.canShowContentViewForTreeElement.bind(this);
</ins><span class="cx">
</span><span class="cx"> this.element.classList.add("timeline-view");
</span><span class="cx">
</span><span class="lines">@@ -191,23 +192,31 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><ins>+ canShowContentViewForTreeElement: function(treeElement)
+ {
+ // Implemented by sub-classes if needed.
+
+ if (treeElement instanceof WebInspector.TimelineRecordTreeElement)
+ return !!treeElement.sourceCodeLocation;
+ return false;
+ },
+
</ins><span class="cx"> showContentViewForTreeElement: function(treeElement)
</span><span class="cx"> {
</span><span class="cx"> // Implemented by sub-classes if needed.
</span><span class="cx">
</span><span class="cx"> if (!(treeElement instanceof WebInspector.TimelineRecordTreeElement)) {
</span><span class="cx"> console.error("Unknown tree element selected.", treeElement);
</span><del>- return false;
</del><ins>+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- var sourceCodeLocation = treeElement.record.sourceCodeLocation;
</del><ins>+ var sourceCodeLocation = treeElement.sourceCodeLocation;
</ins><span class="cx"> if (!sourceCodeLocation) {
</span><span class="cx"> this._timelineSidebarPanel.showTimelineViewForTimeline(this.representedObject);
</span><del>- return true;
</del><ins>+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> WebInspector.showOriginalOrFormattedSourceCodeLocation(sourceCodeLocation);
</span><del>- return true;
</del><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> treeElementPathComponentSelected: function(event)
</span><span class="lines">@@ -218,9 +227,6 @@
</span><span class="cx"> treeElementDeselected: function(treeElement)
</span><span class="cx"> {
</span><span class="cx"> // Implemented by sub-classes if needed.
</span><del>-
- if (this._closeStatusButton && treeElement.status === this._closeStatusButton.element)
- treeElement.status = "";
</del><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> treeElementSelected: function(treeElement, selectedByUser)
</span><span class="lines">@@ -233,10 +239,7 @@
</span><span class="cx"> if (treeElement instanceof WebInspector.FolderTreeElement)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!this.showContentViewForTreeElement(treeElement))
- return;
-
- this._updateTreeElementWithCloseButton(treeElement);
</del><ins>+ this.showContentViewForTreeElement(treeElement);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> needsLayout: function()
</span><span class="lines">@@ -248,30 +251,5 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> this._scheduledLayoutUpdateIdentifier = requestAnimationFrame(this.updateLayout.bind(this));
</span><del>- },
-
- // Private
-
- _closeStatusButtonClicked: function(event)
- {
- if (this.navigationSidebarTreeOutline.selectedTreeElement)
- this.navigationSidebarTreeOutline.selectedTreeElement.deselect();
-
- this._timelineSidebarPanel.showTimelineViewForTimeline(this.representedObject);
- },
-
- _updateTreeElementWithCloseButton: function(treeElement)
- {
- if (this._closeStatusButton) {
- treeElement.status = this._closeStatusButton.element;
- return;
- }
-
- wrappedSVGDocument("Images/Close.svg", null, WebInspector.UIString("Close resource view"), function(element) {
- this._closeStatusButton = new WebInspector.TreeElementStatusButton(element);
- this._closeStatusButton.addEventListener(WebInspector.TreeElementStatusButton.Event.Clicked, this._closeStatusButtonClicked, this);
- if (treeElement === this.navigationSidebarTreeOutline.selectedTreeElement)
- this._updateTreeElementWithCloseButton(treeElement);
- }.bind(this));
</del><span class="cx"> }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeElementStatusButtoncss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.css (183820 => 183821)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.css 2015-05-05 18:02:09 UTC (rev 183820)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.css 2015-05-05 18:11:50 UTC (rev 183821)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><span class="cx"> display: inline-block;
</span><ins>+ vertical-align: middle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .item > .status > .status-button > svg .filled {
</span></span></pre>
</div>
</div>
</body>
</html>