<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183856] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183856">183856</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2015-05-05 23:17:02 -0700 (Tue, 05 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add missing vtable override specifiers under Source/WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=144569
Reviewed by Darin Adler.
Update virtual method overrides under Source/WebCore/Modules
which are missing the override specifier.
* Modules/mediasource/SourceBuffer.h:
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/RTCVoidRequestImpl.h:
* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::mediaType): Deleted.
(WebCore::AudioContext::presentationType): Deleted.
(WebCore::AudioContext::canReceiveRemoteControlCommands): Deleted.
(WebCore::AudioContext::didReceiveRemoteControlCommand): Deleted.
(WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Deleted.
* Modules/webaudio/MediaStreamAudioDestinationNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/WaveShaperDSPKernel.h:
* Modules/websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::refThreadableWebSocketChannel): Deleted.
(WebCore::WebSocketChannel::derefThreadableWebSocketChannel): Deleted.
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceSourceBufferh">trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackh">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCVoidRequestImplh">trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioContexth">trunk/Source/WebCore/Modules/webaudio/AudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioMediaStreamAudioDestinationNodeh">trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioMediaStreamAudioSourceNodeh">trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioWaveShaperDSPKernelh">trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketChannelh">trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWorkerThreadableWebSocketChannelh">trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/ChangeLog 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -1,5 +1,34 @@
</span><span class="cx"> 2015-05-05 Žan Doberšek <zdobersek@igalia.com>
</span><span class="cx">
</span><ins>+ Add missing vtable override specifiers under Source/WebCore/Modules
+ https://bugs.webkit.org/show_bug.cgi?id=144569
+
+ Reviewed by Darin Adler.
+
+ Update virtual method overrides under Source/WebCore/Modules
+ which are missing the override specifier.
+
+ * Modules/mediasource/SourceBuffer.h:
+ * Modules/mediastream/MediaStreamTrack.h:
+ * Modules/mediastream/RTCVoidRequestImpl.h:
+ * Modules/webaudio/AudioContext.h:
+ (WebCore::AudioContext::mediaType): Deleted.
+ (WebCore::AudioContext::presentationType): Deleted.
+ (WebCore::AudioContext::canReceiveRemoteControlCommands): Deleted.
+ (WebCore::AudioContext::didReceiveRemoteControlCommand): Deleted.
+ (WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Deleted.
+ * Modules/webaudio/MediaStreamAudioDestinationNode.h:
+ * Modules/webaudio/MediaStreamAudioSourceNode.h:
+ * Modules/webaudio/WaveShaperDSPKernel.h:
+ * Modules/websockets/WebSocketChannel.h:
+ (WebCore::WebSocketChannel::refThreadableWebSocketChannel): Deleted.
+ (WebCore::WebSocketChannel::derefThreadableWebSocketChannel): Deleted.
+ * Modules/websockets/WorkerThreadableWebSocketChannel.h:
+ (WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel): Deleted.
+ (WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel): Deleted.
+
+2015-05-05 Žan Doberšek <zdobersek@igalia.com>
+
</ins><span class="cx"> EventHandler::m_eventHandlerWillResetCapturingMouseEventsElement is incorrectly initialized
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=144583
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceSourceBufferh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> virtual bool sourceBufferPrivateHasAudio(const SourceBufferPrivate*) const override;
</span><span class="cx"> virtual bool sourceBufferPrivateHasVideo(const SourceBufferPrivate*) const override;
</span><span class="cx"> virtual void sourceBufferPrivateDidBecomeReadyForMoreSamples(SourceBufferPrivate*, AtomicString trackID) override;
</span><del>- virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(SourceBufferPrivate*, const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold);
</del><ins>+ virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(SourceBufferPrivate*, const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold) override;
</ins><span class="cx"> virtual void sourceBufferPrivateAppendComplete(SourceBufferPrivate*, AppendResult) override;
</span><span class="cx"> virtual void sourceBufferPrivateDidReceiveRenderingError(SourceBufferPrivate*, int errorCode) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -121,9 +121,9 @@
</span><span class="cx"> virtual void derefEventTarget() override final { deref(); }
</span><span class="cx">
</span><span class="cx"> // MediaStreamTrackPrivateClient
</span><del>- void trackReadyStateChanged();
- void trackMutedChanged();
- void trackEnabledChanged();
</del><ins>+ void trackReadyStateChanged() override;
+ void trackMutedChanged() override;
+ void trackEnabledChanged() override;
</ins><span class="cx">
</span><span class="cx"> Vector<RefPtr<Event>> m_scheduledEvents;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCVoidRequestImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/mediastream/RTCVoidRequestImpl.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -47,8 +47,8 @@
</span><span class="cx"> static PassRefPtr<RTCVoidRequestImpl> create(ScriptExecutionContext*, PassRefPtr<VoidCallback>, PassRefPtr<RTCPeerConnectionErrorCallback>);
</span><span class="cx"> virtual ~RTCVoidRequestImpl();
</span><span class="cx">
</span><del>- virtual void requestSucceeded();
- virtual void requestFailed(const String& error);
</del><ins>+ virtual void requestSucceeded() override;
+ virtual void requestFailed(const String& error) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RTCVoidRequestImpl(ScriptExecutionContext*, PassRefPtr<VoidCallback>, PassRefPtr<RTCPeerConnectionErrorCallback>);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -307,13 +307,13 @@
</span><span class="cx"> void derefUnfinishedSourceNodes();
</span><span class="cx">
</span><span class="cx"> // MediaSessionClient
</span><del>- virtual MediaSession::MediaType mediaType() const { return MediaSession::WebAudio; }
- virtual MediaSession::MediaType presentationType() const { return MediaSession::WebAudio; }
- virtual bool canReceiveRemoteControlCommands() const { return false; }
- virtual void didReceiveRemoteControlCommand(MediaSession::RemoteControlCommandType) { }
- virtual bool overrideBackgroundPlaybackRestriction() const { return false; }
</del><ins>+ virtual MediaSession::MediaType mediaType() const override { return MediaSession::WebAudio; }
+ virtual MediaSession::MediaType presentationType() const override { return MediaSession::WebAudio; }
+ virtual void mayResumePlayback(bool shouldResume) override;
</ins><span class="cx"> virtual void suspendPlayback() override;
</span><del>- virtual void mayResumePlayback(bool shouldResume) override;
</del><ins>+ virtual bool canReceiveRemoteControlCommands() const override { return false; }
+ virtual void didReceiveRemoteControlCommand(MediaSession::RemoteControlCommandType) override { }
+ virtual bool overrideBackgroundPlaybackRestriction() const override { return false; }
</ins><span class="cx">
</span><span class="cx"> // EventTarget
</span><span class="cx"> virtual void refEventTarget() override { ref(); }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioMediaStreamAudioDestinationNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -46,8 +46,8 @@
</span><span class="cx"> MediaStream* stream() { return m_stream.get(); }
</span><span class="cx">
</span><span class="cx"> // AudioNode.
</span><del>- virtual void process(size_t framesToProcess);
- virtual void reset();
</del><ins>+ virtual void process(size_t framesToProcess) override;
+ virtual void reset() override;
</ins><span class="cx">
</span><span class="cx"> RealtimeMediaSource* mediaStreamSource();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioMediaStreamAudioSourceNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -47,11 +47,11 @@
</span><span class="cx"> MediaStream* mediaStream() { return m_mediaStream.get(); }
</span><span class="cx">
</span><span class="cx"> // AudioNode
</span><del>- virtual void process(size_t framesToProcess);
- virtual void reset();
</del><ins>+ virtual void process(size_t framesToProcess) override;
+ virtual void reset() override;
</ins><span class="cx">
</span><span class="cx"> // AudioSourceProviderClient
</span><del>- virtual void setFormat(size_t numberOfChannels, float sampleRate);
</del><ins>+ virtual void setFormat(size_t numberOfChannels, float sampleRate) override;
</ins><span class="cx">
</span><span class="cx"> AudioSourceProvider* audioSourceProvider() const { return m_audioSourceProvider; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioWaveShaperDSPKernelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -43,8 +43,8 @@
</span><span class="cx"> explicit WaveShaperDSPKernel(WaveShaperProcessor*);
</span><span class="cx">
</span><span class="cx"> // AudioDSPKernel
</span><del>- virtual void process(const float* source, float* dest, size_t framesToProcess);
- virtual void reset();
</del><ins>+ virtual void process(const float* source, float* dest, size_t framesToProcess) override;
+ virtual void reset() override;
</ins><span class="cx"> virtual double tailTime() const override { return 0; }
</span><span class="cx"> virtual double latencyTime() const override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketChannelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -109,17 +109,17 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // FileReaderLoaderClient functions.
</span><del>- virtual void didStartLoading();
- virtual void didReceiveData();
- virtual void didFinishLoading();
- virtual void didFail(int errorCode);
</del><ins>+ virtual void didStartLoading() override;
+ virtual void didReceiveData() override;
+ virtual void didFinishLoading() override;
+ virtual void didFail(int errorCode) override;
</ins><span class="cx">
</span><span class="cx"> using RefCounted<WebSocketChannel>::ref;
</span><span class="cx"> using RefCounted<WebSocketChannel>::deref;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void refThreadableWebSocketChannel() { ref(); }
- virtual void derefThreadableWebSocketChannel() { deref(); }
</del><ins>+ virtual void refThreadableWebSocketChannel() override { ref(); }
+ virtual void derefThreadableWebSocketChannel() override { deref(); }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> WebSocketChannel(Document*, WebSocketChannelClient*);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWorkerThreadableWebSocketChannelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h (183855 => 183856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2015-05-06 06:14:51 UTC (rev 183855)
+++ trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h 2015-05-06 06:17:02 UTC (rev 183856)
</span><span class="lines">@@ -119,8 +119,8 @@
</span><span class="cx"> using RefCounted<WorkerThreadableWebSocketChannel>::deref;
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void refThreadableWebSocketChannel() { ref(); }
- virtual void derefThreadableWebSocketChannel() { deref(); }
</del><ins>+ virtual void refThreadableWebSocketChannel() override { ref(); }
+ virtual void derefThreadableWebSocketChannel() override { deref(); }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // Bridge for Peer. Running on the worker thread.
</span></span></pre>
</div>
</div>
</body>
</html>