<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183857] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183857">183857</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2015-05-05 23:21:20 -0700 (Tue, 05 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add missing vtable override specifiers under Source/WebCore/rendering
https://bugs.webkit.org/show_bug.cgi?id=144570
Reviewed by Darin Adler.
Update virtual method overrides under Source/WebCore/rendering
which are missing the override specifiers.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::calculateBoundaries): Deleted.
* rendering/RenderFlowThread.h:
* rendering/RenderMedia.h:
(WebCore::RenderMedia::shadowControlsNeedCustomLayoutMetrics): Deleted.
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
* rendering/RenderRegionSet.h:
* rendering/RenderThemeGtk.h:
* rendering/mathml/RenderMathMLOperator.h:
* rendering/svg/RenderSVGBlock.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineTextBoxh">trunk/Source/WebCore/rendering/InlineTextBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFlowThreadh">trunk/Source/WebCore/rendering/RenderFlowThread.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMediah">trunk/Source/WebCore/rendering/RenderMedia.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnSeth">trunk/Source/WebCore/rendering/RenderMultiColumnSet.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRegionh">trunk/Source/WebCore/rendering/RenderRegion.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderRegionSeth">trunk/Source/WebCore/rendering/RenderRegionSet.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeGtkh">trunk/Source/WebCore/rendering/RenderThemeGtk.h</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLOperatorh">trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGBlockh">trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/ChangeLog 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -1,5 +1,27 @@
</span><span class="cx"> 2015-05-05 Žan Doberšek <zdobersek@igalia.com>
</span><span class="cx">
</span><ins>+ Add missing vtable override specifiers under Source/WebCore/rendering
+ https://bugs.webkit.org/show_bug.cgi?id=144570
+
+ Reviewed by Darin Adler.
+
+ Update virtual method overrides under Source/WebCore/rendering
+ which are missing the override specifiers.
+
+ * rendering/InlineTextBox.h:
+ (WebCore::InlineTextBox::calculateBoundaries): Deleted.
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderMedia.h:
+ (WebCore::RenderMedia::shadowControlsNeedCustomLayoutMetrics): Deleted.
+ * rendering/RenderMultiColumnSet.h:
+ * rendering/RenderRegion.h:
+ * rendering/RenderRegionSet.h:
+ * rendering/RenderThemeGtk.h:
+ * rendering/mathml/RenderMathMLOperator.h:
+ * rendering/svg/RenderSVGBlock.h:
+
+2015-05-05 Žan Doberšek <zdobersek@igalia.com>
+
</ins><span class="cx"> Add missing vtable override specifiers under Source/WebCore/Modules
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=144569
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineTextBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineTextBox.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -114,14 +114,14 @@
</span><span class="cx"> TextRun constructTextRun(const RenderStyle&, const FontCascade&, String, unsigned maximumLength, String* hyphenatedStringBuffer = nullptr) const;
</span><span class="cx">
</span><span class="cx"> public:
</span><del>- virtual FloatRect calculateBoundaries() const { return FloatRect(x(), y(), width(), height()); }
</del><ins>+ virtual FloatRect calculateBoundaries() const override { return FloatRect(x(), y(), width(), height()); }
</ins><span class="cx">
</span><span class="cx"> virtual LayoutRect localSelectionRect(int startPos, int endPos) const;
</span><span class="cx"> bool isSelected(int startPos, int endPos) const;
</span><span class="cx"> void selectionStartEnd(int& sPos, int& ePos);
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
</ins><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom, HitTestAction) override;
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFlowThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFlowThread.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx">
</span><span class="cx"> virtual RenderFlowThread* locateFlowThreadContainingBlock() const override { return const_cast<RenderFlowThread*>(this); }
</span><span class="cx">
</span><del>- virtual const char* renderName() const = 0;
</del><ins>+ virtual const char* renderName() const override = 0;
</ins><span class="cx">
</span><span class="cx"> // Overridden by columns/pages to set up an initial logical width of the page width even when
</span><span class="cx"> // no regions have been generated yet.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMediah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMedia.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMedia.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderMedia.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool requiresForcedStyleRecalcPropagation() const override final { return true; }
</span><span class="cx">
</span><del>- virtual bool shadowControlsNeedCustomLayoutMetrics() const { return true; }
</del><ins>+ virtual bool shadowControlsNeedCustomLayoutMetrics() const override { return true; }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutPoint columnTranslationForOffset(const LayoutUnit&) const;
</span><span class="cx">
</span><del>- void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset);
</del><ins>+ void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset) override;
</ins><span class="cx">
</span><span class="cx"> enum ColumnHitTestTranslationMode {
</span><span class="cx"> ClampHitTestTranslationToColumns,
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRegionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRegion.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRegion.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderRegion.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> class RenderRegion : public RenderBlockFlow {
</span><span class="cx"> public:
</span><del>- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
</del><ins>+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</ins><span class="cx">
</span><span class="cx"> void setFlowThreadPortionRect(const LayoutRect& rect) { m_flowThreadPortionRect = rect; }
</span><span class="cx"> LayoutRect flowThreadPortionRect() const { return m_flowThreadPortionRect; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderRegionSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderRegionSet.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderRegionSet.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderRegionSet.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> private:
</span><span class="cx"> virtual void installFlowThread() override final;
</span><span class="cx">
</span><del>- virtual const char* renderName() const = 0;
</del><ins>+ virtual const char* renderName() const override = 0;
</ins><span class="cx">
</span><span class="cx"> virtual bool isRenderRegionSet() const override final { return true; }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> virtual bool paintSearchField(const RenderObject&, const PaintInfo&, const IntRect&) override;
</span><span class="cx">
</span><span class="cx"> virtual void adjustSearchFieldResultsButtonStyle(StyleResolver&, RenderStyle&, Element*) const override;
</span><del>- virtual bool paintSearchFieldResultsButton(const RenderObject&, const PaintInfo&, const IntRect&);
</del><ins>+ virtual bool paintSearchFieldResultsButton(const RenderObject&, const PaintInfo&, const IntRect&) override;
</ins><span class="cx">
</span><span class="cx"> virtual void adjustSearchFieldCancelButtonStyle(StyleResolver&, RenderStyle&, Element*) const override;
</span><span class="cx"> virtual bool paintSearchFieldCancelButton(const RenderObject&, const PaintInfo&, const IntRect&) override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLOperatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void updateStyle() override final;
</span><span class="cx">
</span><del>- virtual void paint(PaintInfo&, const LayoutPoint&);
</del><ins>+ virtual void paint(PaintInfo&, const LayoutPoint&) override;
</ins><span class="cx">
</span><span class="cx"> void updateTokenContent(const String& operatorString);
</span><span class="cx"> virtual void updateTokenContent() override final;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGBlockh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h (183856 => 183857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2015-05-06 06:17:02 UTC (rev 183856)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGBlock.h 2015-05-06 06:21:20 UTC (rev 183857)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool isRenderSVGBlock() const override final { return true; }
</span><span class="cx">
</span><del>- virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const;
</del><ins>+ virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const override;
</ins><span class="cx">
</span><span class="cx"> virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override final;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>