<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183794] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183794">183794</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-05-04 21:29:30 -0700 (Mon, 04 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix assertions in WK1 tests after <a href="http://trac.webkit.org/projects/webkit/changeset/183777">r183777</a>.
Source/WebCore:
Two issues with the original change:
If not in compositing mode, we shouldn't schedule layer flushes, since
Document::documentWillSuspendForPageCache() only only calls cancelCompositingLayerUpdate()
if in compositing mode.
Second, RenderLayerCompositor::rootBackgroundTransparencyChanged() never stored the
new color, resulting in too many triggered compositing updates.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
LayoutTests:
Behavior difference with the change to RenderLayerCompositor::rootBackgroundTransparencyChanged().
* platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2tileddrawingbackgroundtransparencytoggleexpectedtxt">trunk/LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183793 => 183794)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-05 04:24:23 UTC (rev 183793)
+++ trunk/LayoutTests/ChangeLog 2015-05-05 04:29:30 UTC (rev 183794)
</span><span class="lines">@@ -1,3 +1,11 @@
</span><ins>+2015-05-04 Simon Fraser <simon.fraser@apple.com>
+
+ Fix assertions in WK1 tests after r183777.
+
+ Behavior difference with the change to RenderLayerCompositor::rootBackgroundTransparencyChanged().
+
+ * platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt:
+
</ins><span class="cx"> 2015-05-04 Doug Russell <d_russell@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2tileddrawingbackgroundtransparencytoggleexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt (183793 => 183794)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt 2015-05-05 04:24:23 UTC (rev 183793)
+++ trunk/LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt 2015-05-05 04:29:30 UTC (rev 183794)
</span><span class="lines">@@ -46,7 +46,6 @@
</span><span class="cx"> (GraphicsLayer
</span><span class="cx"> (bounds 785.00 648.00)
</span><span class="cx"> (contentsOpaque 1)
</span><del>- (backgroundColor #CCCCCC)
</del><span class="cx"> (tile cache coverage 0, 0 785 x 648)
</span><span class="cx"> (tile size 512 x 512)
</span><span class="cx"> (top left tile 0, 0 tiles grid 2 x 2)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183793 => 183794)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-05 04:24:23 UTC (rev 183793)
+++ trunk/Source/WebCore/ChangeLog 2015-05-05 04:29:30 UTC (rev 183794)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-05-04 Simon Fraser <simon.fraser@apple.com>
+
+ Fix assertions in WK1 tests after r183777.
+
+ Two issues with the original change:
+
+ If not in compositing mode, we shouldn't schedule layer flushes, since
+ Document::documentWillSuspendForPageCache() only only calls cancelCompositingLayerUpdate()
+ if in compositing mode.
+
+ Second, RenderLayerCompositor::rootBackgroundTransparencyChanged() never stored the
+ new color, resulting in too many triggered compositing updates.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
+
</ins><span class="cx"> 2015-05-04 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> RenderWidget::setWidgetGeometry() can end up destroying *this*.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (183793 => 183794)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-05-05 04:24:23 UTC (rev 183793)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-05-05 04:29:30 UTC (rev 183794)
</span><span class="lines">@@ -3216,10 +3216,15 @@
</span><span class="cx">
</span><span class="cx"> void RenderLayerCompositor::rootBackgroundTransparencyChanged()
</span><span class="cx"> {
</span><ins>+ if (!inCompositingMode())
+ return;
+
</ins><span class="cx"> Color documentBackgroundColor = m_renderView.frameView().documentBackgroundColor();
</span><span class="cx"> if (m_lastDocumentBackgroundColor.isValid() && documentBackgroundColor.hasAlpha() == m_lastDocumentBackgroundColor.hasAlpha())
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ m_lastDocumentBackgroundColor = documentBackgroundColor;
+
</ins><span class="cx"> // FIXME: We should do something less expensive than a full layer rebuild.
</span><span class="cx"> setCompositingLayersNeedRebuild();
</span><span class="cx"> scheduleCompositingLayerUpdate();
</span></span></pre>
</div>
</div>
</body>
</html>