<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183680] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183680">183680</a></dd>
<dt>Author</dt> <dd>mrobinson@webkit.org</dd>
<dt>Date</dt> <dd>2015-05-01 10:50:49 -0700 (Fri, 01 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Freetype] Properly support synthetic oblique in vertical text
https://bugs.webkit.org/show_bug.cgi?id=144492
Reviewed by Sergio Villar Senin.
Source/WebCore:
No new tests. Covered by existing tests.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
oblique for vertical text.
LayoutTests:
* platform/gtk/TestExpectations: Unskip passing tests.
* platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
* platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfreetypeFontPlatformDataFreeTypecpp">trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformgtkfasttextinternationalsynthesizeditalicverticallatinexpectedpng">trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasttextinternationalsynthesizeditalicverticallatinexpectedtxt">trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183679 => 183680)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 17:50:49 UTC (rev 183680)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-05-01 Martin Robinson <mrobinson@igalia.com>
+
+ [Freetype] Properly support synthetic oblique in vertical text
+ https://bugs.webkit.org/show_bug.cgi?id=144492
+
+ Reviewed by Sergio Villar Senin.
+
+ * platform/gtk/TestExpectations: Unskip passing tests.
+ * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
+ * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
+
</ins><span class="cx"> 2015-05-01 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix text track language selection logic
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (183679 => 183680)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-01 17:50:49 UTC (rev 183680)
</span><span class="lines">@@ -424,9 +424,6 @@
</span><span class="cx"> # No concept of secure text input
</span><span class="cx"> Bug(GTK) editing/secure-input [ Failure ]
</span><span class="cx">
</span><del>-# Synthesized italics not supported
-webkit.org/b/117975 fast/text/international/synthesized-italic-vertical-latin.html [ Skip ]
-
</del><span class="cx"> # crypto.subtle is not yet enabled, but digest algorithms are already implemented
</span><span class="cx"> # and their tests are whitelisted
</span><span class="cx"> webkit.org/b/133122 crypto/subtle [ Skip ]
</span><span class="lines">@@ -2005,8 +2002,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/118221 fast/text/complex-first-glyph-with-initial-advance.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/118222 fast/text/international/synthesized-italic-vertical.html [ ImageOnlyFailure ]
-
</del><span class="cx"> webkit.org/b/118416 storage/websql/sql-error-codes.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # May take too long on the bots.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasttextinternationalsynthesizeditalicverticallatinexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformgtkfasttextinternationalsynthesizeditalicverticallatinexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt (0 => 183680)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt 2015-05-01 17:50:49 UTC (rev 183680)
</span><span class="lines">@@ -0,0 +1,8 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 93x600
+ RenderBlock {HTML} at (0,0) size 93x600
+ RenderBody {BODY} at (30,8) size 33x584
+ RenderBlock {P} at (0,0) size 33x584
+ RenderText {#text} at (0,0) size 33x376
+ text run at (0,0) width 376: "ABC\x{4E39}\x{7FBD} \x{4EAE}\x{4ECB}ABC\x{4E39}\x{7FBD} \x{4EAE}\x{4ECB}"
</ins><span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183679 => 183680)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 17:50:49 UTC (rev 183680)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-05-01 Martin Robinson <mrobinson@igalia.com>
+
+ [Freetype] Properly support synthetic oblique in vertical text
+ https://bugs.webkit.org/show_bug.cgi?id=144492
+
+ Reviewed by Sergio Villar Senin.
+
+ No new tests. Covered by existing tests.
+
+ * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
+ (WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
+ oblique for vertical text.
+
</ins><span class="cx"> 2015-05-01 Joanmarie Diggs <jdiggs@igalia.com>
</span><span class="cx">
</span><span class="cx"> AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfreetypeFontPlatformDataFreeTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp (183679 => 183680)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2015-05-01 17:50:49 UTC (rev 183680)
</span><span class="lines">@@ -339,8 +339,9 @@
</span><span class="cx">
</span><span class="cx"> if (syntheticOblique()) {
</span><span class="cx"> static const float syntheticObliqueSkew = -tanf(14 * acosf(0) / 90);
</span><del>- cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
- cairo_matrix_multiply(&fontMatrix, &skew, &fontMatrix);
</del><ins>+ static const cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
+ static const cairo_matrix_t verticalSkew = {1, -syntheticObliqueSkew, 0, 1, 0, 0};
+ cairo_matrix_multiply(&fontMatrix, m_orientation == Vertical ? &verticalSkew : &skew, &fontMatrix);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_horizontalOrientationMatrix = fontMatrix;
</span></span></pre>
</div>
</div>
</body>
</html>