<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183703] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183703">183703</a></dd>
<dt>Author</dt> <dd>roger_fong@apple.com</dd>
<dt>Date</dt> <dd>2015-05-01 17:47:04 -0700 (Fri, 01 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Media control volume slider should be vertical to avoid flickering issues.
https://bugs.webkit.org/show_bug.cgi?id=144496.
<rdar://problem/20451328>
Reviewed by Darin Adler.
* Modules/mediacontrols/mediaControlsApple.css:
Resize and reposition the volume box so that it does not have to rotated via a transform.
(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-panel .volume-box): Also set overflow: hidden so we can't interact
with the volume slider while the volume box is hidden.
(audio::-webkit-media-controls-panel .volume-box:active):
Rotate and position the volume slider via transforms. Make sure it's not transformed in the fullscreen controls.
(video::-webkit-media-controls-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183702 => 183703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-02 00:39:37 UTC (rev 183702)
+++ trunk/Source/WebCore/ChangeLog 2015-05-02 00:47:04 UTC (rev 183703)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-05-01 Roger Fong <roger_fong@apple.com>
+
+ Media control volume slider should be vertical to avoid flickering issues.
+ https://bugs.webkit.org/show_bug.cgi?id=144496.
+ <rdar://problem/20451328>
+
+ Reviewed by Darin Adler.
+
+ * Modules/mediacontrols/mediaControlsApple.css:
+ Resize and reposition the volume box so that it does not have to rotated via a transform.
+ (audio::-webkit-media-controls-panel):
+ (audio::-webkit-media-controls-panel .volume-box): Also set overflow: hidden so we can't interact
+ with the volume slider while the volume box is hidden.
+ (audio::-webkit-media-controls-panel .volume-box:active):
+ Rotate and position the volume slider via transforms. Make sure it's not transformed in the fullscreen controls.
+ (video::-webkit-media-controls-volume-slider):
+ (video:-webkit-full-screen::-webkit-media-controls-volume-slider):
+
</ins><span class="cx"> 2015-05-01 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Expand test infrastructure to support scrolling tests (Part 4): Scroll Snap Support
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (183702 => 183703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-05-02 00:39:37 UTC (rev 183702)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-05-02 00:47:04 UTC (rev 183703)
</span><span class="lines">@@ -213,16 +213,13 @@
</span><span class="cx"> audio::-webkit-media-controls-panel .volume-box {
</span><span class="cx"> position: absolute;
</span><span class="cx"> box-sizing: border-box;
</span><del>- height: 63px;
- bottom: 0;
- left: 0;
</del><ins>+ width: 63px;
+ bottom: 5px;
+ left: -25px;
</ins><span class="cx">
</span><del>- -webkit-clip-path: inset(20px 20px 20px 20px round 0px 4px 4px 0px);
- -webkit-transform: rotate(-90deg) translateY(-51.5px) translateX(31.5px);
-
</del><ins>+ -webkit-clip-path: inset(20px 20px 20px 20px round 4px 4px 0px 0px);
</ins><span class="cx"> background-color: transparent;
</span><del>- border-bottom-right-radius: 4px;
- border-top-right-radius: 4px;
</del><ins>+ overflow: hidden;
</ins><span class="cx">
</span><span class="cx"> display: -webkit-flex;
</span><span class="cx"> -webkit-flex-direction: row;
</span><span class="lines">@@ -230,8 +227,8 @@
</span><span class="cx"> -webkit-justify-content: flex-end;
</span><span class="cx">
</span><span class="cx"> opacity: 0;
</span><del>- /* make zero width (rather than display:none) for AX and FKA */
- width: 0; /* will become 101px when shown */
</del><ins>+ /* make zero height (rather than display:none) for AX and FKA */
+ height: 0px; /* will become 116px when shown */
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -274,7 +271,7 @@
</span><span class="cx"> audio::-webkit-media-controls-panel .volume-box:active {
</span><span class="cx"> opacity: 1;
</span><span class="cx"> /* resize to usable amount (rather than display:none) for AX and FKA */
</span><del>- width: 116px;
</del><ins>+ height: 116px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> audio::-webkit-media-controls-volume-slider,
</span><span class="lines">@@ -282,13 +279,16 @@
</span><span class="cx"> -webkit-appearance: none !important;
</span><span class="cx"> box-sizing: border-box !important;
</span><span class="cx"> height: 9px !important;
</span><ins>+ min-width: 64px !important;
</ins><span class="cx"> width: 64px !important;
</span><span class="cx"> padding: 0 !important;
</span><del>- margin-right: 30px !important;
</del><ins>+ margin: 0 !important;
</ins><span class="cx">
</span><span class="cx"> background-color: transparent !important;
</span><span class="cx"> background-size: 100% 100%;
</span><span class="cx"> background-repeat: no-repeat;
</span><ins>+ -webkit-transform-origin: 0 0;
+ -webkit-transform: rotate(-90deg) translateY(28px) translateX(-40px);
</ins><span class="cx"> mix-blend-mode: plus-lighter;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -669,8 +669,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> video:-webkit-full-screen::-webkit-media-controls-volume-slider {
</span><ins>+ -webkit-transform: none;
</ins><span class="cx"> background-color: transparent;
</span><ins>+ min-width: 60px !important;
</ins><span class="cx"> width: 60px !important;
</span><ins>+ height: 9px !important;
</ins><span class="cx"> margin: 0 !important;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>