<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[183682] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/183682">183682</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2015-05-01 11:19:58 -0700 (Fri, 01 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add API to disable meta refreshes.
<rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: loader/meta-refresh-disabled.html
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Bail early if Settings have meta refreshes disabled.
* page/Settings.in:
Source/WebKit/mac:
Add a preference to enable/disable meta refreshes, enabled by default.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setMetaRefreshEnabled:]):
(-[WebPreferences metaRefreshEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Add a preference to enable/disable meta refreshes, enabled by default.
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMetaRefreshEnabled):
(WKPreferencesGetMetaRefreshEnabled):
(WKPreferencesGetIgnoreViewportScalingConstraints): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
LayoutTests:
* loader/meta-refresh-disabled-expected.txt: Added.
* loader/meta-refresh-disabled.html: Added.
* loader/resources/notify-done.html: Added.
* platform/win/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsloadermetarefreshdisabledexpectedtxt">trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestsloadermetarefreshdisabledhtml">trunk/LayoutTests/loader/meta-refresh-disabled.html</a></li>
<li><a href="#trunkLayoutTestsloaderresourcesnotifydonehtml">trunk/LayoutTests/loader/resources/notify-done.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-05-01 Brady Eidson <beidson@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ * loader/meta-refresh-disabled-expected.txt: Added.
+ * loader/meta-refresh-disabled.html: Added.
+ * loader/resources/notify-done.html: Added.
+ * platform/win/TestExpectations:
+
</ins><span class="cx"> 2015-05-01 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed gardening for WebKitGTK+
</span></span></pre></div>
<a id="trunkLayoutTestsloadermetarefreshdisabledexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt (0 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+This test makes sure the preference to disable meta refreshes works as expected.
+You should see this text when the test is done.
+If you do not see this text, and instead you see a blank page, then the redirect happened, which it should not have.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsloadermetarefreshdisabledhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/meta-refresh-disabled.html (0 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/meta-refresh-disabled.html (rev 0)
+++ trunk/LayoutTests/loader/meta-refresh-disabled.html 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+<head>
+<script>
+if (window.testRunner) {
+ testRunner.overridePreference("WebKitMetaRefreshEnabled", "0");
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+// This bizarre practice of continuously delaying notifyDone() by multiple 0-delay timers
+// is meant to work around a few 0-delays in the meta refresh process.
+// The refresh itself is on a timer, and then the policy delegate's reply might be on a timer.
+// The goal here is to give a successfully scheduled meta refresh long enough to occur,
+// but to not also wait an arbitrary amount of clock time before concluding the test.
+function notifyDoneDelayer(iteration)
+{
+ if (iteration == 10) {
+ if (window.testRunner)
+ testRunner.notifyDone();
+ else
+ document.body.innerHTML = "This test can only be run under DRT/WKTR";
+ return;
+ }
+
+ setTimeout("notifyDoneDelayer(" + ++iteration + ");", 0);
+}
+
+function loaded()
+{
+ setTimeout("notifyDoneDelayer(1);", 0);
+}
+
+</script>
+<meta http-equiv="refresh" content="0;url=resources/notify-done.html">
+</head>
+<body onload="loaded();">
+This test makes sure the preference to disable meta refreshes works as expected.<br>
+You should see this text when the test is done.<br>
+If you do not see this text, and instead you see a blank page, then the redirect happened, which it should not have.<br>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsloaderresourcesnotifydonehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/loader/resources/notify-done.html (0 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/loader/resources/notify-done.html (rev 0)
+++ trunk/LayoutTests/loader/resources/notify-done.html 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+<script>
+if (window.testRunner)
+ testRunner.notifyDone();
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -3083,6 +3083,9 @@
</span><span class="cx"> [ Release ] inspector-protocol/layers/layers-for-node.html [ Skip ] # Timeouts
</span><span class="cx"> [ Release ] inspector-protocol/layers/layers-generated-content.html [ Skip ] # Timeouts
</span><span class="cx">
</span><ins>+# Windows doesn't have API for disabling meta refresh
+loader/meta-refresh-disabled.html [ Skip ]
+
</ins><span class="cx"> # Started failing recently.
</span><span class="cx"> webkit.org/b/143275 accessibility/aria-hidden-hides-all-elements.html [ Pass Failure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-05-01 Brady Eidson <beidson@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Test: loader/meta-refresh-disabled.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::processHttpEquiv): Bail early if Settings have meta refreshes disabled.
+ * page/Settings.in:
+
</ins><span class="cx"> 2015-05-01 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [Freetype] Properly support synthetic oblique in vertical text
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -3002,6 +3002,9 @@
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case HTTPHeaderName::Refresh: {
</span><ins>+ if (page() && !page()->settings().metaRefreshEnabled())
+ break;
+
</ins><span class="cx"> double delay;
</span><span class="cx"> String urlString;
</span><span class="cx"> if (frame && parseHTTPRefresh(content, true, delay, urlString)) {
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/page/Settings.in 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -241,3 +241,4 @@
</span><span class="cx">
</span><span class="cx"> newBlockInsideInlineModelEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
</span><span class="cx">
</span><ins>+metaRefreshEnabled initial=true
</ins></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-05-01 Brady Eidson <beidson@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a preference to enable/disable meta refreshes, enabled by default.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setMetaRefreshEnabled:]):
+ (-[WebPreferences metaRefreshEnabled]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2015-04-30 Jon Davis <jond@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: console should show an icon for console.info() messages
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -172,6 +172,7 @@
</span><span class="cx"> #define WebKitDebugFullPageZoomPreferenceKey @"WebKitDebugFullPageZoomPreferenceKey"
</span><span class="cx"> #define WebKitMinimumZoomFontSizePreferenceKey @"WebKitMinimumZoomFontSizePreferenceKey"
</span><span class="cx"> #define WebKitAntialiasedFontDilationEnabledKey @"AntialiasedFontDilationEnabled"
</span><ins>+#define WebKitMetaRefreshEnabledPreferenceKey @"WebKitMetaRefreshEnabled"
</ins><span class="cx">
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> #define WebKitStandalonePreferenceKey @"WebKitStandalonePreferenceKey"
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -444,6 +444,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitPluginsEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitDatabasesEnabledPreferenceKey,
</span><ins>+ [NSNumber numberWithBool:YES], WebKitMetaRefreshEnabledPreferenceKey,
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitStorageTrackerEnabledPreferenceKey,
</span><span class="cx"> #endif
</span><span class="lines">@@ -2496,6 +2497,16 @@
</span><span class="cx"> return [self _boolValueForKey:WebKitAntialiasedFontDilationEnabledKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)setMetaRefreshEnabled:(BOOL)enabled
+{
+ [self _setBoolValue:enabled forKey:WebKitMetaRefreshEnabledPreferenceKey];
+}
+
+- (BOOL)metaRefreshEnabled
+{
+ return [self _boolValueForKey:WebKitMetaRefreshEnabledPreferenceKey];
+}
+
</ins><span class="cx"> - (BOOL)javaScriptMarkupEnabled
</span><span class="cx"> {
</span><span class="cx"> return [self _boolValueForKey:WebKitJavaScriptMarkupEnabledPreferenceKey];
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -439,6 +439,9 @@
</span><span class="cx"> - (void)setAntialiasedFontDilationEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)antialiasedFontDilationEnabled;
</span><span class="cx">
</span><ins>+- (void)setMetaRefreshEnabled:(BOOL)flag;
+- (BOOL)metaRefreshEnabled;
+
</ins><span class="cx"> @property (nonatomic) BOOL javaScriptMarkupEnabled;
</span><span class="cx">
</span><span class="cx"> #if TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < 80000
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -2330,6 +2330,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> settings.setPlugInSnapshottingEnabled([preferences plugInSnapshottingEnabled]);
</span><ins>+ settings.setMetaRefreshEnabled([preferences metaRefreshEnabled]);
</ins><span class="cx">
</span><span class="cx"> settings.setFixedPositionCreatesStackingContext(true);
</span><span class="cx"> #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-05-01 Brady Eidson <beidson@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a preference to enable/disable meta refreshes, enabled by default.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetMetaRefreshEnabled):
+ (WKPreferencesGetMetaRefreshEnabled):
+ (WKPreferencesGetIgnoreViewportScalingConstraints): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2015-05-01 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove network process load serialization code
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -196,6 +196,7 @@
</span><span class="cx"> macro(LongMousePressEnabled, longMousePressEnabled, Bool, bool, false) \
</span><span class="cx"> macro(NewBlockInsideInlineModelEnabled, newBlockInsideInlineModelEnabled, Bool, bool, false) \
</span><span class="cx"> macro(AntialiasedFontDilationEnabled, antialiasedFontDilationEnabled, Bool, bool, true) \
</span><ins>+ macro(MetaRefreshEnabled, metaRefreshEnabled, Bool, bool, true) \
</ins><span class="cx">
</span><span class="cx"> #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
</span><span class="cx"> macro(IncrementalRenderingSuppressionTimeout, incrementalRenderingSuppressionTimeout, Double, double, 5) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1356,3 +1356,13 @@
</span><span class="cx"> {
</span><span class="cx"> return toImpl(preferencesRef)->ignoreViewportScalingConstraints();
</span><span class="cx"> }
</span><ins>+
+void WKPreferencesSetMetaRefreshEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setMetaRefreshEnabled(enabled);
+}
+
+bool WKPreferencesGetMetaRefreshEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->metaRefreshEnabled();
+}
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -369,6 +369,10 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetJavaScriptRuntimeFlags(WKPreferencesRef preferences, WKJavaScriptRuntimeFlagSet javascriptRuntimeFlagSet);
</span><span class="cx"> WK_EXPORT WKJavaScriptRuntimeFlagSet WKPreferencesGetJavaScriptRuntimeFlags(WKPreferencesRef preferences);
</span><span class="cx">
</span><ins>+// Defaults to true.
+WK_EXPORT void WKPreferencesSetMetaRefreshEnabled(WKPreferencesRef preferences, bool enabled);
+WK_EXPORT bool WKPreferencesGetMetaRefreshEnabled(WKPreferencesRef preferences);
+
</ins><span class="cx"> #ifdef __cplusplus
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -206,7 +206,8 @@
</span><span class="cx"> macro(WebKitShouldRespectImageOrientation, ShouldRespectImageOrientation, shouldRespectImageOrientation) \
</span><span class="cx"> macro(WebKitEnableCaretBrowsing, CaretBrowsingEnabled, caretBrowsingEnabled) \
</span><span class="cx"> macro(WebKitDisplayImagesKey, LoadsImagesAutomatically, loadsImagesAutomatically) \
</span><del>- macro(WebKitMediaStreamEnabled, MediaStreamEnabled, mediaStreamEnabled)
</del><ins>+ macro(WebKitMediaStreamEnabled, MediaStreamEnabled, mediaStreamEnabled) \
+ macro(WebKitMetaRefreshEnabled, MetaRefreshEnabled, metaRefreshEnabled)
</ins><span class="cx">
</span><span class="cx"> #define OVERRIDE_PREFERENCE_AND_SET_IN_EXISTING_PAGES(TestRunnerName, SettingsName, WebPreferencesName) \
</span><span class="cx"> if (preference == #TestRunnerName) { \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -2757,6 +2757,8 @@
</span><span class="cx"> settings.setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
</span><span class="cx"> settings.setSpatialNavigationEnabled(store.getBoolValueForKey(WebPreferencesKey::spatialNavigationEnabledKey()));
</span><span class="cx">
</span><ins>+ settings.setMetaRefreshEnabled(store.getBoolValueForKey(WebPreferencesKey::metaRefreshEnabledKey()));
+
</ins><span class="cx"> DatabaseManager::singleton().setIsAvailable(store.getBoolValueForKey(WebPreferencesKey::databasesEnabledKey()));
</span><span class="cx">
</span><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Tools/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-05-01 Brady Eidson <beidson@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
+
</ins><span class="cx"> 2015-05-01 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Provide a runtime flag to run-webkit-tests that shows the test view
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (183681 => 183682)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-05-01 18:19:58 UTC (rev 183682)
</span><span class="lines">@@ -928,6 +928,8 @@
</span><span class="cx"> [preferences setLoadsSiteIconsIgnoringImageLoadingPreference:NO];
</span><span class="cx"> [preferences setFrameFlatteningEnabled:NO];
</span><span class="cx"> [preferences setSpatialNavigationEnabled:NO];
</span><ins>+ [preferences setMetaRefreshEnabled:YES];
+
</ins><span class="cx"> if (persistentUserStyleSheetLocation) {
</span><span class="cx"> [preferences setUserStyleSheetLocation:[NSURL URLWithString:(NSString *)(persistentUserStyleSheetLocation.get())]];
</span><span class="cx"> [preferences setUserStyleSheetEnabled:YES];
</span></span></pre>
</div>
</div>
</body>
</html>