<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182902] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182902">182902</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-16 12:47:41 -0700 (Thu, 16 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console
https://bugs.webkit.org/show_bug.cgi?id=143813
Reviewed by Brian Burg.
Always give DOM Nodes a "Log Element" context menu to log it to the console.
This will give a $n reference, and is a convenient alternative to $0 or
the now removed $1-$9.
* Localizations/en.lproj/localizedStrings.js:
New "Log Element" and "Selected Element" strings.
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
(WebInspector.DOMTreeOutline.prototype._contextMenuEventFired):
(WebInspector.DOMTreeOutline.prototype._updateModifiedNodes):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu.revealElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):
Always include the "Log Element" context menu/
* UserInterface/Views/FormattedValue.js:
(WebInspector.FormattedValue.createElementForNode):
This uses all the defaults.
* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
This enables all the extra behavior.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsFormattedValuejs">trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (182901 => 182902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-16 19:39:50 UTC (rev 182901)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-16 19:47:41 UTC (rev 182902)
</span><span class="lines">@@ -1,5 +1,36 @@
</span><span class="cx"> 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console
+ https://bugs.webkit.org/show_bug.cgi?id=143813
+
+ Reviewed by Brian Burg.
+
+ Always give DOM Nodes a "Log Element" context menu to log it to the console.
+ This will give a $n reference, and is a convenient alternative to $0 or
+ the now removed $1-$9.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ New "Log Element" and "Selected Element" strings.
+
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline):
+ (WebInspector.DOMTreeOutline.prototype._contextMenuEventFired):
+ (WebInspector.DOMTreeOutline.prototype._updateModifiedNodes):
+ (WebInspector.DOMTreeOutline.prototype._populateContextMenu.revealElement):
+ (WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
+ (WebInspector.DOMTreeOutline.prototype._populateContextMenu):
+ Always include the "Log Element" context menu/
+
+ * UserInterface/Views/FormattedValue.js:
+ (WebInspector.FormattedValue.createElementForNode):
+ This uses all the defaults.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WebInspector.DOMTreeContentView):
+ This enables all the extra behavior.
+
+2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Remove unnecessary intermediate object from DOMTreeOutline
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=143811
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (182901 => 182902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-04-16 19:39:50 UTC (rev 182901)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-04-16 19:47:41 UTC (rev 182902)
</span><span class="lines">@@ -295,6 +295,7 @@
</span><span class="cx"> localizedStrings["Local Variables"] = "Local Variables";
</span><span class="cx"> localizedStrings["Located at %s"] = "Located at %s";
</span><span class="cx"> localizedStrings["Location"] = "Location";
</span><ins>+localizedStrings["Log Element"] = "Log Element";
</ins><span class="cx"> localizedStrings["Log Message"] = "Log Message";
</span><span class="cx"> localizedStrings["Log Symbol"] = "Log Symbol";
</span><span class="cx"> localizedStrings["Log Value"] = "Log Value";
</span><span class="lines">@@ -414,6 +415,7 @@
</span><span class="cx"> localizedStrings["Secure"] = "Secure";
</span><span class="cx"> localizedStrings["Security Issue"] = "Security Issue";
</span><span class="cx"> localizedStrings["Selected"] = "Selected";
</span><ins>+localizedStrings["Selected Element"] = "Selected Element";
</ins><span class="cx"> localizedStrings["Selected Item"] = "Selected Item";
</span><span class="cx"> localizedStrings["Selected Items"] = "Selected Items";
</span><span class="cx"> localizedStrings["Selected Range"] = "Selected Range";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (182901 => 182902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-04-16 19:39:50 UTC (rev 182901)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-04-16 19:47:41 UTC (rev 182902)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> this.element.classList.add(WebInspector.DOMTreeContentView.StyleClassName);
</span><span class="cx"> this.element.addEventListener("click", this._mouseWasClicked.bind(this), false);
</span><span class="cx">
</span><del>- this._domTreeOutline = new WebInspector.DOMTreeOutline(true, true, false);
</del><ins>+ this._domTreeOutline = new WebInspector.DOMTreeOutline(true, true, true);
</ins><span class="cx"> this._domTreeOutline.addEventListener(WebInspector.DOMTreeOutline.Event.SelectedNodeChanged, this._selectedNodeDidChange, this);
</span><span class="cx"> this._domTreeOutline.wireToDomAgent();
</span><span class="cx"> this.element.appendChild(this._domTreeOutline.element);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (182901 => 182902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-04-16 19:39:50 UTC (rev 182901)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-04-16 19:47:41 UTC (rev 182902)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.DOMTreeOutline = class DOMTreeOutline extends WebInspector.TreeOutline
</span><span class="cx"> {
</span><del>- constructor(omitRootDOMNode, selectEnabled, showInElementsPanelEnabled)
</del><ins>+ constructor(omitRootDOMNode, selectEnabled, excludeRevealElementContextMenu)
</ins><span class="cx"> {
</span><span class="cx"> var element = document.createElement("ol");
</span><span class="cx">
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx">
</span><span class="cx"> this._includeRootDOMNode = !omitRootDOMNode;
</span><span class="cx"> this._selectEnabled = selectEnabled;
</span><del>- this._showInElementsPanelEnabled = showInElementsPanelEnabled;
</del><ins>+ this._excludeRevealElementContextMenu = excludeRevealElementContextMenu;
</ins><span class="cx"> this._rootDOMNode = null;
</span><span class="cx"> this._selectedDOMNode = null;
</span><span class="cx">
</span><span class="lines">@@ -483,16 +483,27 @@
</span><span class="cx">
</span><span class="cx"> _populateContextMenu(contextMenu, domNode)
</span><span class="cx"> {
</span><del>- if (!this._showInElementsPanelEnabled)
- return;
-
</del><span class="cx"> function revealElement()
</span><span class="cx"> {
</span><span class="cx"> WebInspector.domTreeManager.inspectElement(domNode.id);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ function logElement()
+ {
+ WebInspector.RemoteObject.resolveNode(domNode, "console", function(remoteObject) {
+ if (!remoteObject)
+ return;
+ var text = WebInspector.UIString("Selected Element");
+ WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, remoteObject);
+ });
+ }
+
</ins><span class="cx"> contextMenu.appendSeparator();
</span><del>- contextMenu.appendItem(WebInspector.UIString("Reveal in DOM Tree"), revealElement);
</del><ins>+
+ if (!this._excludeRevealElementContextMenu)
+ contextMenu.appendItem(WebInspector.UIString("Reveal in DOM Tree"), revealElement);
+
+ contextMenu.appendItem(WebInspector.UIString("Log Element"), logElement);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _showShadowDOMSettingChanged(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsFormattedValuejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js (182901 => 182902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js 2015-04-16 19:39:50 UTC (rev 182901)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js 2015-04-16 19:47:41 UTC (rev 182902)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var treeOutline = new WebInspector.DOMTreeOutline(false, false, true);
</del><ins>+ var treeOutline = new WebInspector.DOMTreeOutline;
</ins><span class="cx"> treeOutline.setVisible(true);
</span><span class="cx"> treeOutline.rootDOMNode = WebInspector.domTreeManager.nodeForId(nodeId);
</span><span class="cx"> if (!treeOutline.children[0].hasChildren)
</span></span></pre>
</div>
</div>
</body>
</html>