<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182870] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182870">182870</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-15 16:21:47 -0700 (Wed, 15 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: InspectorTest frontend console methods redirected to the frontend are wrong
https://bugs.webkit.org/show_bug.cgi?id=143801
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-04-15
Reviewed by Brian Burg.
* UserInterface/Base/Test.js:
(InspectorTest.evaluateInPage):
Properly if check for the existence of an agent.
(global):
Properly hook up console redirect handlers so they
will output the right type and arguments strings.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseTestjs">trunk/Source/WebInspectorUI/UserInterface/Base/Test.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (182869 => 182870)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-15 23:21:42 UTC (rev 182869)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-15 23:21:47 UTC (rev 182870)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2015-04-15 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: InspectorTest frontend console methods redirected to the frontend are wrong
+ https://bugs.webkit.org/show_bug.cgi?id=143801
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/Test.js:
+ (InspectorTest.evaluateInPage):
+ Properly if check for the existence of an agent.
+
+ (global):
+ Properly hook up console redirect handlers so they
+ will output the right type and arguments strings.
+
+2015-04-15 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Handle all possible Console message Source types in IssueMessage
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=143803
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseTestjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Test.js (182869 => 182870)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2015-04-15 23:21:42 UTC (rev 182869)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2015-04-15 23:21:47 UTC (rev 182870)
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx"> {
</span><span class="cx"> // If we load this page outside of the inspector, or hit an early error when loading
</span><span class="cx"> // the test frontend, then defer evaluating the commands (indefinitely in the former case).
</span><del>- if (!RuntimeAgent) {
</del><ins>+ if (!window.RuntimeAgent) {
</ins><span class="cx"> this._originalConsoleMethods["error"]("Tried to evaluate in test page, but connection not yet established:", codeString);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -265,10 +265,16 @@
</span><span class="cx"> // Catch syntax errors, type errors, and other exceptions.
</span><span class="cx"> window.onerror = InspectorTest.reportUncaughtException.bind(InspectorTest);
</span><span class="cx">
</span><del>-for (var logType of ["log", "error", "info"]) {
- // Redirect console methods to log messages into the test page's DOM.
- InspectorTest._originalConsoleMethods[logType] = console[logType].bind(console);
- console[logType] = function() {
- InspectorTest.addResult(logType.toUpperCase() + ": " + Array.from(arguments).toString());
- };
-}
</del><ins>+// Redirect frontend console methods to log messages into the test result.
+(function() {
+ function createProxyConsoleHandler(type) {
+ return function() {
+ InspectorTest.addResult(type + ": " + Array.from(arguments).join(" "));
+ };
+ }
+
+ for (var type of ["log", "error", "info"]) {
+ InspectorTest._originalConsoleMethods[type] = console[type].bind(console);
+ console[type] = createProxyConsoleHandler(type.toUpperCase());
+ }
+})();
</ins></span></pre>
</div>
</div>
</body>
</html>