<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182785] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182785">182785</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-14 01:37:03 -0700 (Tue, 14 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/182743">r182743</a> - Fixed position element is truncated if moved onscreen by a transform
https://bugs.webkit.org/show_bug.cgi?id=143655
Source/WebCore:
rdar://problem/15020044
Reviewed by Darin Adler.
Our "don't do layout if transform changes" code was too aggressive.
If an element changes between having a transform and not having one, we
really need to do a layout since so much else depends on transforms. In
this particular case, we clip position:fixed elements to the viewport if
they are not transformed, and were failing to re-evaluate this when a
transform was added. Doing a layout fixes this.
Test: compositing/geometry/fixed-transformed.html
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/StyleTransformData.h:
(WebCore::StyleTransformData::hasTransform):
LayoutTests:
Reviewed by Darin Adler.
Test that moves a position:fixed element on-screen using a transform.
* compositing/geometry/fixed-transformed.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorerenderingstyleRenderStylecpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorerenderingstyleStyleTransformDatah">releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/StyleTransformData.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestscompositinggeometryfixedtransformedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (182784 => 182785)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-04-14 08:37:03 UTC (rev 182785)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-04-13 Simon Fraser <simon.fraser@apple.com>
+
+ Fixed position element is truncated if moved onscreen by a transform
+ https://bugs.webkit.org/show_bug.cgi?id=143655
+
+ Reviewed by Darin Adler.
+
+ Test that moves a position:fixed element on-screen using a transform.
+
+ * compositing/geometry/fixed-transformed.html: Added.
+
</ins><span class="cx"> 2015-04-12 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Selects don't scroll at some aspect ratios
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestscompositinggeometryfixedtransformedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html (0 => 182785)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html 2015-04-14 08:37:03 UTC (rev 182785)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ #slider {
+ position: fixed;
+ top: 100px;
+ left: -100px;
+ width: 200px;
+ height: 100px;
+ background-color: blue;
+ border: 10px solid gray;
+ }
+ #slider.out {
+ -webkit-transform: translateX(100px);
+ }
+ </style>
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+ window.addEventListener('load', function() {
+ window.setTimeout(function() {
+ document.getElementById('slider').classList.add('out');
+ if (window.testRunner) {
+ document.getElementById('layertree').innerText = window.internals.layerTreeAsText(document);
+ testRunner.notifyDone();
+ }
+ }, 0);
+ }, false);
+
+ </script>
+</head>
+<body>
+<div id="slider"></div>
+<pre id="layertree"></pre>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (182784 => 182785)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-04-14 08:37:03 UTC (rev 182785)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-04-13 Simon Fraser <simon.fraser@apple.com>
+
+ Fixed position element is truncated if moved onscreen by a transform
+ https://bugs.webkit.org/show_bug.cgi?id=143655
+ rdar://problem/15020044
+
+ Reviewed by Darin Adler.
+
+ Our "don't do layout if transform changes" code was too aggressive.
+ If an element changes between having a transform and not having one, we
+ really need to do a layout since so much else depends on transforms. In
+ this particular case, we clip position:fixed elements to the viewport if
+ they are not transformed, and were failing to re-evaluate this when a
+ transform was added. Doing a layout fixes this.
+
+ Test: compositing/geometry/fixed-transformed.html
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::changeRequiresLayout):
+ * rendering/style/StyleTransformData.h:
+ (WebCore::StyleTransformData::hasTransform):
+
</ins><span class="cx"> 2015-04-13 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove needless recreation of URL in NavigationScheduler::scheduleLocationChange
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/RenderStyle.cpp (182784 => 182785)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/RenderStyle.cpp 2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/RenderStyle.cpp 2015-04-14 08:37:03 UTC (rev 182785)
</span><span class="lines">@@ -474,10 +474,13 @@
</span><span class="cx"> && *rareNonInheritedData->m_multiCol.get() != *other.rareNonInheritedData->m_multiCol.get())
</span><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (rareNonInheritedData->m_transform.get() != other.rareNonInheritedData->m_transform.get()
- && *rareNonInheritedData->m_transform.get() != *other.rareNonInheritedData->m_transform.get()) {
- changedContextSensitiveProperties |= ContextSensitivePropertyTransform;
- // Don't return; keep looking for another change
</del><ins>+ if (rareNonInheritedData->m_transform != other.rareNonInheritedData->m_transform) {
+ if (rareNonInheritedData->m_transform->hasTransform() != other.rareNonInheritedData->m_transform->hasTransform())
+ return true;
+ if (*rareNonInheritedData->m_transform != *other.rareNonInheritedData->m_transform) {
+ changedContextSensitiveProperties |= ContextSensitivePropertyTransform;
+ // Don't return; keep looking for another change
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorerenderingstyleStyleTransformDatah"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/StyleTransformData.h (182784 => 182785)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/StyleTransformData.h 2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/StyleTransformData.h 2015-04-14 08:37:03 UTC (rev 182785)
</span><span class="lines">@@ -42,6 +42,8 @@
</span><span class="cx"> {
</span><span class="cx"> return !(*this == o);
</span><span class="cx"> }
</span><ins>+
+ bool hasTransform() const { return m_operations.size(); }
</ins><span class="cx">
</span><span class="cx"> TransformOperations m_operations;
</span><span class="cx"> Length m_x;
</span></span></pre>
</div>
</div>
</body>
</html>