<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182811] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182811">182811</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2015-04-14 14:25:22 -0700 (Tue, 14 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist.
https://bugs.webkit.org/show_bug.cgi?id=143722
Reviewed by Michael Saboff.
Renaming JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist so that it is
shorter, and easier to remember (without having to look it up) and to
type. JSC options now support descriptions, and one can always look up
the description if the option's purpose is not already obvious.
* dfg/DFGFunctionWhitelist.cpp:
(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
(JSC::DFG::FunctionWhitelist::contains):
* runtime/Options.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGFunctionWhitelistcpp">trunk/Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (182810 => 182811)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-04-14 21:25:22 UTC (rev 182811)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-04-14 Mark Lam <mark.lam@apple.com>
+
+ Rename JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist.
+ https://bugs.webkit.org/show_bug.cgi?id=143722
+
+ Reviewed by Michael Saboff.
+
+ Renaming JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist so that it is
+ shorter, and easier to remember (without having to look it up) and to
+ type. JSC options now support descriptions, and one can always look up
+ the description if the option's purpose is not already obvious.
+
+ * dfg/DFGFunctionWhitelist.cpp:
+ (JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
+ (JSC::DFG::FunctionWhitelist::contains):
+ * runtime/Options.h:
+
</ins><span class="cx"> 2015-04-13 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that use FAST_ALLOCATED.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGFunctionWhitelistcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp (182810 => 182811)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp 2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp 2015-04-14 21:25:22 UTC (rev 182811)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> static LazyNeverDestroyed<FunctionWhitelist> functionWhitelist;
</span><span class="cx"> static std::once_flag initializeWhitelistFlag;
</span><span class="cx"> std::call_once(initializeWhitelistFlag, [] {
</span><del>- const char* functionWhitelistFile = Options::dfgFunctionWhitelistFile();
</del><ins>+ const char* functionWhitelistFile = Options::dfgWhitelist();
</ins><span class="cx"> functionWhitelist.construct(functionWhitelistFile);
</span><span class="cx"> });
</span><span class="cx"> return functionWhitelist;
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> bool FunctionWhitelist::contains(CodeBlock* codeBlock) const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!isCompilationThread());
</span><del>- if (!Options::dfgFunctionWhitelistFile())
</del><ins>+ if (!Options::dfgWhitelist())
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> if (m_entries.isEmpty())
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (182810 => 182811)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2015-04-14 21:25:22 UTC (rev 182811)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> v(bool, showFTLDisassembly, false, "dumps disassembly of FTL function upon compilation") \
</span><span class="cx"> v(bool, showAllDFGNodes, false, nullptr) \
</span><span class="cx"> v(optionRange, bytecodeRangeToDFGCompile, 0, "bytecode size range to allow DFG compilation on, e.g. 1:100") \
</span><del>- v(optionString, dfgFunctionWhitelistFile, nullptr, "file with list of function signatures to allow DFG compilation on") \
</del><ins>+ v(optionString, dfgWhitelist, nullptr, "file with list of function signatures to allow DFG compilation on") \
</ins><span class="cx"> v(bool, dumpSourceAtDFGTime, false, "dumps source code of JS function being DFG compiled") \
</span><span class="cx"> v(bool, dumpBytecodeAtDFGTime, false, "dumps bytecode of JS function being DFG compiled") \
</span><span class="cx"> v(bool, dumpGraphAfterParsing, false, nullptr) \
</span></span></pre>
</div>
</div>
</body>
</html>