<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182725] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182725">182725</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-13 06:06:58 -0700 (Mon, 13 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/182672">r182672</a> - Selects don't scroll at some aspect ratios
https://bugs.webkit.org/show_bug.cgi?id=143649
rdar://problem/19365694
Reviewed by Darin Adler.
Source/WebCore:
Fix width/height flip in RenderListBox which caused us to fail to scroll when
the list was wider than the scroll height.
We're generally confused about RenderListBox scroll offsets (webkit.org/b/143648)
but this fixes the immediate problem.
Test: fast/forms/listbox-visible-size.html
* rendering/RenderListBox.h:
LayoutTests:
* fast/forms/listbox-visible-size-expected.txt: Added.
* fast/forms/listbox-visible-size.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorerenderingRenderListBoxh">releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderListBox.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastformslistboxvisiblesizeexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastformslistboxvisiblesizehtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (182724 => 182725)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-04-13 13:04:57 UTC (rev 182724)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-04-13 13:06:58 UTC (rev 182725)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-04-12 Simon Fraser <simon.fraser@apple.com>
+
+ Selects don't scroll at some aspect ratios
+ https://bugs.webkit.org/show_bug.cgi?id=143649
+ rdar://problem/19365694
+
+ Reviewed by Darin Adler.
+
+ * fast/forms/listbox-visible-size-expected.txt: Added.
+ * fast/forms/listbox-visible-size.html: Added.
+
</ins><span class="cx"> 2015-04-09 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Text-combine erroneously draws vertically after non-layout-causing style change
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastformslistboxvisiblesizeexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size-expected.txt (0 => 182725)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size-expected.txt 2015-04-13 13:06:58 UTC (rev 182725)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS select.scrollTop is targetTop
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastformslistboxvisiblesizehtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size.html (0 => 182725)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size.html (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/forms/listbox-visible-size.html 2015-04-13 13:06:58 UTC (rev 182725)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ select {
+ width: 12em;
+ }
+ </style>
+ <script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+ <select id="select" size="5">
+ <option>Monday</option>
+ <option>Tuesday</option>
+ <option>Wednesday</option>
+ <option>Thursday</option>
+ <option>Friday</option>
+ <option>Saturday</option>
+ <option>Sunday</option>
+ </select>
+ <script>
+ const targetTop = 28;
+ var select;
+ function scrollSelect(newTop)
+ {
+ var select = document.getElementById('select');
+ select.scrollTop = newTop;
+ }
+
+ scrollSelect(targetTop);
+ shouldBe('select.scrollTop', 'targetTop');
+ </script>
+ <script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (182724 => 182725)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-04-13 13:04:57 UTC (rev 182724)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-04-13 13:06:58 UTC (rev 182725)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-04-12 Simon Fraser <simon.fraser@apple.com>
+
+ Selects don't scroll at some aspect ratios
+ https://bugs.webkit.org/show_bug.cgi?id=143649
+ rdar://problem/19365694
+
+ Reviewed by Darin Adler.
+
+ Fix width/height flip in RenderListBox which caused us to fail to scroll when
+ the list was wider than the scroll height.
+
+ We're generally confused about RenderListBox scroll offsets (webkit.org/b/143648)
+ but this fixes the immediate problem.
+
+ Test: fast/forms/listbox-visible-size.html
+
+ * rendering/RenderListBox.h:
+
</ins><span class="cx"> 2015-04-09 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Text-combine erroneously draws vertically after non-layout-causing style change
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorerenderingRenderListBoxh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderListBox.h (182724 => 182725)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderListBox.h 2015-04-13 13:04:57 UTC (rev 182724)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderListBox.h 2015-04-13 13:06:58 UTC (rev 182725)
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar*, const IntPoint&) const override;
</span><span class="cx"> virtual Scrollbar* verticalScrollbar() const override { return m_vBar.get(); }
</span><span class="cx"> virtual IntSize contentsSize() const override;
</span><del>- virtual IntSize visibleSize() const override { return IntSize(height(), width()); }
</del><ins>+ virtual IntSize visibleSize() const override { return IntSize(width(), height()); }
</ins><span class="cx"> virtual IntPoint lastKnownMousePosition() const override;
</span><span class="cx"> virtual bool isHandlingWheelEvent() const override;
</span><span class="cx"> virtual bool shouldSuspendScrollAnimations() const override;
</span></span></pre>
</div>
</div>
</body>
</html>