<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182749] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182749">182749</a></dd>
<dt>Author</dt> <dd>jhoneycutt@apple.com</dd>
<dt>Date</dt> <dd>2015-04-13 12:52:11 -0700 (Mon, 13 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cannot click "Next" button on Google two-factor auth setup page
<https://bugs.webkit.org/show_bug.cgi?id=143624>
<rdar://problem/19175714>
.:
Reviewed by Darin Adler.
* ManualTests/button-that-focuses-itself-on-click.html: Added.
Source/WebKit2:
This issue occurs when this site focuses the submit button. When it
receives focus, we try to assist it. While we consider ourselves to be
assisting it, we ignore further gesture inputs for that node, including
the tap gesture.
To fix this, only assist input types that we know are assistable,
including text fields, select and date elements, etc.
Reviewed by Darin Adler.
* UIProcess/ios/WKContentViewInteraction.mm:
(isAssistableInputType):
If the type is a known-assistable type, return true.
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
Call isAssistableInputType() to determine whether we should do any kind
of assistance for this node.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm">trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkManualTestsbuttonthatfocusesitselfonclickhtml">trunk/ManualTests/button-that-focuses-itself-on-click.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (182748 => 182749)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/ChangeLog 2015-04-13 19:52:11 UTC (rev 182749)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-04-10 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Cannot click "Next" button on Google two-factor auth setup page
+
+ <https://bugs.webkit.org/show_bug.cgi?id=143624>
+ <rdar://problem/19175714>
+
+ Reviewed by Darin Adler.
+
+ * ManualTests/button-that-focuses-itself-on-click.html: Added.
+
</ins><span class="cx"> 2015-04-13 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [cmake] REGRESSION(182663): It broke feature dependency handling
</span></span></pre></div>
<a id="trunkManualTestsbuttonthatfocusesitselfonclickhtml"></a>
<div class="addfile"><h4>Added: trunk/ManualTests/button-that-focuses-itself-on-click.html (0 => 182749)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ManualTests/button-that-focuses-itself-on-click.html (rev 0)
+++ trunk/ManualTests/button-that-focuses-itself-on-click.html 2015-04-13 19:52:11 UTC (rev 182749)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+<head>
+ <meta name="viewport" content="width=device-width">
+ <script>
+ var haveClicked = false;
+ function runTest(e) {
+ if (haveClicked) {
+ e.value = "Test passed";
+ e.disabled = true;
+ return;
+ }
+ e.value = "Click me again";
+ e.focus();
+ haveClicked = true;
+ }
+ </script>
+</head>
+
+<body>
+ <center>
+ <input type=submit onclick="runTest(this); return false;" value="Click me" style="font-size: 36px">
+ </center>
+ <br><br>
+ <div style="font-size: 20px; font-family: helvetica;">
+ Test for WebKit bug #<a href="https://bugs.webkit.org/show_bug.cgi?id=143624">143624</a>
+ <br><br>
+ Tap button above twice to run test. &ldquo;Test passed&rdquo; will
+ appear above if the test passes. If you cannot click the button a
+ second time, the test failed.
+ <br><br>
+ To rerun this test, open it in a new tab. Do not reload.
+ </div>
+</body>
+
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (182748 => 182749)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-13 19:52:11 UTC (rev 182749)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-04-10 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Cannot click "Next" button on Google two-factor auth setup page
+
+ <https://bugs.webkit.org/show_bug.cgi?id=143624>
+ <rdar://problem/19175714>
+
+ This issue occurs when this site focuses the submit button. When it
+ receives focus, we try to assist it. While we consider ourselves to be
+ assisting it, we ignore further gesture inputs for that node, including
+ the tap gesture.
+
+ To fix this, only assist input types that we know are assistable,
+ including text fields, select and date elements, etc.
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (isAssistableInputType):
+ If the type is a known-assistable type, return true.
+ (-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
+ Call isAssistableInputType() to determine whether we should do any kind
+ of assistance for this node.
+
</ins><span class="cx"> 2015-04-13 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Add force property to MouseEvents
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (182748 => 182749)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-04-13 19:52:11 UTC (rev 182749)
</span><span class="lines">@@ -2765,6 +2765,36 @@
</span><span class="cx"> return _formAccessoryView.get();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static bool isAssistableInputType(InputType type)
+{
+ switch (type) {
+ case InputType::ContentEditable:
+ case InputType::Text:
+ case InputType::Password:
+ case InputType::TextArea:
+ case InputType::Search:
+ case InputType::Email:
+ case InputType::URL:
+ case InputType::Phone:
+ case InputType::Number:
+ case InputType::NumberPad:
+ case InputType::Date:
+ case InputType::DateTime:
+ case InputType::DateTimeLocal:
+ case InputType::Month:
+ case InputType::Week:
+ case InputType::Time:
+ case InputType::Select:
+ return true;
+
+ case InputType::None:
+ return false;
+ }
+
+ ASSERT_NOT_REACHED();
+ return false;
+}
+
</ins><span class="cx"> - (void)_startAssistingNode:(const AssistedNodeInformation&)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode userObject:(NSObject <NSSecureCoding> *)userObject
</span><span class="cx"> {
</span><span class="cx"> if (!userIsInteracting && !_textSelectionAssistant)
</span><span class="lines">@@ -2773,6 +2803,9 @@
</span><span class="cx"> if (blurPreviousNode)
</span><span class="cx"> [self _stopAssistingNode];
</span><span class="cx">
</span><ins>+ if (!isAssistableInputType(information.elementType))
+ return;
+
</ins><span class="cx"> // FIXME: We should remove this check when we manage to send StartAssistingNode from the WebProcess
</span><span class="cx"> // only when it is truly time to show the keyboard.
</span><span class="cx"> if (_assistedNodeInformation.elementType == information.elementType && _assistedNodeInformation.elementRect == information.elementRect)
</span></span></pre>
</div>
</div>
</body>
</html>