<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182614] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182614">182614</a></dd>
<dt>Author</dt> <dd>mmirman@apple.com</dd>
<dt>Date</dt> <dd>2015-04-09 16:42:01 -0700 (Thu, 09 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Updated expectations on a few tests to account for error
info not being added at throw time anymore.
https://bugs.webkit.org/show_bug.cgi?id=143542
rdar://problem/20475871
Reviewed by Michael Saboff.
Because sourceURL is now being appended at error construction time rather than when thrown,
the tests now attempt to append it during the code run by InspectorTest.sendCommand which I assume uses an eval.
Because this code is generated on the fly, it has no URL and thus sourceURL makes no sense.
Also since they are generated in a new locations, they will have a new lines and columns.
* inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt:
* inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt:
* inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt:
* platform/win/TestExpectations: Enabled the above tests on windows.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsallexpectedtxt">trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsnoneexpectedtxt">trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsuncaughtexpectedtxt">trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (182613 => 182614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-04-09 23:36:28 UTC (rev 182613)
+++ trunk/LayoutTests/ChangeLog 2015-04-09 23:42:01 UTC (rev 182614)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-04-09 Matthew Mirman <mmirman@apple.com>
+
+ Updated expectations on a few tests to account for error
+ info not being added at throw time anymore.
+ https://bugs.webkit.org/show_bug.cgi?id=143542
+ rdar://problem/20475871
+
+ Reviewed by Michael Saboff.
+
+ Because sourceURL is now being appended at error construction time rather than when thrown,
+ the tests now attempt to append it during the code run by InspectorTest.sendCommand which I assume uses an eval.
+ Because this code is generated on the fly, it has no URL and thus sourceURL makes no sense.
+ Also since they are generated in a new locations, they will have a new lines and columns.
+
+ * inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt:
+ * inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt:
+ * inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt:
+ * platform/win/TestExpectations: Enabled the above tests on windows.
+
</ins><span class="cx"> 2015-04-09 Javier Fernandez <jfernandez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Implement justify-self and justify-item css properties.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsallexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt (182613 => 182614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt 2015-04-09 23:36:28 UTC (rev 182613)
+++ trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt 2015-04-09 23:42:01 UTC (rev 182614)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: {"code":8,"name":"NotFoundError","message":"NotFoundError: DOM Exception 8","line":8,"column":30,"sourceURL":"exception.js"}
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception in host function"
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception string"
</span><del>-CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":18,"column":12,"sourceURL":"exception.js"}
</del><ins>+CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":1,"column":61}
</ins><span class="cx"> CONSOLE MESSAGE: line 1: TypeError: undefined is not an object (evaluating '({}).a.b')
</span><span class="cx"> CONSOLE MESSAGE: line 3: TypeError: undefined is not an object (evaluating '({}).a.b')
</span><span class="cx"> CONSOLE MESSAGE: line 8: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsnoneexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt (182613 => 182614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt 2015-04-09 23:36:28 UTC (rev 182613)
+++ trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt 2015-04-09 23:42:01 UTC (rev 182614)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: {"code":8,"name":"NotFoundError","message":"NotFoundError: DOM Exception 8","line":8,"column":30,"sourceURL":"exception.js"}
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception in host function"
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception string"
</span><del>-CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":18,"column":12,"sourceURL":"exception.js"}
</del><ins>+CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":1,"column":61}
</ins><span class="cx"> CONSOLE MESSAGE: line 3: TypeError: undefined is not an object (evaluating '({}).a.b')
</span><span class="cx"> CONSOLE MESSAGE: line 8: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
</span><span class="cx"> CONSOLE MESSAGE: line 24: exception in host function
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldebuggersetPauseOnExceptionsuncaughtexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt (182613 => 182614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt 2015-04-09 23:36:28 UTC (rev 182613)
+++ trunk/LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt 2015-04-09 23:42:01 UTC (rev 182614)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: {"code":8,"name":"NotFoundError","message":"NotFoundError: DOM Exception 8","line":8,"column":30,"sourceURL":"exception.js"}
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception in host function"
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception string"
</span><del>-CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":18,"column":12,"sourceURL":"exception.js"}
</del><ins>+CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":1,"column":61}
</ins><span class="cx"> CONSOLE MESSAGE: line 1: TypeError: undefined is not an object (evaluating '({}).a.b')
</span><span class="cx"> CONSOLE MESSAGE: line 3: TypeError: undefined is not an object (evaluating '({}).a.b')
</span><span class="cx"> CONSOLE MESSAGE: line 8: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: {"code":8,"name":"NotFoundError","message":"NotFoundError: DOM Exception 8","line":8,"column":30,"sourceURL":"exception.js"}
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception in host function"
</span><span class="cx"> CONSOLE MESSAGE: line 38: catchNested caught exception: "exception string"
</span><del>-CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":18,"column":12,"sourceURL":"exception.js"}
</del><ins>+CONSOLE MESSAGE: line 38: catchNested caught exception: {"line":1,"column":61}
</ins><span class="cx"> Debugger.setPauseOnExceptions uncaught
</span><span class="cx">
</span><span class="cx"> Debugger.setPauseOnExceptions - uncaught
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (182613 => 182614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2015-04-09 23:36:28 UTC (rev 182613)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-04-09 23:42:01 UTC (rev 182614)
</span><span class="lines">@@ -2352,9 +2352,6 @@
</span><span class="cx"> inspector-protocol/debugger/removeBreakpoint.html [ Skip ] # Crashing
</span><span class="cx"> inspector-protocol/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
</span><span class="cx">
</span><del>-webkit.org/b/143542 inspector-protocol/debugger/setPauseOnExceptions-all.html [ Failure ]
-webkit.org/b/143542 inspector-protocol/debugger/setPauseOnExceptions-none.html [ Failure ]
-webkit.org/b/143542 inspector-protocol/debugger/setPauseOnExceptions-uncaught.html [ Failure ]
</del><span class="cx"> webkit.org/b/143548 inspector/console/console-api.html [ Skip ] # Timeout
</span><span class="cx"> ################################################################################
</span><span class="cx"> ################# End Inspector Issues ####################
</span></span></pre>
</div>
</div>
</body>
</html>