<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182617] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182617">182617</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-09 17:30:00 -0700 (Thu, 09 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Minor cleanups to WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=143509
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-04-09
Reviewed by Anders Carlsson.
1. Remove unnecessary #includes.
2. Fix some wrong namespace comments for consistency.
No new tests, no behavior change.
* plugins/DOMMimeType.cpp:
* plugins/DOMMimeType.h:
* plugins/DOMMimeTypeArray.h:
* plugins/DOMPlugin.h:
* plugins/DOMPluginArray.h:
* plugins/PluginData.cpp:
* plugins/PluginData.h:
* plugins/PluginMainThreadScheduler.cpp:
* plugins/PluginViewBase.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMMimeTypecpp">trunk/Source/WebCore/plugins/DOMMimeType.cpp</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMMimeTypeh">trunk/Source/WebCore/plugins/DOMMimeType.h</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMMimeTypeArrayh">trunk/Source/WebCore/plugins/DOMMimeTypeArray.h</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginh">trunk/Source/WebCore/plugins/DOMPlugin.h</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginArrayh">trunk/Source/WebCore/plugins/DOMPluginArray.h</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginDatacpp">trunk/Source/WebCore/plugins/PluginData.cpp</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginDatah">trunk/Source/WebCore/plugins/PluginData.h</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginMainThreadSchedulercpp">trunk/Source/WebCore/plugins/PluginMainThreadScheduler.cpp</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginViewBaseh">trunk/Source/WebCore/plugins/PluginViewBase.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/ChangeLog 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-04-09 Sungmann Cho <sungmann.cho@navercorp.com>
+
+ Minor cleanups to WebCore/plugins
+ https://bugs.webkit.org/show_bug.cgi?id=143509
+
+ Reviewed by Anders Carlsson.
+
+ 1. Remove unnecessary #includes.
+ 2. Fix some wrong namespace comments for consistency.
+
+ No new tests, no behavior change.
+
+ * plugins/DOMMimeType.cpp:
+ * plugins/DOMMimeType.h:
+ * plugins/DOMMimeTypeArray.h:
+ * plugins/DOMPlugin.h:
+ * plugins/DOMPluginArray.h:
+ * plugins/PluginData.cpp:
+ * plugins/PluginData.h:
+ * plugins/PluginMainThreadScheduler.cpp:
+ * plugins/PluginViewBase.h:
+
</ins><span class="cx"> 2015-04-09 Javier Fernandez <jfernandez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Implement justify-self and justify-item css properties.
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMMimeTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMimeType.cpp (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMMimeType.cpp 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/DOMMimeType.cpp 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -21,11 +21,9 @@
</span><span class="cx">
</span><span class="cx"> #include "DOMPlugin.h"
</span><span class="cx"> #include "FrameLoader.h"
</span><del>-#include "FrameLoaderClient.h"
</del><span class="cx"> #include "MainFrame.h"
</span><span class="cx"> #include "Page.h"
</span><span class="cx"> #include "PluginData.h"
</span><del>-#include "Settings.h"
</del><span class="cx"> #include "SubframeLoader.h"
</span><span class="cx"> #include <wtf/text/StringBuilder.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMMimeTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMimeType.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMMimeType.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/DOMMimeType.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -23,7 +23,6 @@
</span><span class="cx"> #include "FrameDestructionObserver.h"
</span><span class="cx"> #include "PluginData.h"
</span><span class="cx">
</span><del>-#include <wtf/Forward.h>
</del><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="lines">@@ -50,6 +49,6 @@
</span><span class="cx"> unsigned m_index;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-}
</del><ins>+} // namespace WebCore
</ins><span class="cx">
</span><del>-#endif
</del><ins>+#endif // DOMMimeType_h
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMMimeTypeArrayh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMimeTypeArray.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMMimeTypeArray.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/DOMMimeTypeArray.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -24,10 +24,8 @@
</span><span class="cx"> #include "DOMMimeType.h"
</span><span class="cx"> #include "DOMWindowProperty.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><del>-#include <wtf/Forward.h>
</del><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><del>-#include <wtf/Vector.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -51,4 +49,4 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><del>-#endif // MimeTypeArray_h
</del><ins>+#endif // DOMMimeTypeArray_h
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPlugin.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPlugin.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/DOMPlugin.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -23,9 +23,8 @@
</span><span class="cx"> #include "FrameDestructionObserver.h"
</span><span class="cx"> #include "DOMMimeType.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><del>-#include <wtf/Forward.h>
-#include <wtf/RefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><ins>+#include <wtf/RefPtr.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -57,4 +56,4 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><del>-#endif // Plugin_h
</del><ins>+#endif // DOMPlugin_h
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginArrayh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPluginArray.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPluginArray.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/DOMPluginArray.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -24,10 +24,8 @@
</span><span class="cx"> #include "DOMPlugin.h"
</span><span class="cx"> #include "DOMWindowProperty.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><del>-#include <wtf/Forward.h>
</del><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><del>-#include <wtf/Vector.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -53,4 +51,4 @@
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><del>-#endif // PluginArray_h
</del><ins>+#endif // DOMPluginArray_h
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginData.cpp (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginData.cpp 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/PluginData.cpp 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -120,4 +120,4 @@
</span><span class="cx"> platformStrategies()->pluginStrategy()->getPluginInfo(m_page, m_plugins);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-}
</del><ins>+} // namespace WebCore
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginData.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginData.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/PluginData.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -110,6 +110,6 @@
</span><span class="cx"> Vector<PluginInfo> m_plugins;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-}
</del><ins>+} // namespace WebCore
</ins><span class="cx">
</span><del>-#endif
</del><ins>+#endif // PluginData_h
</ins></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginMainThreadSchedulercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginMainThreadScheduler.cpp (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginMainThreadScheduler.cpp 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/PluginMainThreadScheduler.cpp 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -25,7 +25,6 @@
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "PluginMainThreadScheduler.h"
</span><del>-#include <wtf/StdLibExtras.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginViewBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginViewBase.h (182616 => 182617)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginViewBase.h 2015-04-10 00:21:12 UTC (rev 182616)
+++ trunk/Source/WebCore/plugins/PluginViewBase.h 2015-04-10 00:30:00 UTC (rev 182617)
</span><span class="lines">@@ -22,8 +22,8 @@
</span><span class="cx"> * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#ifndef PluginWidget_h
-#define PluginWidget_h
</del><ins>+#ifndef PluginViewBase_h
+#define PluginViewBase_h
</ins><span class="cx">
</span><span class="cx"> #include "AudioHardwareListener.h"
</span><span class="cx"> #include "BridgeJSC.h"
</span><span class="lines">@@ -90,4 +90,4 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_WIDGET(PluginViewBase, isPluginViewBase())
</span><span class="cx">
</span><del>-#endif // PluginWidget_h
</del><ins>+#endif // PluginViewBase_h
</ins></span></pre>
</div>
</div>
</body>
</html>