<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182546] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182546">182546</a></dd>
<dt>Author</dt> <dd>changseok.oh@collabora.com</dd>
<dt>Date</dt> <dd>2015-04-08 10:14:07 -0700 (Wed, 08 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fill list style background with same color with that of list background.
https://bugs.webkit.org/show_bug.cgi?id=143483
Reviewed by Simon Fraser.
Source/WebCore:
LayoutListMarker does not have a node so its selectionBackgroundColor alway returns
the default theme color for selection. We can make it more natural by filling
the same color with that of LayoutListItem into it.
Tests: fast/backgrounds/selection-background-color-of-image-list-style.html
fast/backgrounds/selection-background-color-of-list-style.html
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
LayoutTests:
* fast/backgrounds/selection-background-color-of-image-list-style.html: Added.
* fast/backgrounds/selection-background-color-of-list-style.html: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListMarkercpp">trunk/Source/WebCore/rendering/RenderListMarker.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbackgroundsselectionbackgroundcolorofimageliststylehtml">trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsselectionbackgroundcolorofliststylehtml">trunk/LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedpng">trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedtxt">trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofliststyleexpectedpng">trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofliststyleexpectedtxt">trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedpng">trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedtxt">trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofliststyleexpectedpng">trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofliststyleexpectedtxt">trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (182545 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-04-08 16:47:56 UTC (rev 182545)
+++ trunk/LayoutTests/ChangeLog 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-04-08 ChangSeok Oh <changseok.oh@collabora.com>
+
+ Fill list style background with same color with that of list background.
+ https://bugs.webkit.org/show_bug.cgi?id=143483
+
+ Reviewed by Simon Fraser.
+
+ * fast/backgrounds/selection-background-color-of-image-list-style.html: Added.
+ * fast/backgrounds/selection-background-color-of-list-style.html: Added.
+ * platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
+ * platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
+ * platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
+ * platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
+ * platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
+ * platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
+ * platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
+ * platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
+
</ins><span class="cx"> 2015-04-08 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r182536.
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsselectionbackgroundcolorofimageliststylehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html>
+<style>
+ul { list-style-image: url('./resources/diamond.png'); }
+ul>li::selection { background: yellow; }
+</style>
+<div>
+ Test pass if background of image list style in ul is yellow.
+ <ul>
+ <li>One</li>
+ <li>Two</li>
+ </ul>
+</div>
+<script>
+var range = document.createRange();
+range.selectNode(document.querySelector('ul'));
+getSelection().addRange(range);
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsselectionbackgroundcolorofliststylehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+<!DOCTYPE html>
+<style>
+ul>li::selection { background: green; }
+ol>li::selection { background: yellow; }
+</style>
+<div>
+ Test passes if backgrounds of list style in ul and ol are each green and yellow.
+ <ul>
+ <li>One</li>
+ <li>Two</li>
+ </ul>
+ <ol>
+ <li>One</li>
+ <li>Two</li>
+ </ol>
+</div>
+<script>
+var range = document.createRange();
+range.setStartBefore(document.querySelector('ul'));
+range.setEndAfter(document.querySelector('ol'));
+getSelection().addRange(range);
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x91
+ RenderBlock {HTML} at (0,0) size 800x91
+ RenderBody {BODY} at (8,8) size 784x67
+ RenderBlock {DIV} at (0,0) size 784x67
+ RenderBlock (anonymous) at (0,0) size 784x17
+ RenderText {#text} at (0,0) size 361x17
+ text run at (0,0) width 361: "Test pass if background of image list style in ul is yellow."
+ RenderBlock {UL} at (0,33) size 784x34
+ RenderListItem {LI} at (40,0) size 744x17
+ RenderListMarker at (-17,4) size 10x10
+ RenderText {#text} at (0,0) size 27x17
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,17) size 744x17
+ RenderListMarker at (-17,4) size 10x10
+ RenderText {#text} at (0,0) size 30x17
+ text run at (0,0) width 30: "Two"
+selection start: position 66 of child 0 {#text} of child 0 {DIV} of body
+selection end: position 3 of child 0 {#text} of child 3 {LI} of child 1 {UL} of child 0 {DIV} of body
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofliststyleexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformgtkfastbackgroundsselectionbackgroundcolorofliststyleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x141
+ RenderBlock {HTML} at (0,0) size 800x141
+ RenderBody {BODY} at (8,8) size 784x117
+ RenderBlock {DIV} at (0,0) size 784x117
+ RenderBlock (anonymous) at (0,0) size 784x17
+ RenderText {#text} at (0,0) size 489x17
+ text run at (0,0) width 489: "Test passes if backgrounds of list style in ul and ol are each green and yellow."
+ RenderBlock {UL} at (0,33) size 784x34
+ RenderListItem {LI} at (40,0) size 744x17
+ RenderListMarker at (-17,0) size 7x17: bullet
+ RenderText {#text} at (0,0) size 27x17
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,17) size 744x17
+ RenderListMarker at (-17,0) size 7x17: bullet
+ RenderText {#text} at (0,0) size 30x17
+ text run at (0,0) width 30: "Two"
+ RenderBlock {OL} at (0,83) size 784x34
+ RenderListItem {LI} at (40,0) size 744x17
+ RenderListMarker at (-20,0) size 16x17: "1"
+ RenderText {#text} at (0,0) size 27x17
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,17) size 744x17
+ RenderListMarker at (-20,0) size 16x17: "2"
+ RenderText {#text} at (0,0) size 30x17
+ text run at (0,0) width 30: "Two"
+selection start: position 86 of child 0 {#text} of child 0 {DIV} of body
+selection end: position 3 of child 0 {#text} of child 3 {LI} of child 3 {OL} of child 0 {DIV} of body
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofimageliststyleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x94
+ RenderBlock {HTML} at (0,0) size 800x94
+ RenderBody {BODY} at (8,8) size 784x70
+ RenderBlock {DIV} at (0,0) size 784x70
+ RenderBlock (anonymous) at (0,0) size 784x18
+ RenderText {#text} at (0,0) size 368x18
+ text run at (0,0) width 368: "Test pass if background of image list style in ul is yellow."
+ RenderBlock {UL} at (0,34) size 784x36
+ RenderListItem {LI} at (40,0) size 744x18
+ RenderListMarker at (-17,4) size 10x10
+ RenderText {#text} at (0,0) size 27x18
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,18) size 744x18
+ RenderListMarker at (-17,4) size 10x10
+ RenderText {#text} at (0,0) size 29x18
+ text run at (0,0) width 29: "Two"
+selection start: position 66 of child 0 {#text} of child 0 {DIV} of body
+selection end: position 3 of child 0 {#text} of child 3 {LI} of child 1 {UL} of child 0 {DIV} of body
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofliststyleexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformmacfastbackgroundsselectionbackgroundcolorofliststyleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt (0 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x146
+ RenderBlock {HTML} at (0,0) size 800x146
+ RenderBody {BODY} at (8,8) size 784x122
+ RenderBlock {DIV} at (0,0) size 784x122
+ RenderBlock (anonymous) at (0,0) size 784x18
+ RenderText {#text} at (0,0) size 497x18
+ text run at (0,0) width 497: "Test passes if backgrounds of list style in ul and ol are each green and yellow."
+ RenderBlock {UL} at (0,34) size 784x36
+ RenderListItem {LI} at (40,0) size 744x18
+ RenderListMarker at (-17,0) size 7x18: bullet
+ RenderText {#text} at (0,0) size 27x18
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,18) size 744x18
+ RenderListMarker at (-17,0) size 7x18: bullet
+ RenderText {#text} at (0,0) size 29x18
+ text run at (0,0) width 29: "Two"
+ RenderBlock {OL} at (0,86) size 784x36
+ RenderListItem {LI} at (40,0) size 744x18
+ RenderListMarker at (-20,0) size 16x18: "1"
+ RenderText {#text} at (0,0) size 27x18
+ text run at (0,0) width 27: "One"
+ RenderListItem {LI} at (40,18) size 744x18
+ RenderListMarker at (-20,0) size 16x18: "2"
+ RenderText {#text} at (0,0) size 29x18
+ text run at (0,0) width 29: "Two"
+selection start: position 86 of child 0 {#text} of child 0 {DIV} of body
+selection end: position 3 of child 0 {#text} of child 3 {LI} of child 3 {OL} of child 0 {DIV} of body
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182545 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-08 16:47:56 UTC (rev 182545)
+++ trunk/Source/WebCore/ChangeLog 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-04-08 ChangSeok Oh <changseok.oh@collabora.com>
+
+ Fill list style background with same color with that of list background.
+ https://bugs.webkit.org/show_bug.cgi?id=143483
+
+ Reviewed by Simon Fraser.
+
+ LayoutListMarker does not have a node so its selectionBackgroundColor alway returns
+ the default theme color for selection. We can make it more natural by filling
+ the same color with that of LayoutListItem into it.
+
+ Tests: fast/backgrounds/selection-background-color-of-image-list-style.html
+ fast/backgrounds/selection-background-color-of-list-style.html
+
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+
</ins><span class="cx"> 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add CMake build system for WinCairo port.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListMarkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (182545 => 182546)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListMarker.cpp 2015-04-08 16:47:56 UTC (rev 182545)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp 2015-04-08 17:14:07 UTC (rev 182546)
</span><span class="lines">@@ -1201,7 +1201,7 @@
</span><span class="cx"> if (selectionState() != SelectionNone) {
</span><span class="cx"> LayoutRect selRect = localSelectionRect();
</span><span class="cx"> selRect.moveBy(boxOrigin);
</span><del>- context->fillRect(snappedIntRect(selRect), selectionBackgroundColor(), style().colorSpace());
</del><ins>+ context->fillRect(snappedIntRect(selRect), m_listItem.selectionBackgroundColor(), style().colorSpace());
</ins><span class="cx"> }
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1209,7 +1209,7 @@
</span><span class="cx"> if (selectionState() != SelectionNone) {
</span><span class="cx"> LayoutRect selRect = localSelectionRect();
</span><span class="cx"> selRect.moveBy(boxOrigin);
</span><del>- context->fillRect(snappedIntRect(selRect), selectionBackgroundColor(), style().colorSpace());
</del><ins>+ context->fillRect(snappedIntRect(selRect), m_listItem.selectionBackgroundColor(), style().colorSpace());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const Color color(style().visitedDependentColor(CSSPropertyColor));
</span></span></pre>
</div>
</div>
</body>
</html>