<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182520] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182520">182520</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-07 22:57:02 -0700 (Tue, 07 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Bug 142887 - role progress bar does not support indeterminate state
https://bugs.webkit.org/show_bug.cgi?id=142887
Patch by Michael Peechatt <mpeechatt@gmail.com> on 2015-04-07
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/mac/accessibility/progressbar-indeterminate.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
When getting min or max value of an indeterminate progress indicator, return 0.
This is so VoiceOver will recognize it as indeterminate.
LayoutTests:
* platform/mac/accessibility/progressbar-indeterminate-expected.txt: Added.
* platform/mac/accessibility/progressbar-indeterminate.html: Added.
Test that checks if 0 is returned for indetermiate progress indicators when
aria min and max values are non zero.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityprogressbarindeterminateexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityprogressbarindeterminatehtml">trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (182519 => 182520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-04-08 05:44:28 UTC (rev 182519)
+++ trunk/LayoutTests/ChangeLog 2015-04-08 05:57:02 UTC (rev 182520)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-04-07 Michael Peechatt <mpeechatt@gmail.com>
+
+ Bug 142887 - role progress bar does not support indeterminate state
+ https://bugs.webkit.org/show_bug.cgi?id=142887
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac/accessibility/progressbar-indeterminate-expected.txt: Added.
+ * platform/mac/accessibility/progressbar-indeterminate.html: Added.
+ Test that checks if 0 is returned for indetermiate progress indicators when
+ aria min and max values are non zero.
+
</ins><span class="cx"> 2015-04-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Open WebSockets should not prevent a page from entering PageCache
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityprogressbarindeterminateexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt (0 => 182520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt 2015-04-08 05:57:02 UTC (rev 182520)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+X
+
+This tests that elements with progressbar role return 0 for min and max value, if indeterminate.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS prog1.maxValue is 0
+PASS prog1.minValue is 0
+PASS prog2.maxValue is 0
+PASS prog2.minValue is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityprogressbarindeterminatehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html (0 => 182520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html 2015-04-08 05:57:02 UTC (rev 182520)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div tabindex="0" id="progressbar1" role="progressbar" aria-valuemin="35" aria-valuemax="100">X</div>
+<progress tabindex="0" id="progressbar2" role="progressbar" aria-valuemin="75" aria-valuemax="100"></progress>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+ description("This tests that elements with progressbar role return 0 for min and max value, if indeterminate.");
+
+ if (window.accessibilityController) {
+ // Div element given progressbar role, with no value.
+ var prog1 = accessibilityController.accessibleElementById("progressbar1");
+ shouldBe("prog1.maxValue", "0");
+ shouldBe("prog1.minValue", "0");
+
+ // Indeterminate progress element.
+ var prog2 = accessibilityController.accessibleElementById("progressbar2");
+ shouldBe("prog2.maxValue", "0");
+ shouldBe("prog2.minValue", "0");
+ }
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182519 => 182520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-08 05:44:28 UTC (rev 182519)
+++ trunk/Source/WebCore/ChangeLog 2015-04-08 05:57:02 UTC (rev 182520)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-04-07 Michael Peechatt <mpeechatt@gmail.com>
+
+ Bug 142887 - role progress bar does not support indeterminate state
+ https://bugs.webkit.org/show_bug.cgi?id=142887
+
+ Reviewed by Chris Fleizach.
+
+ Test: platform/mac/accessibility/progressbar-indeterminate.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+ When getting min or max value of an indeterminate progress indicator, return 0.
+ This is so VoiceOver will recognize it as indeterminate.
+
</ins><span class="cx"> 2015-04-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, speculative iOS build fix after r182516.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (182519 => 182520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-04-08 05:44:28 UTC (rev 182519)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-04-08 05:57:02 UTC (rev 182520)
</span><span class="lines">@@ -2496,12 +2496,20 @@
</span><span class="cx"> const unichar ch = 0x2713; // ✓ used on Mac for selected menu items.
</span><span class="cx"> return (m_object->isChecked()) ? [NSString stringWithCharacters:&ch length:1] : nil;
</span><span class="cx"> }
</span><del>-
- if ([attributeName isEqualToString: NSAccessibilityMinValueAttribute])
</del><ins>+
+ if ([attributeName isEqualToString: NSAccessibilityMinValueAttribute]) {
+ // Indeterminate progress indicator should return 0.
+ if (m_object->isProgressIndicator() && !m_object->hasAttribute(aria_valuenowAttr))
+ return @0;
</ins><span class="cx"> return [NSNumber numberWithFloat:m_object->minValueForRange()];
</span><ins>+ }
</ins><span class="cx">
</span><del>- if ([attributeName isEqualToString: NSAccessibilityMaxValueAttribute])
</del><ins>+ if ([attributeName isEqualToString: NSAccessibilityMaxValueAttribute]) {
+ // Indeterminate progress indicator should return 0.
+ if (m_object->isProgressIndicator() && !m_object->hasAttribute(aria_valuenowAttr))
+ return @0;
</ins><span class="cx"> return [NSNumber numberWithFloat:m_object->maxValueForRange()];
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> if ([attributeName isEqualToString: NSAccessibilityHelpAttribute])
</span><span class="cx"> return [self baseAccessibilityHelpText];
</span></span></pre>
</div>
</div>
</body>
</html>