<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182509] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182509">182509</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-07 16:42:16 -0700 (Tue, 07 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get the features.json files ready for open contributions
https://bugs.webkit.org/show_bug.cgi?id=143436
Reviewed by Darin Adler.
Source/JavaScriptCore:
* features.json:
Source/WebCore:
* features.json:
Tools:
* Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONFeaturesChecker.check):
Extend the syntax checking a bit, but leave everything non-mandatory
very loose until we figure what fields are important.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorefeaturesjson">trunk/Source/JavaScriptCore/features.json</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorefeaturesjson">trunk/Source/WebCore/features.json</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckersjsoncheckerpy">trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-04-07 Benjamin Poulain <benjamin@webkit.org>
+
+ Get the features.json files ready for open contributions
+ https://bugs.webkit.org/show_bug.cgi?id=143436
+
+ Reviewed by Darin Adler.
+
+ * features.json:
+
</ins><span class="cx"> 2015-04-07 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Constant folding of typed array properties should be handled by AI rather than strength reduction
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorefeaturesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/features.json (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/features.json 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Source/JavaScriptCore/features.json 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -7,6 +7,7 @@
</span><span class="cx"> },
</span><span class="cx"> {
</span><span class="cx"> "name": "ES7",
</span><ins>+ "url": "https://github.com/tc39/ecma262",
</ins><span class="cx"> "keywords": ["es7", "ecmascript"]
</span><span class="cx"> }
</span><span class="cx"> ],
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Source/WebCore/ChangeLog 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-04-07 Benjamin Poulain <benjamin@webkit.org>
+
+ Get the features.json files ready for open contributions
+ https://bugs.webkit.org/show_bug.cgi?id=143436
+
+ Reviewed by Darin Adler.
+
+ * features.json:
+
</ins><span class="cx"> 2015-04-07 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> More unreviewed fixing API tests.
</span></span></pre></div>
<a id="trunkSourceWebCorefeaturesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/features.json (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/features.json 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Source/WebCore/features.json 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -1,39 +1,114 @@
</span><span class="cx"> {
</span><span class="cx"> "specification": [
</span><span class="cx"> {
</span><del>- "name": "HTML5",
- "url": "https://html.spec.whatwg.org",
- "keywords": ["html", "html5", "html5.1"],
- "category": "html"
</del><ins>+ "name": "CSS Media Queries Level 4",
+ "url": "http://dev.w3.org/csswg/mediaqueries-4/",
+ "keywords": ["css media queries", "media queries"],
+ "category": "css"
</ins><span class="cx"> },
</span><span class="cx"> {
</span><ins>+ "name": "CSS Selectors Level 4",
+ "url": "http://dev.w3.org/csswg/selectors-4/",
+ "keywords": ["css selectors", "selectors"],
+ "category": "css"
+ },
+ {
</ins><span class="cx"> "name": "DOM",
</span><span class="cx"> "url": "https://dom.spec.whatwg.org",
</span><span class="cx"> "keywords": ["dom", "dom4"],
</span><span class="cx"> "category": "html"
</span><span class="cx"> },
</span><span class="cx"> {
</span><ins>+ "name": "HTML5",
+ "url": "https://html.spec.whatwg.org",
+ "keywords": ["html", "html5", "html5.1"],
+ "category": "html"
+ },
+ {
</ins><span class="cx"> "name": "Streams",
</span><span class="cx"> "url": "https://streams.spec.whatwg.org",
</span><span class="cx"> "keywords": ["streams api"],
</span><span class="cx"> "category": "webapps"
</span><del>- },
- {
- "name": "CSS Selectors Level 4",
- "url": "http://dev.w3.org/csswg/selectors-4/",
- "keywords": ["css selectors", "selectors"],
- "category": "css"
- },
- {
- "name": "CSS Media Queries Level 4",
- "url": "http://dev.w3.org/csswg/mediaqueries-4/",
- "keywords": ["css media queries", "media queries"],
- "category": "css"
</del><span class="cx"> }
</span><span class="cx"> ],
</span><span class="cx">
</span><span class="cx"> "features": [
</span><span class="cx"> {
</span><ins>+ "name": "CSS Selector :any-link",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#the-any-link-pseudo",
+ "specification": "CSS Selectors Level 4",
+ "description": "The pseudo class :any-link matches any element that would match :link or :visisted.",
+ "comment": "A prefix version :-webkit-any-link has been available for a while but it was not 100% compliant to the specification."
+ },
+ {
+ "name": "CSS Selector :lang() level 4",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#the-lang-pseudo",
+ "specification": "CSS Selectors Level 4",
+ "description": "The selector :lang() is extended in level 4 to support a list of language range, each range can contain a wildcard. For example: p:lang(\"*-be\", \"en\")."
+ },
+ {
+ "name": "CSS Selector :matches()",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#matches",
+ "specification": "CSS Selectors Level 4",
+ "description": "The selector :matches() takes a selector list as argument and matches an element if any of them matches (e.g. :matches(article > section, #target)). When used for styling, the specificity of :matches() is the higest specificity of all selectors in the selector list.",
+ "comment": "The pseudo classes <em>:visited</em> and <em>:link</em> are not supported inside :matches()."
+ },
+ {
+ "name": "CSS Selector :not() level 4",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#negation",
+ "specification": "CSS Selectors Level 4",
+ "description": "The selector :not() in level 4 supports full selector lists as argument. For example: :not(:any-link >> img, :any-link >> picture).",
+ "comment": "The pseudo classes <em>:visited</em> and <em>:link</em> are not supported inside :not()."
+ },
+ {
+ "name": "CSS Selector :nth-child(An+B of selector list) and :nth-last-child(An+B of selector list)",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#the-nth-child-pseudo",
+ "specification": "CSS Selectors Level 4",
+ "description": "The pseudo classes :nth-child() and :nth-last-child() now supports a selector list that filters what to count. For example: \":nth-child(even of .visible)\".",
+ "comment": "The pseudo classes <em>:visited</em> and <em>:link</em> are not supported inside :nth-child() and :nth-last-child()."
+ },
+ {
+ "name": "CSS Selector :placeholder-shown",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#placeholder",
+ "specification": "CSS Selectors Level 4",
+ "description": "The selector :placeholder-shown matches any input element that has a visible placeholder.",
+ "comment": "Styling the placeholder can be done through the WebKit pseudo-element \"::-webkit-input-placeholder\"."
+ },
+ {
+ "name": "Case-insensitive attribute selectors",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/selectors-4/#attribute-case",
+ "specification": "CSS Selectors Level 4",
+ "description": "Any attribute selector that test a value can take a flag \"i\" to use case insensitive checks. For example: input[type=number i] test the value \"number\" case-insensitively."
+ },
+ {
</ins><span class="cx"> "name": "Element.closest()",
</span><span class="cx"> "status": {
</span><span class="cx"> "status": "Done",
</span><span class="lines">@@ -55,13 +130,35 @@
</span><span class="cx"> "description": "Provide the events necessary to handle force click events in the page, overriding the default behavior."
</span><span class="cx"> },
</span><span class="cx"> {
</span><ins>+ "name": "Interaction Media Features (pointer, hover, any-pointer, any-hover)",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction",
+ "specification": "CSS Media Queries Level 4",
+ "description": "The \"pointer\" media defines how percise the pointing device is. The \"hover\" media defines the ability of the poiting device to hover elements."
+ },
+ {
+ "name": "Navigator.hardwareConcurrency",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "https://wiki.whatwg.org/wiki/Navigator_HW_Concurrency",
+ "webkit-url": "http://trac.webkit.org/changeset/169017",
+ "description": "Navigator.hardwareConcurrency provides the total number of logical processors available to the user agent."
+ },
+ {
</ins><span class="cx"> "name": "Readable Streams",
</span><span class="cx"> "status": {
</span><span class="cx"> "status": "In Development",
</span><span class="cx"> "enabled-by-default": true
</span><span class="cx"> },
</span><span class="cx"> "url": "https://streams.spec.whatwg.org/#rs",
</span><del>- "specification": "Streams"
</del><ins>+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=138967",
+ "specification": "Streams",
+ "comment": "The ReadableStream and ReadableStreamReader interfaces are available but not functional."
</ins><span class="cx"> }
</span><span class="cx"> ]
</span><span class="cx"> }
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Tools/ChangeLog 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-04-07 Benjamin Poulain <benjamin@webkit.org>
+
+ Get the features.json files ready for open contributions
+ https://bugs.webkit.org/show_bug.cgi?id=143436
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/style/checkers/jsonchecker.py:
+ (JSONFeaturesChecker.check):
+ Extend the syntax checking a bit, but leave everything non-mandatory
+ very loose until we figure what fields are important.
+
</ins><span class="cx"> 2015-04-07 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Expose and test fixedLayoutSize via modern WebKit SPI
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckersjsoncheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py (182508 => 182509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2015-04-07 23:37:13 UTC (rev 182508)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2015-04-07 23:42:16 UTC (rev 182509)
</span><span class="lines">@@ -24,8 +24,8 @@
</span><span class="cx">
</span><span class="cx"> import json
</span><span class="cx"> import re
</span><ins>+from sets import Set
</ins><span class="cx">
</span><del>-
</del><span class="cx"> class JSONChecker(object):
</span><span class="cx"> """Processes JSON lines for checking style."""
</span><span class="cx">
</span><span class="lines">@@ -69,12 +69,42 @@
</span><span class="cx"> self._handle_style_error(0, 'json/syntax', 5, '"features" key not found, the key is mandatory.')
</span><span class="cx"> return
</span><span class="cx">
</span><ins>+ specification_name_set = Set()
+ if 'specification' in features_definition:
+ previous_specification_name = ''
+ for specification_object in features_definition['specification']:
+ if 'name' not in specification_object or not specification_object['name']:
+ self._handle_style_error(0, 'json/syntax', 5, 'The "name" field is mandatory for specifications.')
+ continue
+ name = specification_object['name']
+
+ if name < previous_specification_name:
+ self._handle_style_error(0, 'json/syntax', 5, 'The specifications should be sorted alphabetically by name, "%s" appears after "%s".' % (name, previous_specification_name))
+ previous_specification_name = name
+
+ specification_name_set.add(name)
+ if 'url' not in specification_object or not specification_object['url']:
+ self._handle_style_error(0, 'json/syntax', 5, 'The specifciation "%s" does not have an URL' % name)
+ continue
+
</ins><span class="cx"> features_list = features_definition['features']
</span><ins>+ previous_feature_name = ''
</ins><span class="cx"> for i in xrange(len(features_list)):
</span><span class="cx"> feature = features_list[i]
</span><del>- if 'name' not in feature:
</del><ins>+ feature_name = 'Feature %s' % i
+ if 'name' not in feature or not feature['name']:
</ins><span class="cx"> self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "name".' % i)
</span><del>- if 'status' not in feature:
- self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "status".' % i)
</del><ins>+ else:
+ feature_name = feature['name']
+
+ if feature_name < previous_feature_name:
+ self._handle_style_error(0, 'json/syntax', 5, 'The features should be sorted alphabetically by name, "%s" appears after "%s".' % (feature_name, previous_feature_name))
+ previous_feature_name = feature_name
+
+ if 'status' not in feature or not feature['status']:
+ self._handle_style_error(0, 'json/syntax', 5, 'The feature "%s" does not have the mandatory field "status".' % feature_name)
+ if 'specification' in feature:
+ if feature['specification'] not in specification_name_set:
+ self._handle_style_error(0, 'json/syntax', 5, 'The feature "%s" has a specification field but no specification of that name exists.' % feature_name)
</ins><span class="cx"> except:
</span><span class="cx"> pass
</span></span></pre>
</div>
</div>
</body>
</html>