<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182364] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182364">182364</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-04-05 13:17:11 -0700 (Sun, 05 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove "go ahead and" from comments
https://bugs.webkit.org/show_bug.cgi?id=143421
Reviewed by Darin Adler, Benjamin Poulain.
Remove the phrase "go ahead and" from comments where it doesn't add
anything (which is almost all of them).
Source/JavaScriptCore:
* interpreter/JSStack.cpp:
(JSC::JSStack::growSlowCase):
Source/WebCore:
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::deleteOriginLockFor):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat):
* css/CSSPrimitiveValue.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addIncrementalDataBuffer):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport):
* page/PageOverlay.cpp:
(WebCore::PageOverlay::fadeAnimationTimerFired):
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::create):
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPRefresh):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::appendRunsForObject):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleWillChange):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::dirtyRange):
* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleText):
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
* style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
Source/WebKit/mac:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView updateScrollers]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):
Source/WebKit2:
* Platform/unix/EnvironmentUtilities.cpp:
(WebKit::EnvironmentUtilities::stripValuesEndingWithString):
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didClose):
* UIProcess/API/mac/WKView.mm:
(-[WKView insertText:replacementRange:]):
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinterpreterJSStackcpp">trunk/Source/JavaScriptCore/interpreter/JSStack.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSFontFaceSrcValuecpp">trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValueh">trunk/Source/WebCore/css/CSSPrimitiveValue.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingApplyStyleCommandcpp">trunk/Source/WebCore/editing/ApplyStyleCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderDocumentLoadercpp">trunk/Source/WebCore/loader/DocumentLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedImagecpp">trunk/Source/WebCore/loader/cache/CachedImage.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadericonIconDatabasecpp">trunk/Source/WebCore/loader/icon/IconDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageOverlaycpp">trunk/Source/WebCore/page/PageOverlay.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewcpp">trunk/Source/WebCore/platform/ScrollView.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsDisplayRefreshMonitorcpp">trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsContextcpp">trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacComplexTextControllercpp">trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkHTTPParserscpp">trunk/Source/WebCore/platform/network/HTTPParsers.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockcpp">trunk/Source/WebCore/rendering/RenderBlock.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockLineLayoutcpp">trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxModelObjectcpp">trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerModelObjectcpp">trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLineBoxListcpp">trunk/Source/WebCore/rendering/RenderLineBoxList.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTextLineBoxescpp">trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderinglineBreakingContexth">trunk/Source/WebCore/rendering/line/BreakingContext.h</a></li>
<li><a href="#trunkSourceWebCorerenderinglineLineBreakercpp">trunk/Source/WebCore/rendering/line/LineBreaker.cpp</a></li>
<li><a href="#trunkSourceWebCorestyleStyleResolveTreecpp">trunk/Source/WebCore/style/StyleResolveTree.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLHttpRequestProgressEventThrottlecpp">trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlparserXMLDocumentParsercpp">trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebDynamicScrollBarsViewmm">trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLViewmm">trunk/Source/WebKit/mac/WebView/WebHTMLView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformunixEnvironmentUtilitiescpp">trunk/Source/WebKit2/Platform/unix/EnvironmentUtilities.cpp</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessPluginProcesscpp">trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessStorageLocalStorageDatabaseTrackercpp">trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-04-05 Simon Fraser <simon.fraser@apple.com>
+
+ Remove "go ahead and" from comments
+ https://bugs.webkit.org/show_bug.cgi?id=143421
+
+ Reviewed by Darin Adler, Benjamin Poulain.
+
+ Remove the phrase "go ahead and" from comments where it doesn't add
+ anything (which is almost all of them).
+
+ * interpreter/JSStack.cpp:
+ (JSC::JSStack::growSlowCase):
+
</ins><span class="cx"> 2015-04-04 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Logically empty WeakBlocks should not pin down their MarkedBlocks indefinitely.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinterpreterJSStackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/interpreter/JSStack.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/interpreter/JSStack.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/JavaScriptCore/interpreter/JSStack.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -97,8 +97,7 @@
</span><span class="cx"> if (newCommitTop < reservationTop())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- // Otherwise, the growth is still within our budget. Go ahead and commit
- // it and return true.
</del><ins>+ // Otherwise, the growth is still within our budget. Commit it and return true.
</ins><span class="cx"> m_reservation.commit(newCommitTop, delta);
</span><span class="cx"> addToCommittedByteCount(delta);
</span><span class="cx"> m_commitTop = newCommitTop;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/ChangeLog 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1,3 +1,87 @@
</span><ins>+2015-04-05 Simon Fraser <simon.fraser@apple.com>
+
+ Remove "go ahead and" from comments
+ https://bugs.webkit.org/show_bug.cgi?id=143421
+
+ Reviewed by Darin Adler, Benjamin Poulain.
+
+ Remove the phrase "go ahead and" from comments where it doesn't add
+ anything (which is almost all of them).
+
+ * Modules/webdatabase/DatabaseTracker.cpp:
+ (WebCore::DatabaseTracker::deleteOriginLockFor):
+ * css/CSSFontFaceSrcValue.cpp:
+ (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
+ * css/CSSPrimitiveValue.h:
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::styleForKeyframe):
+ (WebCore::StyleResolver::styleForPage):
+ (WebCore::StyleResolver::applyMatchedProperties):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::detachFromFrame):
+ * loader/cache/CachedImage.cpp:
+ (WebCore::CachedImage::addIncrementalDataBuffer):
+ * loader/icon/IconDatabase.cpp:
+ (WebCore::IconDatabase::performURLImport):
+ * page/PageOverlay.cpp:
+ (WebCore::PageOverlay::fadeAnimationTimerFired):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::updateScrollbars):
+ (WebCore::ScrollView::scrollContents):
+ * platform/graphics/DisplayRefreshMonitor.cpp:
+ (WebCore::DisplayRefreshMonitor::create):
+ * platform/graphics/GraphicsContext.cpp:
+ * platform/graphics/mac/ComplexTextController.cpp:
+ (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
+ * platform/network/HTTPParsers.cpp:
+ (WebCore::parseHTTPRefresh):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::removeChild):
+ (WebCore::RenderBlock::layoutPositionedObjects):
+ (WebCore::RenderBlock::selectionGaps):
+ (WebCore::RenderBlock::blockSelectionGaps):
+ (WebCore::RenderBlock::absoluteRects):
+ (WebCore::RenderBlock::absoluteQuads):
+ (WebCore::RenderBlock::addFocusRingRects):
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::layoutBlockChild):
+ (WebCore::RenderBlockFlow::handleAfterSideOfBlock):
+ (WebCore::RenderBlockFlow::adjustBlockChildForPagination):
+ (WebCore::RenderBlockFlow::insertFloatingObject):
+ (WebCore::RenderBlockFlow::addOverhangingFloats):
+ (WebCore::RenderBlockFlow::inlineSelectionGaps):
+ (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlockFlow::appendRunsForObject):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::positionLineBox):
+ (WebCore::RenderBox::sizesLogicalWidthToFitContent):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::RenderLayer::hitTestLayer):
+ (WebCore::RenderLayer::calculateClipRects):
+ * rendering/RenderLayerModelObject.cpp:
+ (WebCore::RenderLayerModelObject::styleWillChange):
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
+ * rendering/RenderTextLineBoxes.cpp:
+ (WebCore::RenderTextLineBoxes::dirtyRange):
+ * rendering/line/BreakingContext.h:
+ (WebCore::BreakingContext::handleOutOfFlowPositioned):
+ (WebCore::BreakingContext::handleText):
+ * rendering/line/LineBreaker.cpp:
+ (WebCore::LineBreaker::nextLineBreak):
+ * style/StyleResolveTree.cpp:
+ (WebCore::Style::resolveLocal):
+ * xml/XMLHttpRequestProgressEventThrottle.cpp:
+ (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):
+ * xml/parser/XMLDocumentParser.cpp:
+ (WebCore::XMLDocumentParser::append):
+
</ins><span class="cx"> 2015-04-04 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [Content Filtering] Blocked page is not always displayed when it should be
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseTrackercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -684,8 +684,7 @@
</span><span class="cx"> // files in this origin. We'll give the OriginLock one chance to do an
</span><span class="cx"> // orderly clean up first when we remove its ref from the m_originLockMap.
</span><span class="cx"> // This may or may not be possible depending on whether other threads are
</span><del>- // also using the OriginLock at the same time. After that, we will go ahead
- // and delete the lock file.
</del><ins>+ // also using the OriginLock at the same time. After that, we will delete the lock file.
</ins><span class="cx">
</span><span class="cx"> m_originLockMap.remove(origin->databaseIdentifier());
</span><span class="cx"> OriginLock::deleteLockFile(originPath(origin));
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFontFaceSrcValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/css/CSSFontFaceSrcValue.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> bool CSSFontFaceSrcValue::isSupportedFormat() const
</span><span class="cx"> {
</span><span class="cx"> // Normally we would just check the format, but in order to avoid conflicts with the old WinIE style of font-face,
</span><del>- // we will also check to see if the URL ends with .eot. If so, we'll go ahead and assume that we shouldn't load it.
</del><ins>+ // we will also check to see if the URL ends with .eot. If so, we'll assume that we shouldn't load it.
</ins><span class="cx"> if (m_format.isEmpty()) {
</span><span class="cx"> // Check for .eot.
</span><span class="cx"> if (!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false))
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -59,8 +59,7 @@
</span><span class="cx"> const int minValueForCssLength = intMinForLayoutUnit + 2;
</span><span class="cx">
</span><span class="cx"> // Dimension calculations are imprecise, often resulting in values of e.g.
</span><del>-// 44.99998. We need to go ahead and round if we're really close to the next
-// integer value.
</del><ins>+// 44.99998. We need to round if we're really close to the next integer value.
</ins><span class="cx"> template<typename T> inline T roundForImpreciseConversion(double value)
</span><span class="cx"> {
</span><span class="cx"> value += (value < 0) ? -0.01 : +0.01;
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -868,14 +868,13 @@
</span><span class="cx">
</span><span class="cx"> applyCascadedProperties(cascade, firstCSSProperty, lastHighPriorityProperty);
</span><span class="cx">
</span><del>- // If our font got dirtied, go ahead and update it now.
</del><ins>+ // If our font got dirtied, update it now.
</ins><span class="cx"> updateFont();
</span><span class="cx">
</span><span class="cx"> // Now do rest of the properties.
</span><span class="cx"> applyCascadedProperties(cascade, firstLowPriorityProperty, lastCSSProperty);
</span><span class="cx">
</span><del>- // If our font got dirtied by one of the non-essential font props,
- // go ahead and update it a second time.
</del><ins>+ // If our font got dirtied by one of the non-essential font props, update it a second time.
</ins><span class="cx"> updateFont();
</span><span class="cx">
</span><span class="cx"> cascade.applyDeferredProperties(*this);
</span><span class="lines">@@ -1034,7 +1033,7 @@
</span><span class="cx">
</span><span class="cx"> applyCascadedProperties(cascade, firstCSSProperty, lastHighPriorityProperty);
</span><span class="cx">
</span><del>- // If our font got dirtied, go ahead and update it now.
</del><ins>+ // If our font got dirtied, update it now.
</ins><span class="cx"> updateFont();
</span><span class="cx">
</span><span class="cx"> applyCascadedProperties(cascade, firstLowPriorityProperty, lastCSSProperty);
</span><span class="lines">@@ -1790,7 +1789,7 @@
</span><span class="cx"> if (cacheItem && cacheItem->renderStyle->effectiveZoom() != state.style()->effectiveZoom())
</span><span class="cx"> return applyMatchedProperties(matchResult, element, DoNotUseMatchedPropertiesCache);
</span><span class="cx">
</span><del>- // If our font got dirtied, go ahead and update it now.
</del><ins>+ // If our font got dirtied, update it now.
</ins><span class="cx"> updateFont();
</span><span class="cx">
</span><span class="cx"> // If the font changed, we can't use the matched properties cache. Start over.
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingApplyStyleCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1065,7 +1065,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Apply style to all nodes containing targetNode and their siblings but NOT to targetNode
</span><del>- // But if we've removed styledElement then go ahead and always apply the style.
</del><ins>+ // But if we've removed styledElement then always apply the style.
</ins><span class="cx"> if (&child != targetNode || styledElement)
</span><span class="cx"> applyInlineStyleToPushDown(&child, styleToPushDown.get());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderDocumentLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -906,7 +906,7 @@
</span><span class="cx"> Ref<DocumentLoader> protectLoader(*this);
</span><span class="cx">
</span><span class="cx"> // It never makes sense to have a document loader that is detached from its
</span><del>- // frame have any loads active, so go ahead and kill all the loads.
</del><ins>+ // frame have any loads active, so kill all the loads.
</ins><span class="cx"> stopLoading();
</span><span class="cx"> if (m_mainResource && m_mainResource->hasClient(this))
</span><span class="cx"> m_mainResource->removeClient(this);
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -390,9 +390,8 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Go ahead and tell our observers to try to draw.
- // Each chunk from the network causes observers to repaint, which will
- // force that chunk to decode.
</del><ins>+ // Tell our observers to try to draw.
+ // Each chunk from the network causes observers to repaint, which will force that chunk to decode.
</ins><span class="cx"> // It would be nice to only redraw the decoded band of the image, but with the current design
</span><span class="cx"> // (decoding delayed until painting) that seems hard.
</span><span class="cx"> notifyObservers();
</span></span></pre></div>
<a id="trunkSourceWebCoreloadericonIconDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/icon/IconDatabase.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/icon/IconDatabase.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1221,7 +1221,7 @@
</span><span class="cx">
</span><span class="cx"> // If the pageRecord doesn't exist in this map, then no one has retained this pageURL
</span><span class="cx"> // If the s_databaseCleanupCounter count is non-zero, then we're not supposed to be pruning the database in any manner,
</span><del>- // so go ahead and actually create a pageURLRecord for this url even though it's not retained.
</del><ins>+ // so actually create a pageURLRecord for this url even though it's not retained.
</ins><span class="cx"> // If database cleanup *is* allowed, we don't want to bother pulling in a page url from disk that noone is actually interested
</span><span class="cx"> // in - we'll prune it later instead!
</span><span class="cx"> if (!pageRecord && databaseCleanupCounter && documentCanHaveIcon(pageURL)) {
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageOverlaycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageOverlay.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageOverlay.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/page/PageOverlay.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -251,7 +251,7 @@
</span><span class="cx"> bool wasFadingOut = m_fadeAnimationType == FadeOutAnimation;
</span><span class="cx"> m_fadeAnimationType = NoAnimation;
</span><span class="cx">
</span><del>- // If this was a fade out, go ahead and uninstall the page overlay.
</del><ins>+ // If this was a fade out, uninstall the page overlay.
</ins><span class="cx"> if (wasFadingOut)
</span><span class="cx"> controller()->uninstallPageOverlay(this, PageOverlay::FadeMode::DoNotFade);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -604,8 +604,8 @@
</span><span class="cx">
</span><span class="cx"> bool hasOverlayScrollbars = (!m_horizontalScrollbar || m_horizontalScrollbar->isOverlayScrollbar()) && (!m_verticalScrollbar || m_verticalScrollbar->isOverlayScrollbar());
</span><span class="cx">
</span><del>- // If we came in here with the view already needing a layout, then go ahead and do that
- // first. (This will be the common case, e.g., when the page changes due to window resizing for example).
</del><ins>+ // If we came in here with the view already needing a layout then do that first.
+ // (This will be the common case, e.g., when the page changes due to window resizing for example).
</ins><span class="cx"> // This layout will not re-enter updateScrollbars and does not count towards our max layout pass total.
</span><span class="cx"> if (!m_scrollbarsSuppressed && !hasOverlayScrollbars) {
</span><span class="cx"> m_inUpdateScrollbars = true;
</span><span class="lines">@@ -839,9 +839,8 @@
</span><span class="cx"> if (!scrollContentsFastPath(-scrollDelta, scrollViewRect, clipRect))
</span><span class="cx"> scrollContentsSlowPath(updateRect);
</span><span class="cx"> } else {
</span><del>- // We need to go ahead and repaint the entire backing store. Do it now before moving the
- // windowed plugins.
- scrollContentsSlowPath(updateRect);
</del><ins>+ // We need to repaint the entire backing store. Do it now before moving the windowed plugins.
+ scrollContentsSlowPath(updateRect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Invalidate the overhang areas if they are visible.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsDisplayRefreshMonitorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> if (Optional<RefPtr<DisplayRefreshMonitor>> monitor = client->createDisplayRefreshMonitor(displayID))
</span><span class="cx"> return monitor.value();
</span><span class="cx">
</span><del>- // If ChromeClient returned Nullopt, we'll go ahead and make one of the default type.
</del><ins>+ // If ChromeClient returned Nullopt, we'll make one of the default type.
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> return DisplayRefreshMonitorMac::create(displayID);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -562,8 +562,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !USE(CG)
</span><del>-// Implement this if you want to go ahead and push the drawing mode into your native context
-// immediately.
</del><ins>+// Implement this if you want to go push the drawing mode into your native context immediately.
</ins><span class="cx"> void GraphicsContext::setPlatformTextDrawingMode(TextDrawingModeFlags)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacComplexTextControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -689,7 +689,7 @@
</span><span class="cx"> advance.width = font.adjustedSpaceWidth();
</span><span class="cx">
</span><span class="cx"> if (hasExtraSpacing) {
</span><del>- // If we're a glyph with an advance, go ahead and add in letter-spacing.
</del><ins>+ // If we're a glyph with an advance, add in letter-spacing.
</ins><span class="cx"> // That way we weed out zero width lurkers. This behavior matches the fast text code path.
</span><span class="cx"> if (advance.width)
</span><span class="cx"> advance.width += m_font.letterSpacing();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkHTTPParserscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/HTTPParsers.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -223,7 +223,7 @@
</span><span class="cx">
</span><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=27868
</span><span class="cx"> // Sometimes there is no closing quote for the end of the URL even though there was an opening quote.
</span><del>- // If we looped over the entire alleged URL string back to the opening quote, just go ahead and use everything
</del><ins>+ // If we looped over the entire alleged URL string back to the opening quote, just use everything
</ins><span class="cx"> // after the opening quote instead.
</span><span class="cx"> if (urlEndPos == urlStartPos)
</span><span class="cx"> urlEndPos = len;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -691,9 +691,8 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // If this child is a block, and if our previous and next siblings are
- // both anonymous blocks with inline content, then we can go ahead and
- // fold the inline content back together.
</del><ins>+ // If this child is a block, and if our previous and next siblings are both anonymous blocks
+ // with inline content, then we can fold the inline content back together.
</ins><span class="cx"> RenderObject* prev = oldChild.previousSibling();
</span><span class="cx"> RenderObject* next = oldChild.nextSibling();
</span><span class="cx"> bool canMergeAnonymousBlocks = canMergeContiguousAnonymousBlocks(oldChild, prev, next);
</span><span class="lines">@@ -747,8 +746,7 @@
</span><span class="cx"> RenderObject* child = prev ? prev : next;
</span><span class="cx"> if (canMergeAnonymousBlocks && child && !child->previousSibling() && !child->nextSibling() && canCollapseAnonymousBlockChild()) {
</span><span class="cx"> // The removal has knocked us down to containing only a single anonymous
</span><del>- // box. We can go ahead and pull the content right back up into our
- // box.
</del><ins>+ // box. We can pull the content right back up into our box.
</ins><span class="cx"> collapseAnonymousBoxChild(*this, downcast<RenderBlock>(child));
</span><span class="cx"> } else if (((prev && prev->isAnonymousBlock()) || (next && next->isAnonymousBlock())) && canCollapseAnonymousBlockChild()) {
</span><span class="cx"> // It's possible that the removal has knocked us down to a single anonymous
</span><span class="lines">@@ -1331,7 +1329,7 @@
</span><span class="cx"> if (r.needsPositionedMovementLayoutOnly() && r.tryLayoutDoingPositionedMovementOnly())
</span><span class="cx"> r.clearNeedsLayout();
</span><span class="cx">
</span><del>- // If we are paginated or in a line grid, go ahead and compute a vertical position for our object now.
</del><ins>+ // If we are paginated or in a line grid, compute a vertical position for our object now.
</ins><span class="cx"> // If it's wrong we'll lay out again.
</span><span class="cx"> LayoutUnit oldLogicalTop = 0;
</span><span class="cx"> bool needsBlockDirectionLocationSetBeforeLayout = r.needsLayout() && view().layoutState()->needsBlockDirectionLocationSetBeforeLayout();
</span><span class="lines">@@ -1860,7 +1858,7 @@
</span><span class="cx"> else
</span><span class="cx"> result = blockSelectionGaps(rootBlock, rootBlockPhysicalPosition, offsetFromRootBlock, lastLogicalTop, lastLogicalLeft, lastLogicalRight, cache, paintInfo);
</span><span class="cx">
</span><del>- // Go ahead and fill the vertical gap all the way to the bottom of our block if the selection extends past our block.
</del><ins>+ // Fill the vertical gap all the way to the bottom of our block if the selection extends past our block.
</ins><span class="cx"> if (&rootBlock == this && (selectionState() != SelectionBoth && selectionState() != SelectionEnd) && !isRubyBase() && !isRubyText()) {
</span><span class="cx"> result.uniteCenter(blockSelectionGap(rootBlock, rootBlockPhysicalPosition, offsetFromRootBlock,
</span><span class="cx"> lastLogicalTop, lastLogicalLeft, lastLogicalRight, logicalHeight(), cache, paintInfo));
</span><span class="lines">@@ -1880,7 +1878,7 @@
</span><span class="cx"> {
</span><span class="cx"> GapRects result;
</span><span class="cx">
</span><del>- // Go ahead and jump right to the first block child that contains some selected objects.
</del><ins>+ // Jump right to the first block child that contains some selected objects.
</ins><span class="cx"> RenderBox* curr;
</span><span class="cx"> for (curr = firstChildBox(); curr && curr->selectionState() == SelectionNone; curr = curr->nextSiblingBox()) { }
</span><span class="cx">
</span><span class="lines">@@ -1936,7 +1934,7 @@
</span><span class="cx"> lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, curr->logicalBottom(), cache);
</span><span class="cx"> lastLogicalRight = logicalRightSelectionOffset(rootBlock, curr->logicalBottom(), cache);
</span><span class="cx"> } else if (childState != SelectionNone && is<RenderBlock>(*curr)) {
</span><del>- // We must be a block that has some selected object inside it. Go ahead and recur.
</del><ins>+ // We must be a block that has some selected object inside it, so recur.
</ins><span class="cx"> result.unite(downcast<RenderBlock>(*curr).selectionGaps(rootBlock, rootBlockPhysicalPosition, LayoutSize(offsetFromRootBlock.width() + curr->x(), offsetFromRootBlock.height() + curr->y()),
</span><span class="cx"> lastLogicalTop, lastLogicalLeft, lastLogicalRight, childCache, paintInfo));
</span><span class="cx"> }
</span><span class="lines">@@ -3312,9 +3310,8 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlock::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
</span><span class="cx"> {
</span><del>- // For blocks inside inlines, we go ahead and include margins so that we run right up to the
- // inline boxes above and below us (thus getting merged with them to form a single irregular
- // shape).
</del><ins>+ // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+ // above and below us (thus getting merged with them to form a single irregular shape).
</ins><span class="cx"> if (isAnonymousBlockContinuation()) {
</span><span class="cx"> // FIXME: This is wrong for block-flows that are horizontal.
</span><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=46781
</span><span class="lines">@@ -3328,9 +3325,8 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlock::absoluteQuads(Vector<FloatQuad>& quads, bool* wasFixed) const
</span><span class="cx"> {
</span><del>- // For blocks inside inlines, we go ahead and include margins so that we run right up to the
- // inline boxes above and below us (thus getting merged with them to form a single irregular
- // shape).
</del><ins>+ // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+ // above and below us (thus getting merged with them to form a single irregular shape).
</ins><span class="cx"> FloatRect localRect = isAnonymousBlockContinuation()
</span><span class="cx"> ? FloatRect(0, -collapsedMarginBefore(), width(), height() + collapsedMarginBefore() + collapsedMarginAfter())
</span><span class="cx"> : FloatRect(0, 0, width(), height());
</span><span class="lines">@@ -3413,9 +3409,8 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlock::addFocusRingRects(Vector<IntRect>& rects, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer)
</span><span class="cx"> {
</span><del>- // For blocks inside inlines, we go ahead and include margins so that we run right up to the
- // inline boxes above and below us (thus getting merged with them to form a single irregular
- // shape).
</del><ins>+ // For blocks inside inlines, we include margins so that we run right up to the inline boxes
+ // above and below us (thus getting merged with them to form a single irregular shape).
</ins><span class="cx"> if (inlineElementContinuation()) {
</span><span class="cx"> // FIXME: This check really isn't accurate.
</span><span class="cx"> bool nextInlineHasLineBox = inlineElementContinuation()->firstLineBox();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -671,7 +671,7 @@
</span><span class="cx"> #if !ASSERT_DISABLED
</span><span class="cx"> LayoutSize oldLayoutDelta = view().layoutDelta();
</span><span class="cx"> #endif
</span><del>- // Go ahead and position the child as though it didn't collapse with the top.
</del><ins>+ // Position the child as though it didn't collapse with the top.
</ins><span class="cx"> setLogicalTopForChild(child, logicalTopEstimate, ApplyLayoutDelta);
</span><span class="cx"> estimateRegionRangeForBoxChild(child);
</span><span class="cx">
</span><span class="lines">@@ -728,10 +728,8 @@
</span><span class="cx"> // when collapseMargins dynamically adds overhanging floats because of a child with negative margins.
</span><span class="cx"> if (logicalTopAfterClear != logicalTopEstimate || child.needsLayout() || (paginated && childBlockFlow && childBlockFlow->shouldBreakAtLineToAvoidWidow())) {
</span><span class="cx"> if (child.shrinkToAvoidFloats()) {
</span><del>- // The child's width depends on the line width.
- // When the child shifts to clear an item, its width can
- // change (because it has more available line width).
- // So go ahead and mark the item as dirty.
</del><ins>+ // The child's width depends on the line width. When the child shifts to clear an item, its width can
+ // change (because it has more available line width). So mark the item as dirty.
</ins><span class="cx"> child.setChildNeedsLayout(MarkOnlyThis);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1312,7 +1310,7 @@
</span><span class="cx"> if (is<RenderBlockFlow>(lastBlock) && downcast<RenderBlockFlow>(*lastBlock).isSelfCollapsingBlock())
</span><span class="cx"> setLogicalHeight(logicalHeight() - downcast<RenderBlockFlow>(*lastBlock).marginOffsetForSelfCollapsingBlock());
</span><span class="cx">
</span><del>- // If we can't collapse with children then go ahead and add in the bottom margin.
</del><ins>+ // If we can't collapse with children then add in the bottom margin.
</ins><span class="cx"> if (!marginInfo.discardMargin() && (!marginInfo.canCollapseWithMarginAfter() && !marginInfo.canCollapseWithMarginBefore()
</span><span class="cx"> && (!document().inQuirksMode() || !marginInfo.quirkContainer() || !marginInfo.hasMarginAfterQuirk())))
</span><span class="cx"> setLogicalHeight(logicalHeight() + marginInfo.margin());
</span><span class="lines">@@ -1526,10 +1524,8 @@
</span><span class="cx"> setLogicalTopForChild(child, logicalTopAfterClear, ApplyLayoutDelta);
</span><span class="cx">
</span><span class="cx"> if (child.shrinkToAvoidFloats()) {
</span><del>- // The child's width depends on the line width.
- // When the child shifts to clear an item, its width can
- // change (because it has more available line width).
- // So go ahead and mark the item as dirty.
</del><ins>+ // The child's width depends on the line width. When the child shifts to clear an item, its width can
+ // change (because it has more available line width). So mark the item as dirty.
</ins><span class="cx"> child.setChildNeedsLayout(MarkOnlyThis);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1588,7 +1584,7 @@
</span><span class="cx"> result += paginationStrut;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Similar to how we apply clearance. Go ahead and boost height() to be the place where we're going to position the child.
</del><ins>+ // Similar to how we apply clearance. Boost height() to be the place where we're going to position the child.
</ins><span class="cx"> setLogicalHeight(logicalHeight() + (result - oldTop));
</span><span class="cx">
</span><span class="cx"> // Return the final adjusted logical top.
</span><span class="lines">@@ -2231,8 +2227,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<FloatingObject> floatingObject = FloatingObject::create(floatBox);
</span><span class="cx">
</span><del>- // Our location is irrelevant if we're unsplittable or no pagination is in effect.
- // Just go ahead and lay out the float.
</del><ins>+ // Our location is irrelevant if we're unsplittable or no pagination is in effect. Just lay out the float.
</ins><span class="cx"> bool isChildRenderBlock = floatBox.isRenderBlock();
</span><span class="cx"> if (isChildRenderBlock && !floatBox.needsLayout() && view().layoutState()->pageLogicalHeightChanged())
</span><span class="cx"> floatBox.setChildNeedsLayout(MarkOnlyThis);
</span><span class="lines">@@ -2662,8 +2657,7 @@
</span><span class="cx"> floatingObject->setShouldPaint(true);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Since the float doesn't overhang, it didn't get put into our list. We need to go ahead and add its overflow in to the
- // child now.
</del><ins>+ // Since the float doesn't overhang, it didn't get put into our list. We need to add its overflow in to the child now.
</ins><span class="cx"> if (floatingObject->isDescendant())
</span><span class="cx"> child.addOverflowFromChild(&floatingObject->renderer(), LayoutSize(xPositionForFloatIncludingMargin(floatingObject), yPositionForFloatIncludingMargin(floatingObject)));
</span><span class="cx"> }
</span><span class="lines">@@ -3057,8 +3051,7 @@
</span><span class="cx">
</span><span class="cx"> if (!hasLines()) {
</span><span class="cx"> if (containsStart) {
</span><del>- // Go ahead and update our lastLogicalTop to be the bottom of the block. <hr>s or empty blocks with height can trip this
- // case.
</del><ins>+ // Update our lastLogicalTop to be the bottom of the block. <hr>s or empty blocks with height can trip this case.
</ins><span class="cx"> lastLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + logicalHeight();
</span><span class="cx"> lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, logicalHeight(), cache);
</span><span class="cx"> lastLogicalRight = logicalRightSelectionOffset(rootBlock, logicalHeight(), cache);
</span><span class="lines">@@ -3094,7 +3087,7 @@
</span><span class="cx"> lastSelectedLine = lastRootBox();
</span><span class="cx">
</span><span class="cx"> if (lastSelectedLine && selectionState() != SelectionEnd && selectionState() != SelectionBoth) {
</span><del>- // Go ahead and update our lastY to be the bottom of the last selected line.
</del><ins>+ // Update our lastY to be the bottom of the last selected line.
</ins><span class="cx"> lastLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + lastSelectedLine->selectionBottom();
</span><span class="cx"> lastLogicalLeft = logicalLeftSelectionOffset(rootBlock, lastSelectedLine->selectionBottom(), cache);
</span><span class="cx"> lastLogicalRight = logicalRightSelectionOffset(rootBlock, lastSelectedLine->selectionBottom(), cache);
</span><span class="lines">@@ -4030,10 +4023,9 @@
</span><span class="cx"> bool isAnonymousInlineBlock = child->isAnonymousInlineBlock();
</span><span class="cx">
</span><span class="cx"> if (!child->isBR()) {
</span><del>- // Step One: determine whether or not we need to go ahead and
- // terminate our current line. Each discrete chunk can become
- // the new min-width, if it is the widest chunk seen so far, and
- // it can also become the max-width.
</del><ins>+ // Step One: determine whether or not we need to terminate our current line.
+ // Each discrete chunk can become the new min-width, if it is the widest chunk
+ // seen so far, and it can also become the max-width.
</ins><span class="cx">
</span><span class="cx"> // Children fall into three categories:
</span><span class="cx"> // (1) An inline flow object. These objects always have a min/max of 0,
</span><span class="lines">@@ -4042,8 +4034,8 @@
</span><span class="cx"> //
</span><span class="cx"> // (2) An inline non-text non-flow object, e.g., an inline replaced element.
</span><span class="cx"> // These objects can always be on a line by themselves, so in this situation
</span><del>- // we need to go ahead and break the current line, and then add in our own
- // margins and min/max width on its own line, and then terminate the line.
</del><ins>+ // we need to break the current line, and then add in our own margins and min/max
+ // width on its own line, and then terminate the line.
</ins><span class="cx"> //
</span><span class="cx"> // (3) A text object. Text runs can have breakable characters at the start,
</span><span class="cx"> // the middle or the end. They may also lose whitespace off the front if
</span><span class="lines">@@ -4055,9 +4047,8 @@
</span><span class="cx"> // ends with whitespace.
</span><span class="cx"> // (c) the min/max width of the string (trimmed for whitespace).
</span><span class="cx"> //
</span><del>- // If the text string starts with whitespace, then we need to go ahead and
- // terminate our current line (unless we're already in a whitespace stripping
- // mode.
</del><ins>+ // If the text string starts with whitespace, then we need to terminate our current line
+ // (unless we're already in a whitespace stripping mode.
</ins><span class="cx"> //
</span><span class="cx"> // If the text string has a breakable character in the middle, but didn't start
</span><span class="cx"> // with whitespace, then we add the width of the first non-breakable run and
</span><span class="lines">@@ -4103,8 +4094,7 @@
</span><span class="cx">
</span><span class="cx"> if (!is<RenderInline>(*child) && !is<RenderText>(*child)) {
</span><span class="cx"> // Case (2). Inline replaced elements and floats.
</span><del>- // Go ahead and terminate the current line as far as
- // minwidth is concerned.
</del><ins>+ // Terminate the current line as far as minwidth is concerned.
</ins><span class="cx"> childMin += child->minPreferredLogicalWidth().ceilToFloat();
</span><span class="cx"> childMax += child->maxPreferredLogicalWidth().ceilToFloat();
</span><span class="cx">
</span><span class="lines">@@ -4240,7 +4230,7 @@
</span><span class="cx"> // We have a breakable character. Now we need to know if
</span><span class="cx"> // we start and end with whitespace.
</span><span class="cx"> if (beginWS) {
</span><del>- // Go ahead and end the current line.
</del><ins>+ // End the current line.
</ins><span class="cx"> minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);
</span><span class="cx"> } else {
</span><span class="cx"> inlineMin += beginMin;
</span><span class="lines">@@ -4251,8 +4241,7 @@
</span><span class="cx"> inlineMin = childMin;
</span><span class="cx">
</span><span class="cx"> if (endWS) {
</span><del>- // We end in whitespace, which means we can go ahead
- // and end our current line.
</del><ins>+ // We end in whitespace, which means we can end our current line.
</ins><span class="cx"> minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);
</span><span class="cx"> inlineMin = 0;
</span><span class="cx"> shouldBreakLineAfterText = false;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockLineLayoutcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -103,8 +103,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // An end midpoint has been encountered within our object. We
- // need to go ahead and append a run with our endpoint.
</del><ins>+ // An end midpoint has been encountered within our object. We need to append a run with our endpoint.
</ins><span class="cx"> if (static_cast<int>(nextMidpoint.offset() + 1) <= end) {
</span><span class="cx"> lineMidpointState.setBetweenMidpoints(true);
</span><span class="cx"> lineMidpointState.incrementCurrentMidpoint();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -2082,7 +2082,7 @@
</span><span class="cx"> RootInlineBox& rootBox = box.root();
</span><span class="cx"> rootBox.blockFlow().setStaticInlinePositionForChild(*this, rootBox.lineTopWithLeading(), LayoutUnit::fromFloatRound(box.logicalLeft()));
</span><span class="cx"> if (style().hasStaticInlinePosition(box.isHorizontal()))
</span><del>- setChildNeedsLayout(MarkOnlyThis); // Just go ahead and mark the positioned object as needing layout, so it will update its position properly.
</del><ins>+ setChildNeedsLayout(MarkOnlyThis); // Just mark the positioned object as needing layout, so it will update its position properly.
</ins><span class="cx"> } else {
</span><span class="cx"> // Our object was a block originally, so we make our normal flow position be
</span><span class="cx"> // just below the line box (as though all the inlines that came before us got
</span><span class="lines">@@ -2090,7 +2090,7 @@
</span><span class="cx"> // in flow). This value was cached in the y() of the box.
</span><span class="cx"> layer()->setStaticBlockPosition(box.logicalTop());
</span><span class="cx"> if (style().hasStaticBlockPosition(box.isHorizontal()))
</span><del>- setChildNeedsLayout(MarkOnlyThis); // Just go ahead and mark the positioned object as needing layout, so it will update its position properly.
</del><ins>+ setChildNeedsLayout(MarkOnlyThis); // Just mark the positioned object as needing layout, so it will update its position properly.
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Nuke the box.
</span><span class="lines">@@ -2488,8 +2488,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Flexible box items should shrink wrap, so we lay them out at their intrinsic widths.
</span><del>- // In the case of columns that have a stretch alignment, we go ahead and layout at the
- // stretched size to avoid an extra layout when applying alignment.
</del><ins>+ // In the case of columns that have a stretch alignment, we layout at the stretched size
+ // to avoid an extra layout when applying alignment.
</ins><span class="cx"> if (parent()->isFlexibleBox()) {
</span><span class="cx"> // For multiline columns, we need to apply align-content first, so we can't stretch now.
</span><span class="cx"> if (!parent()->style().isColumnFlexDirection() || parent()->style().flexWrap() != FlexNoWrap)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -813,7 +813,7 @@
</span><span class="cx"> if (!boxShadowShouldBeAppliedToBackground)
</span><span class="cx"> backgroundRect.intersect(paintInfo.rect);
</span><span class="cx">
</span><del>- // If we have an alpha and we are painting the root element, go ahead and blend with the base background color.
</del><ins>+ // If we have an alpha and we are painting the root element, blend with the base background color.
</ins><span class="cx"> Color baseColor;
</span><span class="cx"> bool shouldClearBackground = false;
</span><span class="cx"> if ((baseBgColorUsage != BaseBackgroundColorSkip) && isOpaqueRoot) {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -536,7 +536,7 @@
</span><span class="cx"> m_hasTransformedAncestor = flags & SeenTransformedLayer;
</span><span class="cx"> m_has3DTransformedAncestor = flags & Seen3DTransformedLayer;
</span><span class="cx">
</span><del>- // Go ahead and update the reflection's position and size.
</del><ins>+ // Update the reflection's position and size.
</ins><span class="cx"> if (m_reflection)
</span><span class="cx"> m_reflection->layout();
</span><span class="cx">
</span><span class="lines">@@ -5006,7 +5006,7 @@
</span><span class="cx"> if (parent()) {
</span><span class="cx"> ClipRectsContext clipRectsContext(rootLayer, RootRelativeClipRects, IncludeOverlayScrollbarSize);
</span><span class="cx"> ClipRect clipRect = backgroundClipRect(clipRectsContext);
</span><del>- // Go ahead and test the enclosing clip now.
</del><ins>+ // Test the enclosing clip now.
</ins><span class="cx"> if (!clipRect.intersects(hitTestLocation))
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -5603,15 +5603,14 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (renderer().hasClip()) {
</span><del>- // Clip applies to *us* as well, so go ahead and update the damageRect.
</del><ins>+ // Clip applies to *us* as well, so update the damageRect.
</ins><span class="cx"> LayoutRect newPosClip = downcast<RenderBox>(renderer()).clipRect(toLayoutPoint(offsetFromRootLocal), namedFlowFragment);
</span><span class="cx"> backgroundRect.intersect(newPosClip);
</span><span class="cx"> foregroundRect.intersect(newPosClip);
</span><span class="cx"> outlineRect.intersect(newPosClip);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // If we establish a clip at all, then go ahead and make sure our background
- // rect is intersected with our layer's bounds including our visual overflow,
</del><ins>+ // If we establish a clip at all, then make sure our background rect is intersected with our layer's bounds including our visual overflow,
</ins><span class="cx"> // since any visual overflow like box-shadow or border-outset is not clipped by overflow:auto/hidden.
</span><span class="cx"> if (renderBox()->hasVisualOverflow()) {
</span><span class="cx"> // FIXME: Does not do the right thing with CSS regions yet, since we don't yet factor in the
</span><span class="lines">@@ -5739,8 +5738,7 @@
</span><span class="cx"> if (damageRect.isEmpty())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we
- // can go ahead and return true.
</del><ins>+ // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we can return true.
</ins><span class="cx"> if (!renderer().isRenderInline()) {
</span><span class="cx"> LayoutRect b = layerBounds;
</span><span class="cx"> b.inflate(renderer().view().maximalOutlineSize());
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -101,8 +101,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (diff == StyleDifferenceLayout || diff == StyleDifferenceSimplifiedLayout) {
</span><del>- // When a layout hint happens, we go ahead and do a repaint of the layer, since the layer could
- // end up being destroyed.
</del><ins>+ // When a layout hint happens, we do a repaint of the layer, since the layer could end up being destroyed.
</ins><span class="cx"> if (hasLayer()) {
</span><span class="cx"> if (oldStyle->position() != newStyle.position()
</span><span class="cx"> || oldStyle->zIndex() != newStyle.zIndex()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLineBoxListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLineBoxList.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLineBoxList.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderLineBoxList.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -315,8 +315,7 @@
</span><span class="cx">
</span><span class="cx"> // If we have no first line box, then just bail early.
</span><span class="cx"> if (!firstBox) {
</span><del>- // For an empty inline, go ahead and propagate the check up to our parent, unless the parent
- // is already dirty.
</del><ins>+ // For an empty inline, propagate the check up to our parent, unless the parent is already dirty.
</ins><span class="cx"> if (container.isInline() && !container.ancestorLineBoxDirty()) {
</span><span class="cx"> container.parent()->dirtyLinesFromChangedChild(container);
</span><span class="cx"> container.setAncestorLineBoxDirty(); // Mark the container to avoid dirtying the same lines again across multiple destroy() calls of the same subtree.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTextLineBoxescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -633,8 +633,7 @@
</span><span class="cx"> if (!firstRootBox) {
</span><span class="cx"> firstRootBox = &rootBox;
</span><span class="cx"> if (!dirtiedLines) {
</span><del>- // The affected area was in between two runs. Go ahead and mark the root box of
- // the run after the affected area as dirty.
</del><ins>+ // The affected area was in between two runs. Mark the root box of the run after the affected area as dirty.
</ins><span class="cx"> firstRootBox->markDirty();
</span><span class="cx"> dirtiedLines = true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderinglineBreakingContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/line/BreakingContext.h (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/line/BreakingContext.h 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/line/BreakingContext.h 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -383,15 +383,13 @@
</span><span class="cx">
</span><span class="cx"> inline void BreakingContext::handleOutOfFlowPositioned(Vector<RenderBox*>& positionedObjects)
</span><span class="cx"> {
</span><del>- // If our original display wasn't an inline type, then we can
- // go ahead and determine our static inline position now.
</del><ins>+ // If our original display wasn't an inline type, then we can determine our static inline position now.
</ins><span class="cx"> auto& box = downcast<RenderBox>(*m_current.renderer());
</span><span class="cx"> bool isInlineType = box.style().isOriginalDisplayInlineType();
</span><span class="cx"> if (!isInlineType)
</span><span class="cx"> m_block.setStaticInlinePositionForChild(box, m_block.logicalHeight(), m_block.startOffsetForContent(m_block.logicalHeight()));
</span><span class="cx"> else {
</span><del>- // If our original display was an INLINE type, then we can go ahead
- // and determine our static y position now.
</del><ins>+ // If our original display was an INLINE type, then we can determine our static y position now.
</ins><span class="cx"> box.layer()->setStaticBlockPosition(m_block.logicalHeight());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -920,9 +918,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!m_ignoringSpaces && m_currentStyle->collapseWhiteSpace()) {
</span><del>- // If we encounter a newline, or if we encounter a
- // second space, we need to go ahead and break up this
- // run and enter a mode where we start collapsing spaces.
</del><ins>+ // If we encounter a newline, or if we encounter a second space,
+ // we need to break up this run and enter a mode where we start collapsing spaces.
</ins><span class="cx"> if (m_currentCharacterIsSpace && previousCharacterIsSpace) {
</span><span class="cx"> m_ignoringSpaces = true;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderinglineLineBreakercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/line/LineBreaker.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/line/LineBreaker.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/rendering/line/LineBreaker.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> context.handleReplaced();
</span><span class="cx"> } else if (context.currentObject()->isText()) {
</span><span class="cx"> if (context.handleText(wordMeasurements, m_hyphenated, consecutiveHyphenatedLines)) {
</span><del>- // We've hit a hard text line break. Our line break iterator is updated, so go ahead and early return.
</del><ins>+ // We've hit a hard text line break. Our line break iterator is updated, so early return.
</ins><span class="cx"> return context.lineBreak();
</span><span class="cx"> }
</span><span class="cx"> } else if (context.currentObject()->isLineBreakOpportunity())
</span></span></pre></div>
<a id="trunkSourceWebCorestyleStyleResolveTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/StyleResolveTree.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/StyleResolveTree.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/style/StyleResolveTree.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -771,7 +771,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // If "rem" units are used anywhere in the document, and if the document element's font size changes, then go ahead and force font updating
</del><ins>+ // If "rem" units are used anywhere in the document, and if the document element's font size changes, then force font updating
</ins><span class="cx"> // all the way down the tree. This is simpler than having to maintain a cache of objects (and such font size changes should be rare anyway).
</span><span class="cx"> if (document.styleSheetCollection().usesRemUnits() && document.documentElement() == &current && localChange != NoChange && currentStyle && newStyle && currentStyle->fontSize() != newStyle->fontSize()) {
</span><span class="cx"> // Cached RenderStyles may depend on the re units.
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLHttpRequestProgressEventThrottlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -66,8 +66,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!isActive()) {
</span><del>- // The timer is not active so the least frequent event for now is every byte.
- // Just go ahead and dispatch the event.
</del><ins>+ // The timer is not active so the least frequent event for now is every byte. Just dispatch the event.
</ins><span class="cx">
</span><span class="cx"> // We should not have any throttled progress event.
</span><span class="cx"> ASSERT(!m_hasThrottledProgressEvent);
</span></span></pre></div>
<a id="trunkSourceWebCorexmlparserXMLDocumentParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx">
</span><span class="cx"> doWrite(source.toString());
</span><span class="cx">
</span><del>- // After parsing, go ahead and dispatch image beforeload events.
</del><ins>+ // After parsing, dispatch image beforeload events.
</ins><span class="cx"> ImageLoader::dispatchPendingBeforeLoadEvents();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-04-05 Simon Fraser <simon.fraser@apple.com>
+
+ Remove "go ahead and" from comments
+ https://bugs.webkit.org/show_bug.cgi?id=143421
+
+ Reviewed by Darin Adler, Benjamin Poulain.
+
+ Remove the phrase "go ahead and" from comments where it doesn't add
+ anything (which is almost all of them).
+
+ * WebView/WebDynamicScrollBarsView.mm:
+ (-[WebDynamicScrollBarsView updateScrollers]):
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView insertText:]):
+
</ins><span class="cx"> 2015-04-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed: Reland change after rollout.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebDynamicScrollBarsViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -285,8 +285,8 @@
</span><span class="cx"> {
</span><span class="cx"> NSView *documentView = [self documentView];
</span><span class="cx">
</span><del>- // If we came in here with the view already needing a layout, then go ahead and do that
- // first. (This will be the common case, e.g., when the page changes due to window resizing for example).
</del><ins>+ // If we came in here with the view already needing a layout, then do that first.
+ // (This will be the common case, e.g., when the page changes due to window resizing for example).
</ins><span class="cx"> // This layout will not re-enter updateScrollers and does not count towards our max layout pass total.
</span><span class="cx"> if (!_private->suppressLayout && !_private->suppressScrollers && [documentView isKindOfClass:[WebHTMLView class]]) {
</span><span class="cx"> WebHTMLView* htmlView = (WebHTMLView*)documentView;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -6402,7 +6402,7 @@
</span><span class="cx">
</span><span class="cx"> // insertText can be called for several reasons:
</span><span class="cx"> // - If it's from normal key event processing (including key bindings), we may need to save the action to perform it later.
</span><del>- // - If it's from an input method, then we should go ahead and insert the text now. We assume it's from the input method if we have marked text.
</del><ins>+ // - If it's from an input method, then we should insert the text now. We assume it's from the input method if we have marked text.
</ins><span class="cx"> // FIXME: In theory, this could be wrong for some input methods, so we should try to find another way to determine if the call is from the input method.
</span><span class="cx"> // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),
</span><span class="cx"> // then we also execute it immediately, as there will be no other chance.
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-04-05 Simon Fraser <simon.fraser@apple.com>
+
+ Remove "go ahead and" from comments
+ https://bugs.webkit.org/show_bug.cgi?id=143421
+
+ Reviewed by Darin Adler, Benjamin Poulain.
+
+ Remove the phrase "go ahead and" from comments where it doesn't add
+ anything (which is almost all of them).
+
+ * Platform/unix/EnvironmentUtilities.cpp:
+ (WebKit::EnvironmentUtilities::stripValuesEndingWithString):
+ * PluginProcess/PluginProcess.cpp:
+ (WebKit::PluginProcess::didClose):
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView insertText:replacementRange:]):
+ (-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
+ * UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
+ (WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
+
</ins><span class="cx"> 2015-04-05 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Bloom filter should support longer hashes
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformunixEnvironmentUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/unix/EnvironmentUtilities.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/unix/EnvironmentUtilities.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit2/Platform/unix/EnvironmentUtilities.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx">
</span><span class="cx"> // Copy over everything right of the match to the current component start, and search from there again.
</span><span class="cx"> if (componentStart[0] == ':') {
</span><del>- // If componentStart points to a colon, go ahead and copy the colon over.
</del><ins>+ // If componentStart points to a colon, copy the colon over.
</ins><span class="cx"> strcpy(componentStart, match + searchLength);
</span><span class="cx"> } else {
</span><span class="cx"> // Otherwise, componentStart still points to the beginning of environmentValueBuffer, so don't copy over the colon.
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessPluginProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx">
</span><span class="cx"> void PluginProcess::didClose(IPC::Connection&)
</span><span class="cx"> {
</span><del>- // The UI process has crashed, just go ahead and quit.
</del><ins>+ // The UI process has crashed, just quit.
</ins><span class="cx"> // FIXME: If the plug-in is spinning in the main loop, we'll never get this message.
</span><span class="cx"> stopRunLoop();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -1608,7 +1608,7 @@
</span><span class="cx">
</span><span class="cx"> // insertText can be called for several reasons:
</span><span class="cx"> // - If it's from normal key event processing (including key bindings), we save the action to perform it later.
</span><del>- // - If it's from an input method, then we should go ahead and insert the text now.
</del><ins>+ // - If it's from an input method, then we should insert the text now.
</ins><span class="cx"> // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),
</span><span class="cx"> // then we also execute it immediately, as there will be no other chance.
</span><span class="cx"> Vector<KeypressCommand>* keypressCommands = _data->_collectedKeypressCommands;
</span><span class="lines">@@ -2078,7 +2078,7 @@
</span><span class="cx">
</span><span class="cx"> // insertText can be called for several reasons:
</span><span class="cx"> // - If it's from normal key event processing (including key bindings), we may need to save the action to perform it later.
</span><del>- // - If it's from an input method, then we should go ahead and insert the text now. We assume it's from the input method if we have marked text.
</del><ins>+ // - If it's from an input method, then we should insert the text now. We assume it's from the input method if we have marked text.
</ins><span class="cx"> // FIXME: In theory, this could be wrong for some input methods, so we should try to find another way to determine if the call is from the input method.
</span><span class="cx"> // - If it's sent outside of keyboard event processing (e.g. from Character Viewer, or when confirming an inline input area with a mouse),
</span><span class="cx"> // then we also execute it immediately, as there will be no other chance.
</span><span class="lines">@@ -3394,7 +3394,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (inputSourceChanged) {
</span><del>- // The input source changed, go ahead and discard any entered text.
</del><ins>+ // The input source changed; discard any entered text.
</ins><span class="cx"> [[WKTextInputWindowController sharedTextInputWindowController] unmarkText];
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessStorageLocalStorageDatabaseTrackercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp (182363 => 182364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp 2015-04-05 18:45:38 UTC (rev 182363)
+++ trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp 2015-04-05 20:17:11 UTC (rev 182364)
</span><span class="lines">@@ -342,7 +342,7 @@
</span><span class="cx">
</span><span class="cx"> m_origins.remove(originIdentifier);
</span><span class="cx"> if (m_origins.isEmpty()) {
</span><del>- // There are no origins left, go ahead and delete the tracker database.
</del><ins>+ // There are no origins left; delete the tracker database.
</ins><span class="cx"> m_database.close();
</span><span class="cx"> deleteFile(trackerDatabasePath());
</span><span class="cx"> deleteEmptyDirectory(m_localStorageDirectory);
</span></span></pre>
</div>
</div>
</body>
</html>