<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182354] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182354">182354</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-04-04 23:11:00 -0700 (Sat, 04 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>More const in CSSToStyleMap
https://bugs.webkit.org/show_bug.cgi?id=143409
Reviewed by Andreas Kling.
The CSSValues passed to CSSToStyleMap functions can mostly be treated
as |const|, except for CSSImageValues which have special behavior.
This makes it clearer what the inputs and outputs of these
functions are.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeDegrees):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeTime):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapAnimationTrigger):
* css/CSSToStyleMap.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValuecpp">trunk/Source/WebCore/css/CSSPrimitiveValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValueh">trunk/Source/WebCore/css/CSSPrimitiveValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSToStyleMapcpp">trunk/Source/WebCore/css/CSSToStyleMap.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSToStyleMaph">trunk/Source/WebCore/css/CSSToStyleMap.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182353 => 182354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-04-05 03:09:24 UTC (rev 182353)
+++ trunk/Source/WebCore/ChangeLog 2015-04-05 06:11:00 UTC (rev 182354)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2015-04-04 Simon Fraser <simon.fraser@apple.com>
+
+ More const in CSSToStyleMap
+ https://bugs.webkit.org/show_bug.cgi?id=143409
+
+ Reviewed by Andreas Kling.
+
+ The CSSValues passed to CSSToStyleMap functions can mostly be treated
+ as |const|, except for CSSImageValues which have special behavior.
+
+ This makes it clearer what the inputs and outputs of these
+ functions are.
+
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::computeDegrees):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::computeTime):
+ * css/CSSToStyleMap.cpp:
+ (WebCore::CSSToStyleMap::mapFillAttachment):
+ (WebCore::CSSToStyleMap::mapFillClip):
+ (WebCore::CSSToStyleMap::mapFillComposite):
+ (WebCore::CSSToStyleMap::mapFillBlendMode):
+ (WebCore::CSSToStyleMap::mapFillOrigin):
+ (WebCore::CSSToStyleMap::mapFillRepeatX):
+ (WebCore::CSSToStyleMap::mapFillRepeatY):
+ (WebCore::CSSToStyleMap::mapFillSize):
+ (WebCore::CSSToStyleMap::mapFillXPosition):
+ (WebCore::CSSToStyleMap::mapFillYPosition):
+ (WebCore::CSSToStyleMap::mapFillMaskSourceType):
+ (WebCore::CSSToStyleMap::mapAnimationDelay):
+ (WebCore::CSSToStyleMap::mapAnimationDirection):
+ (WebCore::CSSToStyleMap::mapAnimationDuration):
+ (WebCore::CSSToStyleMap::mapAnimationFillMode):
+ (WebCore::CSSToStyleMap::mapAnimationIterationCount):
+ (WebCore::CSSToStyleMap::mapAnimationName):
+ (WebCore::CSSToStyleMap::mapAnimationPlayState):
+ (WebCore::CSSToStyleMap::mapAnimationProperty):
+ (WebCore::CSSToStyleMap::mapAnimationTimingFunction):
+ (WebCore::CSSToStyleMap::mapAnimationTrigger):
+ * css/CSSToStyleMap.h:
+
</ins><span class="cx"> 2015-04-04 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Tried to fix the build.
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (182353 => 182354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-04-05 03:09:24 UTC (rev 182353)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2015-04-05 06:11:00 UTC (rev 182354)
</span><span class="lines">@@ -541,7 +541,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double CSSPrimitiveValue::computeDegrees()
</del><ins>+double CSSPrimitiveValue::computeDegrees() const
</ins><span class="cx"> {
</span><span class="cx"> switch (primitiveType()) {
</span><span class="cx"> case CSS_DEG:
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (182353 => 182354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2015-04-05 03:09:24 UTC (rev 182353)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2015-04-05 06:11:00 UTC (rev 182354)
</span><span class="lines">@@ -259,10 +259,10 @@
</span><span class="cx">
</span><span class="cx"> unsigned short primitiveType() const;
</span><span class="cx">
</span><del>- double computeDegrees();
</del><ins>+ double computeDegrees() const;
</ins><span class="cx">
</span><span class="cx"> enum TimeUnit { Seconds, Milliseconds };
</span><del>- template <typename T, TimeUnit timeUnit> T computeTime()
</del><ins>+ template <typename T, TimeUnit timeUnit> T computeTime() const
</ins><span class="cx"> {
</span><span class="cx"> if (timeUnit == Seconds && primitiveType() == CSS_S)
</span><span class="cx"> return getValue<T>();
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSToStyleMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSToStyleMap.cpp (182353 => 182354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSToStyleMap.cpp 2015-04-05 03:09:24 UTC (rev 182353)
+++ trunk/Source/WebCore/css/CSSToStyleMap.cpp 2015-04-05 06:11:00 UTC (rev 182354)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> return m_resolver->styleImage(propertyId, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillAttachment(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillAttachment(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setAttachment(FillLayer::initialFillAttachment(layer.type()));
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillClip(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillClip(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setClip(FillLayer::initialFillClip(layer.type()));
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> layer.setClip(downcast<CSSPrimitiveValue>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillComposite(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillComposite(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setComposite(FillLayer::initialFillComposite(layer.type()));
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx"> layer.setComposite(downcast<CSSPrimitiveValue>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillBlendMode(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillBlendMode(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setBlendMode(FillLayer::initialFillBlendMode(layer.type()));
</span><span class="lines">@@ -135,7 +135,7 @@
</span><span class="cx"> layer.setBlendMode(downcast<CSSPrimitiveValue>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillOrigin(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillOrigin(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setOrigin(FillLayer::initialFillOrigin(layer.type()));
</span><span class="lines">@@ -148,7 +148,6 @@
</span><span class="cx"> layer.setOrigin(downcast<CSSPrimitiveValue>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> void CSSToStyleMap::mapFillImage(CSSPropertyID property, FillLayer& layer, CSSValue& value)
</span><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="lines">@@ -159,7 +158,7 @@
</span><span class="cx"> layer.setImage(styleImage(property, value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillRepeatX(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillRepeatX(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setRepeatX(FillLayer::initialFillRepeatX(layer.type()));
</span><span class="lines">@@ -172,7 +171,7 @@
</span><span class="cx"> layer.setRepeatX(downcast<CSSPrimitiveValue>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillRepeatY(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillRepeatY(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setRepeatY(FillLayer::initialFillRepeatY(layer.type()));
</span><span class="lines">@@ -196,7 +195,7 @@
</span><span class="cx"> return !size.width().isUndefined() && !size.height().isUndefined();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillSize(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillSize(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setSize(FillLayer::initialFillSize(layer.type()));
</span><span class="lines">@@ -224,7 +223,7 @@
</span><span class="cx"> layer.setSize(fillSize);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillXPosition(CSSPropertyID propertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillXPosition(CSSPropertyID propertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setXPosition(FillLayer::initialFillXPosition(layer.type()));
</span><span class="lines">@@ -256,7 +255,7 @@
</span><span class="cx"> layer.setBackgroundXOrigin(*pair->first());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillYPosition(CSSPropertyID propertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillYPosition(CSSPropertyID propertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setYPosition(FillLayer::initialFillYPosition(layer.type()));
</span><span class="lines">@@ -288,7 +287,7 @@
</span><span class="cx"> layer.setBackgroundYOrigin(*pair->first());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapFillMaskSourceType(CSSPropertyID, FillLayer& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapFillMaskSourceType(CSSPropertyID, FillLayer& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> EMaskSourceType type = FillLayer::initialFillMaskSourceType(layer.type());
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="lines">@@ -315,7 +314,7 @@
</span><span class="cx"> layer.setMaskSourceType(type);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationDelay(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationDelay(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setDelay(Animation::initialDelay());
</span><span class="lines">@@ -328,7 +327,7 @@
</span><span class="cx"> animation.setDelay(downcast<CSSPrimitiveValue>(value).computeTime<double, CSSPrimitiveValue::Seconds>());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationDirection(Animation& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationDirection(Animation& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setDirection(Animation::initialDirection());
</span><span class="lines">@@ -356,7 +355,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationDuration(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationDuration(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setDuration(Animation::initialDuration());
</span><span class="lines">@@ -369,7 +368,7 @@
</span><span class="cx"> animation.setDuration(downcast<CSSPrimitiveValue>(value).computeTime<double, CSSPrimitiveValue::Seconds>());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationFillMode(Animation& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationFillMode(Animation& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setFillMode(Animation::initialFillMode());
</span><span class="lines">@@ -397,7 +396,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationIterationCount(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationIterationCount(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setIterationCount(Animation::initialIterationCount());
</span><span class="lines">@@ -414,7 +413,7 @@
</span><span class="cx"> animation.setIterationCount(primitiveValue.getFloatValue());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationName(Animation& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationName(Animation& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setName(Animation::initialName());
</span><span class="lines">@@ -431,7 +430,7 @@
</span><span class="cx"> layer.setName(primitiveValue.getStringValue());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationPlayState(Animation& layer, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationPlayState(Animation& layer, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> layer.setPlayState(Animation::initialPlayState());
</span><span class="lines">@@ -445,7 +444,7 @@
</span><span class="cx"> layer.setPlayState(playState);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationProperty(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationProperty(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setAnimationMode(Animation::AnimateAll);
</span><span class="lines">@@ -469,7 +468,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CSSToStyleMap::mapAnimationTimingFunction(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationTimingFunction(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setTimingFunction(Animation::initialTimingFunction());
</span><span class="lines">@@ -515,7 +514,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_ANIMATIONS_LEVEL_2)
</span><del>-void CSSToStyleMap::mapAnimationTrigger(Animation& animation, CSSValue& value)
</del><ins>+void CSSToStyleMap::mapAnimationTrigger(Animation& animation, const CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (value.isInitialValue()) {
</span><span class="cx"> animation.setTrigger(Animation::initialTrigger());
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSToStyleMaph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSToStyleMap.h (182353 => 182354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSToStyleMap.h 2015-04-05 03:09:24 UTC (rev 182353)
+++ trunk/Source/WebCore/css/CSSToStyleMap.h 2015-04-05 06:11:00 UTC (rev 182354)
</span><span class="lines">@@ -45,30 +45,30 @@
</span><span class="cx"> public:
</span><span class="cx"> CSSToStyleMap(StyleResolver*);
</span><span class="cx">
</span><del>- void mapFillAttachment(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillClip(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillComposite(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillBlendMode(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillOrigin(CSSPropertyID, FillLayer&, CSSValue&);
</del><ins>+ void mapFillAttachment(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillClip(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillComposite(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillBlendMode(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillOrigin(CSSPropertyID, FillLayer&, const CSSValue&);
</ins><span class="cx"> void mapFillImage(CSSPropertyID, FillLayer&, CSSValue&);
</span><del>- void mapFillRepeatX(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillRepeatY(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillSize(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillXPosition(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillYPosition(CSSPropertyID, FillLayer&, CSSValue&);
- void mapFillMaskSourceType(CSSPropertyID, FillLayer&, CSSValue&);
</del><ins>+ void mapFillRepeatX(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillRepeatY(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillSize(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillXPosition(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillYPosition(CSSPropertyID, FillLayer&, const CSSValue&);
+ void mapFillMaskSourceType(CSSPropertyID, FillLayer&, const CSSValue&);
</ins><span class="cx">
</span><del>- void mapAnimationDelay(Animation&, CSSValue&);
- void mapAnimationDirection(Animation&, CSSValue&);
- void mapAnimationDuration(Animation&, CSSValue&);
- void mapAnimationFillMode(Animation&, CSSValue&);
- void mapAnimationIterationCount(Animation&, CSSValue&);
- void mapAnimationName(Animation&, CSSValue&);
- void mapAnimationPlayState(Animation&, CSSValue&);
- void mapAnimationProperty(Animation&, CSSValue&);
- void mapAnimationTimingFunction(Animation&, CSSValue&);
</del><ins>+ void mapAnimationDelay(Animation&, const CSSValue&);
+ void mapAnimationDirection(Animation&, const CSSValue&);
+ void mapAnimationDuration(Animation&, const CSSValue&);
+ void mapAnimationFillMode(Animation&, const CSSValue&);
+ void mapAnimationIterationCount(Animation&, const CSSValue&);
+ void mapAnimationName(Animation&, const CSSValue&);
+ void mapAnimationPlayState(Animation&, const CSSValue&);
+ void mapAnimationProperty(Animation&, const CSSValue&);
+ void mapAnimationTimingFunction(Animation&, const CSSValue&);
</ins><span class="cx"> #if ENABLE(CSS_ANIMATIONS_LEVEL_2)
</span><del>- void mapAnimationTrigger(Animation&, CSSValue&);
</del><ins>+ void mapAnimationTrigger(Animation&, const CSSValue&);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> void mapNinePieceImage(CSSPropertyID, CSSValue*, NinePieceImage&);
</span></span></pre>
</div>
</div>
</body>
</html>