<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182339] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182339">182339</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2015-04-03 17:07:54 -0700 (Fri, 03 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>fast/fixed-layout/fixed-layout.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143379
Reviewed by Simon Fraser.
* TestExpectations:
Un-flakify the fixed layout test.
* fast/css-grid-layout/flex-content-sized-columns-resize-expected.html:
Remove a mistaken line in the original test; this function doesn't exist in WebKit
and was presumably ported directly from the Blink test (and then never noticed because
JS exceptions thrown in -expected files go nowhere).
* fast/fixed-layout/fixed-layout.html:
Make the fixed layout test less racy by waiting for the resize event (which can be
very asynchronous). Also, force a layout before resizing to ensure that we
always do get a resize event.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutflexcontentsizedcolumnsresizeexpectedhtml">trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastfixedlayoutfixedlayouthtml">trunk/LayoutTests/fast/fixed-layout/fixed-layout.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (182338 => 182339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-04-03 23:52:27 UTC (rev 182338)
+++ trunk/LayoutTests/ChangeLog 2015-04-04 00:07:54 UTC (rev 182339)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-04-03 Tim Horton <timothy_horton@apple.com>
+
+ fast/fixed-layout/fixed-layout.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=143379
+
+ Reviewed by Simon Fraser.
+
+ * TestExpectations:
+ Un-flakify the fixed layout test.
+
+ * fast/css-grid-layout/flex-content-sized-columns-resize-expected.html:
+ Remove a mistaken line in the original test; this function doesn't exist in WebKit
+ and was presumably ported directly from the Blink test (and then never noticed because
+ JS exceptions thrown in -expected files go nowhere).
+
+ * fast/fixed-layout/fixed-layout.html:
+ Make the fixed layout test less racy by waiting for the resize event (which can be
+ very asynchronous). Also, force a layout before resizing to ensure that we
+ always do get a resize event.
+
</ins><span class="cx"> 2015-04-03 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Toggling check box state not speaking using plain space, not VO space.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (182338 => 182339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2015-04-03 23:52:27 UTC (rev 182338)
+++ trunk/LayoutTests/TestExpectations 2015-04-04 00:07:54 UTC (rev 182339)
</span><span class="lines">@@ -515,5 +515,3 @@
</span><span class="cx"> webkit.org/b/142937 ietestcenter/Javascript/15.2.3.14-1-1.html [ Failure ]
</span><span class="cx"> webkit.org/b/142937 ietestcenter/Javascript/15.2.3.14-1-2.html [ Failure ]
</span><span class="cx"> webkit.org/b/142937 ietestcenter/Javascript/15.2.3.14-1-3.html [ Failure ]
</span><del>-
-webkit.org/b/143379 fast/fixed-layout/fixed-layout.html [ Pass Failure ]
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutflexcontentsizedcolumnsresizeexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize-expected.html (182338 => 182339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize-expected.html 2015-04-03 23:52:27 UTC (rev 182338)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize-expected.html 2015-04-04 00:07:54 UTC (rev 182339)
</span><span class="lines">@@ -20,7 +20,6 @@
</span><span class="cx"> <script>
</span><span class="cx"> function runTest() {
</span><span class="cx"> if (window.testRunner) {
</span><del>- testRunner.useUnfortunateSynchronousResizeMode();
</del><span class="cx"> window.resizeTo(600, 600);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestsfastfixedlayoutfixedlayouthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/fixed-layout/fixed-layout.html (182338 => 182339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/fixed-layout/fixed-layout.html 2015-04-03 23:52:27 UTC (rev 182338)
+++ trunk/LayoutTests/fast/fixed-layout/fixed-layout.html 2015-04-04 00:07:54 UTC (rev 182339)
</span><span class="lines">@@ -6,16 +6,19 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // Ensure layout is up to date here so that we get a resize event instead of just using
+ // 200x200 as the initial size, in WebKit1 (causing the test to hang).
+ document.body.offsetTop;
+
</ins><span class="cx"> testRunner.waitUntilDone();
</span><del>-
</del><span class="cx"> window.resizeTo(200, 200);
</span><ins>+}
</ins><span class="cx">
</span><ins>+window.onresize = function () {
</ins><span class="cx"> internals.setUseFixedLayout(true);
</span><span class="cx"> internals.setFixedLayoutSize(400, 400);
</span><span class="cx">
</span><del>- setTimeout(function () {
- testRunner.notifyDone();
- }, 0);
</del><ins>+ testRunner.notifyDone();
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre>
</div>
</div>
</body>
</html>